Re: [PATCH] io:health:afe4404: Remove duplicated error reporting in .remove()

[Jonathan Cameron <jic23@kernel.org>]

On Sun, 22 May 2022 21:58:42 +0200
Uwe Kleine-König <u.kleine-koenig@pengutronix.de> wrote:

> Hello Jonathan,
> 
> On Sat, May 14, 2022 at 02:38:12PM +0100, Jonathan Cameron wrote:
> > On Sat, 14 May 2022 15:04:32 +0200
> > Uwe Kleine-König         <u.kleine-koenig@pengutronix.de> wrote:
> >   
> > > Returning an error value in an i2c remove callback results in an error
> > > message being emitted by the i2c core, but otherwise it doesn't make a
> > > difference.
> > > 
> > > As afe4404_remove() already emits an error message on failure and the
> > > additional error message by the i2c core doesn't add any useful
> > > information, change the return value to zero to suppress this message.
> > > 
> > > This patch is a preparation for making i2c remove callbacks return void.
> > > 
> > > Signed-off-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de>  
> > Applied.
> > 
> > Like the others this will sit in testing until I can rebase the togreg
> > branch.  
> 
> Don't know if it's to late to fix already, but I just noticed we'd want
> s/io/iio/ in the Subject line.
Good spot. Fixed up as haven't pushed the tree out as non rebasing yet
(I'm waiting as I normally rebase on rc1).

Jonathan

> 
> Best regards
> Uwe
>