From: Jonathan Cameron <jic23@kernel.org>
To: Andy Shevchenko <andy.shevchenko@gmail.com>
Cc: "Uwe Kleine-König" <ukleinek@debian.org>,
"Lars-Peter Clausen" <lars@metafoo.de>,
"Andy Shevchenko" <andriy.shevchenko@linux.intel.com>,
linux-iio <linux-iio@vger.kernel.org>,
"Yves-Alexis Perez" <corsac@debian.org>
Subject: Re: [PATCH v2 3/3] iio: humidity: dht11: Use dev_err_probe consistently
Date: Tue, 19 Jul 2022 09:47:09 +0100 [thread overview]
Message-ID: <20220719094709.78a52856@jic23-huawei> (raw)
In-Reply-To: <CAHp75VdC1eW-KQmQ3EXEh70k4XDQ1HoO9m5dEY9=VGKNN2K-oA@mail.gmail.com>
On Mon, 18 Jul 2022 22:32:17 +0200
Andy Shevchenko <andy.shevchenko@gmail.com> wrote:
> On Mon, Jul 18, 2022 at 10:29 PM Andy Shevchenko
> <andy.shevchenko@gmail.com> wrote:
> > On Mon, Jul 18, 2022 at 9:51 PM Uwe Kleine-König <ukleinek@debian.org> wrote:
>
> ...
>
> > And to be honest I don't like this desc_to_gpio() usage. It's not for
> > board files, it will bring confusing information to the user. What is
> > important is the name of GPIO, i.o.w. "connection id".
>
> Yes, I have noticed that this is in the original code, just if you
> want to make it better at the same time. Not sure if Jonathan wants
> all these in the single patch again, however it will touch almost the
> same line in all (three ?).
>
So ideal would be separate patches for the different change types, but
meh, that's a pain as you say so given it's just a few lines I'm
fine with whatever combining you want to do.
next prev parent reply other threads:[~2022-07-19 8:37 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-07-18 19:42 [PATCH v2 1/3] iio: humidity: dht11: Don't warn on memory allocation failure Uwe Kleine-König
2022-07-18 19:42 ` [PATCH v2 2/3] iio: humidity: dht11: Emit error messages for probe failures Uwe Kleine-König
2022-07-18 20:27 ` Andy Shevchenko
2022-07-18 20:35 ` Uwe Kleine-König
2022-07-19 8:48 ` Jonathan Cameron
2022-07-19 9:08 ` Andy Shevchenko
2022-07-18 19:42 ` [PATCH v2 3/3] iio: humidity: dht11: Use dev_err_probe consistently Uwe Kleine-König
2022-07-18 20:29 ` Andy Shevchenko
2022-07-18 20:32 ` Andy Shevchenko
2022-07-19 8:47 ` Jonathan Cameron [this message]
2022-07-18 20:26 ` [PATCH v2 1/3] iio: humidity: dht11: Don't warn on memory allocation failure Andy Shevchenko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220719094709.78a52856@jic23-huawei \
--to=jic23@kernel.org \
--cc=andriy.shevchenko@linux.intel.com \
--cc=andy.shevchenko@gmail.com \
--cc=corsac@debian.org \
--cc=lars@metafoo.de \
--cc=linux-iio@vger.kernel.org \
--cc=ukleinek@debian.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox