From: Jonathan Cameron <jic23@kernel.org>
To: sunliming <sunliming@kylinos.cn>
Cc: ktsai@capellamicro.com, lars@metafoo.de,
kai.heng.feng@canonical.com, linux-iio@vger.kernel.org,
linux-kernel@vger.kernel.org, kelulanainsley@gmail.com,
kernel test robot <lkp@intel.com>
Subject: Re: [PATCH] iio: light: cm32181: make cm32181_pm_ops static
Date: Sat, 20 Aug 2022 12:57:09 +0100 [thread overview]
Message-ID: <20220820125709.7df567c1@jic23-huawei> (raw)
In-Reply-To: <20220815012930.150078-1-sunliming@kylinos.cn>
On Mon, 15 Aug 2022 09:29:30 +0800
sunliming <sunliming@kylinos.cn> wrote:
> This symbol is not used outside of cm32181.c, so marks it static.
>
> Fixes the following sparse warnings:
> >> drivers/iio/light/cm32181.c:508:1: sparse: sparse: symbol 'cm32181_pm_ops'
> was not declared. Should it be static?
>
> Reported-by: kernel test robot <lkp@intel.com>
> Signed-off-by: sunliming <sunliming@kylinos.cn>
Applied. Thanks,
> ---
> drivers/iio/light/cm32181.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/iio/light/cm32181.c b/drivers/iio/light/cm32181.c
> index edbe6a3138d0..001055d09750 100644
> --- a/drivers/iio/light/cm32181.c
> +++ b/drivers/iio/light/cm32181.c
> @@ -505,7 +505,7 @@ static int cm32181_resume(struct device *dev)
> cm32181->conf_regs[CM32181_REG_ADDR_CMD]);
> }
>
> -DEFINE_SIMPLE_DEV_PM_OPS(cm32181_pm_ops, cm32181_suspend, cm32181_resume);
> +static DEFINE_SIMPLE_DEV_PM_OPS(cm32181_pm_ops, cm32181_suspend, cm32181_resume);
>
> static const struct of_device_id cm32181_of_match[] = {
> { .compatible = "capella,cm3218" },
prev parent reply other threads:[~2022-08-20 11:46 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-08-15 1:29 [PATCH] iio: light: cm32181: make cm32181_pm_ops static sunliming
2022-08-20 11:57 ` Jonathan Cameron [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220820125709.7df567c1@jic23-huawei \
--to=jic23@kernel.org \
--cc=kai.heng.feng@canonical.com \
--cc=kelulanainsley@gmail.com \
--cc=ktsai@capellamicro.com \
--cc=lars@metafoo.de \
--cc=linux-iio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=lkp@intel.com \
--cc=sunliming@kylinos.cn \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox