* [PATCH] iio: light: cm32181: make cm32181_pm_ops static
@ 2022-08-15 1:29 sunliming
2022-08-20 11:57 ` Jonathan Cameron
0 siblings, 1 reply; 2+ messages in thread
From: sunliming @ 2022-08-15 1:29 UTC (permalink / raw)
To: ktsai, jic23, lars, kai.heng.feng
Cc: linux-iio, linux-kernel, kelulanainsley, sunliming,
kernel test robot
This symbol is not used outside of cm32181.c, so marks it static.
Fixes the following sparse warnings:
>> drivers/iio/light/cm32181.c:508:1: sparse: sparse: symbol 'cm32181_pm_ops'
was not declared. Should it be static?
Reported-by: kernel test robot <lkp@intel.com>
Signed-off-by: sunliming <sunliming@kylinos.cn>
---
drivers/iio/light/cm32181.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/iio/light/cm32181.c b/drivers/iio/light/cm32181.c
index edbe6a3138d0..001055d09750 100644
--- a/drivers/iio/light/cm32181.c
+++ b/drivers/iio/light/cm32181.c
@@ -505,7 +505,7 @@ static int cm32181_resume(struct device *dev)
cm32181->conf_regs[CM32181_REG_ADDR_CMD]);
}
-DEFINE_SIMPLE_DEV_PM_OPS(cm32181_pm_ops, cm32181_suspend, cm32181_resume);
+static DEFINE_SIMPLE_DEV_PM_OPS(cm32181_pm_ops, cm32181_suspend, cm32181_resume);
static const struct of_device_id cm32181_of_match[] = {
{ .compatible = "capella,cm3218" },
--
2.25.1
^ permalink raw reply related [flat|nested] 2+ messages in thread* Re: [PATCH] iio: light: cm32181: make cm32181_pm_ops static
2022-08-15 1:29 [PATCH] iio: light: cm32181: make cm32181_pm_ops static sunliming
@ 2022-08-20 11:57 ` Jonathan Cameron
0 siblings, 0 replies; 2+ messages in thread
From: Jonathan Cameron @ 2022-08-20 11:57 UTC (permalink / raw)
To: sunliming
Cc: ktsai, lars, kai.heng.feng, linux-iio, linux-kernel,
kelulanainsley, kernel test robot
On Mon, 15 Aug 2022 09:29:30 +0800
sunliming <sunliming@kylinos.cn> wrote:
> This symbol is not used outside of cm32181.c, so marks it static.
>
> Fixes the following sparse warnings:
> >> drivers/iio/light/cm32181.c:508:1: sparse: sparse: symbol 'cm32181_pm_ops'
> was not declared. Should it be static?
>
> Reported-by: kernel test robot <lkp@intel.com>
> Signed-off-by: sunliming <sunliming@kylinos.cn>
Applied. Thanks,
> ---
> drivers/iio/light/cm32181.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/iio/light/cm32181.c b/drivers/iio/light/cm32181.c
> index edbe6a3138d0..001055d09750 100644
> --- a/drivers/iio/light/cm32181.c
> +++ b/drivers/iio/light/cm32181.c
> @@ -505,7 +505,7 @@ static int cm32181_resume(struct device *dev)
> cm32181->conf_regs[CM32181_REG_ADDR_CMD]);
> }
>
> -DEFINE_SIMPLE_DEV_PM_OPS(cm32181_pm_ops, cm32181_suspend, cm32181_resume);
> +static DEFINE_SIMPLE_DEV_PM_OPS(cm32181_pm_ops, cm32181_suspend, cm32181_resume);
>
> static const struct of_device_id cm32181_of_match[] = {
> { .compatible = "capella,cm3218" },
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2022-08-20 11:46 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2022-08-15 1:29 [PATCH] iio: light: cm32181: make cm32181_pm_ops static sunliming
2022-08-20 11:57 ` Jonathan Cameron
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox