[PATCH] iio: adc: ad9467: Silent no spi_device_id warnings

[PATCH] iio: adc: ad9467: Silent no spi_device_id warnings

[Wei Yongjun]

From: Wei Yongjun <weiyongjun1@huawei.com>

Add spi_device_id entries to silent following SPI warnings:

SPI driver ad9467 has no spi_device_id for adi,ad9265
SPI driver ad9467 has no spi_device_id for adi,ad9434

Signed-off-by: Wei Yongjun <weiyongjun1@huawei.com>
---
 drivers/iio/adc/ad9467.c | 9 +++++++++
 1 file changed, 9 insertions(+)

diff --git a/drivers/iio/adc/ad9467.c b/drivers/iio/adc/ad9467.c
index 7534572f7475..67decbf2e119 100644
--- a/drivers/iio/adc/ad9467.c
+++ b/drivers/iio/adc/ad9467.c
@@ -447,12 +447,21 @@ static const struct of_device_id ad9467_of_match[] = {
 };
 MODULE_DEVICE_TABLE(of, ad9467_of_match);
 
+static const struct spi_device_id ad9467_ids[] = {
+	{ "ad9265", (kernel_ulong_t)&ad9467_chip_tbl[ID_AD9265] },
+	{ "ad9434", (kernel_ulong_t)&ad9467_chip_tbl[ID_AD9434] },
+	{ "ad9467", (kernel_ulong_t)&ad9467_chip_tbl[ID_AD9467] },
+	{ },
+};
+MODULE_DEVICE_TABLE(spi, ad9467_ids);
+
 static struct spi_driver ad9467_driver = {
 	.driver = {
 		.name = "ad9467",
 		.of_match_table = ad9467_of_match,
 	},
 	.probe = ad9467_probe,
+	.id_table = ad9467_ids,
 };
 module_spi_driver(ad9467_driver);
 
-- 
2.34.1

Re: [PATCH] iio: adc: ad9467: Silent no spi_device_id warnings

[Jonathan Cameron]

On Mon, 19 Sep 2022 15:00:03 +0000
Wei Yongjun <weiyongjun@huaweicloud.com> wrote:

> From: Wei Yongjun <weiyongjun1@huawei.com>
> 
> Add spi_device_id entries to silent following SPI warnings:
> 
> SPI driver ad9467 has no spi_device_id for adi,ad9265
> SPI driver ad9467 has no spi_device_id for adi,ad9434

As for other drivers with similar pattern, please make use of
the spi_device_id->driver_data to provide the chip_info pointer
if the of_device_get_match_data() returns NULL.

A side effect of adding this spi_device_id table is that
it enables board file and other non firmware based forms
of device instantiation.

Jonathan
 
> 
> Signed-off-by: Wei Yongjun <weiyongjun1@huawei.com>
> ---
>  drivers/iio/adc/ad9467.c | 9 +++++++++
>  1 file changed, 9 insertions(+)
> 
> diff --git a/drivers/iio/adc/ad9467.c b/drivers/iio/adc/ad9467.c
> index 7534572f7475..67decbf2e119 100644
> --- a/drivers/iio/adc/ad9467.c
> +++ b/drivers/iio/adc/ad9467.c
> @@ -447,12 +447,21 @@ static const struct of_device_id ad9467_of_match[] = {
>  };
>  MODULE_DEVICE_TABLE(of, ad9467_of_match);
>  
> +static const struct spi_device_id ad9467_ids[] = {
> +	{ "ad9265", (kernel_ulong_t)&ad9467_chip_tbl[ID_AD9265] },
> +	{ "ad9434", (kernel_ulong_t)&ad9467_chip_tbl[ID_AD9434] },
> +	{ "ad9467", (kernel_ulong_t)&ad9467_chip_tbl[ID_AD9467] },
> +	{ },
> +};
> +MODULE_DEVICE_TABLE(spi, ad9467_ids);
> +
>  static struct spi_driver ad9467_driver = {
>  	.driver = {
>  		.name = "ad9467",
>  		.of_match_table = ad9467_of_match,
>  	},
>  	.probe = ad9467_probe,
> +	.id_table = ad9467_ids,
>  };
>  module_spi_driver(ad9467_driver);
>