* [PATCH] iio: adc: max11410: fix incomplete vref buffer mask
@ 2022-11-22 11:47 Ibrahim Tilki
2022-11-23 20:33 ` Jonathan Cameron
0 siblings, 1 reply; 2+ messages in thread
From: Ibrahim Tilki @ 2022-11-22 11:47 UTC (permalink / raw)
To: jic23
Cc: Ibrahim Tilki, linux-iio, linux-kernel, kernel test robot,
Julia Lawall
VREFP bit was missing from channel configuration mask and VREFN bit was
included twice instead which fails to enable positive reference buffer when
requested by a channel. Channels that don't enable vrefp buffer were not
affected.
Reported-by: kernel test robot <lkp@intel.com>
Reported-by: Julia Lawall <julia.lawall@lip6.fr>
Signed-off-by: Ibrahim Tilki <Ibrahim.Tilki@analog.com>
---
drivers/iio/adc/max11410.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/iio/adc/max11410.c b/drivers/iio/adc/max11410.c
index 8cd5663671..fdc9f03135 100644
--- a/drivers/iio/adc/max11410.c
+++ b/drivers/iio/adc/max11410.c
@@ -370,7 +370,7 @@ static int max11410_configure_channel(struct max11410_state *st,
FIELD_PREP(MAX11410_CTRL_UNIPOLAR_BIT, cfg.bipolar ? 0 : 1);
ret = regmap_update_bits(st->regmap, MAX11410_REG_CTRL,
MAX11410_CTRL_REFSEL_MASK |
- MAX11410_CTRL_VREFN_BUF_BIT |
+ MAX11410_CTRL_VREFP_BUF_BIT |
MAX11410_CTRL_VREFN_BUF_BIT |
MAX11410_CTRL_UNIPOLAR_BIT, regval);
if (ret)
--
2.25.1
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] iio: adc: max11410: fix incomplete vref buffer mask
2022-11-22 11:47 [PATCH] iio: adc: max11410: fix incomplete vref buffer mask Ibrahim Tilki
@ 2022-11-23 20:33 ` Jonathan Cameron
0 siblings, 0 replies; 2+ messages in thread
From: Jonathan Cameron @ 2022-11-23 20:33 UTC (permalink / raw)
To: Ibrahim Tilki; +Cc: linux-iio, linux-kernel, kernel test robot, Julia Lawall
On Tue, 22 Nov 2022 14:47:18 +0300
Ibrahim Tilki <Ibrahim.Tilki@analog.com> wrote:
> VREFP bit was missing from channel configuration mask and VREFN bit was
> included twice instead which fails to enable positive reference buffer when
> requested by a channel. Channels that don't enable vrefp buffer were not
> affected.
>
> Reported-by: kernel test robot <lkp@intel.com>
> Reported-by: Julia Lawall <julia.lawall@lip6.fr>
> Signed-off-by: Ibrahim Tilki <Ibrahim.Tilki@analog.com>
Applied and I added a fixes tag (given I've just rebased for a broken fixes tag
I'm glad you didn't as it would have been wrong anyway!)
Thanks,
Jonathan
> ---
> drivers/iio/adc/max11410.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/iio/adc/max11410.c b/drivers/iio/adc/max11410.c
> index 8cd5663671..fdc9f03135 100644
> --- a/drivers/iio/adc/max11410.c
> +++ b/drivers/iio/adc/max11410.c
> @@ -370,7 +370,7 @@ static int max11410_configure_channel(struct max11410_state *st,
> FIELD_PREP(MAX11410_CTRL_UNIPOLAR_BIT, cfg.bipolar ? 0 : 1);
> ret = regmap_update_bits(st->regmap, MAX11410_REG_CTRL,
> MAX11410_CTRL_REFSEL_MASK |
> - MAX11410_CTRL_VREFN_BUF_BIT |
> + MAX11410_CTRL_VREFP_BUF_BIT |
> MAX11410_CTRL_VREFN_BUF_BIT |
> MAX11410_CTRL_UNIPOLAR_BIT, regval);
> if (ret)
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2022-11-23 20:25 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2022-11-22 11:47 [PATCH] iio: adc: max11410: fix incomplete vref buffer mask Ibrahim Tilki
2022-11-23 20:33 ` Jonathan Cameron
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox