* [PATCH] iio: addac: ad74413r: fix blank line after declaration warning
@ 2022-11-24 15:30 Cosmin Tanislav
2022-11-24 19:24 ` Jonathan Cameron
0 siblings, 1 reply; 2+ messages in thread
From: Cosmin Tanislav @ 2022-11-24 15:30 UTC (permalink / raw)
Cc: Cosmin Tanislav, Lars-Peter Clausen, Michael Hennerich,
Jonathan Cameron, Rasmus Villemoes, linux-iio, linux-kernel
Checkpatch wants a blank line after all declarations. Add it now,
even though the patch has already been submitted.
Signed-off-by: Cosmin Tanislav <cosmin.tanislav@analog.com>
Fixes: 7b2366008125 ("iio: addac: ad74413r: add spi_device_id table")
---
drivers/iio/addac/ad74413r.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/iio/addac/ad74413r.c b/drivers/iio/addac/ad74413r.c
index 61030053cbea..f32c8c2fb26d 100644
--- a/drivers/iio/addac/ad74413r.c
+++ b/drivers/iio/addac/ad74413r.c
@@ -1315,6 +1315,7 @@ static int ad74413r_probe(struct spi_device *spi)
st->chip_info = device_get_match_data(&spi->dev);
if (!st->chip_info) {
const struct spi_device_id *id = spi_get_device_id(spi);
+
if (id)
st->chip_info =
(struct ad74413r_chip_info *)id->driver_data;
--
2.38.1
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] iio: addac: ad74413r: fix blank line after declaration warning
2022-11-24 15:30 [PATCH] iio: addac: ad74413r: fix blank line after declaration warning Cosmin Tanislav
@ 2022-11-24 19:24 ` Jonathan Cameron
0 siblings, 0 replies; 2+ messages in thread
From: Jonathan Cameron @ 2022-11-24 19:24 UTC (permalink / raw)
To: Cosmin Tanislav
Cc: Cosmin Tanislav, Lars-Peter Clausen, Michael Hennerich,
Rasmus Villemoes, linux-iio, linux-kernel
On Thu, 24 Nov 2022 17:30:49 +0200
Cosmin Tanislav <demonsingur@gmail.com> wrote:
> Checkpatch wants a blank line after all declarations. Add it now,
> even though the patch has already been submitted.
>
> Signed-off-by: Cosmin Tanislav <cosmin.tanislav@analog.com>
> Fixes: 7b2366008125 ("iio: addac: ad74413r: add spi_device_id table")
Dropped fixes tag as this is just cosmetic.
Applied.
> ---
> drivers/iio/addac/ad74413r.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/iio/addac/ad74413r.c b/drivers/iio/addac/ad74413r.c
> index 61030053cbea..f32c8c2fb26d 100644
> --- a/drivers/iio/addac/ad74413r.c
> +++ b/drivers/iio/addac/ad74413r.c
> @@ -1315,6 +1315,7 @@ static int ad74413r_probe(struct spi_device *spi)
> st->chip_info = device_get_match_data(&spi->dev);
> if (!st->chip_info) {
> const struct spi_device_id *id = spi_get_device_id(spi);
> +
> if (id)
> st->chip_info =
> (struct ad74413r_chip_info *)id->driver_data;
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2022-11-24 19:12 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2022-11-24 15:30 [PATCH] iio: addac: ad74413r: fix blank line after declaration warning Cosmin Tanislav
2022-11-24 19:24 ` Jonathan Cameron
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox