* [PATCH] iio: adc: at91-sama5d2_adc: use sysfs_emit() to instead of scnprintf()
@ 2022-12-01 3:42 ye.xingchen
2022-12-04 15:46 ` Jonathan Cameron
0 siblings, 1 reply; 2+ messages in thread
From: ye.xingchen @ 2022-12-01 3:42 UTC (permalink / raw)
To: jic23
Cc: eugen.hristev, lars, nicolas.ferre, alexandre.belloni,
claudiu.beznea, linux-iio, linux-arm-kernel, linux-kernel
From: ye xingchen <ye.xingchen@zte.com.cn>
Replace the open-code with sysfs_emit() to simplify the code.
Signed-off-by: ye xingchen <ye.xingchen@zte.com.cn>
---
drivers/iio/adc/at91-sama5d2_adc.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/iio/adc/at91-sama5d2_adc.c b/drivers/iio/adc/at91-sama5d2_adc.c
index ed4f8501bda8..50d02e5fc6fc 100644
--- a/drivers/iio/adc/at91-sama5d2_adc.c
+++ b/drivers/iio/adc/at91-sama5d2_adc.c
@@ -2181,7 +2181,7 @@ static ssize_t at91_adc_get_fifo_state(struct device *dev,
struct iio_dev *indio_dev = dev_to_iio_dev(dev);
struct at91_adc_state *st = iio_priv(indio_dev);
- return scnprintf(buf, PAGE_SIZE, "%d\n", !!st->dma_st.dma_chan);
+ return sysfs_emit(buf, "%d\n", !!st->dma_st.dma_chan);
}
static ssize_t at91_adc_get_watermark(struct device *dev,
@@ -2190,7 +2190,7 @@ static ssize_t at91_adc_get_watermark(struct device *dev,
struct iio_dev *indio_dev = dev_to_iio_dev(dev);
struct at91_adc_state *st = iio_priv(indio_dev);
- return scnprintf(buf, PAGE_SIZE, "%d\n", st->dma_st.watermark);
+ return sysfs_emit(buf, "%d\n", st->dma_st.watermark);
}
static IIO_DEVICE_ATTR(hwfifo_enabled, 0444,
--
2.25.1
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] iio: adc: at91-sama5d2_adc: use sysfs_emit() to instead of scnprintf()
2022-12-01 3:42 [PATCH] iio: adc: at91-sama5d2_adc: use sysfs_emit() to instead of scnprintf() ye.xingchen
@ 2022-12-04 15:46 ` Jonathan Cameron
0 siblings, 0 replies; 2+ messages in thread
From: Jonathan Cameron @ 2022-12-04 15:46 UTC (permalink / raw)
To: ye.xingchen
Cc: eugen.hristev, lars, nicolas.ferre, alexandre.belloni,
claudiu.beznea, linux-iio, linux-arm-kernel, linux-kernel
On Thu, 1 Dec 2022 11:42:33 +0800 (CST)
<ye.xingchen@zte.com.cn> wrote:
> From: ye xingchen <ye.xingchen@zte.com.cn>
>
> Replace the open-code with sysfs_emit() to simplify the code.
>
> Signed-off-by: ye xingchen <ye.xingchen@zte.com.cn>
Applied.
Thanks,
Jonathan
> ---
> drivers/iio/adc/at91-sama5d2_adc.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/iio/adc/at91-sama5d2_adc.c b/drivers/iio/adc/at91-sama5d2_adc.c
> index ed4f8501bda8..50d02e5fc6fc 100644
> --- a/drivers/iio/adc/at91-sama5d2_adc.c
> +++ b/drivers/iio/adc/at91-sama5d2_adc.c
> @@ -2181,7 +2181,7 @@ static ssize_t at91_adc_get_fifo_state(struct device *dev,
> struct iio_dev *indio_dev = dev_to_iio_dev(dev);
> struct at91_adc_state *st = iio_priv(indio_dev);
>
> - return scnprintf(buf, PAGE_SIZE, "%d\n", !!st->dma_st.dma_chan);
> + return sysfs_emit(buf, "%d\n", !!st->dma_st.dma_chan);
> }
>
> static ssize_t at91_adc_get_watermark(struct device *dev,
> @@ -2190,7 +2190,7 @@ static ssize_t at91_adc_get_watermark(struct device *dev,
> struct iio_dev *indio_dev = dev_to_iio_dev(dev);
> struct at91_adc_state *st = iio_priv(indio_dev);
>
> - return scnprintf(buf, PAGE_SIZE, "%d\n", st->dma_st.watermark);
> + return sysfs_emit(buf, "%d\n", st->dma_st.watermark);
> }
>
> static IIO_DEVICE_ATTR(hwfifo_enabled, 0444,
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2022-12-04 15:33 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2022-12-01 3:42 [PATCH] iio: adc: at91-sama5d2_adc: use sysfs_emit() to instead of scnprintf() ye.xingchen
2022-12-04 15:46 ` Jonathan Cameron
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox