From: Jonathan Cameron <jic23@kernel.org>
To: carlos.song@nxp.com
Cc: lars@metafoo.de, rjones@gateworks.com,
Jonathan.Cameron@huawei.com, haibo.chen@nxp.com,
linux-imx@nxp.com, linux-iio@vger.kernel.org
Subject: Re: [PATCH v2 1/7] iio: imu: fxos8700: fix map lable of channel type to MAGN sensor
Date: Sun, 11 Dec 2022 13:42:02 +0000 [thread overview]
Message-ID: <20221211134202.6b64c717@jic23-huawei> (raw)
In-Reply-To: <20221208071911.2405922-2-carlos.song@nxp.com>
On Thu, 8 Dec 2022 15:19:05 +0800
carlos.song@nxp.com wrote:
> From: Carlos Song <carlos.song@nxp.com>
>
> FXOS8700 is an IMU sensor with ACCEL sensor and MAGN sensor.
> Sensor type is indexed by corresponding channel type in a switch.
> IIO_ANGL_VEL channel type mapped to MAGN sensor has caused confusion.
>
> Fix the mapping lable of "IIO_MAGN" channel type instead of
> "IIO_ANGL_VEL" channel type to MAGN sensor.
>
> Fixes: 84e5ddd5c46e ("iio: imu: Add support for the FXOS8700 IMU")
> Signed-off-by: Carlos Song <carlos.song@nxp.com>
Applied to the fixes-togreg branch of iio.git and marked for stable
inclusion.
Thanks,
Jonathan
> ---
> Changes for V2:
> - Modify the magnetometer sensitivity unit to be consistent with the
> documentation as 0.001g
> - Rework commit log
>
> diff --git a/drivers/iio/imu/fxos8700_core.c b/drivers/iio/imu/fxos8700_core.c
> index 423cfe526f2a..235b02b2f4e5 100644
> --- a/drivers/iio/imu/fxos8700_core.c
> +++ b/drivers/iio/imu/fxos8700_core.c
> @@ -320,7 +320,7 @@ static enum fxos8700_sensor fxos8700_to_sensor(enum iio_chan_type iio_type)
> switch (iio_type) {
> case IIO_ACCEL:
> return FXOS8700_ACCEL;
> - case IIO_ANGL_VEL:
> + case IIO_MAGN:
> return FXOS8700_MAGN;
> default:
> return -EINVAL;
next prev parent reply other threads:[~2022-12-11 13:29 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-12-08 7:19 [PATCH v2 0/7] iio: imu: fxos8700: fix few bugs in data readback and mode set carlos.song
2022-12-08 7:19 ` [PATCH v2 1/7] iio: imu: fxos8700: fix map lable of channel type to MAGN sensor carlos.song
2022-12-11 13:42 ` Jonathan Cameron [this message]
2022-12-08 7:19 ` [PATCH v2 2/7] iio: imu: fxos8700: fix swapped ACCEL and MAGN channels readback carlos.song
2022-12-11 13:43 ` Jonathan Cameron
2022-12-08 7:19 ` [PATCH v2 3/7] iio: imu: fxos8700: fix incompete " carlos.song
2022-12-11 13:45 ` Jonathan Cameron
2022-12-08 7:19 ` [PATCH v2 4/7] iio: imu: fxos8700: fix IMU data bits returned to user space carlos.song
2022-12-11 13:49 ` Jonathan Cameron
2022-12-08 7:19 ` [PATCH v2 5/7] iio: imu: fxos8700: fix ACCEL measurement range selection carlos.song
2022-12-11 13:51 ` Jonathan Cameron
2022-12-08 7:19 ` [PATCH v2 6/7] iio: imu: fxos8700: fix ODR register readback and initialization carlos.song
2022-12-11 14:01 ` Jonathan Cameron
2022-12-08 7:19 ` [PATCH v2 7/7] iio: imu: fxos8700: fix MAGN sensor scale and unit carlos.song
2022-12-11 14:05 ` Jonathan Cameron
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20221211134202.6b64c717@jic23-huawei \
--to=jic23@kernel.org \
--cc=Jonathan.Cameron@huawei.com \
--cc=carlos.song@nxp.com \
--cc=haibo.chen@nxp.com \
--cc=lars@metafoo.de \
--cc=linux-iio@vger.kernel.org \
--cc=linux-imx@nxp.com \
--cc=rjones@gateworks.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox