Linux IIO development
 help / color / mirror / Atom feed
From: Jonathan Cameron <jic23@kernel.org>
To: Peter Robinson <pbrobinson@gmail.com>
Cc: William Breathitt Gray <william.gray@linaro.org>,
	linux-iio@vger.kernel.org
Subject: Re: [PATCH 2/4] counter: intel: Depend on X86
Date: Sun, 8 Jan 2023 11:11:22 +0000	[thread overview]
Message-ID: <20230108111122.4abdadf5@jic23-huawei> (raw)
In-Reply-To: <20230108074750.443705-2-pbrobinson@gmail.com>

On Sun,  8 Jan 2023 07:47:48 +0000
Peter Robinson <pbrobinson@gmail.com> wrote:

> Limite the Intel counter driver to X86, it doesn't
> make sense to build it for all arches if the couner
> subsystem is enabled.
> 
> Signed-off-by: Peter Robinson <pbrobinson@gmail.com>

Probably better to go with
depends on X86 || COMPILE_TEST

Sometimes other compilers throw up issues that are missed by those
targeting a specific architecture.  Obviously this is less important
for x86 drivers than more obscure platforms, but meh the principle still
stands.

Jonathan


> ---
>  drivers/counter/Kconfig | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/drivers/counter/Kconfig b/drivers/counter/Kconfig
> index 508d857808e9..011e6af840fc 100644
> --- a/drivers/counter/Kconfig
> +++ b/drivers/counter/Kconfig
> @@ -41,6 +41,7 @@ config FTM_QUADDEC
>  
>  config INTEL_QEP
>  	tristate "Intel Quadrature Encoder Peripheral driver"
> +	depends on X86
>  	depends on PCI
>  	help
>  	  Select this option to enable the Intel Quadrature Encoder Peripheral


  reply	other threads:[~2023-01-08 10:57 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-01-08  7:47 [PATCH 1/4] counter: Sort the Kconfig entries alphabetically Peter Robinson
2023-01-08  7:47 ` [PATCH 2/4] counter: intel: Depend on X86 Peter Robinson
2023-01-08 11:11   ` Jonathan Cameron [this message]
2023-01-13 19:52   ` William Breathitt Gray
2023-01-08  7:47 ` [PATCH 3/4] counter: FTM quad: Depend on the Layerscape SoC Peter Robinson
2023-01-08 11:30   ` Jonathan Cameron
2023-01-08 11:58     ` Peter Robinson
2023-01-13 19:53   ` William Breathitt Gray
2023-01-08  7:47 ` [PATCH 4/4] counter: microchip: Add appropriate arch deps for TCP driver Peter Robinson
2023-01-13 19:54   ` William Breathitt Gray
2023-01-13 19:48 ` [PATCH 1/4] counter: Sort the Kconfig entries alphabetically William Breathitt Gray

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20230108111122.4abdadf5@jic23-huawei \
    --to=jic23@kernel.org \
    --cc=linux-iio@vger.kernel.org \
    --cc=pbrobinson@gmail.com \
    --cc=william.gray@linaro.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox