[PATCH 1/4] counter: Sort the Kconfig entries alphabetically

[PATCH 1/4] counter: Sort the Kconfig entries alphabetically

[Peter Robinson]

Sort the Kconfig menu alphabetically to make it easier
to read as the list grows larger.

Signed-off-by: Peter Robinson <pbrobinson@gmail.com>
---
 drivers/counter/Kconfig | 88 ++++++++++++++++++++---------------------
 1 file changed, 44 insertions(+), 44 deletions(-)

diff --git a/drivers/counter/Kconfig b/drivers/counter/Kconfig
index d388bf26f4dc..508d857808e9 100644
--- a/drivers/counter/Kconfig
+++ b/drivers/counter/Kconfig
@@ -29,6 +29,26 @@ config 104_QUAD_8
 	  array module parameter. The interrupt line numbers for the devices may
 	  be configured via the irq array module parameter.
 
+config FTM_QUADDEC
+	tristate "Flex Timer Module Quadrature decoder driver"
+	depends on HAS_IOMEM && OF
+	help
+	  Select this option to enable the Flex Timer Quadrature decoder
+	  driver.
+
+	  To compile this driver as a module, choose M here: the
+	  module will be called ftm-quaddec.
+
+config INTEL_QEP
+	tristate "Intel Quadrature Encoder Peripheral driver"
+	depends on PCI
+	help
+	  Select this option to enable the Intel Quadrature Encoder Peripheral
+	  driver.
+
+	  To compile this driver as a module, choose M here: the module
+	  will be called intel-qep.
+
 config INTERRUPT_CNT
 	tristate "Interrupt counter driver"
 	depends on GPIOLIB
@@ -39,15 +59,16 @@ config INTERRUPT_CNT
 	  To compile this driver as a module, choose M here: the
 	  module will be called interrupt-cnt.
 
-config STM32_TIMER_CNT
-	tristate "STM32 Timer encoder counter driver"
-	depends on MFD_STM32_TIMERS || COMPILE_TEST
+config MICROCHIP_TCB_CAPTURE
+	tristate "Microchip Timer Counter Capture driver"
+	depends on HAS_IOMEM && OF
+	select REGMAP_MMIO
 	help
-	  Select this option to enable STM32 Timer quadrature encoder
-	  and counter driver.
+	  Select this option to enable the Microchip Timer Counter Block
+	  capture driver.
 
 	  To compile this driver as a module, choose M here: the
-	  module will be called stm32-timer-cnt.
+	  module will be called microchip-tcb-capture.
 
 config STM32_LPTIMER_CNT
 	tristate "STM32 LP Timer encoder counter driver"
@@ -59,47 +80,15 @@ config STM32_LPTIMER_CNT
 	  To compile this driver as a module, choose M here: the
 	  module will be called stm32-lptimer-cnt.
 
-config TI_EQEP
-	tristate "TI eQEP counter driver"
-	depends on (SOC_AM33XX || COMPILE_TEST)
-	select REGMAP_MMIO
-	help
-	  Select this option to enable the Texas Instruments Enhanced Quadrature
-	  Encoder Pulse (eQEP) counter driver.
-
-	  To compile this driver as a module, choose M here: the module will be
-	  called ti-eqep.
-
-config FTM_QUADDEC
-	tristate "Flex Timer Module Quadrature decoder driver"
-	depends on HAS_IOMEM && OF
-	help
-	  Select this option to enable the Flex Timer Quadrature decoder
-	  driver.
-
-	  To compile this driver as a module, choose M here: the
-	  module will be called ftm-quaddec.
-
-config MICROCHIP_TCB_CAPTURE
-	tristate "Microchip Timer Counter Capture driver"
-	depends on HAS_IOMEM && OF
-	select REGMAP_MMIO
+config STM32_TIMER_CNT
+	tristate "STM32 Timer encoder counter driver"
+	depends on MFD_STM32_TIMERS || COMPILE_TEST
 	help
-	  Select this option to enable the Microchip Timer Counter Block
-	  capture driver.
+	  Select this option to enable STM32 Timer quadrature encoder
+	  and counter driver.
 
 	  To compile this driver as a module, choose M here: the
-	  module will be called microchip-tcb-capture.
-
-config INTEL_QEP
-	tristate "Intel Quadrature Encoder Peripheral driver"
-	depends on PCI
-	help
-	  Select this option to enable the Intel Quadrature Encoder Peripheral
-	  driver.
-
-	  To compile this driver as a module, choose M here: the module
-	  will be called intel-qep.
+	  module will be called stm32-timer-cnt.
 
 config TI_ECAP_CAPTURE
 	tristate "TI eCAP capture driver"
@@ -116,4 +105,15 @@ config TI_ECAP_CAPTURE
 	  To compile this driver as a module, choose M here: the module
 	  will be called ti-ecap-capture.
 
+config TI_EQEP
+	tristate "TI eQEP counter driver"
+	depends on (SOC_AM33XX || COMPILE_TEST)
+	select REGMAP_MMIO
+	help
+	  Select this option to enable the Texas Instruments Enhanced Quadrature
+	  Encoder Pulse (eQEP) counter driver.
+
+	  To compile this driver as a module, choose M here: the module will be
+	  called ti-eqep.
+
 endif # COUNTER
-- 
2.39.0

[PATCH 2/4] counter: intel: Depend on X86

[Peter Robinson]

Limite the Intel counter driver to X86, it doesn't
make sense to build it for all arches if the couner
subsystem is enabled.

Signed-off-by: Peter Robinson <pbrobinson@gmail.com>
---
 drivers/counter/Kconfig | 1 +
 1 file changed, 1 insertion(+)

diff --git a/drivers/counter/Kconfig b/drivers/counter/Kconfig
index 508d857808e9..011e6af840fc 100644
--- a/drivers/counter/Kconfig
+++ b/drivers/counter/Kconfig
@@ -41,6 +41,7 @@ config FTM_QUADDEC
 
 config INTEL_QEP
 	tristate "Intel Quadrature Encoder Peripheral driver"
+	depends on X86
 	depends on PCI
 	help
 	  Select this option to enable the Intel Quadrature Encoder Peripheral
-- 
2.39.0

Re: [PATCH 2/4] counter: intel: Depend on X86

[Jonathan Cameron]

On Sun,  8 Jan 2023 07:47:48 +0000
Peter Robinson <pbrobinson@gmail.com> wrote:

> Limite the Intel counter driver to X86, it doesn't
> make sense to build it for all arches if the couner
> subsystem is enabled.
> 
> Signed-off-by: Peter Robinson <pbrobinson@gmail.com>

Probably better to go with
depends on X86 || COMPILE_TEST

Sometimes other compilers throw up issues that are missed by those
targeting a specific architecture.  Obviously this is less important
for x86 drivers than more obscure platforms, but meh the principle still
stands.

Jonathan


> ---
>  drivers/counter/Kconfig | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/drivers/counter/Kconfig b/drivers/counter/Kconfig
> index 508d857808e9..011e6af840fc 100644
> --- a/drivers/counter/Kconfig
> +++ b/drivers/counter/Kconfig
> @@ -41,6 +41,7 @@ config FTM_QUADDEC
>  
>  config INTEL_QEP
>  	tristate "Intel Quadrature Encoder Peripheral driver"
> +	depends on X86
>  	depends on PCI
>  	help
>  	  Select this option to enable the Intel Quadrature Encoder Peripheral

Re: [PATCH 2/4] counter: intel: Depend on X86

[William Breathitt Gray]

[-- Attachment #1: Type: text/plain, Size: 392 bytes --]

On Sun, Jan 08, 2023 at 07:47:48AM +0000, Peter Robinson wrote:
> Limite the Intel counter driver to X86, it doesn't
> make sense to build it for all arches if the couner

I'll fix the "Limite" and "couner" typos as I pick up this patch.

> subsystem is enabled.
> 
> Signed-off-by: Peter Robinson <pbrobinson@gmail.com>

Applied to counter-next, thanks.

William Breathitt Gray

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 228 bytes --]

[PATCH 3/4] counter: FTM quad: Depend on the Layerscape SoC

[Peter Robinson]

At the moment only the Freescale LS1021A is the only HW that
supports this IP block so add an appropriate dependency and
compile test.

Signed-off-by: Peter Robinson <pbrobinson@gmail.com>
---
 drivers/counter/Kconfig | 1 +
 1 file changed, 1 insertion(+)

diff --git a/drivers/counter/Kconfig b/drivers/counter/Kconfig
index 011e6af840fc..ef78386ccd2e 100644
--- a/drivers/counter/Kconfig
+++ b/drivers/counter/Kconfig
@@ -31,6 +31,7 @@ config 104_QUAD_8
 
 config FTM_QUADDEC
 	tristate "Flex Timer Module Quadrature decoder driver"
+	depends on SOC_LS1021A || COMPILE_TEST
 	depends on HAS_IOMEM && OF
 	help
 	  Select this option to enable the Flex Timer Quadrature decoder
-- 
2.39.0

Re: [PATCH 3/4] counter: FTM quad: Depend on the Layerscape SoC

[Jonathan Cameron]

On Sun,  8 Jan 2023 07:47:49 +0000
Peter Robinson <pbrobinson@gmail.com> wrote:

> At the moment only the Freescale LS1021A is the only HW that
> supports this IP block so add an appropriate dependency and
> compile test.
> 
> Signed-off-by: Peter Robinson <pbrobinson@gmail.com>

Ah I see you had deliberately not put COMPILE_TEST for the x86
one - fair enough I guess.

For this one, the IP is fairly generic and I think appears on other
chips - not sure they are supported by Linux however.  Maybe it's
fine to limit it like this for now and see if anyone shouts...

Jonathan


> ---
>  drivers/counter/Kconfig | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/drivers/counter/Kconfig b/drivers/counter/Kconfig
> index 011e6af840fc..ef78386ccd2e 100644
> --- a/drivers/counter/Kconfig
> +++ b/drivers/counter/Kconfig
> @@ -31,6 +31,7 @@ config 104_QUAD_8
>  
>  config FTM_QUADDEC
>  	tristate "Flex Timer Module Quadrature decoder driver"
> +	depends on SOC_LS1021A || COMPILE_TEST
>  	depends on HAS_IOMEM && OF
>  	help
>  	  Select this option to enable the Flex Timer Quadrature decoder

Re: [PATCH 3/4] counter: FTM quad: Depend on the Layerscape SoC

[Peter Robinson]

On Sun, Jan 8, 2023 at 11:17 AM Jonathan Cameron <jic23@kernel.org> wrote:
>
> On Sun,  8 Jan 2023 07:47:49 +0000
> Peter Robinson <pbrobinson@gmail.com> wrote:
>
> > At the moment only the Freescale LS1021A is the only HW that
> > supports this IP block so add an appropriate dependency and
> > compile test.
> >
> > Signed-off-by: Peter Robinson <pbrobinson@gmail.com>
>
> Ah I see you had deliberately not put COMPILE_TEST for the x86
> one - fair enough I guess.
>
> For this one, the IP is fairly generic and I think appears on other
> chips - not sure they are supported by Linux however.  Maybe it's
> fine to limit it like this for now and see if anyone shouts...

It's currently only referenced in arch/arm/boot/dts/ls1021a.dtsi and I
don't have access to all the Layerscape docs to verify the IP, no
doubt there's others but they may need other changes for different IP
revs etc hence why I specified that one.

> Jonathan
>
>
> > ---
> >  drivers/counter/Kconfig | 1 +
> >  1 file changed, 1 insertion(+)
> >
> > diff --git a/drivers/counter/Kconfig b/drivers/counter/Kconfig
> > index 011e6af840fc..ef78386ccd2e 100644
> > --- a/drivers/counter/Kconfig
> > +++ b/drivers/counter/Kconfig
> > @@ -31,6 +31,7 @@ config 104_QUAD_8
> >
> >  config FTM_QUADDEC
> >       tristate "Flex Timer Module Quadrature decoder driver"
> > +     depends on SOC_LS1021A || COMPILE_TEST
> >       depends on HAS_IOMEM && OF
> >       help
> >         Select this option to enable the Flex Timer Quadrature decoder
>

Re: [PATCH 3/4] counter: FTM quad: Depend on the Layerscape SoC

[William Breathitt Gray]

[-- Attachment #1: Type: text/plain, Size: 331 bytes --]

On Sun, Jan 08, 2023 at 07:47:49AM +0000, Peter Robinson wrote:
> At the moment only the Freescale LS1021A is the only HW that
> supports this IP block so add an appropriate dependency and
> compile test.
> 
> Signed-off-by: Peter Robinson <pbrobinson@gmail.com>

Applied to counter-next, thanks.

William Breathitt Gray

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 228 bytes --]

[PATCH 4/4] counter: microchip: Add appropriate arch deps for TCP driver

[Peter Robinson]

Add the CONFIG_SOC_AT91SAM9 and CONFIG_SOC_SAM_V7 deps for the
Microchip SoCs that support this IP block/driver plus compile
time testing.

Signed-off-by: Peter Robinson <pbrobinson@gmail.com>
---
 drivers/counter/Kconfig | 1 +
 1 file changed, 1 insertion(+)

diff --git a/drivers/counter/Kconfig b/drivers/counter/Kconfig
index ef78386ccd2e..90602536fb13 100644
--- a/drivers/counter/Kconfig
+++ b/drivers/counter/Kconfig
@@ -63,6 +63,7 @@ config INTERRUPT_CNT
 
 config MICROCHIP_TCB_CAPTURE
 	tristate "Microchip Timer Counter Capture driver"
+	depends on CONFIG_SOC_AT91SAM9 || CONFIG_SOC_SAM_V7 || COMPILE_TEST
 	depends on HAS_IOMEM && OF
 	select REGMAP_MMIO
 	help
-- 
2.39.0

Re: [PATCH 4/4] counter: microchip: Add appropriate arch deps for TCP driver

[William Breathitt Gray]

[-- Attachment #1: Type: text/plain, Size: 335 bytes --]

On Sun, Jan 08, 2023 at 07:47:50AM +0000, Peter Robinson wrote:
> Add the CONFIG_SOC_AT91SAM9 and CONFIG_SOC_SAM_V7 deps for the
> Microchip SoCs that support this IP block/driver plus compile
> time testing.
> 
> Signed-off-by: Peter Robinson <pbrobinson@gmail.com>

Applied to counter-next, thanks.

William Breathitt Gray

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 228 bytes --]

Re: [PATCH 1/4] counter: Sort the Kconfig entries alphabetically

[William Breathitt Gray]

[-- Attachment #1: Type: text/plain, Size: 282 bytes --]

On Sun, Jan 08, 2023 at 07:47:47AM +0000, Peter Robinson wrote:
> Sort the Kconfig menu alphabetically to make it easier
> to read as the list grows larger.
> 
> Signed-off-by: Peter Robinson <pbrobinson@gmail.com>

Applied to counter-next, thanks.

William Breathitt Gray

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 228 bytes --]