Linux IIO development
 help / color / mirror / Atom feed
From: Jonathan Cameron <jic23@kernel.org>
To: "Nuno Sá" <nuno.sa@analog.com>
Cc: linux-iio@vger.kernel.org,
	"Uwe Kleine-König" <u.kleine-koenig@pengutronix.de>,
	"Lars-Peter Clausen" <lars@metafoo.de>,
	"Michael Hennerich" <Michael.Hennerich@analog.com>
Subject: Re: [PATCH] iio: imu: adis16475: correct copy paste mistake in comment block
Date: Sat, 18 Feb 2023 14:00:38 +0000	[thread overview]
Message-ID: <20230218140038.7293feb2@jic23-huawei> (raw)
In-Reply-To: <20230213153208.1027602-1-nuno.sa@analog.com>

On Mon, 13 Feb 2023 16:32:08 +0100
Nuno Sá <nuno.sa@analog.com> wrote:

> The minimal advised lower rate for adis16475 compatible devices is
> 1900HZ and not 4000HZ. Set that right in the comments so that it does
> not generate any confusion.
> 
> Signed-off-by: Nuno Sá <nuno.sa@analog.com>
Applied,

Thanks,

Jonathan

> ---
>  drivers/iio/imu/adis16475.c | 6 +++---
>  1 file changed, 3 insertions(+), 3 deletions(-)
> 
> diff --git a/drivers/iio/imu/adis16475.c b/drivers/iio/imu/adis16475.c
> index aec55f7e1f26..3abffb01ba31 100644
> --- a/drivers/iio/imu/adis16475.c
> +++ b/drivers/iio/imu/adis16475.c
> @@ -326,11 +326,11 @@ static int adis16475_set_freq(struct adis16475 *st, const u32 freq)
>  
>  		/*
>  		 * This is not an hard requirement but it's not advised to run the IMU
> -		 * with a sample rate lower than 4000Hz due to possible undersampling
> +		 * with a sample rate lower than 1900Hz due to possible undersampling
>  		 * issues. However, there are users that might really want to take the risk.
>  		 * Hence, we provide a module parameter for them. If set, we allow sample
> -		 * rates lower than 4KHz. By default, we won't allow this and we just roundup
> -		 * the rate to the next multiple of the input clock bigger than 4KHz. This
> +		 * rates lower than 1.9KHz. By default, we won't allow this and we just roundup
> +		 * the rate to the next multiple of the input clock bigger than 1.9KHz. This
>  		 * is done like this as in some cases (when DEC_RATE is 0) might give
>  		 * us the closest value to the one desired by the user...
>  		 */


      reply	other threads:[~2023-02-18 13:46 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-02-13 15:32 [PATCH] iio: imu: adis16475: correct copy paste mistake in comment block Nuno Sá
2023-02-18 14:00 ` Jonathan Cameron [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20230218140038.7293feb2@jic23-huawei \
    --to=jic23@kernel.org \
    --cc=Michael.Hennerich@analog.com \
    --cc=lars@metafoo.de \
    --cc=linux-iio@vger.kernel.org \
    --cc=nuno.sa@analog.com \
    --cc=u.kleine-koenig@pengutronix.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox