Linux IIO development
 help / color / mirror / Atom feed
* [PATCH] iio: imu: adis16475: correct copy paste mistake in comment block
@ 2023-02-13 15:32 Nuno Sá
  2023-02-18 14:00 ` Jonathan Cameron
  0 siblings, 1 reply; 2+ messages in thread
From: Nuno Sá @ 2023-02-13 15:32 UTC (permalink / raw)
  To: linux-iio
  Cc: Uwe Kleine-König, Nuno Sa, Lars-Peter Clausen,
	Michael Hennerich, Jonathan Cameron

The minimal advised lower rate for adis16475 compatible devices is
1900HZ and not 4000HZ. Set that right in the comments so that it does
not generate any confusion.

Signed-off-by: Nuno Sá <nuno.sa@analog.com>
---
 drivers/iio/imu/adis16475.c | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

diff --git a/drivers/iio/imu/adis16475.c b/drivers/iio/imu/adis16475.c
index aec55f7e1f26..3abffb01ba31 100644
--- a/drivers/iio/imu/adis16475.c
+++ b/drivers/iio/imu/adis16475.c
@@ -326,11 +326,11 @@ static int adis16475_set_freq(struct adis16475 *st, const u32 freq)
 
 		/*
 		 * This is not an hard requirement but it's not advised to run the IMU
-		 * with a sample rate lower than 4000Hz due to possible undersampling
+		 * with a sample rate lower than 1900Hz due to possible undersampling
 		 * issues. However, there are users that might really want to take the risk.
 		 * Hence, we provide a module parameter for them. If set, we allow sample
-		 * rates lower than 4KHz. By default, we won't allow this and we just roundup
-		 * the rate to the next multiple of the input clock bigger than 4KHz. This
+		 * rates lower than 1.9KHz. By default, we won't allow this and we just roundup
+		 * the rate to the next multiple of the input clock bigger than 1.9KHz. This
 		 * is done like this as in some cases (when DEC_RATE is 0) might give
 		 * us the closest value to the one desired by the user...
 		 */
-- 
2.39.1


^ permalink raw reply related	[flat|nested] 2+ messages in thread

* Re: [PATCH] iio: imu: adis16475: correct copy paste mistake in comment block
  2023-02-13 15:32 [PATCH] iio: imu: adis16475: correct copy paste mistake in comment block Nuno Sá
@ 2023-02-18 14:00 ` Jonathan Cameron
  0 siblings, 0 replies; 2+ messages in thread
From: Jonathan Cameron @ 2023-02-18 14:00 UTC (permalink / raw)
  To: Nuno Sá
  Cc: linux-iio, Uwe Kleine-König, Lars-Peter Clausen,
	Michael Hennerich

On Mon, 13 Feb 2023 16:32:08 +0100
Nuno Sá <nuno.sa@analog.com> wrote:

> The minimal advised lower rate for adis16475 compatible devices is
> 1900HZ and not 4000HZ. Set that right in the comments so that it does
> not generate any confusion.
> 
> Signed-off-by: Nuno Sá <nuno.sa@analog.com>
Applied,

Thanks,

Jonathan

> ---
>  drivers/iio/imu/adis16475.c | 6 +++---
>  1 file changed, 3 insertions(+), 3 deletions(-)
> 
> diff --git a/drivers/iio/imu/adis16475.c b/drivers/iio/imu/adis16475.c
> index aec55f7e1f26..3abffb01ba31 100644
> --- a/drivers/iio/imu/adis16475.c
> +++ b/drivers/iio/imu/adis16475.c
> @@ -326,11 +326,11 @@ static int adis16475_set_freq(struct adis16475 *st, const u32 freq)
>  
>  		/*
>  		 * This is not an hard requirement but it's not advised to run the IMU
> -		 * with a sample rate lower than 4000Hz due to possible undersampling
> +		 * with a sample rate lower than 1900Hz due to possible undersampling
>  		 * issues. However, there are users that might really want to take the risk.
>  		 * Hence, we provide a module parameter for them. If set, we allow sample
> -		 * rates lower than 4KHz. By default, we won't allow this and we just roundup
> -		 * the rate to the next multiple of the input clock bigger than 4KHz. This
> +		 * rates lower than 1.9KHz. By default, we won't allow this and we just roundup
> +		 * the rate to the next multiple of the input clock bigger than 1.9KHz. This
>  		 * is done like this as in some cases (when DEC_RATE is 0) might give
>  		 * us the closest value to the one desired by the user...
>  		 */


^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2023-02-18 13:46 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2023-02-13 15:32 [PATCH] iio: imu: adis16475: correct copy paste mistake in comment block Nuno Sá
2023-02-18 14:00 ` Jonathan Cameron

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox