Linux IIO development
 help / color / mirror / Atom feed
From: Jonathan Cameron <jic23@kernel.org>
To: Li Zetao <lizetao1@huawei.com>
Cc: <lars@metafoo.de>, <linux-iio@vger.kernel.org>
Subject: Re: [PATCH -next] iio: adc: men_z188_adc: Remove redundant initialization owner in men_z188_driver
Date: Sat, 5 Aug 2023 17:51:56 +0100	[thread overview]
Message-ID: <20230805175156.5b696e8e@jic23-huawei> (raw)
In-Reply-To: <20230804100938.100435-1-lizetao1@huawei.com>

On Fri, 4 Aug 2023 18:09:38 +0800
Li Zetao <lizetao1@huawei.com> wrote:

> The module_mcb_driver() will set "THIS_MODULE" to driver.owner when
> register a mcb_driver, so it is redundant initialization to set
> driver.owner in men_z188_driver statement. Remove it for clean code.
> 
> Signed-off-by: Li Zetao <lizetao1@huawei.com>
Applied to the togreg branch of iio.git.

Thanks,

Jonathan
> ---
>  drivers/iio/adc/men_z188_adc.c | 1 -
>  1 file changed, 1 deletion(-)
> 
> diff --git a/drivers/iio/adc/men_z188_adc.c b/drivers/iio/adc/men_z188_adc.c
> index adc5ceaef8c9..198c7e68e0cf 100644
> --- a/drivers/iio/adc/men_z188_adc.c
> +++ b/drivers/iio/adc/men_z188_adc.c
> @@ -161,7 +161,6 @@ MODULE_DEVICE_TABLE(mcb, men_z188_ids);
>  static struct mcb_driver men_z188_driver = {
>  	.driver = {
>  		.name = "z188-adc",
> -		.owner = THIS_MODULE,
>  	},
>  	.probe = men_z188_probe,
>  	.remove = men_z188_remove,


      reply	other threads:[~2023-08-05 16:52 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-08-04 10:09 [PATCH -next] iio: adc: men_z188_adc: Remove redundant initialization owner in men_z188_driver Li Zetao
2023-08-05 16:51 ` Jonathan Cameron [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20230805175156.5b696e8e@jic23-huawei \
    --to=jic23@kernel.org \
    --cc=lars@metafoo.de \
    --cc=linux-iio@vger.kernel.org \
    --cc=lizetao1@huawei.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox