* [PATCH -next] iio: adc: men_z188_adc: Remove redundant initialization owner in men_z188_driver
@ 2023-08-04 10:09 Li Zetao
2023-08-05 16:51 ` Jonathan Cameron
0 siblings, 1 reply; 2+ messages in thread
From: Li Zetao @ 2023-08-04 10:09 UTC (permalink / raw)
To: jic23, lars; +Cc: lizetao1, linux-iio
The module_mcb_driver() will set "THIS_MODULE" to driver.owner when
register a mcb_driver, so it is redundant initialization to set
driver.owner in men_z188_driver statement. Remove it for clean code.
Signed-off-by: Li Zetao <lizetao1@huawei.com>
---
drivers/iio/adc/men_z188_adc.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/drivers/iio/adc/men_z188_adc.c b/drivers/iio/adc/men_z188_adc.c
index adc5ceaef8c9..198c7e68e0cf 100644
--- a/drivers/iio/adc/men_z188_adc.c
+++ b/drivers/iio/adc/men_z188_adc.c
@@ -161,7 +161,6 @@ MODULE_DEVICE_TABLE(mcb, men_z188_ids);
static struct mcb_driver men_z188_driver = {
.driver = {
.name = "z188-adc",
- .owner = THIS_MODULE,
},
.probe = men_z188_probe,
.remove = men_z188_remove,
--
2.34.1
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH -next] iio: adc: men_z188_adc: Remove redundant initialization owner in men_z188_driver
2023-08-04 10:09 [PATCH -next] iio: adc: men_z188_adc: Remove redundant initialization owner in men_z188_driver Li Zetao
@ 2023-08-05 16:51 ` Jonathan Cameron
0 siblings, 0 replies; 2+ messages in thread
From: Jonathan Cameron @ 2023-08-05 16:51 UTC (permalink / raw)
To: Li Zetao; +Cc: lars, linux-iio
On Fri, 4 Aug 2023 18:09:38 +0800
Li Zetao <lizetao1@huawei.com> wrote:
> The module_mcb_driver() will set "THIS_MODULE" to driver.owner when
> register a mcb_driver, so it is redundant initialization to set
> driver.owner in men_z188_driver statement. Remove it for clean code.
>
> Signed-off-by: Li Zetao <lizetao1@huawei.com>
Applied to the togreg branch of iio.git.
Thanks,
Jonathan
> ---
> drivers/iio/adc/men_z188_adc.c | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/drivers/iio/adc/men_z188_adc.c b/drivers/iio/adc/men_z188_adc.c
> index adc5ceaef8c9..198c7e68e0cf 100644
> --- a/drivers/iio/adc/men_z188_adc.c
> +++ b/drivers/iio/adc/men_z188_adc.c
> @@ -161,7 +161,6 @@ MODULE_DEVICE_TABLE(mcb, men_z188_ids);
> static struct mcb_driver men_z188_driver = {
> .driver = {
> .name = "z188-adc",
> - .owner = THIS_MODULE,
> },
> .probe = men_z188_probe,
> .remove = men_z188_remove,
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2023-08-05 16:52 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2023-08-04 10:09 [PATCH -next] iio: adc: men_z188_adc: Remove redundant initialization owner in men_z188_driver Li Zetao
2023-08-05 16:51 ` Jonathan Cameron
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox