Linux IIO development
 help / color / mirror / Atom feed
* [PATCH] iio: light: opt4001: Use i2c_get_match_data()
@ 2023-08-12 15:19 Biju Das
  2023-08-28 16:23 ` Jonathan Cameron
  2023-08-30  8:17 ` Stefan Windfeldt-Prytz
  0 siblings, 2 replies; 3+ messages in thread
From: Biju Das @ 2023-08-12 15:19 UTC (permalink / raw)
  To: Jonathan Cameron
  Cc: Biju Das, Lars-Peter Clausen, Andy Shevchenko,
	Stefan Windfeldt-Prytz, Uwe Kleine-König, linux-iio,
	Geert Uytterhoeven, linux-renesas-soc

Replace device_get_match_data()->i2c_get_match_data() to extend matching
support for ID table.

Signed-off-by: Biju Das <biju.das.jz@bp.renesas.com>
---
 drivers/iio/light/opt4001.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/iio/light/opt4001.c b/drivers/iio/light/opt4001.c
index 502946bf9f94..6cf60151b3d8 100644
--- a/drivers/iio/light/opt4001.c
+++ b/drivers/iio/light/opt4001.c
@@ -412,7 +412,7 @@ static int opt4001_probe(struct i2c_client *client)
 	if (dev_id != OPT4001_DEVICE_ID_VAL)
 		dev_warn(&client->dev, "Device ID: %#04x unknown\n", dev_id);
 
-	chip->chip_info = device_get_match_data(&client->dev);
+	chip->chip_info = i2c_get_match_data(client);
 
 	indio_dev->channels = opt4001_channels;
 	indio_dev->num_channels = ARRAY_SIZE(opt4001_channels);
-- 
2.25.1


^ permalink raw reply related	[flat|nested] 3+ messages in thread

* Re: [PATCH] iio: light: opt4001: Use i2c_get_match_data()
  2023-08-12 15:19 [PATCH] iio: light: opt4001: Use i2c_get_match_data() Biju Das
@ 2023-08-28 16:23 ` Jonathan Cameron
  2023-08-30  8:17 ` Stefan Windfeldt-Prytz
  1 sibling, 0 replies; 3+ messages in thread
From: Jonathan Cameron @ 2023-08-28 16:23 UTC (permalink / raw)
  To: Biju Das
  Cc: Lars-Peter Clausen, Andy Shevchenko, Stefan Windfeldt-Prytz,
	Uwe Kleine-König, linux-iio, Geert Uytterhoeven,
	linux-renesas-soc

On Sat, 12 Aug 2023 16:19:08 +0100
Biju Das <biju.das.jz@bp.renesas.com> wrote:

> Replace device_get_match_data()->i2c_get_match_data() to extend matching
> support for ID table.
> 
> Signed-off-by: Biju Das <biju.das.jz@bp.renesas.com>

This is fairly harmless (I think) but if Stefan or anyone else has a comment
I won't be pushing this out as non rebasing until after rc1.

Applied to the togreg branch of iio.git and pushed out as testing.

Thanks,

Jonathan

> ---
>  drivers/iio/light/opt4001.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/iio/light/opt4001.c b/drivers/iio/light/opt4001.c
> index 502946bf9f94..6cf60151b3d8 100644
> --- a/drivers/iio/light/opt4001.c
> +++ b/drivers/iio/light/opt4001.c
> @@ -412,7 +412,7 @@ static int opt4001_probe(struct i2c_client *client)
>  	if (dev_id != OPT4001_DEVICE_ID_VAL)
>  		dev_warn(&client->dev, "Device ID: %#04x unknown\n", dev_id);
>  
> -	chip->chip_info = device_get_match_data(&client->dev);
> +	chip->chip_info = i2c_get_match_data(client);
>  
>  	indio_dev->channels = opt4001_channels;
>  	indio_dev->num_channels = ARRAY_SIZE(opt4001_channels);


^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [PATCH] iio: light: opt4001: Use i2c_get_match_data()
  2023-08-12 15:19 [PATCH] iio: light: opt4001: Use i2c_get_match_data() Biju Das
  2023-08-28 16:23 ` Jonathan Cameron
@ 2023-08-30  8:17 ` Stefan Windfeldt-Prytz
  1 sibling, 0 replies; 3+ messages in thread
From: Stefan Windfeldt-Prytz @ 2023-08-30  8:17 UTC (permalink / raw)
  To: Biju Das, Jonathan Cameron
  Cc: Lars-Peter Clausen, Andy Shevchenko, Uwe Kleine-König,
	linux-iio, Geert Uytterhoeven, linux-renesas-soc

On 8/12/23 17:19, Biju Das wrote:
> Replace device_get_match_data()->i2c_get_match_data() to extend matching
> support for ID table.
> 
> Signed-off-by: Biju Das <biju.das.jz@bp.renesas.com>
> ---
>   drivers/iio/light/opt4001.c | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/iio/light/opt4001.c b/drivers/iio/light/opt4001.c
> index 502946bf9f94..6cf60151b3d8 100644
> --- a/drivers/iio/light/opt4001.c
> +++ b/drivers/iio/light/opt4001.c
> @@ -412,7 +412,7 @@ static int opt4001_probe(struct i2c_client *client)
>   	if (dev_id != OPT4001_DEVICE_ID_VAL)
>   		dev_warn(&client->dev, "Device ID: %#04x unknown\n", dev_id);
>   
> -	chip->chip_info = device_get_match_data(&client->dev);
> +	chip->chip_info = i2c_get_match_data(client);
>   
>   	indio_dev->channels = opt4001_channels;
>   	indio_dev->num_channels = ARRAY_SIZE(opt4001_channels);

Reviewed-by: Stefan Windfeldt-Prytz <stefan.windfeldt-prytz@axis.com>
Tested-by: Stefan Windfeldt-Prytz <stefan.windfeldt-prytz@axis.com>

^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2023-08-30 18:36 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2023-08-12 15:19 [PATCH] iio: light: opt4001: Use i2c_get_match_data() Biju Das
2023-08-28 16:23 ` Jonathan Cameron
2023-08-30  8:17 ` Stefan Windfeldt-Prytz

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox