Linux IIO development
 help / color / mirror / Atom feed
From: Jonathan Cameron <jic23@kernel.org>
To: Bough Chen <haibo.chen@nxp.com>
Cc: "lars@metafoo.de" <lars@metafoo.de>,
	"shawnguo@kernel.org" <shawnguo@kernel.org>,
	"s.hauer@pengutronix.de" <s.hauer@pengutronix.de>,
	"kernel@pengutronix.de" <kernel@pengutronix.de>,
	"festevam@gmail.com" <festevam@gmail.com>,
	dl-linux-imx <linux-imx@nxp.com>,
	"linux-iio@vger.kernel.org" <linux-iio@vger.kernel.org>
Subject: Re: [PATCH] iio: adc: imx93: add four channels for imx93 adc
Date: Mon, 4 Dec 2023 09:58:07 +0000	[thread overview]
Message-ID: <20231204095807.492ae925@jic23-huawei> (raw)
In-Reply-To: <DB7PR04MB401023D016E11C44699310D090BDA@DB7PR04MB4010.eurprd04.prod.outlook.com>

On Mon, 27 Nov 2023 02:47:31 +0000
Bough Chen <haibo.chen@nxp.com> wrote:

> > -----Original Message-----
> > From: Jonathan Cameron <jic23@kernel.org>
> > Sent: 2023年11月27日 0:03
> > To: Bough Chen <haibo.chen@nxp.com>
> > Cc: lars@metafoo.de; shawnguo@kernel.org; s.hauer@pengutronix.de;
> > kernel@pengutronix.de; festevam@gmail.com; dl-linux-imx
> > <linux-imx@nxp.com>; linux-iio@vger.kernel.org
> > Subject: Re: [PATCH] iio: adc: imx93: add four channels for imx93 adc
> > 
> > On Thu, 16 Nov 2023 15:10:26 +0800
> > haibo.chen@nxp.com wrote:
> >   
> > > From: Haibo Chen <haibo.chen@nxp.com>
> > >
> > > According to the spec, this ADC totally support 8 channels.
> > > i.MX93 contain this ADC with 4 channels connected to pins in the
> > > package. i.MX95 contain this ADC with 8 channels connected to pins in
> > > the package.
> > >
> > > Signed-off-by: Haibo Chen <haibo.chen@nxp.com>  
> > Should I treat this as a fix?
> > 
> > If so could you reply with a fixes tag please  
> 
> Yes, please help add:
> Fixes: 7d02296ac8b8 ("iio: adc: add imx93 adc support")
Applied.  Thanks,

Jonathan

> 
> Thanks
> Haibo Chen
> > 
> > Thanks,
> > 
> > Jonathan
> >   
> > > ---
> > >  drivers/iio/adc/imx93_adc.c | 4 ++++
> > >  1 file changed, 4 insertions(+)
> > >
> > > diff --git a/drivers/iio/adc/imx93_adc.c b/drivers/iio/adc/imx93_adc.c
> > > index 9bb1e4ba1aee..4ccf4819f1f1 100644
> > > --- a/drivers/iio/adc/imx93_adc.c
> > > +++ b/drivers/iio/adc/imx93_adc.c
> > > @@ -93,6 +93,10 @@ static const struct iio_chan_spec  
> > imx93_adc_iio_channels[] = {  
> > >  	IMX93_ADC_CHAN(1),
> > >  	IMX93_ADC_CHAN(2),
> > >  	IMX93_ADC_CHAN(3),
> > > +	IMX93_ADC_CHAN(4),
> > > +	IMX93_ADC_CHAN(5),
> > > +	IMX93_ADC_CHAN(6),
> > > +	IMX93_ADC_CHAN(7),
> > >  };
> > >
> > >  static void imx93_adc_power_down(struct imx93_adc *adc)  
> 


      reply	other threads:[~2023-12-04  9:58 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-11-16  7:10 [PATCH] iio: adc: imx93: add four channels for imx93 adc haibo.chen
2023-11-26 16:03 ` Jonathan Cameron
2023-11-27  2:47   ` Bough Chen
2023-12-04  9:58     ` Jonathan Cameron [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20231204095807.492ae925@jic23-huawei \
    --to=jic23@kernel.org \
    --cc=festevam@gmail.com \
    --cc=haibo.chen@nxp.com \
    --cc=kernel@pengutronix.de \
    --cc=lars@metafoo.de \
    --cc=linux-iio@vger.kernel.org \
    --cc=linux-imx@nxp.com \
    --cc=s.hauer@pengutronix.de \
    --cc=shawnguo@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox