From: Jonathan Cameron <jic23@kernel.org>
To: haibo.chen@nxp.com
Cc: lars@metafoo.de, shawnguo@kernel.org, s.hauer@pengutronix.de,
kernel@pengutronix.de, festevam@gmail.com, linux-imx@nxp.com,
linux-iio@vger.kernel.org
Subject: Re: [PATCH] iio: adc: imx93: add four channels for imx93 adc
Date: Sun, 26 Nov 2023 16:03:12 +0000 [thread overview]
Message-ID: <20231126160312.2ef8a307@jic23-huawei> (raw)
In-Reply-To: <20231116071026.611269-1-haibo.chen@nxp.com>
On Thu, 16 Nov 2023 15:10:26 +0800
haibo.chen@nxp.com wrote:
> From: Haibo Chen <haibo.chen@nxp.com>
>
> According to the spec, this ADC totally support 8 channels.
> i.MX93 contain this ADC with 4 channels connected to pins in
> the package. i.MX95 contain this ADC with 8 channels connected
> to pins in the package.
>
> Signed-off-by: Haibo Chen <haibo.chen@nxp.com>
Should I treat this as a fix?
If so could you reply with a fixes tag please
Thanks,
Jonathan
> ---
> drivers/iio/adc/imx93_adc.c | 4 ++++
> 1 file changed, 4 insertions(+)
>
> diff --git a/drivers/iio/adc/imx93_adc.c b/drivers/iio/adc/imx93_adc.c
> index 9bb1e4ba1aee..4ccf4819f1f1 100644
> --- a/drivers/iio/adc/imx93_adc.c
> +++ b/drivers/iio/adc/imx93_adc.c
> @@ -93,6 +93,10 @@ static const struct iio_chan_spec imx93_adc_iio_channels[] = {
> IMX93_ADC_CHAN(1),
> IMX93_ADC_CHAN(2),
> IMX93_ADC_CHAN(3),
> + IMX93_ADC_CHAN(4),
> + IMX93_ADC_CHAN(5),
> + IMX93_ADC_CHAN(6),
> + IMX93_ADC_CHAN(7),
> };
>
> static void imx93_adc_power_down(struct imx93_adc *adc)
next prev parent reply other threads:[~2023-11-26 16:03 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-11-16 7:10 [PATCH] iio: adc: imx93: add four channels for imx93 adc haibo.chen
2023-11-26 16:03 ` Jonathan Cameron [this message]
2023-11-27 2:47 ` Bough Chen
2023-12-04 9:58 ` Jonathan Cameron
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20231126160312.2ef8a307@jic23-huawei \
--to=jic23@kernel.org \
--cc=festevam@gmail.com \
--cc=haibo.chen@nxp.com \
--cc=kernel@pengutronix.de \
--cc=lars@metafoo.de \
--cc=linux-iio@vger.kernel.org \
--cc=linux-imx@nxp.com \
--cc=s.hauer@pengutronix.de \
--cc=shawnguo@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox