* [PATCH] iio: adc: imx93: add four channels for imx93 adc
@ 2023-11-16 7:10 haibo.chen
2023-11-26 16:03 ` Jonathan Cameron
0 siblings, 1 reply; 4+ messages in thread
From: haibo.chen @ 2023-11-16 7:10 UTC (permalink / raw)
To: jic23, lars
Cc: shawnguo, s.hauer, kernel, festevam, linux-imx, haibo.chen,
linux-iio
From: Haibo Chen <haibo.chen@nxp.com>
According to the spec, this ADC totally support 8 channels.
i.MX93 contain this ADC with 4 channels connected to pins in
the package. i.MX95 contain this ADC with 8 channels connected
to pins in the package.
Signed-off-by: Haibo Chen <haibo.chen@nxp.com>
---
drivers/iio/adc/imx93_adc.c | 4 ++++
1 file changed, 4 insertions(+)
diff --git a/drivers/iio/adc/imx93_adc.c b/drivers/iio/adc/imx93_adc.c
index 9bb1e4ba1aee..4ccf4819f1f1 100644
--- a/drivers/iio/adc/imx93_adc.c
+++ b/drivers/iio/adc/imx93_adc.c
@@ -93,6 +93,10 @@ static const struct iio_chan_spec imx93_adc_iio_channels[] = {
IMX93_ADC_CHAN(1),
IMX93_ADC_CHAN(2),
IMX93_ADC_CHAN(3),
+ IMX93_ADC_CHAN(4),
+ IMX93_ADC_CHAN(5),
+ IMX93_ADC_CHAN(6),
+ IMX93_ADC_CHAN(7),
};
static void imx93_adc_power_down(struct imx93_adc *adc)
--
2.34.1
^ permalink raw reply related [flat|nested] 4+ messages in thread* Re: [PATCH] iio: adc: imx93: add four channels for imx93 adc
2023-11-16 7:10 [PATCH] iio: adc: imx93: add four channels for imx93 adc haibo.chen
@ 2023-11-26 16:03 ` Jonathan Cameron
2023-11-27 2:47 ` Bough Chen
0 siblings, 1 reply; 4+ messages in thread
From: Jonathan Cameron @ 2023-11-26 16:03 UTC (permalink / raw)
To: haibo.chen
Cc: lars, shawnguo, s.hauer, kernel, festevam, linux-imx, linux-iio
On Thu, 16 Nov 2023 15:10:26 +0800
haibo.chen@nxp.com wrote:
> From: Haibo Chen <haibo.chen@nxp.com>
>
> According to the spec, this ADC totally support 8 channels.
> i.MX93 contain this ADC with 4 channels connected to pins in
> the package. i.MX95 contain this ADC with 8 channels connected
> to pins in the package.
>
> Signed-off-by: Haibo Chen <haibo.chen@nxp.com>
Should I treat this as a fix?
If so could you reply with a fixes tag please
Thanks,
Jonathan
> ---
> drivers/iio/adc/imx93_adc.c | 4 ++++
> 1 file changed, 4 insertions(+)
>
> diff --git a/drivers/iio/adc/imx93_adc.c b/drivers/iio/adc/imx93_adc.c
> index 9bb1e4ba1aee..4ccf4819f1f1 100644
> --- a/drivers/iio/adc/imx93_adc.c
> +++ b/drivers/iio/adc/imx93_adc.c
> @@ -93,6 +93,10 @@ static const struct iio_chan_spec imx93_adc_iio_channels[] = {
> IMX93_ADC_CHAN(1),
> IMX93_ADC_CHAN(2),
> IMX93_ADC_CHAN(3),
> + IMX93_ADC_CHAN(4),
> + IMX93_ADC_CHAN(5),
> + IMX93_ADC_CHAN(6),
> + IMX93_ADC_CHAN(7),
> };
>
> static void imx93_adc_power_down(struct imx93_adc *adc)
^ permalink raw reply [flat|nested] 4+ messages in thread* RE: [PATCH] iio: adc: imx93: add four channels for imx93 adc
2023-11-26 16:03 ` Jonathan Cameron
@ 2023-11-27 2:47 ` Bough Chen
2023-12-04 9:58 ` Jonathan Cameron
0 siblings, 1 reply; 4+ messages in thread
From: Bough Chen @ 2023-11-27 2:47 UTC (permalink / raw)
To: Jonathan Cameron
Cc: lars@metafoo.de, shawnguo@kernel.org, s.hauer@pengutronix.de,
kernel@pengutronix.de, festevam@gmail.com, dl-linux-imx,
linux-iio@vger.kernel.org
> -----Original Message-----
> From: Jonathan Cameron <jic23@kernel.org>
> Sent: 2023年11月27日 0:03
> To: Bough Chen <haibo.chen@nxp.com>
> Cc: lars@metafoo.de; shawnguo@kernel.org; s.hauer@pengutronix.de;
> kernel@pengutronix.de; festevam@gmail.com; dl-linux-imx
> <linux-imx@nxp.com>; linux-iio@vger.kernel.org
> Subject: Re: [PATCH] iio: adc: imx93: add four channels for imx93 adc
>
> On Thu, 16 Nov 2023 15:10:26 +0800
> haibo.chen@nxp.com wrote:
>
> > From: Haibo Chen <haibo.chen@nxp.com>
> >
> > According to the spec, this ADC totally support 8 channels.
> > i.MX93 contain this ADC with 4 channels connected to pins in the
> > package. i.MX95 contain this ADC with 8 channels connected to pins in
> > the package.
> >
> > Signed-off-by: Haibo Chen <haibo.chen@nxp.com>
> Should I treat this as a fix?
>
> If so could you reply with a fixes tag please
Yes, please help add:
Fixes: 7d02296ac8b8 ("iio: adc: add imx93 adc support")
Thanks
Haibo Chen
>
> Thanks,
>
> Jonathan
>
> > ---
> > drivers/iio/adc/imx93_adc.c | 4 ++++
> > 1 file changed, 4 insertions(+)
> >
> > diff --git a/drivers/iio/adc/imx93_adc.c b/drivers/iio/adc/imx93_adc.c
> > index 9bb1e4ba1aee..4ccf4819f1f1 100644
> > --- a/drivers/iio/adc/imx93_adc.c
> > +++ b/drivers/iio/adc/imx93_adc.c
> > @@ -93,6 +93,10 @@ static const struct iio_chan_spec
> imx93_adc_iio_channels[] = {
> > IMX93_ADC_CHAN(1),
> > IMX93_ADC_CHAN(2),
> > IMX93_ADC_CHAN(3),
> > + IMX93_ADC_CHAN(4),
> > + IMX93_ADC_CHAN(5),
> > + IMX93_ADC_CHAN(6),
> > + IMX93_ADC_CHAN(7),
> > };
> >
> > static void imx93_adc_power_down(struct imx93_adc *adc)
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: [PATCH] iio: adc: imx93: add four channels for imx93 adc
2023-11-27 2:47 ` Bough Chen
@ 2023-12-04 9:58 ` Jonathan Cameron
0 siblings, 0 replies; 4+ messages in thread
From: Jonathan Cameron @ 2023-12-04 9:58 UTC (permalink / raw)
To: Bough Chen
Cc: lars@metafoo.de, shawnguo@kernel.org, s.hauer@pengutronix.de,
kernel@pengutronix.de, festevam@gmail.com, dl-linux-imx,
linux-iio@vger.kernel.org
On Mon, 27 Nov 2023 02:47:31 +0000
Bough Chen <haibo.chen@nxp.com> wrote:
> > -----Original Message-----
> > From: Jonathan Cameron <jic23@kernel.org>
> > Sent: 2023年11月27日 0:03
> > To: Bough Chen <haibo.chen@nxp.com>
> > Cc: lars@metafoo.de; shawnguo@kernel.org; s.hauer@pengutronix.de;
> > kernel@pengutronix.de; festevam@gmail.com; dl-linux-imx
> > <linux-imx@nxp.com>; linux-iio@vger.kernel.org
> > Subject: Re: [PATCH] iio: adc: imx93: add four channels for imx93 adc
> >
> > On Thu, 16 Nov 2023 15:10:26 +0800
> > haibo.chen@nxp.com wrote:
> >
> > > From: Haibo Chen <haibo.chen@nxp.com>
> > >
> > > According to the spec, this ADC totally support 8 channels.
> > > i.MX93 contain this ADC with 4 channels connected to pins in the
> > > package. i.MX95 contain this ADC with 8 channels connected to pins in
> > > the package.
> > >
> > > Signed-off-by: Haibo Chen <haibo.chen@nxp.com>
> > Should I treat this as a fix?
> >
> > If so could you reply with a fixes tag please
>
> Yes, please help add:
> Fixes: 7d02296ac8b8 ("iio: adc: add imx93 adc support")
Applied. Thanks,
Jonathan
>
> Thanks
> Haibo Chen
> >
> > Thanks,
> >
> > Jonathan
> >
> > > ---
> > > drivers/iio/adc/imx93_adc.c | 4 ++++
> > > 1 file changed, 4 insertions(+)
> > >
> > > diff --git a/drivers/iio/adc/imx93_adc.c b/drivers/iio/adc/imx93_adc.c
> > > index 9bb1e4ba1aee..4ccf4819f1f1 100644
> > > --- a/drivers/iio/adc/imx93_adc.c
> > > +++ b/drivers/iio/adc/imx93_adc.c
> > > @@ -93,6 +93,10 @@ static const struct iio_chan_spec
> > imx93_adc_iio_channels[] = {
> > > IMX93_ADC_CHAN(1),
> > > IMX93_ADC_CHAN(2),
> > > IMX93_ADC_CHAN(3),
> > > + IMX93_ADC_CHAN(4),
> > > + IMX93_ADC_CHAN(5),
> > > + IMX93_ADC_CHAN(6),
> > > + IMX93_ADC_CHAN(7),
> > > };
> > >
> > > static void imx93_adc_power_down(struct imx93_adc *adc)
>
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2023-12-04 9:58 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2023-11-16 7:10 [PATCH] iio: adc: imx93: add four channels for imx93 adc haibo.chen
2023-11-26 16:03 ` Jonathan Cameron
2023-11-27 2:47 ` Bough Chen
2023-12-04 9:58 ` Jonathan Cameron
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox