Linux IIO development
 help / color / mirror / Atom feed
From: Jonathan Cameron <jic23@kernel.org>
To: Nikita Mikhailevich <ermyril@gmail.com>
Cc: lars@metafoo.de, linux-iio@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] iio: accel: mxc4005: new ACPI ID for the MXC6655 accelerometer
Date: Sun, 4 Feb 2024 15:08:43 +0000	[thread overview]
Message-ID: <20240204150843.79f76071@jic23-huawei> (raw)
In-Reply-To: <20240201151848.1666245-1-ermyril@gmail.com>

On Thu,  1 Feb 2024 16:18:48 +0100
Nikita Mikhailevich <ermyril@gmail.com> wrote:

> New ID was introduced by Chuwi on Minibook X 2023.

So interestingly MDA is a valid PNP ID. But an old one from 1997 for
Media4 Inc. 

Let's hope they never used that device number in a way that will bite us.

Applied to the togreg branch of iio.git and pushed out as testing for 0-day
to play with it.

Note that if anyone has a path to Chuwi to educate them on how to do
ACPI ids correctly then feel free to pass it on!

The MXC ones are also invalid btw - in that case there is no such PNP
ID unless it's been very recently granted which seems unlikely.

Jonathan

> 
> Signed-off-by: Nikita Mikhailevich <ermyril@gmail.com>
> ---
>  drivers/iio/accel/mxc4005.c | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/drivers/iio/accel/mxc4005.c b/drivers/iio/accel/mxc4005.c
> index 82e8d0b39..09764ef8b 100644
> --- a/drivers/iio/accel/mxc4005.c
> +++ b/drivers/iio/accel/mxc4005.c
> @@ -472,6 +472,7 @@ static int mxc4005_probe(struct i2c_client *client)
>  static const struct acpi_device_id mxc4005_acpi_match[] = {
>  	{"MXC4005",	0},
>  	{"MXC6655",	0},
> +	{"MDA6655",	0},
>  	{ },
>  };
>  MODULE_DEVICE_TABLE(acpi, mxc4005_acpi_match);
> --
> 2.43.0
> 


      reply	other threads:[~2024-02-04 15:08 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-02-01 15:18 [PATCH] iio: accel: mxc4005: new ACPI ID for the MXC6655 accelerometer Nikita Mikhailevich
2024-02-04 15:08 ` Jonathan Cameron [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20240204150843.79f76071@jic23-huawei \
    --to=jic23@kernel.org \
    --cc=ermyril@gmail.com \
    --cc=lars@metafoo.de \
    --cc=linux-iio@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox