Linux IIO development
 help / color / mirror / Atom feed
* [PATCH] iio: accel: mxc4005: new ACPI ID for the MXC6655 accelerometer
@ 2024-02-01 15:18 Nikita Mikhailevich
  2024-02-04 15:08 ` Jonathan Cameron
  0 siblings, 1 reply; 2+ messages in thread
From: Nikita Mikhailevich @ 2024-02-01 15:18 UTC (permalink / raw)
  To: jic23; +Cc: lars, linux-iio, linux-kernel, ermyril

New ID was introduced by Chuwi on Minibook X 2023.

Signed-off-by: Nikita Mikhailevich <ermyril@gmail.com>
---
 drivers/iio/accel/mxc4005.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/drivers/iio/accel/mxc4005.c b/drivers/iio/accel/mxc4005.c
index 82e8d0b39..09764ef8b 100644
--- a/drivers/iio/accel/mxc4005.c
+++ b/drivers/iio/accel/mxc4005.c
@@ -472,6 +472,7 @@ static int mxc4005_probe(struct i2c_client *client)
 static const struct acpi_device_id mxc4005_acpi_match[] = {
 	{"MXC4005",	0},
 	{"MXC6655",	0},
+	{"MDA6655",	0},
 	{ },
 };
 MODULE_DEVICE_TABLE(acpi, mxc4005_acpi_match);
--
2.43.0


^ permalink raw reply related	[flat|nested] 2+ messages in thread

* Re: [PATCH] iio: accel: mxc4005: new ACPI ID for the MXC6655 accelerometer
  2024-02-01 15:18 [PATCH] iio: accel: mxc4005: new ACPI ID for the MXC6655 accelerometer Nikita Mikhailevich
@ 2024-02-04 15:08 ` Jonathan Cameron
  0 siblings, 0 replies; 2+ messages in thread
From: Jonathan Cameron @ 2024-02-04 15:08 UTC (permalink / raw)
  To: Nikita Mikhailevich; +Cc: lars, linux-iio, linux-kernel

On Thu,  1 Feb 2024 16:18:48 +0100
Nikita Mikhailevich <ermyril@gmail.com> wrote:

> New ID was introduced by Chuwi on Minibook X 2023.

So interestingly MDA is a valid PNP ID. But an old one from 1997 for
Media4 Inc. 

Let's hope they never used that device number in a way that will bite us.

Applied to the togreg branch of iio.git and pushed out as testing for 0-day
to play with it.

Note that if anyone has a path to Chuwi to educate them on how to do
ACPI ids correctly then feel free to pass it on!

The MXC ones are also invalid btw - in that case there is no such PNP
ID unless it's been very recently granted which seems unlikely.

Jonathan

> 
> Signed-off-by: Nikita Mikhailevich <ermyril@gmail.com>
> ---
>  drivers/iio/accel/mxc4005.c | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/drivers/iio/accel/mxc4005.c b/drivers/iio/accel/mxc4005.c
> index 82e8d0b39..09764ef8b 100644
> --- a/drivers/iio/accel/mxc4005.c
> +++ b/drivers/iio/accel/mxc4005.c
> @@ -472,6 +472,7 @@ static int mxc4005_probe(struct i2c_client *client)
>  static const struct acpi_device_id mxc4005_acpi_match[] = {
>  	{"MXC4005",	0},
>  	{"MXC6655",	0},
> +	{"MDA6655",	0},
>  	{ },
>  };
>  MODULE_DEVICE_TABLE(acpi, mxc4005_acpi_match);
> --
> 2.43.0
> 


^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2024-02-04 15:08 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2024-02-01 15:18 [PATCH] iio: accel: mxc4005: new ACPI ID for the MXC6655 accelerometer Nikita Mikhailevich
2024-02-04 15:08 ` Jonathan Cameron

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox