Re: [PATCH] dt-bindings: iio: ti,tmp117: add optional label binding

[Marco Felsch <m.felsch@pengutronix.de>]

On 24-02-26, Krzysztof Kozlowski wrote:
> On 26/02/2024 11:23, Marco Felsch wrote:
> > On 24-02-26, Krzysztof Kozlowski wrote:
> >> On 23/02/2024 17:20, Marco Felsch wrote:
> >>> Add the support to provide an optional label like we do for ADC
> >>> channels to identify the device more easily.
> >>>
> >>> Signed-off-by: Marco Felsch <m.felsch@pengutronix.de>
> >>> ---
> >>> Hi,
> >>>
> >>> patchset [1] should be applied first to avoid merge conflicts.
> >>>
> >>> [1] https://lore.kernel.org/all/20240219131114.134607-1-m.felsch@pengutronix.de/#t
> >>>
> >>> Regards,
> >>>   Marco
> >>>
> >>>  .../devicetree/bindings/iio/temperature/ti,tmp117.yaml        | 4 ++++
> >>>  1 file changed, 4 insertions(+)
> >>>
> >>> diff --git a/Documentation/devicetree/bindings/iio/temperature/ti,tmp117.yaml b/Documentation/devicetree/bindings/iio/temperature/ti,tmp117.yaml
> >>> index 33f2e9c5bd81..f00c1cb89acd 100644
> >>> --- a/Documentation/devicetree/bindings/iio/temperature/ti,tmp117.yaml
> >>> +++ b/Documentation/devicetree/bindings/iio/temperature/ti,tmp117.yaml
> >>> @@ -27,6 +27,10 @@ properties:
> >>>    vcc-supply:
> >>>      description: provide VCC power to the sensor.
> >>>  
> >>> +  label:
> >>> +    $ref: /schemas/types.yaml#/definitions/string
> >>
> >> Drop ref. Did you take it from any existing binding?
> > 
> > I used Documentation/devicetree/bindings/iio/adc/adc.yaml as reference.
> 
> I'll fix it there.
> 
> Anyway, label comes from iio schema in dtschema, so this should be just
> "true".

For sure, I was searching for this generic binding but didn't checked
the dt-schema repo :/ That beeing said, only a few iio bindings do use
the generic binding. Last question, the dt-schema does not have the
$ref, is "string" the default for properties if not specified?

Regards,
  Marco

> 
> Best regards,
> Krzysztof
> 
>