* [PATCH] iio: adc: ti-ads1015: use device_for_each_child_node_scoped()
@ 2024-04-26 13:19 Lincoln Yuji
2024-04-27 11:14 ` Marcelo Schmitt
0 siblings, 1 reply; 6+ messages in thread
From: Lincoln Yuji @ 2024-04-26 13:19 UTC (permalink / raw)
To: jic23; +Cc: Lincoln Yuji, Luiza Soezima, Sabrina Araujo, Lincoln Yuji,
linux-iio
From: Lincoln Yuji <lincolnyuji@hotmail.com>
This loop definition removes the need for manual releasing of the fwnode_handle
in early exit paths (here an error path) allow simplification of the code
and reducing the chance of future modifications not releasing
fwnode_handle correctly.
Co-developed-by: Luiza Soezima <lbrsoezima@usp.br>
Signed-off-by: Luiza Soezima <lbrsoezima@usp.br>
Co-developed-by: Sabrina Araujo <sabrinaaraujo@usp.br>
Signed-off-by: Sabrina Araujo <sabrinaaraujo@usp.br>
Signed-off-by: Lincoln Yuji <lincolnyuji@usp.br>
---
drivers/iio/adc/ti-ads1015.c | 5 +----
1 file changed, 1 insertion(+), 4 deletions(-)
diff --git a/drivers/iio/adc/ti-ads1015.c b/drivers/iio/adc/ti-ads1015.c
index 6ae967e4d..d3363d02f 100644
--- a/drivers/iio/adc/ti-ads1015.c
+++ b/drivers/iio/adc/ti-ads1015.c
@@ -902,10 +902,9 @@ static int ads1015_client_get_channels_config(struct i2c_client *client)
struct iio_dev *indio_dev = i2c_get_clientdata(client);
struct ads1015_data *data = iio_priv(indio_dev);
struct device *dev = &client->dev;
- struct fwnode_handle *node;
int i = -1;
- device_for_each_child_node(dev, node) {
+ device_for_each_child_node_scoped(dev, node) {
u32 pval;
unsigned int channel;
unsigned int pga = ADS1015_DEFAULT_PGA;
@@ -927,7 +926,6 @@ static int ads1015_client_get_channels_config(struct i2c_client *client)
pga = pval;
if (pga > 5) {
dev_err(dev, "invalid gain on %pfw\n", node);
- fwnode_handle_put(node);
return -EINVAL;
}
}
@@ -936,7 +934,6 @@ static int ads1015_client_get_channels_config(struct i2c_client *client)
data_rate = pval;
if (data_rate > 7) {
dev_err(dev, "invalid data_rate on %pfw\n", node);
- fwnode_handle_put(node);
return -EINVAL;
}
}
--
2.34.1
^ permalink raw reply related [flat|nested] 6+ messages in thread* Re: [PATCH] iio: adc: ti-ads1015: use device_for_each_child_node_scoped()
2024-04-26 13:19 [PATCH] iio: adc: ti-ads1015: use device_for_each_child_node_scoped() Lincoln Yuji
@ 2024-04-27 11:14 ` Marcelo Schmitt
2024-04-28 15:36 ` Jonathan Cameron
0 siblings, 1 reply; 6+ messages in thread
From: Marcelo Schmitt @ 2024-04-27 11:14 UTC (permalink / raw)
To: Lincoln Yuji
Cc: jic23, Lincoln Yuji, Luiza Soezima, Sabrina Araujo, linux-iio
Hi Lincoln, Sabrina, Luiza,
The patch looks good, though the message should be wrapped to 75 columns
and the "From:" tag was not needed and caused an email mismatch.
With those adjustments made,
Reviewed-by: Marcelo Schmitt <marcelo.schmitt1@gmail.com>
Regards,
Marcelo
On 04/26, Lincoln Yuji wrote:
> From: Lincoln Yuji <lincolnyuji@hotmail.com>
>
> This loop definition removes the need for manual releasing of the fwnode_handle
> in early exit paths (here an error path) allow simplification of the code
> and reducing the chance of future modifications not releasing
> fwnode_handle correctly.
>
> Co-developed-by: Luiza Soezima <lbrsoezima@usp.br>
> Signed-off-by: Luiza Soezima <lbrsoezima@usp.br>
> Co-developed-by: Sabrina Araujo <sabrinaaraujo@usp.br>
> Signed-off-by: Sabrina Araujo <sabrinaaraujo@usp.br>
> Signed-off-by: Lincoln Yuji <lincolnyuji@usp.br>
> ---
> drivers/iio/adc/ti-ads1015.c | 5 +----
> 1 file changed, 1 insertion(+), 4 deletions(-)
>
> diff --git a/drivers/iio/adc/ti-ads1015.c b/drivers/iio/adc/ti-ads1015.c
> index 6ae967e4d..d3363d02f 100644
> --- a/drivers/iio/adc/ti-ads1015.c
> +++ b/drivers/iio/adc/ti-ads1015.c
> @@ -902,10 +902,9 @@ static int ads1015_client_get_channels_config(struct i2c_client *client)
> struct iio_dev *indio_dev = i2c_get_clientdata(client);
> struct ads1015_data *data = iio_priv(indio_dev);
> struct device *dev = &client->dev;
> - struct fwnode_handle *node;
> int i = -1;
>
> - device_for_each_child_node(dev, node) {
> + device_for_each_child_node_scoped(dev, node) {
> u32 pval;
> unsigned int channel;
> unsigned int pga = ADS1015_DEFAULT_PGA;
> @@ -927,7 +926,6 @@ static int ads1015_client_get_channels_config(struct i2c_client *client)
> pga = pval;
> if (pga > 5) {
> dev_err(dev, "invalid gain on %pfw\n", node);
> - fwnode_handle_put(node);
> return -EINVAL;
> }
> }
> @@ -936,7 +934,6 @@ static int ads1015_client_get_channels_config(struct i2c_client *client)
> data_rate = pval;
> if (data_rate > 7) {
> dev_err(dev, "invalid data_rate on %pfw\n", node);
> - fwnode_handle_put(node);
> return -EINVAL;
> }
> }
> --
> 2.34.1
>
>
^ permalink raw reply [flat|nested] 6+ messages in thread* Re: [PATCH] iio: adc: ti-ads1015: use device_for_each_child_node_scoped()
2024-04-27 11:14 ` Marcelo Schmitt
@ 2024-04-28 15:36 ` Jonathan Cameron
2024-04-28 15:41 ` Jonathan Cameron
0 siblings, 1 reply; 6+ messages in thread
From: Jonathan Cameron @ 2024-04-28 15:36 UTC (permalink / raw)
To: Marcelo Schmitt
Cc: Lincoln Yuji, Lincoln Yuji, Luiza Soezima, Sabrina Araujo,
linux-iio
On Sat, 27 Apr 2024 08:14:50 -0300
Marcelo Schmitt <marcelo.schmitt1@gmail.com> wrote:
> Hi Lincoln, Sabrina, Luiza,
>
> The patch looks good, though the message should be wrapped to 75 columns
> and the "From:" tag was not needed and caused an email mismatch.
That usually means the commit author in the git tree this was generated
from is incorrect. Set that to match your email with
git commit --amend --author="Lincoln Yuji <lincolnyuji@usp.br>"
>
> With those adjustments made,
> Reviewed-by: Marcelo Schmitt <marcelo.schmitt1@gmail.com>
>
> Regards,
> Marcelo
>
> On 04/26, Lincoln Yuji wrote:
> > From: Lincoln Yuji <lincolnyuji@hotmail.com>
> >
> > This loop definition removes the need for manual releasing of the fwnode_handle
> > in early exit paths (here an error path) allow simplification of the code
> > and reducing the chance of future modifications not releasing
> > fwnode_handle correctly.
> >
> > Co-developed-by: Luiza Soezima <lbrsoezima@usp.br>
> > Signed-off-by: Luiza Soezima <lbrsoezima@usp.br>
> > Co-developed-by: Sabrina Araujo <sabrinaaraujo@usp.br>
> > Signed-off-by: Sabrina Araujo <sabrinaaraujo@usp.br>
> > Signed-off-by: Lincoln Yuji <lincolnyuji@usp.br>
> > ---
> > drivers/iio/adc/ti-ads1015.c | 5 +----
> > 1 file changed, 1 insertion(+), 4 deletions(-)
> >
> > diff --git a/drivers/iio/adc/ti-ads1015.c b/drivers/iio/adc/ti-ads1015.c
> > index 6ae967e4d..d3363d02f 100644
> > --- a/drivers/iio/adc/ti-ads1015.c
> > +++ b/drivers/iio/adc/ti-ads1015.c
> > @@ -902,10 +902,9 @@ static int ads1015_client_get_channels_config(struct i2c_client *client)
> > struct iio_dev *indio_dev = i2c_get_clientdata(client);
> > struct ads1015_data *data = iio_priv(indio_dev);
> > struct device *dev = &client->dev;
> > - struct fwnode_handle *node;
> > int i = -1;
> >
> > - device_for_each_child_node(dev, node) {
> > + device_for_each_child_node_scoped(dev, node) {
> > u32 pval;
> > unsigned int channel;
> > unsigned int pga = ADS1015_DEFAULT_PGA;
> > @@ -927,7 +926,6 @@ static int ads1015_client_get_channels_config(struct i2c_client *client)
> > pga = pval;
> > if (pga > 5) {
> > dev_err(dev, "invalid gain on %pfw\n", node);
> > - fwnode_handle_put(node);
> > return -EINVAL;
> > }
> > }
> > @@ -936,7 +934,6 @@ static int ads1015_client_get_channels_config(struct i2c_client *client)
> > data_rate = pval;
> > if (data_rate > 7) {
> > dev_err(dev, "invalid data_rate on %pfw\n", node);
> > - fwnode_handle_put(node);
> > return -EINVAL;
> > }
> > }
> > --
> > 2.34.1
> >
> >
^ permalink raw reply [flat|nested] 6+ messages in thread* Re: [PATCH] iio: adc: ti-ads1015: use device_for_each_child_node_scoped()
2024-04-28 15:36 ` Jonathan Cameron
@ 2024-04-28 15:41 ` Jonathan Cameron
0 siblings, 0 replies; 6+ messages in thread
From: Jonathan Cameron @ 2024-04-28 15:41 UTC (permalink / raw)
To: Marcelo Schmitt
Cc: Lincoln Yuji, Lincoln Yuji, Luiza Soezima, Sabrina Araujo,
linux-iio
On Sun, 28 Apr 2024 16:36:52 +0100
Jonathan Cameron <jic23@kernel.org> wrote:
> On Sat, 27 Apr 2024 08:14:50 -0300
> Marcelo Schmitt <marcelo.schmitt1@gmail.com> wrote:
>
> > Hi Lincoln, Sabrina, Luiza,
> >
> > The patch looks good, though the message should be wrapped to 75 columns
> > and the "From:" tag was not needed and caused an email mismatch.
> That usually means the commit author in the git tree this was generated
> from is incorrect. Set that to match your email with
> git commit --amend --author="Lincoln Yuji <lincolnyuji@usp.br>"
>
Nope. I was wrong on that. Indeed what Marcelo said in another
thread, you need to set the --from
Jonathan
>
> >
> > With those adjustments made,
> > Reviewed-by: Marcelo Schmitt <marcelo.schmitt1@gmail.com>
> >
> > Regards,
> > Marcelo
> >
> > On 04/26, Lincoln Yuji wrote:
> > > From: Lincoln Yuji <lincolnyuji@hotmail.com>
> > >
> > > This loop definition removes the need for manual releasing of the fwnode_handle
> > > in early exit paths (here an error path) allow simplification of the code
> > > and reducing the chance of future modifications not releasing
> > > fwnode_handle correctly.
> > >
> > > Co-developed-by: Luiza Soezima <lbrsoezima@usp.br>
> > > Signed-off-by: Luiza Soezima <lbrsoezima@usp.br>
> > > Co-developed-by: Sabrina Araujo <sabrinaaraujo@usp.br>
> > > Signed-off-by: Sabrina Araujo <sabrinaaraujo@usp.br>
> > > Signed-off-by: Lincoln Yuji <lincolnyuji@usp.br>
> > > ---
> > > drivers/iio/adc/ti-ads1015.c | 5 +----
> > > 1 file changed, 1 insertion(+), 4 deletions(-)
> > >
> > > diff --git a/drivers/iio/adc/ti-ads1015.c b/drivers/iio/adc/ti-ads1015.c
> > > index 6ae967e4d..d3363d02f 100644
> > > --- a/drivers/iio/adc/ti-ads1015.c
> > > +++ b/drivers/iio/adc/ti-ads1015.c
> > > @@ -902,10 +902,9 @@ static int ads1015_client_get_channels_config(struct i2c_client *client)
> > > struct iio_dev *indio_dev = i2c_get_clientdata(client);
> > > struct ads1015_data *data = iio_priv(indio_dev);
> > > struct device *dev = &client->dev;
> > > - struct fwnode_handle *node;
> > > int i = -1;
> > >
> > > - device_for_each_child_node(dev, node) {
> > > + device_for_each_child_node_scoped(dev, node) {
> > > u32 pval;
> > > unsigned int channel;
> > > unsigned int pga = ADS1015_DEFAULT_PGA;
> > > @@ -927,7 +926,6 @@ static int ads1015_client_get_channels_config(struct i2c_client *client)
> > > pga = pval;
> > > if (pga > 5) {
> > > dev_err(dev, "invalid gain on %pfw\n", node);
> > > - fwnode_handle_put(node);
> > > return -EINVAL;
> > > }
> > > }
> > > @@ -936,7 +934,6 @@ static int ads1015_client_get_channels_config(struct i2c_client *client)
> > > data_rate = pval;
> > > if (data_rate > 7) {
> > > dev_err(dev, "invalid data_rate on %pfw\n", node);
> > > - fwnode_handle_put(node);
> > > return -EINVAL;
> > > }
> > > }
> > > --
> > > 2.34.1
> > >
> > >
>
^ permalink raw reply [flat|nested] 6+ messages in thread
* [PATCH] iio: adc: ti-ads1015: use device_for_each_child_node_scoped()
@ 2024-04-27 12:10 Lincoln Yuji
2024-04-28 11:39 ` Jonathan Cameron
0 siblings, 1 reply; 6+ messages in thread
From: Lincoln Yuji @ 2024-04-27 12:10 UTC (permalink / raw)
To: jic23; +Cc: Luiza Soezima, Sabrina Araujo, Lincoln Yuji, linux-iio
This loop definition removes the need for manual releasing of the
fwnode_handle in early exit paths (here an error path) allow
simplification of the code and reducing the chance of future
modifications not releasing fwnode_handle correctly.
Co-developed-by: Luiza Soezima <lbrsoezima@usp.br>
Signed-off-by: Luiza Soezima <lbrsoezima@usp.br>
Co-developed-by: Sabrina Araujo <sabrinaaraujo@usp.br>
Signed-off-by: Sabrina Araujo <sabrinaaraujo@usp.br>
Signed-off-by: Lincoln Yuji <lincolnyuji@usp.br>
---
drivers/iio/adc/ti-ads1015.c | 5 +----
1 file changed, 1 insertion(+), 4 deletions(-)
diff --git a/drivers/iio/adc/ti-ads1015.c b/drivers/iio/adc/ti-ads1015.c
index 6ae967e4d..d3363d02f 100644
--- a/drivers/iio/adc/ti-ads1015.c
+++ b/drivers/iio/adc/ti-ads1015.c
@@ -902,10 +902,9 @@ static int ads1015_client_get_channels_config(struct i2c_client *client)
struct iio_dev *indio_dev = i2c_get_clientdata(client);
struct ads1015_data *data = iio_priv(indio_dev);
struct device *dev = &client->dev;
- struct fwnode_handle *node;
int i = -1;
- device_for_each_child_node(dev, node) {
+ device_for_each_child_node_scoped(dev, node) {
u32 pval;
unsigned int channel;
unsigned int pga = ADS1015_DEFAULT_PGA;
@@ -927,7 +926,6 @@ static int ads1015_client_get_channels_config(struct i2c_client *client)
pga = pval;
if (pga > 5) {
dev_err(dev, "invalid gain on %pfw\n", node);
- fwnode_handle_put(node);
return -EINVAL;
}
}
@@ -936,7 +934,6 @@ static int ads1015_client_get_channels_config(struct i2c_client *client)
data_rate = pval;
if (data_rate > 7) {
dev_err(dev, "invalid data_rate on %pfw\n", node);
- fwnode_handle_put(node);
return -EINVAL;
}
}
--
2.34.1
^ permalink raw reply related [flat|nested] 6+ messages in thread* Re: [PATCH] iio: adc: ti-ads1015: use device_for_each_child_node_scoped()
2024-04-27 12:10 Lincoln Yuji
@ 2024-04-28 11:39 ` Jonathan Cameron
0 siblings, 0 replies; 6+ messages in thread
From: Jonathan Cameron @ 2024-04-28 11:39 UTC (permalink / raw)
To: Lincoln Yuji; +Cc: Luiza Soezima, Sabrina Araujo, linux-iio
On Sat, 27 Apr 2024 09:10:55 -0300
Lincoln Yuji <lincolnyuji@usp.br> wrote:
> This loop definition removes the need for manual releasing of the
> fwnode_handle in early exit paths (here an error path) allow
> simplification of the code and reducing the chance of future
> modifications not releasing fwnode_handle correctly.
>
> Co-developed-by: Luiza Soezima <lbrsoezima@usp.br>
> Signed-off-by: Luiza Soezima <lbrsoezima@usp.br>
> Co-developed-by: Sabrina Araujo <sabrinaaraujo@usp.br>
> Signed-off-by: Sabrina Araujo <sabrinaaraujo@usp.br>
> Signed-off-by: Lincoln Yuji <lincolnyuji@usp.br>
> ---
I think this is a response to Marcelo's review of v1.
If so, a couple of process things you have gotten wrong.
1) You should pick up tags, assuming you've made the changes
suggested. So should include
Reviewed-by: Marcelo Schmitt <marcelo.schmitt1@gmail.com>
in the block above.
2) It should be clearly marked as v2. Pass -v2 to git format
patch is the easiest way to do this, or edit the patch title
so it says something like
[PATCH V2] ...
Otherwise the patch looks fine.
Please do a v3, correcting the above.
Thanks,
Jonathan
> drivers/iio/adc/ti-ads1015.c | 5 +----
> 1 file changed, 1 insertion(+), 4 deletions(-)
>
> diff --git a/drivers/iio/adc/ti-ads1015.c b/drivers/iio/adc/ti-ads1015.c
> index 6ae967e4d..d3363d02f 100644
> --- a/drivers/iio/adc/ti-ads1015.c
> +++ b/drivers/iio/adc/ti-ads1015.c
> @@ -902,10 +902,9 @@ static int ads1015_client_get_channels_config(struct i2c_client *client)
> struct iio_dev *indio_dev = i2c_get_clientdata(client);
> struct ads1015_data *data = iio_priv(indio_dev);
> struct device *dev = &client->dev;
> - struct fwnode_handle *node;
> int i = -1;
>
> - device_for_each_child_node(dev, node) {
> + device_for_each_child_node_scoped(dev, node) {
> u32 pval;
> unsigned int channel;
> unsigned int pga = ADS1015_DEFAULT_PGA;
> @@ -927,7 +926,6 @@ static int ads1015_client_get_channels_config(struct i2c_client *client)
> pga = pval;
> if (pga > 5) {
> dev_err(dev, "invalid gain on %pfw\n", node);
> - fwnode_handle_put(node);
> return -EINVAL;
> }
> }
> @@ -936,7 +934,6 @@ static int ads1015_client_get_channels_config(struct i2c_client *client)
> data_rate = pval;
> if (data_rate > 7) {
> dev_err(dev, "invalid data_rate on %pfw\n", node);
> - fwnode_handle_put(node);
> return -EINVAL;
> }
> }
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2024-04-28 15:42 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2024-04-26 13:19 [PATCH] iio: adc: ti-ads1015: use device_for_each_child_node_scoped() Lincoln Yuji
2024-04-27 11:14 ` Marcelo Schmitt
2024-04-28 15:36 ` Jonathan Cameron
2024-04-28 15:41 ` Jonathan Cameron
-- strict thread matches above, loose matches on Subject: below --
2024-04-27 12:10 Lincoln Yuji
2024-04-28 11:39 ` Jonathan Cameron
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox