From: Jonathan Cameron <jic23@kernel.org>
To: Christophe JAILLET <christophe.jaillet@wanadoo.fr>
Cc: Rajat Khandelwal <rajat.khandelwal@linux.intel.com>,
Lars-Peter Clausen <lars@metafoo.de>,
linux-kernel@vger.kernel.org, kernel-janitors@vger.kernel.org,
linux-iio@vger.kernel.org
Subject: Re: [PATCH] iio: temperature: max30208: Remove an unused field in struct max30208_data
Date: Sat, 4 May 2024 12:39:27 +0100 [thread overview]
Message-ID: <20240504123927.2d47c232@jic23-huawei> (raw)
In-Reply-To: <73f9f540ecdc7c10e833e6fc782324ae7d34ba9c.1714555144.git.christophe.jaillet@wanadoo.fr>
On Wed, 1 May 2024 11:19:41 +0200
Christophe JAILLET <christophe.jaillet@wanadoo.fr> wrote:
> In "struct max30208_data", the 'indio_dev' field is unused.
> Remove it.
>
> Found with cppcheck, unusedStructMember.
>
> Signed-off-by: Christophe JAILLET <christophe.jaillet@wanadoo.fr>
Applied,
Thanks,
J
> ---
> Compile tested only.
>
> It was added in the initial commit 9ee95ae4cffd ("iio: temperature: Add
> driver support for Maxim MAX30208") but was never used.
> ---
> drivers/iio/temperature/max30208.c | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/drivers/iio/temperature/max30208.c b/drivers/iio/temperature/max30208.c
> index 48be03852cd8..720469f9dc36 100644
> --- a/drivers/iio/temperature/max30208.c
> +++ b/drivers/iio/temperature/max30208.c
> @@ -34,7 +34,6 @@
>
> struct max30208_data {
> struct i2c_client *client;
> - struct iio_dev *indio_dev;
> struct mutex lock; /* Lock to prevent concurrent reads of temperature readings */
> };
>
prev parent reply other threads:[~2024-05-04 11:39 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-05-01 9:19 [PATCH] iio: temperature: max30208: Remove an unused field in struct max30208_data Christophe JAILLET
2024-05-04 11:39 ` Jonathan Cameron [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240504123927.2d47c232@jic23-huawei \
--to=jic23@kernel.org \
--cc=christophe.jaillet@wanadoo.fr \
--cc=kernel-janitors@vger.kernel.org \
--cc=lars@metafoo.de \
--cc=linux-iio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=rajat.khandelwal@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox