* [PATCH] iio: temperature: max30208: Remove an unused field in struct max30208_data
@ 2024-05-01 9:19 Christophe JAILLET
2024-05-04 11:39 ` Jonathan Cameron
0 siblings, 1 reply; 2+ messages in thread
From: Christophe JAILLET @ 2024-05-01 9:19 UTC (permalink / raw)
To: Rajat Khandelwal, Jonathan Cameron, Lars-Peter Clausen
Cc: linux-kernel, kernel-janitors, Christophe JAILLET, linux-iio
In "struct max30208_data", the 'indio_dev' field is unused.
Remove it.
Found with cppcheck, unusedStructMember.
Signed-off-by: Christophe JAILLET <christophe.jaillet@wanadoo.fr>
---
Compile tested only.
It was added in the initial commit 9ee95ae4cffd ("iio: temperature: Add
driver support for Maxim MAX30208") but was never used.
---
drivers/iio/temperature/max30208.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/drivers/iio/temperature/max30208.c b/drivers/iio/temperature/max30208.c
index 48be03852cd8..720469f9dc36 100644
--- a/drivers/iio/temperature/max30208.c
+++ b/drivers/iio/temperature/max30208.c
@@ -34,7 +34,6 @@
struct max30208_data {
struct i2c_client *client;
- struct iio_dev *indio_dev;
struct mutex lock; /* Lock to prevent concurrent reads of temperature readings */
};
--
2.44.0
^ permalink raw reply related [flat|nested] 2+ messages in thread* Re: [PATCH] iio: temperature: max30208: Remove an unused field in struct max30208_data
2024-05-01 9:19 [PATCH] iio: temperature: max30208: Remove an unused field in struct max30208_data Christophe JAILLET
@ 2024-05-04 11:39 ` Jonathan Cameron
0 siblings, 0 replies; 2+ messages in thread
From: Jonathan Cameron @ 2024-05-04 11:39 UTC (permalink / raw)
To: Christophe JAILLET
Cc: Rajat Khandelwal, Lars-Peter Clausen, linux-kernel,
kernel-janitors, linux-iio
On Wed, 1 May 2024 11:19:41 +0200
Christophe JAILLET <christophe.jaillet@wanadoo.fr> wrote:
> In "struct max30208_data", the 'indio_dev' field is unused.
> Remove it.
>
> Found with cppcheck, unusedStructMember.
>
> Signed-off-by: Christophe JAILLET <christophe.jaillet@wanadoo.fr>
Applied,
Thanks,
J
> ---
> Compile tested only.
>
> It was added in the initial commit 9ee95ae4cffd ("iio: temperature: Add
> driver support for Maxim MAX30208") but was never used.
> ---
> drivers/iio/temperature/max30208.c | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/drivers/iio/temperature/max30208.c b/drivers/iio/temperature/max30208.c
> index 48be03852cd8..720469f9dc36 100644
> --- a/drivers/iio/temperature/max30208.c
> +++ b/drivers/iio/temperature/max30208.c
> @@ -34,7 +34,6 @@
>
> struct max30208_data {
> struct i2c_client *client;
> - struct iio_dev *indio_dev;
> struct mutex lock; /* Lock to prevent concurrent reads of temperature readings */
> };
>
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2024-05-04 11:39 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2024-05-01 9:19 [PATCH] iio: temperature: max30208: Remove an unused field in struct max30208_data Christophe JAILLET
2024-05-04 11:39 ` Jonathan Cameron
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox