From: Jonathan Cameron <jic23@kernel.org>
To: Denis Benato <benato.denis96@gmail.com>
Cc: Jagath Jog J <jagathjog1996@gmail.com>,
Lars-Peter Clausen <lars@metafoo.de>,
"Luke D . Jones" <luke@ljones.dev>,
Jonathan LoBue <jlobue10@gmail.com>,
linux-iio@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 1/1] iio: imu: bmi323: Use iio read_acpi_mount_matrix() helper
Date: Sun, 26 May 2024 13:24:22 +0100 [thread overview]
Message-ID: <20240526132422.01d3855b@jic23-huawei> (raw)
In-Reply-To: <20240523174736.16692-2-benato.denis96@gmail.com>
On Thu, 23 May 2024 19:47:36 +0200
Denis Benato <benato.denis96@gmail.com> wrote:
> bmi150-accel and bmi323-imu are declared in an almost identical way in the ACPI and in some devices such as the Asus RC71L the "ROTM" property can be found: parse and use the ACPI-defined mount-matrix.
>
> Co-developed-by: Luke D. Jones <luke@ljones.dev>
> Co-developed-by: Jonathan LoBue <jlobue10@gmail.com>
> Signed-off-by: Denis Benato <benato.denis96@gmail.com>
Applied.
Thanks,
Jonathan
> ---
> drivers/iio/imu/bmi323/bmi323_core.c | 8 +++++---
> 1 file changed, 5 insertions(+), 3 deletions(-)
>
> diff --git a/drivers/iio/imu/bmi323/bmi323_core.c b/drivers/iio/imu/bmi323/bmi323_core.c
> index 5d42ab9b176a..b391e5e701b1 100644
> --- a/drivers/iio/imu/bmi323/bmi323_core.c
> +++ b/drivers/iio/imu/bmi323/bmi323_core.c
> @@ -2083,9 +2083,11 @@ int bmi323_core_probe(struct device *dev)
> if (ret)
> return -EINVAL;
>
> - ret = iio_read_mount_matrix(dev, &data->orientation);
> - if (ret)
> - return ret;
> + if (!iio_read_acpi_mount_matrix(dev, &data->orientation, "ROTM")) {
> + ret = iio_read_mount_matrix(dev, &data->orientation);
> + if (ret)
> + return ret;
> + }
>
> indio_dev->name = "bmi323-imu";
> indio_dev->info = &bmi323_info;
prev parent reply other threads:[~2024-05-26 12:24 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-05-23 17:47 [PATCH 0/1] iio: imu: bmi323: Use the new shared iio_read_acpi_mount_matrix() helper Denis Benato
2024-05-23 17:47 ` [PATCH 1/1] iio: imu: bmi323: Use iio read_acpi_mount_matrix() helper Denis Benato
2024-05-26 12:24 ` Jonathan Cameron [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240526132422.01d3855b@jic23-huawei \
--to=jic23@kernel.org \
--cc=benato.denis96@gmail.com \
--cc=jagathjog1996@gmail.com \
--cc=jlobue10@gmail.com \
--cc=lars@metafoo.de \
--cc=linux-iio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=luke@ljones.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox