From: Jonathan Cameron <jic23@kernel.org>
To: Ke Sun <sunke@kylinos.cn>
Cc: Lars-Peter Clausen <lars@metafoo.de>,
Nuno Sa <nuno.sa@analog.com>, Anshul Dalal <anshulusr@gmail.com>,
Dragos Bogdan <dragos.bogdan@analog.com>,
Andrea Collamati <andrea.collamati@gmail.com>,
linux-iio@vger.kernel.org, k2ci <kernel-bot@kylinos.cn>,
kernel test robot <lkp@intel.com>
Subject: Re: [PATCH] iio: dac: fix ad9739a random config compile error
Date: Sun, 9 Jun 2024 11:37:51 +0100 [thread overview]
Message-ID: <20240609113751.70517cfc@jic23-huawei> (raw)
In-Reply-To: <20240609030847.2869455-1-sunke@kylinos.cn>
On Sun, 9 Jun 2024 11:08:47 +0800
Ke Sun <sunke@kylinos.cn> wrote:
> WARNING: unmet direct dependencies detected for REGMAP_SPI
> Depends on [n]: SPI [=n]
> Selected by [m]:
> - AD9739A [=m] && IIO [=m] && (SPI [=n] || COMPILE_TEST [=y])
> ...
> ERROR: modpost: "spi_write_then_read" [drivers/base/regmap/regmap-spi.ko] undefined!
> ERROR: modpost: "spi_async" [drivers/base/regmap/regmap-spi.ko] undefined!
> ERROR: modpost: "spi_sync" [drivers/base/regmap/regmap-spi.ko] undefined!
> ERROR: modpost: "__spi_register_driver" [drivers/iio/dac/ad9739a.ko] undefined!
>
> Fixes: e77603d5468b ("iio: dac: support the ad9739a RF DAC")
> Reported-by: k2ci <kernel-bot@kylinos.cn>
> Reported-by: kernel test robot <lkp@intel.com>
> Closes: https://lore.kernel.org/oe-kbuild-all/202404250156.2PQRWmex-lkp@intel.com/
>
No blank line in tag blocks they are used by various scripts and also checked
by various patch correctness scripts so this will just get me moaned at
by bots. I'll fix that.
> Signed-off-by: Ke Sun <sunke@kylinos.cn>
SPI is built in most rand configs anyway so this seems like it won't
reduce our testing scope significantly.
Applied.
> ---
> drivers/iio/dac/Kconfig | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/iio/dac/Kconfig b/drivers/iio/dac/Kconfig
> index 3c2bf620f00f..ee0d9798d8b4 100644
> --- a/drivers/iio/dac/Kconfig
> +++ b/drivers/iio/dac/Kconfig
> @@ -133,7 +133,7 @@ config AD5624R_SPI
>
> config AD9739A
> tristate "Analog Devices AD9739A RF DAC spi driver"
> - depends on SPI || COMPILE_TEST
> + depends on SPI
> select REGMAP_SPI
> select IIO_BACKEND
> help
next prev parent reply other threads:[~2024-06-09 10:38 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-06-09 3:08 [PATCH] iio: dac: fix ad9739a random config compile error Ke Sun
2024-06-09 10:37 ` Jonathan Cameron [this message]
2024-06-10 15:19 ` Jonathan Cameron
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240609113751.70517cfc@jic23-huawei \
--to=jic23@kernel.org \
--cc=andrea.collamati@gmail.com \
--cc=anshulusr@gmail.com \
--cc=dragos.bogdan@analog.com \
--cc=kernel-bot@kylinos.cn \
--cc=lars@metafoo.de \
--cc=linux-iio@vger.kernel.org \
--cc=lkp@intel.com \
--cc=nuno.sa@analog.com \
--cc=sunke@kylinos.cn \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox