[PATCH] iio: dac: fix ad9739a random config compile error

[PATCH] iio: dac: fix ad9739a random config compile error

[Ke Sun]

WARNING: unmet direct dependencies detected for REGMAP_SPI
  Depends on [n]: SPI [=n]
  Selected by [m]:
  - AD9739A [=m] && IIO [=m] && (SPI [=n] || COMPILE_TEST [=y])
...
ERROR: modpost: "spi_write_then_read" [drivers/base/regmap/regmap-spi.ko] undefined!
ERROR: modpost: "spi_async" [drivers/base/regmap/regmap-spi.ko] undefined!
ERROR: modpost: "spi_sync" [drivers/base/regmap/regmap-spi.ko] undefined!
ERROR: modpost: "__spi_register_driver" [drivers/iio/dac/ad9739a.ko] undefined!

Fixes: e77603d5468b ("iio: dac: support the ad9739a RF DAC")
Reported-by: k2ci <kernel-bot@kylinos.cn>
Reported-by: kernel test robot <lkp@intel.com>
Closes: https://lore.kernel.org/oe-kbuild-all/202404250156.2PQRWmex-lkp@intel.com/

Signed-off-by: Ke Sun <sunke@kylinos.cn>
---
 drivers/iio/dac/Kconfig | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/iio/dac/Kconfig b/drivers/iio/dac/Kconfig
index 3c2bf620f00f..ee0d9798d8b4 100644
--- a/drivers/iio/dac/Kconfig
+++ b/drivers/iio/dac/Kconfig
@@ -133,7 +133,7 @@ config AD5624R_SPI
 
 config AD9739A
 	tristate "Analog Devices AD9739A RF DAC spi driver"
-	depends on SPI || COMPILE_TEST
+	depends on SPI
 	select REGMAP_SPI
 	select IIO_BACKEND
 	help
-- 
2.34.1

Re: [PATCH] iio: dac: fix ad9739a random config compile error

[Jonathan Cameron]

On Sun,  9 Jun 2024 11:08:47 +0800
Ke Sun <sunke@kylinos.cn> wrote:

> WARNING: unmet direct dependencies detected for REGMAP_SPI
>   Depends on [n]: SPI [=n]
>   Selected by [m]:
>   - AD9739A [=m] && IIO [=m] && (SPI [=n] || COMPILE_TEST [=y])
> ...
> ERROR: modpost: "spi_write_then_read" [drivers/base/regmap/regmap-spi.ko] undefined!
> ERROR: modpost: "spi_async" [drivers/base/regmap/regmap-spi.ko] undefined!
> ERROR: modpost: "spi_sync" [drivers/base/regmap/regmap-spi.ko] undefined!
> ERROR: modpost: "__spi_register_driver" [drivers/iio/dac/ad9739a.ko] undefined!
> 
> Fixes: e77603d5468b ("iio: dac: support the ad9739a RF DAC")
> Reported-by: k2ci <kernel-bot@kylinos.cn>
> Reported-by: kernel test robot <lkp@intel.com>
> Closes: https://lore.kernel.org/oe-kbuild-all/202404250156.2PQRWmex-lkp@intel.com/
> 
No blank line in tag blocks they are used by various scripts and also checked
by various patch correctness scripts so this will just get me moaned at
by bots.  I'll fix that.

> Signed-off-by: Ke Sun <sunke@kylinos.cn>
SPI is built in most rand configs anyway so this seems like it won't
reduce our testing scope significantly.

Applied.

> ---
>  drivers/iio/dac/Kconfig | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/iio/dac/Kconfig b/drivers/iio/dac/Kconfig
> index 3c2bf620f00f..ee0d9798d8b4 100644
> --- a/drivers/iio/dac/Kconfig
> +++ b/drivers/iio/dac/Kconfig
> @@ -133,7 +133,7 @@ config AD5624R_SPI
>  
>  config AD9739A
>  	tristate "Analog Devices AD9739A RF DAC spi driver"
> -	depends on SPI || COMPILE_TEST
> +	depends on SPI
>  	select REGMAP_SPI
>  	select IIO_BACKEND
>  	help

Re: [PATCH] iio: dac: fix ad9739a random config compile error

[Jonathan Cameron]

On Sun, 9 Jun 2024 11:37:51 +0100
Jonathan Cameron <jic23@kernel.org> wrote:

> On Sun,  9 Jun 2024 11:08:47 +0800
> Ke Sun <sunke@kylinos.cn> wrote:
> 
> > WARNING: unmet direct dependencies detected for REGMAP_SPI
> >   Depends on [n]: SPI [=n]
> >   Selected by [m]:
> >   - AD9739A [=m] && IIO [=m] && (SPI [=n] || COMPILE_TEST [=y])
> > ...
> > ERROR: modpost: "spi_write_then_read" [drivers/base/regmap/regmap-spi.ko] undefined!
> > ERROR: modpost: "spi_async" [drivers/base/regmap/regmap-spi.ko] undefined!
> > ERROR: modpost: "spi_sync" [drivers/base/regmap/regmap-spi.ko] undefined!
> > ERROR: modpost: "__spi_register_driver" [drivers/iio/dac/ad9739a.ko] undefined!
> > 
> > Fixes: e77603d5468b ("iio: dac: support the ad9739a RF DAC")
> > Reported-by: k2ci <kernel-bot@kylinos.cn>
> > Reported-by: kernel test robot <lkp@intel.com>
> > Closes: https://lore.kernel.org/oe-kbuild-all/202404250156.2PQRWmex-lkp@intel.com/
> >   
> No blank line in tag blocks they are used by various scripts and also checked
> by various patch correctness scripts so this will just get me moaned at
> by bots.  I'll fix that.
> 
> > Signed-off-by: Ke Sun <sunke@kylinos.cn>  
> SPI is built in most rand configs anyway so this seems like it won't
> reduce our testing scope significantly.
> 
> Applied.

Ah. I'm an idiot and had queued Arnd's earlier fix for this
on the wrong tree hence it missed my last fixes pull request.

I'll do another one later this week with a version of this patch on it.

Thanks,

Jonathan



> 
> > ---
> >  drivers/iio/dac/Kconfig | 2 +-
> >  1 file changed, 1 insertion(+), 1 deletion(-)
> > 
> > diff --git a/drivers/iio/dac/Kconfig b/drivers/iio/dac/Kconfig
> > index 3c2bf620f00f..ee0d9798d8b4 100644
> > --- a/drivers/iio/dac/Kconfig
> > +++ b/drivers/iio/dac/Kconfig
> > @@ -133,7 +133,7 @@ config AD5624R_SPI
> >  
> >  config AD9739A
> >  	tristate "Analog Devices AD9739A RF DAC spi driver"
> > -	depends on SPI || COMPILE_TEST
> > +	depends on SPI
> >  	select REGMAP_SPI
> >  	select IIO_BACKEND
> >  	help  
> 
>