From: Fernando Yang <hagisf@usp.br>
To: linux-iio@vger.kernel.org
Cc: Fernando Yang <hagisf@usp.br>,
Lars-Peter Clausen <lars@metafoo.de>,
Michael Hennerich <Michael.Hennerich@analog.com>,
Jonathan Cameron <jic23@kernel.org>,
Eduardo Figueredo <eduardofp@usp.br>,
Marcelo Schmitt <marcelo.schmitt1@gmail.com>
Subject: [PATCH v3 1/3] iio: adc: ad7266: Fix variable checking bug
Date: Thu, 13 Jun 2024 12:39:18 -0300 [thread overview]
Message-ID: <20240613153920.14647-2-hagisf@usp.br> (raw)
In-Reply-To: <20240613153920.14647-1-hagisf@usp.br>
The ret variable was not checked after iio_device_release_direct_mode(),
which could possibly cause errors
Fixes: c70df20e3159 ("iio: adc: ad7266: claim direct mode during sensor read")
Signed-off-by: Fernando Yang <hagisf@usp.br>
---
drivers/iio/adc/ad7266.c | 2 ++
1 file changed, 2 insertions(+)
diff --git a/drivers/iio/adc/ad7266.c b/drivers/iio/adc/ad7266.c
index 353a97f9c..13ea8a107 100644
--- a/drivers/iio/adc/ad7266.c
+++ b/drivers/iio/adc/ad7266.c
@@ -157,6 +157,8 @@ static int ad7266_read_raw(struct iio_dev *indio_dev,
ret = ad7266_read_single(st, val, chan->address);
iio_device_release_direct_mode(indio_dev);
+ if (ret < 0)
+ return ret;
*val = (*val >> 2) & 0xfff;
if (chan->scan_type.sign == 's')
*val = sign_extend32(*val,
--
2.34.1
next prev parent reply other threads:[~2024-06-13 15:40 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-06-13 15:39 [PATCH v3 0/3] iio: adc: ad7266: Use iio_device_claim_direct_scoped() and clean some codestyle error Fernando Yang
2024-06-13 15:39 ` Fernando Yang [this message]
2024-06-15 10:52 ` [PATCH v3 1/3] iio: adc: ad7266: Fix variable checking bug Jonathan Cameron
2024-06-13 15:39 ` [PATCH v3 2/3] iio: adc: ad7266: Use iio_device_claim_direct_scoped() Fernando Yang
2024-06-15 10:56 ` Jonathan Cameron
2024-06-13 15:39 ` [PATCH v3 3/3] iio: adc: ad7266: Fix codestyle error Fernando Yang
2024-06-15 10:56 ` Jonathan Cameron
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240613153920.14647-2-hagisf@usp.br \
--to=hagisf@usp.br \
--cc=Michael.Hennerich@analog.com \
--cc=eduardofp@usp.br \
--cc=jic23@kernel.org \
--cc=lars@metafoo.de \
--cc=linux-iio@vger.kernel.org \
--cc=marcelo.schmitt1@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox