Re: [PATCH v3 1/3] iio: adc: ad7266: Fix variable checking bug

[Jonathan Cameron <jic23@kernel.org>]

On Thu, 13 Jun 2024 12:39:18 -0300
Fernando Yang <hagisf@usp.br> wrote:

> The ret variable was not checked after iio_device_release_direct_mode(),
> which could possibly cause errors
> 
> Fixes: c70df20e3159 ("iio: adc: ad7266: claim direct mode during sensor read")
> 
No blank line here as Fixes is very much part of the tag block.

> Signed-off-by: Fernando Yang <hagisf@usp.br>
Also I've just sent a pull request with this included.

I mentioned it was queued in reply to v2.
Once a patch is queued, don't resend it as it just confuses people :(

Jonathan


> ---
>  drivers/iio/adc/ad7266.c | 2 ++
>  1 file changed, 2 insertions(+)
> 
> diff --git a/drivers/iio/adc/ad7266.c b/drivers/iio/adc/ad7266.c
> index 353a97f9c..13ea8a107 100644
> --- a/drivers/iio/adc/ad7266.c
> +++ b/drivers/iio/adc/ad7266.c
> @@ -157,6 +157,8 @@ static int ad7266_read_raw(struct iio_dev *indio_dev,
>  		ret = ad7266_read_single(st, val, chan->address);
>  		iio_device_release_direct_mode(indio_dev);
>  
> +		if (ret < 0)
> +			return ret;
>  		*val = (*val >> 2) & 0xfff;
>  		if (chan->scan_type.sign == 's')
>  			*val = sign_extend32(*val,