Linux IIO development
 help / color / mirror / Atom feed
From: Dumitru Ceclan <mitrutzceclan@gmail.com>
To: Jonathan Cameron <jic23@kernel.org>,
	 Stefan Popa <stefan.popa@analog.com>,
	 Alexandru Tachici <alexandru.tachici@analog.com>
Cc: Dumitru Ceclan <mitrutzceclan@gmail.com>,
	 Jonathan Cameron <Jonathan.Cameron@huawei.com>,
	linux-iio@vger.kernel.org,  linux-kernel@vger.kernel.org,
	Dumitru Ceclan <dumitru.ceclan@analog.com>
Subject: [PATCH 0/4] ad7124 fixes and improvements
Date: Wed, 31 Jul 2024 15:37:21 +0300	[thread overview]
Message-ID: <20240731-ad7124-fix-v1-0-46a76aa4b9be@analog.com> (raw)

This patch series adds fixes and improvements in the ad7124 driver.

Fixes:
- properly compare config values
- add a delay after reset to allow chip initialization

Improvements:
- reduce the number of SPI transfers
- ensure that after probe the ADC is in idle mode
  and not continuos conversion mode

Another thing that could be considered is improving the config pop
behavior as kfifo_get() will return the least recently added config
instead of the least recently *used* one.

This could be an issue when multiple channels are using the same "old"
config and the LRU considers that one as the least recently used.

If this is considered a valid issue, I can add another patch for it.

Signed-off-by: Dumitru Ceclan <dumitru.ceclan@analog.com>
---
Dumitru Ceclan (4):
      iio: adc: ad7124: fix chip ID mismatch
      iio: adc: ad7124: fix config comparison
      iio: adc: ad7124: reduce the number of SPI transfers
      iio: adc: ad7124: set initial ADC mode to idle

 drivers/iio/adc/ad7124.c | 61 ++++++++++++++++++++++++------------------------
 1 file changed, 31 insertions(+), 30 deletions(-)
---
base-commit: 380afccc2a55e8015adae4266e8beff96ab620be
change-id: 20240731-ad7124-fix-37aec7fe0b6b

Best regards,
-- 
Dumitru Ceclan <dumitru.ceclan@analog.com>


             reply	other threads:[~2024-07-31 12:37 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-07-31 12:37 Dumitru Ceclan [this message]
2024-07-31 12:37 ` [PATCH 1/4] iio: adc: ad7124: fix chip ID mismatch Dumitru Ceclan
2024-08-03 15:03   ` Jonathan Cameron
2024-07-31 12:37 ` [PATCH 2/4] iio: adc: ad7124: fix config comparison Dumitru Ceclan
2024-08-03 15:04   ` Jonathan Cameron
2024-07-31 12:37 ` [PATCH 3/4] iio: adc: ad7124: reduce the number of SPI transfers Dumitru Ceclan
2024-08-03 15:07   ` Jonathan Cameron
2024-07-31 12:37 ` [PATCH 4/4] iio: adc: ad7124: set initial ADC mode to idle Dumitru Ceclan
2024-08-01  8:36 ` [PATCH 0/4] ad7124 fixes and improvements Nuno Sá

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20240731-ad7124-fix-v1-0-46a76aa4b9be@analog.com \
    --to=mitrutzceclan@gmail.com \
    --cc=Jonathan.Cameron@huawei.com \
    --cc=alexandru.tachici@analog.com \
    --cc=dumitru.ceclan@analog.com \
    --cc=jic23@kernel.org \
    --cc=linux-iio@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=stefan.popa@analog.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox