Linux IIO development
 help / color / mirror / Atom feed
From: Jonathan Cameron <jic23@kernel.org>
To: Dumitru Ceclan <mitrutzceclan@gmail.com>
Cc: Stefan Popa <stefan.popa@analog.com>,
	Alexandru Tachici <alexandru.tachici@analog.com>,
	Jonathan Cameron <Jonathan.Cameron@huawei.com>,
	linux-iio@vger.kernel.org, linux-kernel@vger.kernel.org,
	Dumitru Ceclan <dumitru.ceclan@analog.com>
Subject: Re: [PATCH 3/4] iio: adc: ad7124: reduce the number of SPI transfers
Date: Sat, 3 Aug 2024 16:07:00 +0100	[thread overview]
Message-ID: <20240803160700.2f20479e@jic23-huawei> (raw)
In-Reply-To: <20240731-ad7124-fix-v1-3-46a76aa4b9be@analog.com>

On Wed, 31 Jul 2024 15:37:24 +0300
Dumitru Ceclan <mitrutzceclan@gmail.com> wrote:

> The ad7124_init_config_vref() function writes the AD7124_ADC_CONTROL
> register for each channel that is configured to use the internal
> reference.
> 
> The ad7124_write_config()function performs 7 SPI transfers for
> configuring 2 registers: config_x and filter_x.
> 
> Reduce the number of SPI transfers:
> -during the probe by only setting the st->adc_control value in
>  ad7124_init_config_vref() and writing to the device only at the end of
>  ad7124_setup().
> -in ad7124_write_config() by grouping writes to the same register.
> 
> Signed-off-by: Dumitru Ceclan <dumitru.ceclan@analog.com>
There doesn't seem to be any overlap between code touched by 1 and 2 (the fixes)
and 3 and 4 (non fixes), so I've picked 3 and 4 up now via the togreg branch of
iio.git which will be pushed out as testing for 0-day to look at.

Thanks,

Jonathan

  reply	other threads:[~2024-08-03 15:07 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-07-31 12:37 [PATCH 0/4] ad7124 fixes and improvements Dumitru Ceclan
2024-07-31 12:37 ` [PATCH 1/4] iio: adc: ad7124: fix chip ID mismatch Dumitru Ceclan
2024-08-03 15:03   ` Jonathan Cameron
2024-07-31 12:37 ` [PATCH 2/4] iio: adc: ad7124: fix config comparison Dumitru Ceclan
2024-08-03 15:04   ` Jonathan Cameron
2024-07-31 12:37 ` [PATCH 3/4] iio: adc: ad7124: reduce the number of SPI transfers Dumitru Ceclan
2024-08-03 15:07   ` Jonathan Cameron [this message]
2024-07-31 12:37 ` [PATCH 4/4] iio: adc: ad7124: set initial ADC mode to idle Dumitru Ceclan
2024-08-01  8:36 ` [PATCH 0/4] ad7124 fixes and improvements Nuno Sá

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20240803160700.2f20479e@jic23-huawei \
    --to=jic23@kernel.org \
    --cc=Jonathan.Cameron@huawei.com \
    --cc=alexandru.tachici@analog.com \
    --cc=dumitru.ceclan@analog.com \
    --cc=linux-iio@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mitrutzceclan@gmail.com \
    --cc=stefan.popa@analog.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox