From: Jonathan Cameron <jic23@kernel.org>
To: Conor Dooley <conor@kernel.org>
Cc: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>,
Lars-Peter Clausen <lars@metafoo.de>,
Rob Herring <robh@kernel.org>,
Krzysztof Kozlowski <krzk+dt@kernel.org>,
Conor Dooley <conor+dt@kernel.org>,
Jonathan Albrieux <jonathan.albrieux@gmail.com>,
Matt Ranostay <matt@ranostay.sg>,
linux-iio@vger.kernel.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH 2/2] dt-bindings: iio: asahi-kasei,ak8975: drop incorrect AK09116 compatible
Date: Tue, 6 Aug 2024 17:11:13 +0100 [thread overview]
Message-ID: <20240806171113.0cf9b992@jic23-huawei> (raw)
In-Reply-To: <20240806-unlocked-womankind-f9e5e1d19055@spud>
On Tue, 6 Aug 2024 17:02:49 +0100
Conor Dooley <conor@kernel.org> wrote:
> On Tue, Aug 06, 2024 at 07:30:16AM +0200, Krzysztof Kozlowski wrote:
> > All compatibles in this binding without prefixes were deprecated, so
> > adding a new deprecated one after some time is not allowed, because it
> > defies the core logic of deprecating things.
> >
> > Drop the AK09916 vendorless compatible.
> >
> > Fixes: 76e28aa97fa0 ("iio: magnetometer: ak8975: add AK09116 support")
> > Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
> >
> > ---
> >
> > Offending commit did not even bother to Cc devicetree mailing list and
> > DT maintainers... Lovely. Let's ignore submitting patches and
> > maintainers just to sneak my important patch into the kernel.
>
> :/
>
> Reviewed-by: Conor Dooley <conor.dooley@microchip.com>
Let's assume mistake rather than malicious.
I should have noticed this :(
Anyhow, applied both patches to the togreg branch of iio.git.
Initially pushed out as testing for 0-day to take a look at other
stuff that's queued up.
Jonathan
>
> Thanks,
> Conor.
>
> > ---
> > .../devicetree/bindings/iio/magnetometer/asahi-kasei,ak8975.yaml | 1 -
> > 1 file changed, 1 deletion(-)
> >
> > diff --git a/Documentation/devicetree/bindings/iio/magnetometer/asahi-kasei,ak8975.yaml b/Documentation/devicetree/bindings/iio/magnetometer/asahi-kasei,ak8975.yaml
> > index 9790f75fc669..fe5145d3b73c 100644
> > --- a/Documentation/devicetree/bindings/iio/magnetometer/asahi-kasei,ak8975.yaml
> > +++ b/Documentation/devicetree/bindings/iio/magnetometer/asahi-kasei,ak8975.yaml
> > @@ -23,7 +23,6 @@ properties:
> > - ak8963
> > - ak09911
> > - ak09912
> > - - ak09916
> > deprecated: true
> >
> > reg:
> > --
> > 2.43.0
> >
next prev parent reply other threads:[~2024-08-06 16:11 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-08-06 5:30 [PATCH 1/2] iio: magnetometer: ak8975: drop incorrect AK09116 compatible Krzysztof Kozlowski
2024-08-06 5:30 ` [PATCH 2/2] dt-bindings: iio: asahi-kasei,ak8975: " Krzysztof Kozlowski
2024-08-06 16:02 ` Conor Dooley
2024-08-06 16:11 ` Jonathan Cameron [this message]
2024-08-06 16:40 ` Krzysztof Kozlowski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240806171113.0cf9b992@jic23-huawei \
--to=jic23@kernel.org \
--cc=conor+dt@kernel.org \
--cc=conor@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=jonathan.albrieux@gmail.com \
--cc=krzk+dt@kernel.org \
--cc=krzysztof.kozlowski@linaro.org \
--cc=lars@metafoo.de \
--cc=linux-iio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=matt@ranostay.sg \
--cc=robh@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox