[PATCH 1/2] iio: magnetometer: ak8975: drop incorrect AK09116 compatible

[PATCH 1/2] iio: magnetometer: ak8975: drop incorrect AK09116 compatible

[Krzysztof Kozlowski]

All compatibles in this binding without prefixes were deprecated, so
adding a new deprecated one after some time is not allowed, because it
defies the core logic of deprecating things.

Drop the AK09916 vendorless compatible.

Fixes: 76e28aa97fa0 ("iio: magnetometer: ak8975: add AK09116 support")
Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
---
 drivers/iio/magnetometer/ak8975.c | 1 -
 1 file changed, 1 deletion(-)

diff --git a/drivers/iio/magnetometer/ak8975.c b/drivers/iio/magnetometer/ak8975.c
index dd466c5fa621..ccbebe5b66cd 100644
--- a/drivers/iio/magnetometer/ak8975.c
+++ b/drivers/iio/magnetometer/ak8975.c
@@ -1081,7 +1081,6 @@ static const struct of_device_id ak8975_of_match[] = {
 	{ .compatible = "asahi-kasei,ak09912", .data = &ak_def_array[AK09912] },
 	{ .compatible = "ak09912", .data = &ak_def_array[AK09912] },
 	{ .compatible = "asahi-kasei,ak09916", .data = &ak_def_array[AK09916] },
-	{ .compatible = "ak09916", .data = &ak_def_array[AK09916] },
 	{}
 };
 MODULE_DEVICE_TABLE(of, ak8975_of_match);
-- 
2.43.0

[PATCH 2/2] dt-bindings: iio: asahi-kasei,ak8975: drop incorrect AK09116 compatible

[Krzysztof Kozlowski]

All compatibles in this binding without prefixes were deprecated, so
adding a new deprecated one after some time is not allowed, because it
defies the core logic of deprecating things.

Drop the AK09916 vendorless compatible.

Fixes: 76e28aa97fa0 ("iio: magnetometer: ak8975: add AK09116 support")
Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>

---

Offending commit did not even bother to Cc devicetree mailing list and
DT maintainers... Lovely. Let's ignore submitting patches and
maintainers just to sneak my important patch into the kernel.
---
 .../devicetree/bindings/iio/magnetometer/asahi-kasei,ak8975.yaml | 1 -
 1 file changed, 1 deletion(-)

diff --git a/Documentation/devicetree/bindings/iio/magnetometer/asahi-kasei,ak8975.yaml b/Documentation/devicetree/bindings/iio/magnetometer/asahi-kasei,ak8975.yaml
index 9790f75fc669..fe5145d3b73c 100644
--- a/Documentation/devicetree/bindings/iio/magnetometer/asahi-kasei,ak8975.yaml
+++ b/Documentation/devicetree/bindings/iio/magnetometer/asahi-kasei,ak8975.yaml
@@ -23,7 +23,6 @@ properties:
           - ak8963
           - ak09911
           - ak09912
-          - ak09916
         deprecated: true
 
   reg:
-- 
2.43.0

Re: [PATCH 2/2] dt-bindings: iio: asahi-kasei,ak8975: drop incorrect AK09116 compatible

[Conor Dooley]

[-- Attachment #1: Type: text/plain, Size: 1457 bytes --]

On Tue, Aug 06, 2024 at 07:30:16AM +0200, Krzysztof Kozlowski wrote:
> All compatibles in this binding without prefixes were deprecated, so
> adding a new deprecated one after some time is not allowed, because it
> defies the core logic of deprecating things.
> 
> Drop the AK09916 vendorless compatible.
> 
> Fixes: 76e28aa97fa0 ("iio: magnetometer: ak8975: add AK09116 support")
> Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
> 
> ---
> 
> Offending commit did not even bother to Cc devicetree mailing list and
> DT maintainers... Lovely. Let's ignore submitting patches and
> maintainers just to sneak my important patch into the kernel.

:/

Reviewed-by: Conor Dooley <conor.dooley@microchip.com>

Thanks,
Conor.

> ---
>  .../devicetree/bindings/iio/magnetometer/asahi-kasei,ak8975.yaml | 1 -
>  1 file changed, 1 deletion(-)
> 
> diff --git a/Documentation/devicetree/bindings/iio/magnetometer/asahi-kasei,ak8975.yaml b/Documentation/devicetree/bindings/iio/magnetometer/asahi-kasei,ak8975.yaml
> index 9790f75fc669..fe5145d3b73c 100644
> --- a/Documentation/devicetree/bindings/iio/magnetometer/asahi-kasei,ak8975.yaml
> +++ b/Documentation/devicetree/bindings/iio/magnetometer/asahi-kasei,ak8975.yaml
> @@ -23,7 +23,6 @@ properties:
>            - ak8963
>            - ak09911
>            - ak09912
> -          - ak09916
>          deprecated: true
>  
>    reg:
> -- 
> 2.43.0
> 

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 228 bytes --]

Re: [PATCH 2/2] dt-bindings: iio: asahi-kasei,ak8975: drop incorrect AK09116 compatible

[Jonathan Cameron]

On Tue, 6 Aug 2024 17:02:49 +0100
Conor Dooley <conor@kernel.org> wrote:

> On Tue, Aug 06, 2024 at 07:30:16AM +0200, Krzysztof Kozlowski wrote:
> > All compatibles in this binding without prefixes were deprecated, so
> > adding a new deprecated one after some time is not allowed, because it
> > defies the core logic of deprecating things.
> > 
> > Drop the AK09916 vendorless compatible.
> > 
> > Fixes: 76e28aa97fa0 ("iio: magnetometer: ak8975: add AK09116 support")
> > Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
> > 
> > ---
> > 
> > Offending commit did not even bother to Cc devicetree mailing list and
> > DT maintainers... Lovely. Let's ignore submitting patches and
> > maintainers just to sneak my important patch into the kernel.
> 
> :/
> 
> Reviewed-by: Conor Dooley <conor.dooley@microchip.com>

Let's assume mistake rather than malicious.
I should have noticed this :(

Anyhow, applied both patches to the togreg branch of iio.git.
Initially pushed out as testing for 0-day to take a look at other
stuff that's queued up.

Jonathan

> 
> Thanks,
> Conor.
> 
> > ---
> >  .../devicetree/bindings/iio/magnetometer/asahi-kasei,ak8975.yaml | 1 -
> >  1 file changed, 1 deletion(-)
> > 
> > diff --git a/Documentation/devicetree/bindings/iio/magnetometer/asahi-kasei,ak8975.yaml b/Documentation/devicetree/bindings/iio/magnetometer/asahi-kasei,ak8975.yaml
> > index 9790f75fc669..fe5145d3b73c 100644
> > --- a/Documentation/devicetree/bindings/iio/magnetometer/asahi-kasei,ak8975.yaml
> > +++ b/Documentation/devicetree/bindings/iio/magnetometer/asahi-kasei,ak8975.yaml
> > @@ -23,7 +23,6 @@ properties:
> >            - ak8963
> >            - ak09911
> >            - ak09912
> > -          - ak09916
> >          deprecated: true
> >  
> >    reg:
> > -- 
> > 2.43.0
> > 

Re: [PATCH 2/2] dt-bindings: iio: asahi-kasei,ak8975: drop incorrect AK09116 compatible

[Krzysztof Kozlowski]

On 06/08/2024 18:11, Jonathan Cameron wrote:
> On Tue, 6 Aug 2024 17:02:49 +0100
> Conor Dooley <conor@kernel.org> wrote:
> 
>> On Tue, Aug 06, 2024 at 07:30:16AM +0200, Krzysztof Kozlowski wrote:
>>> All compatibles in this binding without prefixes were deprecated, so
>>> adding a new deprecated one after some time is not allowed, because it
>>> defies the core logic of deprecating things.
>>>
>>> Drop the AK09916 vendorless compatible.
>>>
>>> Fixes: 76e28aa97fa0 ("iio: magnetometer: ak8975: add AK09116 support")
>>> Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
>>>
>>> ---
>>>
>>> Offending commit did not even bother to Cc devicetree mailing list and
>>> DT maintainers... Lovely. Let's ignore submitting patches and
>>> maintainers just to sneak my important patch into the kernel.
>>
>> :/
>>
>> Reviewed-by: Conor Dooley <conor.dooley@microchip.com>
> 
> Let's assume mistake rather than malicious.
> I should have noticed this :(

You have enough of patches going through your hands, so I did not want
to say that it was your job to notice.

It was job of submitter to follow the process - run get_maintainers.pl...

Best regards,
Krzysztof