* [PATCH v1 1/1] iio: light: cm32181: Remove duplicate ACPI handle check
@ 2024-09-04 18:36 Andy Shevchenko
2024-09-07 17:17 ` Jonathan Cameron
0 siblings, 1 reply; 2+ messages in thread
From: Andy Shevchenko @ 2024-09-04 18:36 UTC (permalink / raw)
To: Andy Shevchenko, linux-iio, linux-kernel
Cc: Kevin Tsai, Jonathan Cameron, Lars-Peter Clausen
cm32181_acpi_parse_cpm_tables() is a no-op if ACPI handle
is not available. Remove duplicate ACPI handle check at
the caller side.
Signed-off-by: Andy Shevchenko <andy.shevchenko@gmail.com>
---
drivers/iio/light/cm32181.c | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/drivers/iio/light/cm32181.c b/drivers/iio/light/cm32181.c
index 9df85b3999fa..aeae0566ec12 100644
--- a/drivers/iio/light/cm32181.c
+++ b/drivers/iio/light/cm32181.c
@@ -217,8 +217,7 @@ static int cm32181_reg_init(struct cm32181_chip *cm32181)
cm32181->lux_per_bit = CM32181_LUX_PER_BIT;
cm32181->lux_per_bit_base_it = CM32181_LUX_PER_BIT_BASE_IT;
- if (ACPI_HANDLE(cm32181->dev))
- cm32181_acpi_parse_cpm_tables(cm32181);
+ cm32181_acpi_parse_cpm_tables(cm32181);
/* Initialize registers*/
for_each_set_bit(i, &cm32181->init_regs_bitmap, CM32181_CONF_REG_NUM) {
--
2.46.0
^ permalink raw reply related [flat|nested] 2+ messages in thread* Re: [PATCH v1 1/1] iio: light: cm32181: Remove duplicate ACPI handle check
2024-09-04 18:36 [PATCH v1 1/1] iio: light: cm32181: Remove duplicate ACPI handle check Andy Shevchenko
@ 2024-09-07 17:17 ` Jonathan Cameron
0 siblings, 0 replies; 2+ messages in thread
From: Jonathan Cameron @ 2024-09-07 17:17 UTC (permalink / raw)
To: Andy Shevchenko; +Cc: linux-iio, linux-kernel, Kevin Tsai, Lars-Peter Clausen
On Wed, 4 Sep 2024 21:36:46 +0300
Andy Shevchenko <andy.shevchenko@gmail.com> wrote:
> cm32181_acpi_parse_cpm_tables() is a no-op if ACPI handle
> is not available. Remove duplicate ACPI handle check at
> the caller side.
>
> Signed-off-by: Andy Shevchenko <andy.shevchenko@gmail.com>
Hmmm. Not the most obvious code give it relies on an error
being definitely less than the header size, but indeed it
will error out if the handle isn't there.
Applied.
Jonathan
> ---
> drivers/iio/light/cm32181.c | 3 +--
> 1 file changed, 1 insertion(+), 2 deletions(-)
>
> diff --git a/drivers/iio/light/cm32181.c b/drivers/iio/light/cm32181.c
> index 9df85b3999fa..aeae0566ec12 100644
> --- a/drivers/iio/light/cm32181.c
> +++ b/drivers/iio/light/cm32181.c
> @@ -217,8 +217,7 @@ static int cm32181_reg_init(struct cm32181_chip *cm32181)
> cm32181->lux_per_bit = CM32181_LUX_PER_BIT;
> cm32181->lux_per_bit_base_it = CM32181_LUX_PER_BIT_BASE_IT;
>
> - if (ACPI_HANDLE(cm32181->dev))
> - cm32181_acpi_parse_cpm_tables(cm32181);
> + cm32181_acpi_parse_cpm_tables(cm32181);
>
> /* Initialize registers*/
> for_each_set_bit(i, &cm32181->init_regs_bitmap, CM32181_CONF_REG_NUM) {
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2024-09-07 17:18 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2024-09-04 18:36 [PATCH v1 1/1] iio: light: cm32181: Remove duplicate ACPI handle check Andy Shevchenko
2024-09-07 17:17 ` Jonathan Cameron
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox