From: Jonathan Cameron <jic23@kernel.org>
To: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Cc: "Hans de Goede" <hdegoede@redhat.com>,
"Jonathan Cameron" <Jonathan.Cameron@huawei.com>,
linux-iio@vger.kernel.org, linux-kernel@vger.kernel.org,
"Lars-Peter Clausen" <lars@metafoo.de>,
"Ilpo Järvinen" <ilpo.jarvinen@linux.intel.com>
Subject: Re: [PATCH v1 1/1] iio: light: ltr501: Drop most likely fake ACPI ID
Date: Sat, 14 Sep 2024 15:25:41 +0100 [thread overview]
Message-ID: <20240914152541.1c2228f4@jic23-huawei> (raw)
In-Reply-To: <ZuQGcyrTFek1yExt@smile.fi.intel.com>
On Fri, 13 Sep 2024 12:31:31 +0300
Andy Shevchenko <andriy.shevchenko@linux.intel.com> wrote:
> On Thu, Sep 12, 2024 at 03:51:09PM +0200, Hans de Goede wrote:
> > Hi,
> >
> > On 9/11/24 11:22 PM, Andy Shevchenko wrote:
> > > The commit in question does not proove that ACPI ID exists.
> > > Quite likely it was a cargo cult addition while doint that
> > > for DT-based enumeration. Drop most likely fake ACPI ID.
> > >
> > > Googling for LTERxxxx gives no useful results in regard to DSDT.
> > > Moreover, there is no "LTER" official vendor ID in the registry.
> > >
> > > Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
> >
> > Thanks, patch looks good to me:
>
> Have you grepped over your collection of real DSDTs?
>
> > Reviewed-by: Hans de Goede <hdegoede@redhat.com>
>
> Thank you!
>
I'll pick these up in the meantime. Applied to the testing
branch of iio.git.
next prev parent reply other threads:[~2024-09-14 14:25 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-09-11 21:22 [PATCH v1 1/1] iio: light: ltr501: Drop most likely fake ACPI ID Andy Shevchenko
2024-09-12 13:51 ` Hans de Goede
2024-09-13 9:31 ` Andy Shevchenko
2024-09-14 14:25 ` Jonathan Cameron [this message]
2024-09-14 14:30 ` Hans de Goede
2024-09-14 15:06 ` Jonathan Cameron
2024-09-14 13:45 ` Hans de Goede
2024-09-16 10:00 ` Andy Shevchenko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240914152541.1c2228f4@jic23-huawei \
--to=jic23@kernel.org \
--cc=Jonathan.Cameron@huawei.com \
--cc=andriy.shevchenko@linux.intel.com \
--cc=hdegoede@redhat.com \
--cc=ilpo.jarvinen@linux.intel.com \
--cc=lars@metafoo.de \
--cc=linux-iio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox