* [PATCH] iio: adc: max1363: Convert to get_unaligned_be16
@ 2024-09-20 18:14 Abhash Jha
2024-09-28 15:30 ` Jonathan Cameron
0 siblings, 1 reply; 2+ messages in thread
From: Abhash Jha @ 2024-09-20 18:14 UTC (permalink / raw)
To: linux-iio; +Cc: jic23, lars, linux-kernel, Abhash Jha
Converted manual shifting and or to use `get_unaligned_be16` api
instead.
Signed-off-by: Abhash Jha <abhashkumarjha123@gmail.com>
---
drivers/iio/adc/max1363.c | 4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)
diff --git a/drivers/iio/adc/max1363.c b/drivers/iio/adc/max1363.c
index bf4b6dc53..0801317da 100644
--- a/drivers/iio/adc/max1363.c
+++ b/drivers/iio/adc/max1363.c
@@ -33,6 +33,8 @@
#include <linux/iio/trigger_consumer.h>
#include <linux/iio/triggered_buffer.h>
+#include <asm/unaligned.h>
+
#define MAX1363_SETUP_BYTE(a) ((a) | 0x80)
/* There is a fair bit more defined here than currently
@@ -391,7 +393,7 @@ static int max1363_read_single_chan(struct iio_dev *indio_dev,
if (data < 0)
return data;
- data = (rxbuf[1] | rxbuf[0] << 8) &
+ data = get_unaligned_be16(rxbuf) &
((1 << st->chip_info->bits) - 1);
} else {
/* Get reading */
--
2.43.0
^ permalink raw reply related [flat|nested] 2+ messages in thread* Re: [PATCH] iio: adc: max1363: Convert to get_unaligned_be16
2024-09-20 18:14 [PATCH] iio: adc: max1363: Convert to get_unaligned_be16 Abhash Jha
@ 2024-09-28 15:30 ` Jonathan Cameron
0 siblings, 0 replies; 2+ messages in thread
From: Jonathan Cameron @ 2024-09-28 15:30 UTC (permalink / raw)
To: Abhash Jha; +Cc: linux-iio, lars, linux-kernel
On Fri, 20 Sep 2024 23:44:37 +0530
Abhash Jha <abhashkumarjha123@gmail.com> wrote:
> Converted manual shifting and or to use `get_unaligned_be16` api
> instead.
>
> Signed-off-by: Abhash Jha <abhashkumarjha123@gmail.com>
Applied
Thanks,
Jonathan
> ---
> drivers/iio/adc/max1363.c | 4 +++-
> 1 file changed, 3 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/iio/adc/max1363.c b/drivers/iio/adc/max1363.c
> index bf4b6dc53..0801317da 100644
> --- a/drivers/iio/adc/max1363.c
> +++ b/drivers/iio/adc/max1363.c
> @@ -33,6 +33,8 @@
> #include <linux/iio/trigger_consumer.h>
> #include <linux/iio/triggered_buffer.h>
>
> +#include <asm/unaligned.h>
> +
> #define MAX1363_SETUP_BYTE(a) ((a) | 0x80)
>
> /* There is a fair bit more defined here than currently
> @@ -391,7 +393,7 @@ static int max1363_read_single_chan(struct iio_dev *indio_dev,
> if (data < 0)
> return data;
>
> - data = (rxbuf[1] | rxbuf[0] << 8) &
> + data = get_unaligned_be16(rxbuf) &
> ((1 << st->chip_info->bits) - 1);
> } else {
> /* Get reading */
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2024-09-28 15:30 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2024-09-20 18:14 [PATCH] iio: adc: max1363: Convert to get_unaligned_be16 Abhash Jha
2024-09-28 15:30 ` Jonathan Cameron
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox