* [PATCH 00/51] treewide: Switch to __pm_runtime_put_autosuspend()
@ 2024-10-04 9:41 Sakari Ailus
2024-10-04 9:41 ` [PATCH 19/51] iio: " Sakari Ailus
2024-10-04 14:38 ` [PATCH 00/51] treewide: " Ulf Hansson
0 siblings, 2 replies; 14+ messages in thread
From: Sakari Ailus @ 2024-10-04 9:41 UTC (permalink / raw)
To: dri-devel, linux-kernel, linux-bluetooth, linux-clk, linux-crypto,
dmaengine, linux-gpio, amd-gfx, nouveau, linux-stm32,
linux-arm-kernel, linux-i2c, linux-i3c, linux-iio, linux-input,
patches, iommu, imx, linux-mediatek, linux-media, linux-mmc,
linux-mtd, netdev, linux-wireless, linux-pci, linux-phy,
linux-pwm, linux-remoteproc, linux-sound, linux-spi,
linux-staging, linux-usb, linux-serial, greybus-dev, asahi
Cc: laurent.pinchart, rafael, Andy Shevchenko
Hello everyone,
This set will switch the users of pm_runtime_put_autosuspend() to
__pm_runtime_put_autosuspend() while the former will soon be re-purposed
to include a call to pm_runtime_mark_last_busy(). The two are almost
always used together, apart from bugs which are likely common. Going
forward, most new users should be using pm_runtime_put_autosuspend().
Once this conversion is done and pm_runtime_put_autosuspend() re-purposed,
I'll post another set to merge the calls to __pm_runtime_put_autosuspend()
and pm_runtime_mark_last_busy().
The diff in these patches have been generated using the following
Coccinelle script (besides a manual change in
drivers/iio/magnetometer/af8133j.c):
----------8<-------------------
@@
expression E1;
@@
- pm_runtime_put_autosuspend(E1)
+ __pm_runtime_put_autosuspend(E1)
----------8<-------------------
These patches are on top of today's linux-next (i.e. next-20241004).
Sakari Ailus (51):
accel/ivpu: Switch to __pm_runtime_put_autosuspend()
bluetooth: Switch to __pm_runtime_put_autosuspend()
bus: sunxi-rsb: Switch to __pm_runtime_put_autosuspend()
hwrng: Switch to __pm_runtime_put_autosuspend()
clk: Switch to __pm_runtime_put_autosuspend()
crypto: Switch to __pm_runtime_put_autosuspend()
dmaengine: Switch to __pm_runtime_put_autosuspend()
gpio: Switch to __pm_runtime_put_autosuspend()
drm/amd: Switch to __pm_runtime_put_autosuspend()
drm/nouveau: Switch to __pm_runtime_put_autosuspend()
drm/radeon: Switch to __pm_runtime_put_autosuspend()
drm/panfrost: Switch to __pm_runtime_put_autosuspend()
drivers: drm: Switch to __pm_runtime_put_autosuspend()
HSI: omap_ssi_port: Switch to __pm_runtime_put_autosuspend()
stm class: Switch to __pm_runtime_put_autosuspend()
i2c: Switch to __pm_runtime_put_autosuspend()
i3c: master: svc: Switch to __pm_runtime_put_autosuspend()
i3c: dw: Switch to __pm_runtime_put_autosuspend()
iio: Switch to __pm_runtime_put_autosuspend()
Input: omap4-keypad: Switch to __pm_runtime_put_autosuspend()
Input: cs40l50: Switch to __pm_runtime_put_autosuspend()
iommu/arm-smmu: Switch to __pm_runtime_put_autosuspend()
irqchip/imx-irqsteer: Switch to __pm_runtime_put_autosuspend()
mailbox: mtk-cmdq-mailbox: Switch to __pm_runtime_put_autosuspend()
media: Switch to __pm_runtime_put_autosuspend()
mfd: Switch to __pm_runtime_put_autosuspend()
mei: Switch to __pm_runtime_put_autosuspend()
mmc: Switch to __pm_runtime_put_autosuspend()
mtd: rawnand: gpmi: Switch to __pm_runtime_put_autosuspend()
net: Switch to __pm_runtime_put_autosuspend()
nfc: trf7970a: Switch to __pm_runtime_put_autosuspend()
PCI/portdrv: Switch to __pm_runtime_put_autosuspend()
phy: motorola: phy-mapphone-mdm6600: Switch to
__pm_runtime_put_autosuspend()
phy: ti: phy-twl4030-usb: Switch to __pm_runtime_put_autosuspend()
power: Switch to __pm_runtime_put_autosuspend()
pwm: img: Switch to __pm_runtime_put_autosuspend()
regulator: stm32-vrefbuf: Switch to __pm_runtime_put_autosuspend()
remoteproc: omap: Switch to __pm_runtime_put_autosuspend()
slimbus: Switch to __pm_runtime_put_autosuspend()
soundwire: Switch to __pm_runtime_put_autosuspend()
spi: Switch to __pm_runtime_put_autosuspend()
staging: Switch to __pm_runtime_put_autosuspend()
thunderbolt: Switch to __pm_runtime_put_autosuspend()
serial: Switch to __pm_runtime_put_autosuspend()
usb: Switch to __pm_runtime_put_autosuspend()
w1: omap-hdq: Switch to __pm_runtime_put_autosuspend()
staging: greybus: Switch to __pm_runtime_put_autosuspend()
ALSA: hda: Switch to __pm_runtime_put_autosuspend()
ASoC: Switch to __pm_runtime_put_autosuspend()
ALSA: intel_hdmi: Switch to __pm_runtime_put_autosuspend()
soc: apple: mailbox: Switch to __pm_runtime_put_autosuspend()
drivers/accel/ivpu/ivpu_drv.c | 2 +-
drivers/accel/ivpu/ivpu_pm.c | 8 +-
drivers/bluetooth/btmtksdio.c | 2 +-
drivers/bluetooth/hci_bcm.c | 6 +-
drivers/bluetooth/hci_h5.c | 4 +-
drivers/bluetooth/hci_intel.c | 6 +-
drivers/bus/sunxi-rsb.c | 4 +-
drivers/char/hw_random/cctrng.c | 2 +-
drivers/char/hw_random/omap3-rom-rng.c | 2 +-
drivers/clk/imx/clk-imx8qxp-lpcg.c | 2 +-
drivers/clk/imx/clk-scu.c | 2 +-
drivers/clk/qcom/lpassaudiocc-sc7280.c | 4 +-
drivers/clk/qcom/lpasscorecc-sc7180.c | 4 +-
drivers/crypto/ccree/cc_pm.c | 2 +-
drivers/crypto/hisilicon/qm.c | 2 +-
drivers/crypto/omap-aes-gcm.c | 2 +-
drivers/crypto/omap-aes.c | 2 +-
drivers/crypto/omap-des.c | 2 +-
drivers/crypto/omap-sham.c | 2 +-
drivers/crypto/rockchip/rk3288_crypto_ahash.c | 2 +-
.../crypto/rockchip/rk3288_crypto_skcipher.c | 2 +-
drivers/crypto/stm32/stm32-crc32.c | 4 +-
drivers/crypto/stm32/stm32-cryp.c | 2 +-
drivers/crypto/stm32/stm32-hash.c | 2 +-
drivers/dma/at_xdmac.c | 24 +--
drivers/dma/pl330.c | 14 +-
drivers/dma/qcom/bam_dma.c | 10 +-
drivers/dma/qcom/hidma.c | 18 +-
drivers/dma/qcom/hidma_dbg.c | 2 +-
drivers/dma/qcom/hidma_mgmt.c | 4 +-
drivers/dma/ste_dma40.c | 16 +-
drivers/dma/ti/cppi41.c | 10 +-
drivers/dma/xilinx/zynqmp_dma.c | 2 +-
drivers/gpio/gpio-arizona.c | 10 +-
drivers/gpio/gpio-mxc.c | 2 +-
drivers/gpu/drm/amd/amdgpu/amdgpu_acpi.c | 2 +-
.../gpu/drm/amd/amdgpu/amdgpu_connectors.c | 16 +-
drivers/gpu/drm/amd/amdgpu/amdgpu_debugfs.c | 120 ++++++------
drivers/gpu/drm/amd/amdgpu/amdgpu_display.c | 2 +-
drivers/gpu/drm/amd/amdgpu/amdgpu_drv.c | 6 +-
drivers/gpu/drm/amd/amdgpu/amdgpu_fence.c | 6 +-
drivers/gpu/drm/amd/amdgpu/amdgpu_gfx.c | 4 +-
drivers/gpu/drm/amd/amdgpu/amdgpu_kms.c | 4 +-
drivers/gpu/drm/amd/amdgpu/amdgpu_rap.c | 4 +-
drivers/gpu/drm/amd/amdgpu/amdgpu_ras.c | 2 +-
.../gpu/drm/amd/amdgpu/amdgpu_securedisplay.c | 4 +-
drivers/gpu/drm/amd/amdkfd/kfd_process.c | 4 +-
.../gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c | 2 +-
drivers/gpu/drm/amd/pm/amdgpu_pm.c | 178 +++++++++---------
.../drm/bridge/analogix/analogix_dp_core.c | 2 +-
drivers/gpu/drm/bridge/analogix/anx7625.c | 4 +-
drivers/gpu/drm/bridge/parade-ps8640.c | 4 +-
drivers/gpu/drm/bridge/ti-sn65dsi86.c | 14 +-
drivers/gpu/drm/etnaviv/etnaviv_gpu.c | 12 +-
drivers/gpu/drm/exynos/exynos_drm_fimc.c | 4 +-
drivers/gpu/drm/exynos/exynos_drm_g2d.c | 4 +-
drivers/gpu/drm/exynos/exynos_drm_gsc.c | 6 +-
drivers/gpu/drm/exynos/exynos_drm_rotator.c | 2 +-
drivers/gpu/drm/exynos/exynos_drm_scaler.c | 2 +-
drivers/gpu/drm/i915/intel_runtime_pm.c | 4 +-
drivers/gpu/drm/imx/dcss/dcss-crtc.c | 2 +-
drivers/gpu/drm/lima/lima_sched.c | 2 +-
drivers/gpu/drm/msm/adreno/adreno_device.c | 2 +-
drivers/gpu/drm/msm/adreno/adreno_gpu.c | 2 +-
drivers/gpu/drm/msm/msm_gpu.c | 2 +-
drivers/gpu/drm/msm/msm_iommu.c | 4 +-
drivers/gpu/drm/msm/msm_submitqueue.c | 2 +-
drivers/gpu/drm/nouveau/dispnv50/disp.c | 10 +-
drivers/gpu/drm/nouveau/nouveau_connector.c | 4 +-
drivers/gpu/drm/nouveau/nouveau_debugfs.c | 8 +-
drivers/gpu/drm/nouveau/nouveau_display.c | 4 +-
drivers/gpu/drm/nouveau/nouveau_drm.c | 10 +-
drivers/gpu/drm/nouveau/nouveau_gem.c | 10 +-
drivers/gpu/drm/panel/panel-edp.c | 8 +-
.../gpu/drm/panel/panel-samsung-atna33xc20.c | 6 +-
drivers/gpu/drm/panel/panel-simple.c | 6 +-
drivers/gpu/drm/panfrost/panfrost_job.c | 4 +-
drivers/gpu/drm/panfrost/panfrost_mmu.c | 4 +-
drivers/gpu/drm/panfrost/panfrost_perfcnt.c | 4 +-
drivers/gpu/drm/panthor/panthor_device.c | 2 +-
drivers/gpu/drm/panthor/panthor_sched.c | 6 +-
drivers/gpu/drm/radeon/radeon_acpi.c | 2 +-
drivers/gpu/drm/radeon/radeon_connectors.c | 20 +-
drivers/gpu/drm/radeon/radeon_display.c | 6 +-
drivers/gpu/drm/radeon/radeon_drv.c | 4 +-
drivers/gpu/drm/radeon/radeon_fbdev.c | 4 +-
drivers/gpu/drm/radeon/radeon_kms.c | 10 +-
drivers/gpu/drm/tegra/submit.c | 2 +-
drivers/gpu/drm/tidss/tidss_drv.c | 2 +-
drivers/gpu/drm/vc4/vc4_v3d.c | 2 +-
drivers/hsi/controllers/omap_ssi_port.c | 42 ++---
drivers/hwtracing/stm/core.c | 8 +-
drivers/i2c/busses/i2c-amd-mp2-pci.c | 2 +-
drivers/i2c/busses/i2c-amd-mp2.h | 2 +-
drivers/i2c/busses/i2c-at91-master.c | 2 +-
drivers/i2c/busses/i2c-cadence.c | 2 +-
drivers/i2c/busses/i2c-davinci.c | 4 +-
drivers/i2c/busses/i2c-designware-master.c | 2 +-
drivers/i2c/busses/i2c-designware-pcidrv.c | 2 +-
drivers/i2c/busses/i2c-hix5hd2.c | 2 +-
drivers/i2c/busses/i2c-i801.c | 4 +-
drivers/i2c/busses/i2c-img-scb.c | 6 +-
drivers/i2c/busses/i2c-imx-lpi2c.c | 6 +-
drivers/i2c/busses/i2c-imx.c | 4 +-
drivers/i2c/busses/i2c-mv64xxx.c | 2 +-
drivers/i2c/busses/i2c-nvidia-gpu.c | 4 +-
drivers/i2c/busses/i2c-omap.c | 6 +-
drivers/i2c/busses/i2c-qcom-cci.c | 2 +-
drivers/i2c/busses/i2c-qcom-geni.c | 2 +-
drivers/i2c/busses/i2c-qup.c | 4 +-
drivers/i2c/busses/i2c-riic.c | 4 +-
drivers/i2c/busses/i2c-rzv2m.c | 2 +-
drivers/i2c/busses/i2c-sprd.c | 4 +-
drivers/i2c/busses/i2c-stm32f7.c | 10 +-
drivers/i2c/busses/i2c-xiic.c | 2 +-
drivers/i3c/master/dw-i3c-master.c | 16 +-
drivers/i3c/master/svc-i3c-master.c | 16 +-
drivers/iio/accel/bmc150-accel-core.c | 2 +-
drivers/iio/accel/bmi088-accel-core.c | 6 +-
drivers/iio/accel/fxls8962af-core.c | 2 +-
drivers/iio/accel/kxcjk-1013.c | 2 +-
drivers/iio/accel/kxsd9.c | 6 +-
drivers/iio/accel/mma8452.c | 2 +-
drivers/iio/accel/mma9551_core.c | 2 +-
drivers/iio/accel/msa311.c | 12 +-
drivers/iio/adc/ab8500-gpadc.c | 2 +-
drivers/iio/adc/at91-sama5d2_adc.c | 20 +-
drivers/iio/adc/rcar-gyroadc.c | 2 +-
drivers/iio/adc/stm32-adc-core.c | 2 +-
drivers/iio/adc/stm32-adc.c | 12 +-
drivers/iio/adc/sun4i-gpadc-iio.c | 4 +-
drivers/iio/adc/ti-ads1015.c | 2 +-
drivers/iio/adc/ti-ads1100.c | 2 +-
drivers/iio/adc/ti-ads1119.c | 4 +-
drivers/iio/chemical/atlas-sensor.c | 4 +-
.../common/hid-sensors/hid-sensor-trigger.c | 2 +-
drivers/iio/dac/stm32-dac.c | 6 +-
drivers/iio/gyro/bmg160_core.c | 2 +-
drivers/iio/gyro/fxas21002c_core.c | 2 +-
drivers/iio/gyro/mpu3050-core.c | 6 +-
drivers/iio/gyro/mpu3050-i2c.c | 2 +-
.../iio/imu/inv_icm42600/inv_icm42600_accel.c | 10 +-
.../imu/inv_icm42600/inv_icm42600_buffer.c | 2 +-
.../iio/imu/inv_icm42600/inv_icm42600_gyro.c | 10 +-
.../iio/imu/inv_icm42600/inv_icm42600_temp.c | 2 +-
drivers/iio/imu/inv_mpu6050/inv_mpu_core.c | 14 +-
drivers/iio/imu/inv_mpu6050/inv_mpu_trigger.c | 4 +-
drivers/iio/imu/kmx61.c | 2 +-
drivers/iio/light/apds9306.c | 6 +-
drivers/iio/light/apds9960.c | 4 +-
drivers/iio/light/bh1780.c | 2 +-
drivers/iio/light/gp2ap002.c | 4 +-
drivers/iio/light/isl29028.c | 2 +-
drivers/iio/light/ltrf216a.c | 2 +-
drivers/iio/light/pa12203001.c | 2 +-
drivers/iio/light/rpr0521.c | 2 +-
drivers/iio/light/tsl2583.c | 2 +-
drivers/iio/light/tsl2591.c | 4 +-
drivers/iio/light/us5182d.c | 2 +-
drivers/iio/light/vcnl4000.c | 2 +-
drivers/iio/light/vcnl4035.c | 2 +-
drivers/iio/magnetometer/af8133j.c | 4 +-
drivers/iio/magnetometer/ak8974.c | 4 +-
drivers/iio/magnetometer/ak8975.c | 2 +-
drivers/iio/magnetometer/bmc150_magn.c | 2 +-
drivers/iio/magnetometer/tmag5273.c | 4 +-
drivers/iio/magnetometer/yamaha-yas530.c | 4 +-
drivers/iio/pressure/bmp280-core.c | 10 +-
drivers/iio/pressure/icp10100.c | 2 +-
drivers/iio/pressure/mpl115.c | 4 +-
drivers/iio/pressure/zpa2326.c | 4 +-
.../iio/proximity/pulsedlight-lidar-lite-v2.c | 2 +-
drivers/iio/proximity/srf04.c | 2 +-
drivers/iio/temperature/mlx90614.c | 4 +-
drivers/iio/temperature/mlx90632.c | 4 +-
drivers/iio/temperature/mlx90635.c | 4 +-
drivers/input/keyboard/omap4-keypad.c | 8 +-
drivers/input/misc/cs40l50-vibra.c | 8 +-
drivers/iommu/arm/arm-smmu/arm-smmu.c | 2 +-
drivers/irqchip/irq-imx-irqsteer.c | 2 +-
drivers/mailbox/mtk-cmdq-mailbox.c | 10 +-
drivers/media/i2c/alvium-csi2.c | 2 +-
drivers/media/i2c/ccs/ccs-core.c | 10 +-
drivers/media/i2c/dw9719.c | 2 +-
drivers/media/i2c/gc0308.c | 6 +-
drivers/media/i2c/gc2145.c | 8 +-
drivers/media/i2c/imx283.c | 6 +-
drivers/media/i2c/imx290.c | 6 +-
drivers/media/i2c/imx296.c | 4 +-
drivers/media/i2c/imx415.c | 4 +-
drivers/media/i2c/mt9m114.c | 12 +-
drivers/media/i2c/ov2680.c | 2 +-
drivers/media/i2c/ov4689.c | 6 +-
drivers/media/i2c/ov5640.c | 8 +-
drivers/media/i2c/ov5645.c | 6 +-
drivers/media/i2c/ov5693.c | 2 +-
drivers/media/i2c/ov64a40.c | 8 +-
drivers/media/i2c/ov7251.c | 2 +-
drivers/media/i2c/ov8858.c | 4 +-
drivers/media/i2c/thp7312.c | 8 +-
drivers/media/i2c/video-i2c.c | 8 +-
.../media/platform/nvidia/tegra-vde/h264.c | 4 +-
drivers/media/platform/qcom/venus/vdec.c | 4 +-
drivers/media/platform/qcom/venus/venc.c | 4 +-
.../platform/raspberrypi/pisp_be/pisp_be.c | 4 +-
.../media/platform/st/sti/delta/delta-v4l2.c | 4 +-
drivers/media/platform/st/sti/hva/hva-hw.c | 8 +-
.../media/platform/verisilicon/hantro_drv.c | 2 +-
drivers/media/rc/gpio-ir-recv.c | 2 +-
drivers/mfd/arizona-irq.c | 2 +-
drivers/mfd/cs40l50-core.c | 2 +-
drivers/mfd/cs42l43.c | 2 +-
drivers/misc/mei/client.c | 14 +-
drivers/mmc/core/core.c | 4 +-
drivers/mmc/host/atmel-mci.c | 4 +-
drivers/mmc/host/dw_mmc-rockchip.c | 2 +-
drivers/mmc/host/dw_mmc.c | 2 +-
drivers/mmc/host/mmci.c | 2 +-
drivers/mmc/host/omap_hsmmc.c | 6 +-
drivers/mmc/host/sdhci-msm.c | 2 +-
drivers/mmc/host/sdhci-of-at91.c | 2 +-
drivers/mmc/host/sdhci-omap.c | 4 +-
drivers/mmc/host/sdhci-pci-core.c | 2 +-
drivers/mmc/host/sdhci-pxav3.c | 6 +-
drivers/mmc/host/sdhci-sprd.c | 2 +-
drivers/mmc/host/sdhci-xenon.c | 2 +-
drivers/mmc/host/sdhci_am654.c | 2 +-
drivers/mmc/host/tmio_mmc_core.c | 2 +-
drivers/mtd/nand/raw/gpmi-nand/gpmi-nand.c | 10 +-
drivers/net/ethernet/cadence/macb_main.c | 10 +-
drivers/net/ethernet/freescale/fec_main.c | 16 +-
drivers/net/ethernet/renesas/ravb_main.c | 8 +-
drivers/net/ethernet/ti/davinci_mdio.c | 14 +-
drivers/net/ipa/ipa_interrupt.c | 2 +-
drivers/net/ipa/ipa_main.c | 2 +-
drivers/net/ipa/ipa_modem.c | 8 +-
drivers/net/ipa/ipa_smp2p.c | 4 +-
drivers/net/ipa/ipa_uc.c | 4 +-
drivers/net/wireless/ath/wil6210/pm.c | 2 +-
drivers/net/wireless/ti/wl18xx/debugfs.c | 6 +-
drivers/net/wireless/ti/wlcore/cmd.c | 2 +-
drivers/net/wireless/ti/wlcore/debugfs.c | 22 +--
drivers/net/wireless/ti/wlcore/main.c | 72 +++----
drivers/net/wireless/ti/wlcore/scan.c | 2 +-
drivers/net/wireless/ti/wlcore/sysfs.c | 2 +-
drivers/net/wireless/ti/wlcore/testmode.c | 4 +-
drivers/net/wireless/ti/wlcore/tx.c | 2 +-
drivers/net/wireless/ti/wlcore/vendor_cmd.c | 6 +-
drivers/net/wwan/qcom_bam_dmux.c | 4 +-
drivers/net/wwan/t7xx/t7xx_hif_cldma.c | 6 +-
drivers/net/wwan/t7xx/t7xx_hif_dpmaif_rx.c | 6 +-
drivers/net/wwan/t7xx/t7xx_hif_dpmaif_tx.c | 4 +-
drivers/nfc/trf7970a.c | 2 +-
drivers/pci/pcie/portdrv.c | 2 +-
drivers/phy/motorola/phy-mapphone-mdm6600.c | 4 +-
drivers/phy/ti/phy-twl4030-usb.c | 8 +-
drivers/power/supply/bq24190_charger.c | 28 +--
drivers/power/supply/twl4030_charger.c | 2 +-
drivers/pwm/pwm-img.c | 4 +-
drivers/regulator/stm32-vrefbuf.c | 12 +-
drivers/remoteproc/omap_remoteproc.c | 6 +-
drivers/slimbus/core.c | 2 +-
drivers/slimbus/messaging.c | 4 +-
drivers/soc/apple/mailbox.c | 2 +-
drivers/soundwire/bus.c | 2 +-
drivers/soundwire/cadence_master.c | 2 +-
drivers/soundwire/qcom.c | 6 +-
drivers/spi/atmel-quadspi.c | 10 +-
drivers/spi/spi-cadence-quadspi.c | 4 +-
drivers/spi/spi-cadence.c | 2 +-
drivers/spi/spi-dw-pci.c | 2 +-
drivers/spi/spi-fsl-espi.c | 4 +-
drivers/spi/spi-fsl-lpspi.c | 4 +-
drivers/spi/spi-imx.c | 6 +-
drivers/spi/spi-mtk-nor.c | 2 +-
drivers/spi/spi-omap2-mcspi.c | 6 +-
drivers/spi/spi-pxa2xx-pci.c | 2 +-
drivers/spi/spi-s3c64xx.c | 6 +-
drivers/spi/spi-sprd.c | 2 +-
drivers/spi/spi-stm32-qspi.c | 14 +-
drivers/spi/spi-stm32.c | 4 +-
drivers/spi/spi-ti-qspi.c | 4 +-
drivers/spi/spi-zynqmp-gqspi.c | 2 +-
drivers/spi/spi.c | 6 +-
drivers/staging/greybus/gbphy.h | 2 +-
drivers/staging/media/rkvdec/rkvdec.c | 2 +-
drivers/thunderbolt/debugfs.c | 22 +--
drivers/thunderbolt/domain.c | 4 +-
drivers/thunderbolt/icm.c | 14 +-
drivers/thunderbolt/nhi.c | 2 +-
drivers/thunderbolt/retimer.c | 4 +-
drivers/thunderbolt/switch.c | 6 +-
drivers/thunderbolt/tb.c | 18 +-
drivers/thunderbolt/usb4_port.c | 4 +-
drivers/tty/serial/8250/8250_omap.c | 18 +-
drivers/tty/serial/8250/8250_port.c | 4 +-
drivers/tty/serial/fsl_lpuart.c | 2 +-
drivers/tty/serial/serial_core.c | 2 +-
drivers/tty/serial/uartlite.c | 4 +-
drivers/tty/serial/xilinx_uartps.c | 2 +-
drivers/usb/cdns3/cdns3-gadget.c | 2 +-
drivers/usb/cdns3/cdnsp-gadget.c | 2 +-
drivers/usb/chipidea/core.c | 2 +-
drivers/usb/chipidea/otg_fsm.c | 2 +-
drivers/usb/dwc3/core.c | 2 +-
drivers/usb/dwc3/dwc3-am62.c | 2 +-
drivers/usb/dwc3/dwc3-imx8mp.c | 2 +-
drivers/usb/gadget/udc/cdns2/cdns2-gadget.c | 2 +-
drivers/usb/host/xhci-mtk.c | 2 +-
drivers/usb/misc/apple-mfi-fastcharge.c | 2 +-
drivers/usb/mtu3/mtu3_plat.c | 2 +-
drivers/usb/musb/musb_core.c | 10 +-
drivers/usb/musb/musb_debugfs.c | 10 +-
drivers/usb/musb/musb_dsps.c | 2 +-
drivers/usb/musb/musb_gadget.c | 8 +-
drivers/usb/musb/omap2430.c | 2 +-
drivers/w1/masters/omap_hdq.c | 10 +-
include/linux/greybus/bundle.h | 2 +-
sound/hda/hdac_device.c | 2 +-
sound/pci/hda/cs35l41_hda.c | 8 +-
sound/pci/hda/cs35l56_hda.c | 2 +-
sound/pci/hda/hda_intel.c | 2 +-
sound/pci/hda/tas2781_hda_i2c.c | 6 +-
sound/soc/atmel/mchp-spdifrx.c | 12 +-
sound/soc/codecs/arizona-jack.c | 12 +-
sound/soc/codecs/arizona.c | 2 +-
sound/soc/codecs/cs35l41.c | 4 +-
sound/soc/codecs/cs35l45.c | 2 +-
sound/soc/codecs/cs35l56-sdw.c | 4 +-
sound/soc/codecs/cs35l56-shared.c | 2 +-
sound/soc/codecs/cs35l56.c | 2 +-
sound/soc/codecs/cs42l42-sdw.c | 2 +-
sound/soc/codecs/cs42l42.c | 4 +-
sound/soc/codecs/cs42l43-jack.c | 10 +-
sound/soc/codecs/cs42l43.c | 4 +-
sound/soc/codecs/hda.c | 6 +-
sound/soc/codecs/madera.c | 6 +-
sound/soc/codecs/max98363.c | 2 +-
sound/soc/codecs/max98373-sdw.c | 2 +-
sound/soc/codecs/rt1017-sdca-sdw.c | 2 +-
sound/soc/codecs/rt1308-sdw.c | 2 +-
sound/soc/codecs/rt1316-sdw.c | 2 +-
sound/soc/codecs/rt1318-sdw.c | 2 +-
sound/soc/codecs/rt1320-sdw.c | 2 +-
sound/soc/codecs/rt5682-sdw.c | 2 +-
sound/soc/codecs/rt700.c | 4 +-
sound/soc/codecs/rt711-sdca.c | 4 +-
sound/soc/codecs/rt711.c | 4 +-
sound/soc/codecs/rt712-sdca-dmic.c | 2 +-
sound/soc/codecs/rt712-sdca.c | 4 +-
sound/soc/codecs/rt715-sdca.c | 2 +-
sound/soc/codecs/rt715.c | 2 +-
sound/soc/codecs/rt722-sdca.c | 4 +-
sound/soc/codecs/wcd-mbhc-v2.c | 4 +-
sound/soc/codecs/wsa881x.c | 2 +-
sound/soc/codecs/wsa884x.c | 2 +-
sound/soc/intel/atom/sst/sst_pvt.c | 2 +-
sound/soc/intel/avs/core.c | 2 +-
sound/soc/intel/avs/debugfs.c | 4 +-
sound/soc/intel/avs/pcm.c | 2 +-
sound/soc/intel/catpt/pcm.c | 12 +-
sound/soc/intel/catpt/sysfs.c | 2 +-
sound/soc/soc-component.c | 2 +-
sound/soc/sof/control.c | 2 +-
sound/soc/sof/debug.c | 2 +-
sound/soc/sof/ipc3-dtrace.c | 2 +-
sound/soc/sof/ipc4-loader.c | 2 +-
sound/soc/sof/pcm.c | 2 +-
sound/soc/sof/sof-client-ipc-flood-test.c | 2 +-
.../soc/sof/sof-client-ipc-kernel-injector.c | 2 +-
sound/soc/sof/sof-client-ipc-msg-injector.c | 2 +-
sound/soc/sof/sof-client-probes.c | 6 +-
sound/x86/intel_hdmi_audio.c | 6 +-
373 files changed, 1076 insertions(+), 1076 deletions(-)
--
2.39.5
^ permalink raw reply [flat|nested] 14+ messages in thread
* [PATCH 19/51] iio: Switch to __pm_runtime_put_autosuspend()
2024-10-04 9:41 [PATCH 00/51] treewide: Switch to __pm_runtime_put_autosuspend() Sakari Ailus
@ 2024-10-04 9:41 ` Sakari Ailus
2024-10-04 13:45 ` Jonathan Cameron
2024-10-04 14:38 ` [PATCH 00/51] treewide: " Ulf Hansson
1 sibling, 1 reply; 14+ messages in thread
From: Sakari Ailus @ 2024-10-04 9:41 UTC (permalink / raw)
To: Jonathan Cameron, Lars-Peter Clausen; +Cc: linux-iio
pm_runtime_put_autosuspend() will soon be changed to include a call to
pm_runtime_mark_last_busy(). This patch switches the current users to
__pm_runtime_put_autosuspend() which will continue to have the
functionality of old pm_runtime_put_autosuspend().
Signed-off-by: Sakari Ailus <sakari.ailus@linux.intel.com>
---
drivers/iio/accel/bmc150-accel-core.c | 2 +-
drivers/iio/accel/bmi088-accel-core.c | 6 +++---
drivers/iio/accel/fxls8962af-core.c | 2 +-
drivers/iio/accel/kxcjk-1013.c | 2 +-
drivers/iio/accel/kxsd9.c | 6 +++---
drivers/iio/accel/mma8452.c | 2 +-
drivers/iio/accel/mma9551_core.c | 2 +-
drivers/iio/accel/msa311.c | 12 +++++------
drivers/iio/adc/ab8500-gpadc.c | 2 +-
drivers/iio/adc/at91-sama5d2_adc.c | 20 +++++++++----------
drivers/iio/adc/rcar-gyroadc.c | 2 +-
drivers/iio/adc/stm32-adc-core.c | 2 +-
drivers/iio/adc/stm32-adc.c | 12 +++++------
drivers/iio/adc/sun4i-gpadc-iio.c | 4 ++--
drivers/iio/adc/ti-ads1015.c | 2 +-
drivers/iio/adc/ti-ads1100.c | 2 +-
drivers/iio/adc/ti-ads1119.c | 4 ++--
drivers/iio/chemical/atlas-sensor.c | 4 ++--
.../common/hid-sensors/hid-sensor-trigger.c | 2 +-
drivers/iio/dac/stm32-dac.c | 6 +++---
drivers/iio/gyro/bmg160_core.c | 2 +-
drivers/iio/gyro/fxas21002c_core.c | 2 +-
drivers/iio/gyro/mpu3050-core.c | 6 +++---
drivers/iio/gyro/mpu3050-i2c.c | 2 +-
.../iio/imu/inv_icm42600/inv_icm42600_accel.c | 10 +++++-----
.../imu/inv_icm42600/inv_icm42600_buffer.c | 2 +-
.../iio/imu/inv_icm42600/inv_icm42600_gyro.c | 10 +++++-----
.../iio/imu/inv_icm42600/inv_icm42600_temp.c | 2 +-
drivers/iio/imu/inv_mpu6050/inv_mpu_core.c | 14 ++++++-------
drivers/iio/imu/inv_mpu6050/inv_mpu_trigger.c | 4 ++--
drivers/iio/imu/kmx61.c | 2 +-
drivers/iio/light/apds9306.c | 6 +++---
drivers/iio/light/apds9960.c | 4 ++--
drivers/iio/light/bh1780.c | 2 +-
drivers/iio/light/gp2ap002.c | 4 ++--
drivers/iio/light/isl29028.c | 2 +-
drivers/iio/light/ltrf216a.c | 2 +-
drivers/iio/light/pa12203001.c | 2 +-
drivers/iio/light/rpr0521.c | 2 +-
drivers/iio/light/tsl2583.c | 2 +-
drivers/iio/light/tsl2591.c | 4 ++--
drivers/iio/light/us5182d.c | 2 +-
drivers/iio/light/vcnl4000.c | 2 +-
drivers/iio/light/vcnl4035.c | 2 +-
drivers/iio/magnetometer/af8133j.c | 4 ++--
drivers/iio/magnetometer/ak8974.c | 4 ++--
drivers/iio/magnetometer/ak8975.c | 2 +-
drivers/iio/magnetometer/bmc150_magn.c | 2 +-
drivers/iio/magnetometer/tmag5273.c | 4 ++--
drivers/iio/magnetometer/yamaha-yas530.c | 4 ++--
drivers/iio/pressure/bmp280-core.c | 10 +++++-----
drivers/iio/pressure/icp10100.c | 2 +-
drivers/iio/pressure/mpl115.c | 4 ++--
drivers/iio/pressure/zpa2326.c | 4 ++--
.../iio/proximity/pulsedlight-lidar-lite-v2.c | 2 +-
drivers/iio/proximity/srf04.c | 2 +-
drivers/iio/temperature/mlx90614.c | 4 ++--
drivers/iio/temperature/mlx90632.c | 4 ++--
drivers/iio/temperature/mlx90635.c | 4 ++--
59 files changed, 122 insertions(+), 122 deletions(-)
diff --git a/drivers/iio/accel/bmc150-accel-core.c b/drivers/iio/accel/bmc150-accel-core.c
index 0f32c1e92b4d..da02727c8626 100644
--- a/drivers/iio/accel/bmc150-accel-core.c
+++ b/drivers/iio/accel/bmc150-accel-core.c
@@ -339,7 +339,7 @@ static int bmc150_accel_set_power_state(struct bmc150_accel_data *data, bool on)
ret = pm_runtime_resume_and_get(dev);
} else {
pm_runtime_mark_last_busy(dev);
- ret = pm_runtime_put_autosuspend(dev);
+ ret = __pm_runtime_put_autosuspend(dev);
}
if (ret < 0) {
diff --git a/drivers/iio/accel/bmi088-accel-core.c b/drivers/iio/accel/bmi088-accel-core.c
index fc1c1613d673..f57960509c7f 100644
--- a/drivers/iio/accel/bmi088-accel-core.c
+++ b/drivers/iio/accel/bmi088-accel-core.c
@@ -375,7 +375,7 @@ static int bmi088_accel_read_raw(struct iio_dev *indio_dev,
out_read_raw_pm_put:
pm_runtime_mark_last_busy(dev);
- pm_runtime_put_autosuspend(dev);
+ __pm_runtime_put_autosuspend(dev);
return ret;
}
@@ -419,7 +419,7 @@ static int bmi088_accel_write_raw(struct iio_dev *indio_dev,
ret = bmi088_accel_set_scale(data, val, val2);
pm_runtime_mark_last_busy(dev);
- pm_runtime_put_autosuspend(dev);
+ __pm_runtime_put_autosuspend(dev);
return ret;
case IIO_CHAN_INFO_SAMP_FREQ:
ret = pm_runtime_resume_and_get(dev);
@@ -428,7 +428,7 @@ static int bmi088_accel_write_raw(struct iio_dev *indio_dev,
ret = bmi088_accel_set_sample_freq(data, val);
pm_runtime_mark_last_busy(dev);
- pm_runtime_put_autosuspend(dev);
+ __pm_runtime_put_autosuspend(dev);
return ret;
default:
return -EINVAL;
diff --git a/drivers/iio/accel/fxls8962af-core.c b/drivers/iio/accel/fxls8962af-core.c
index 37f33c29fb4b..50e1b2575af0 100644
--- a/drivers/iio/accel/fxls8962af-core.c
+++ b/drivers/iio/accel/fxls8962af-core.c
@@ -219,7 +219,7 @@ static int fxls8962af_power_off(struct fxls8962af_data *data)
int ret;
pm_runtime_mark_last_busy(dev);
- ret = pm_runtime_put_autosuspend(dev);
+ ret = __pm_runtime_put_autosuspend(dev);
if (ret)
dev_err(dev, "failed to power off\n");
diff --git a/drivers/iio/accel/kxcjk-1013.c b/drivers/iio/accel/kxcjk-1013.c
index b76df8816323..01c6bc9b0f99 100644
--- a/drivers/iio/accel/kxcjk-1013.c
+++ b/drivers/iio/accel/kxcjk-1013.c
@@ -625,7 +625,7 @@ static int kxcjk1013_set_power_state(struct kxcjk1013_data *data, bool on)
ret = pm_runtime_resume_and_get(&data->client->dev);
else {
pm_runtime_mark_last_busy(&data->client->dev);
- ret = pm_runtime_put_autosuspend(&data->client->dev);
+ ret = __pm_runtime_put_autosuspend(&data->client->dev);
}
if (ret < 0) {
dev_err(&data->client->dev,
diff --git a/drivers/iio/accel/kxsd9.c b/drivers/iio/accel/kxsd9.c
index 70dfd6e354db..41dcf80784f1 100644
--- a/drivers/iio/accel/kxsd9.c
+++ b/drivers/iio/accel/kxsd9.c
@@ -151,7 +151,7 @@ static int kxsd9_write_raw(struct iio_dev *indio_dev,
}
pm_runtime_mark_last_busy(st->dev);
- pm_runtime_put_autosuspend(st->dev);
+ __pm_runtime_put_autosuspend(st->dev);
return ret;
}
@@ -199,7 +199,7 @@ static int kxsd9_read_raw(struct iio_dev *indio_dev,
error_ret:
pm_runtime_mark_last_busy(st->dev);
- pm_runtime_put_autosuspend(st->dev);
+ __pm_runtime_put_autosuspend(st->dev);
return ret;
};
@@ -251,7 +251,7 @@ static int kxsd9_buffer_postdisable(struct iio_dev *indio_dev)
struct kxsd9_state *st = iio_priv(indio_dev);
pm_runtime_mark_last_busy(st->dev);
- pm_runtime_put_autosuspend(st->dev);
+ __pm_runtime_put_autosuspend(st->dev);
return 0;
}
diff --git a/drivers/iio/accel/mma8452.c b/drivers/iio/accel/mma8452.c
index 62e6369e2269..17786868855b 100644
--- a/drivers/iio/accel/mma8452.c
+++ b/drivers/iio/accel/mma8452.c
@@ -227,7 +227,7 @@ static int mma8452_set_runtime_pm_state(struct i2c_client *client, bool on)
ret = pm_runtime_resume_and_get(&client->dev);
} else {
pm_runtime_mark_last_busy(&client->dev);
- ret = pm_runtime_put_autosuspend(&client->dev);
+ ret = __pm_runtime_put_autosuspend(&client->dev);
}
if (ret < 0) {
diff --git a/drivers/iio/accel/mma9551_core.c b/drivers/iio/accel/mma9551_core.c
index b898f865fb87..d97cac6cc4da 100644
--- a/drivers/iio/accel/mma9551_core.c
+++ b/drivers/iio/accel/mma9551_core.c
@@ -673,7 +673,7 @@ int mma9551_set_power_state(struct i2c_client *client, bool on)
ret = pm_runtime_resume_and_get(&client->dev);
else {
pm_runtime_mark_last_busy(&client->dev);
- ret = pm_runtime_put_autosuspend(&client->dev);
+ ret = __pm_runtime_put_autosuspend(&client->dev);
}
if (ret < 0) {
diff --git a/drivers/iio/accel/msa311.c b/drivers/iio/accel/msa311.c
index 57025354c7cd..21ec55dc1c5a 100644
--- a/drivers/iio/accel/msa311.c
+++ b/drivers/iio/accel/msa311.c
@@ -608,7 +608,7 @@ static int msa311_read_raw_data(struct iio_dev *indio_dev,
iio_device_release_direct_mode(indio_dev);
pm_runtime_mark_last_busy(dev);
- pm_runtime_put_autosuspend(dev);
+ __pm_runtime_put_autosuspend(dev);
if (err) {
dev_err(dev, "can't get axis %s (%pe)\n",
@@ -740,7 +740,7 @@ static int msa311_write_scale(struct iio_dev *indio_dev, int val, int val2)
}
pm_runtime_mark_last_busy(dev);
- pm_runtime_put_autosuspend(dev);
+ __pm_runtime_put_autosuspend(dev);
if (err)
dev_err(dev, "can't update scale (%pe)\n", ERR_PTR(err));
@@ -781,7 +781,7 @@ static int msa311_write_samp_freq(struct iio_dev *indio_dev, int val, int val2)
iio_device_release_direct_mode(indio_dev);
pm_runtime_mark_last_busy(dev);
- pm_runtime_put_autosuspend(dev);
+ __pm_runtime_put_autosuspend(dev);
if (err)
dev_err(dev, "can't update frequency (%pe)\n", ERR_PTR(err));
@@ -830,7 +830,7 @@ static int msa311_debugfs_reg_access(struct iio_dev *indio_dev,
mutex_unlock(&msa311->lock);
pm_runtime_mark_last_busy(dev);
- pm_runtime_put_autosuspend(dev);
+ __pm_runtime_put_autosuspend(dev);
if (err)
dev_err(dev, "can't %s register %u from debugfs (%pe)\n",
@@ -853,7 +853,7 @@ static int msa311_buffer_postdisable(struct iio_dev *indio_dev)
struct device *dev = msa311->dev;
pm_runtime_mark_last_busy(dev);
- pm_runtime_put_autosuspend(dev);
+ __pm_runtime_put_autosuspend(dev);
return 0;
}
@@ -1231,7 +1231,7 @@ static int msa311_probe(struct i2c_client *i2c)
return err;
pm_runtime_mark_last_busy(dev);
- pm_runtime_put_autosuspend(dev);
+ __pm_runtime_put_autosuspend(dev);
err = devm_iio_device_register(dev, indio_dev);
if (err)
diff --git a/drivers/iio/adc/ab8500-gpadc.c b/drivers/iio/adc/ab8500-gpadc.c
index 59f66e9cb0e8..f2d1b06bac44 100644
--- a/drivers/iio/adc/ab8500-gpadc.c
+++ b/drivers/iio/adc/ab8500-gpadc.c
@@ -608,7 +608,7 @@ static int ab8500_gpadc_read(struct ab8500_gpadc *gpadc,
/* This eventually drops the regulator */
pm_runtime_mark_last_busy(gpadc->dev);
- pm_runtime_put_autosuspend(gpadc->dev);
+ __pm_runtime_put_autosuspend(gpadc->dev);
return (high_data << 8) | low_data;
diff --git a/drivers/iio/adc/at91-sama5d2_adc.c b/drivers/iio/adc/at91-sama5d2_adc.c
index d7fd21e7c6e2..628e6e3c667c 100644
--- a/drivers/iio/adc/at91-sama5d2_adc.c
+++ b/drivers/iio/adc/at91-sama5d2_adc.c
@@ -893,7 +893,7 @@ static int at91_adc_config_emr(struct at91_adc_state *st,
at91_adc_writel(st, EMR, emr);
pm_runtime_mark_last_busy(st->dev);
- pm_runtime_put_autosuspend(st->dev);
+ __pm_runtime_put_autosuspend(st->dev);
st->oversampling_ratio = oversampling_ratio;
@@ -968,7 +968,7 @@ static int at91_adc_configure_touch(struct at91_adc_state *st, bool state)
at91_adc_writel(st, TSMR, 0);
pm_runtime_mark_last_busy(st->dev);
- pm_runtime_put_autosuspend(st->dev);
+ __pm_runtime_put_autosuspend(st->dev);
return 0;
}
/*
@@ -1140,7 +1140,7 @@ static int at91_adc_configure_trigger(struct iio_trigger *trig, bool state)
if (!state) {
pm_runtime_mark_last_busy(st->dev);
- pm_runtime_put_autosuspend(st->dev);
+ __pm_runtime_put_autosuspend(st->dev);
}
return 0;
@@ -1333,7 +1333,7 @@ static int at91_adc_buffer_prepare(struct iio_dev *indio_dev)
pm_runtime_put:
pm_runtime_mark_last_busy(st->dev);
- pm_runtime_put_autosuspend(st->dev);
+ __pm_runtime_put_autosuspend(st->dev);
return ret;
}
@@ -1391,7 +1391,7 @@ static int at91_adc_buffer_postdisable(struct iio_dev *indio_dev)
dmaengine_terminate_sync(st->dma_st.dma_chan);
pm_runtime_mark_last_busy(st->dev);
- pm_runtime_put_autosuspend(st->dev);
+ __pm_runtime_put_autosuspend(st->dev);
return 0;
}
@@ -1600,7 +1600,7 @@ static void at91_adc_setup_samp_freq(struct iio_dev *indio_dev, unsigned freq,
at91_adc_writel(st, MR, mr);
pm_runtime_mark_last_busy(st->dev);
- pm_runtime_put_autosuspend(st->dev);
+ __pm_runtime_put_autosuspend(st->dev);
dev_dbg(&indio_dev->dev, "freq: %u, startup: %u, prescal: %u, tracktim=%u\n",
freq, startup, prescal, tracktim);
@@ -1806,7 +1806,7 @@ static int at91_adc_read_info_raw(struct iio_dev *indio_dev,
pm_runtime_put:
pm_runtime_mark_last_busy(st->dev);
- pm_runtime_put_autosuspend(st->dev);
+ __pm_runtime_put_autosuspend(st->dev);
return ret;
}
@@ -1899,7 +1899,7 @@ static int at91_adc_read_temp(struct iio_dev *indio_dev,
/* Revert previous settings. */
at91_adc_temp_sensor_configure(st, false);
pm_runtime_mark_last_busy(st->dev);
- pm_runtime_put_autosuspend(st->dev);
+ __pm_runtime_put_autosuspend(st->dev);
unlock:
mutex_unlock(&st->lock);
iio_device_release_direct_mode(indio_dev);
@@ -2467,7 +2467,7 @@ static int at91_adc_probe(struct platform_device *pdev)
readl_relaxed(st->base + st->soc_info.platform->layout->VERSION));
pm_runtime_mark_last_busy(st->dev);
- pm_runtime_put_autosuspend(st->dev);
+ __pm_runtime_put_autosuspend(st->dev);
return 0;
@@ -2569,7 +2569,7 @@ static int at91_adc_resume(struct device *dev)
}
pm_runtime_mark_last_busy(st->dev);
- pm_runtime_put_autosuspend(st->dev);
+ __pm_runtime_put_autosuspend(st->dev);
return 0;
diff --git a/drivers/iio/adc/rcar-gyroadc.c b/drivers/iio/adc/rcar-gyroadc.c
index 15a21d2860e7..d2a4557a5c07 100644
--- a/drivers/iio/adc/rcar-gyroadc.c
+++ b/drivers/iio/adc/rcar-gyroadc.c
@@ -167,7 +167,7 @@ static int rcar_gyroadc_set_power(struct rcar_gyroadc *priv, bool on)
return pm_runtime_resume_and_get(dev);
} else {
pm_runtime_mark_last_busy(dev);
- return pm_runtime_put_autosuspend(dev);
+ return __pm_runtime_put_autosuspend(dev);
}
}
diff --git a/drivers/iio/adc/stm32-adc-core.c b/drivers/iio/adc/stm32-adc-core.c
index 616dd729666a..a67e972bcc5d 100644
--- a/drivers/iio/adc/stm32-adc-core.c
+++ b/drivers/iio/adc/stm32-adc-core.c
@@ -798,7 +798,7 @@ static int stm32_adc_probe(struct platform_device *pdev)
}
pm_runtime_mark_last_busy(dev);
- pm_runtime_put_autosuspend(dev);
+ __pm_runtime_put_autosuspend(dev);
return 0;
diff --git a/drivers/iio/adc/stm32-adc.c b/drivers/iio/adc/stm32-adc.c
index 32ca26ed59f7..50c3651413d2 100644
--- a/drivers/iio/adc/stm32-adc.c
+++ b/drivers/iio/adc/stm32-adc.c
@@ -1456,7 +1456,7 @@ static int stm32_adc_single_conv(struct iio_dev *indio_dev,
stm32_adc_conv_irq_disable(adc);
pm_runtime_mark_last_busy(dev);
- pm_runtime_put_autosuspend(dev);
+ __pm_runtime_put_autosuspend(dev);
return ret;
}
@@ -1623,7 +1623,7 @@ static int stm32_adc_update_scan_mode(struct iio_dev *indio_dev,
ret = stm32_adc_conf_scan_seq(indio_dev, scan_mask);
pm_runtime_mark_last_busy(dev);
- pm_runtime_put_autosuspend(dev);
+ __pm_runtime_put_autosuspend(dev);
return ret;
}
@@ -1672,7 +1672,7 @@ static int stm32_adc_debugfs_reg_access(struct iio_dev *indio_dev,
*readval = stm32_adc_readl(adc, reg);
pm_runtime_mark_last_busy(dev);
- pm_runtime_put_autosuspend(dev);
+ __pm_runtime_put_autosuspend(dev);
return 0;
}
@@ -1816,7 +1816,7 @@ static int stm32_adc_buffer_postenable(struct iio_dev *indio_dev)
stm32_adc_set_trig(indio_dev, NULL);
err_pm_put:
pm_runtime_mark_last_busy(dev);
- pm_runtime_put_autosuspend(dev);
+ __pm_runtime_put_autosuspend(dev);
return ret;
}
@@ -1839,7 +1839,7 @@ static int stm32_adc_buffer_predisable(struct iio_dev *indio_dev)
dev_err(&indio_dev->dev, "Can't clear trigger\n");
pm_runtime_mark_last_busy(dev);
- pm_runtime_put_autosuspend(dev);
+ __pm_runtime_put_autosuspend(dev);
return 0;
}
@@ -2473,7 +2473,7 @@ static int stm32_adc_probe(struct platform_device *pdev)
}
pm_runtime_mark_last_busy(dev);
- pm_runtime_put_autosuspend(dev);
+ __pm_runtime_put_autosuspend(dev);
if (IS_ENABLED(CONFIG_DEBUG_FS))
stm32_adc_debugfs_init(indio_dev);
diff --git a/drivers/iio/adc/sun4i-gpadc-iio.c b/drivers/iio/adc/sun4i-gpadc-iio.c
index 00a3a4db0fe0..43746e026042 100644
--- a/drivers/iio/adc/sun4i-gpadc-iio.c
+++ b/drivers/iio/adc/sun4i-gpadc-iio.c
@@ -248,7 +248,7 @@ static int sun4i_gpadc_read(struct iio_dev *indio_dev, int channel, int *val,
pm_runtime_mark_last_busy(indio_dev->dev.parent);
err:
- pm_runtime_put_autosuspend(indio_dev->dev.parent);
+ __pm_runtime_put_autosuspend(indio_dev->dev.parent);
disable_irq(irq);
mutex_unlock(&info->mutex);
@@ -273,7 +273,7 @@ static int sun4i_gpadc_temp_read(struct iio_dev *indio_dev, int *val)
regmap_read(info->regmap, SUN4I_GPADC_TEMP_DATA, val);
pm_runtime_mark_last_busy(indio_dev->dev.parent);
- pm_runtime_put_autosuspend(indio_dev->dev.parent);
+ __pm_runtime_put_autosuspend(indio_dev->dev.parent);
return 0;
}
diff --git a/drivers/iio/adc/ti-ads1015.c b/drivers/iio/adc/ti-ads1015.c
index 052d2124b215..380aeabc8a72 100644
--- a/drivers/iio/adc/ti-ads1015.c
+++ b/drivers/iio/adc/ti-ads1015.c
@@ -377,7 +377,7 @@ static int ads1015_set_power_state(struct ads1015_data *data, bool on)
ret = pm_runtime_resume_and_get(dev);
} else {
pm_runtime_mark_last_busy(dev);
- ret = pm_runtime_put_autosuspend(dev);
+ ret = __pm_runtime_put_autosuspend(dev);
}
return ret < 0 ? ret : 0;
diff --git a/drivers/iio/adc/ti-ads1100.c b/drivers/iio/adc/ti-ads1100.c
index 1e46f07a9ca6..038901c93b7d 100644
--- a/drivers/iio/adc/ti-ads1100.c
+++ b/drivers/iio/adc/ti-ads1100.c
@@ -105,7 +105,7 @@ static int ads1100_get_adc_result(struct ads1100_data *data, int chan, int *val)
ret = i2c_master_recv(data->client, (char *)&buffer, sizeof(buffer));
pm_runtime_mark_last_busy(&data->client->dev);
- pm_runtime_put_autosuspend(&data->client->dev);
+ __pm_runtime_put_autosuspend(&data->client->dev);
if (ret < 0) {
dev_err(&data->client->dev, "I2C read fail: %d\n", ret);
diff --git a/drivers/iio/adc/ti-ads1119.c b/drivers/iio/adc/ti-ads1119.c
index 1c7606375149..52e20c4ed8bb 100644
--- a/drivers/iio/adc/ti-ads1119.c
+++ b/drivers/iio/adc/ti-ads1119.c
@@ -292,7 +292,7 @@ static int ads1119_single_conversion(struct ads1119_state *st,
ret = IIO_VAL_INT;
pdown:
pm_runtime_mark_last_busy(dev);
- pm_runtime_put_autosuspend(dev);
+ __pm_runtime_put_autosuspend(dev);
return ret;
}
@@ -466,7 +466,7 @@ static int ads1119_triggered_buffer_postdisable(struct iio_dev *indio_dev)
return ret;
pm_runtime_mark_last_busy(dev);
- pm_runtime_put_autosuspend(dev);
+ __pm_runtime_put_autosuspend(dev);
return 0;
}
diff --git a/drivers/iio/chemical/atlas-sensor.c b/drivers/iio/chemical/atlas-sensor.c
index baf93e5e3ca7..d0ab2656919e 100644
--- a/drivers/iio/chemical/atlas-sensor.c
+++ b/drivers/iio/chemical/atlas-sensor.c
@@ -427,7 +427,7 @@ static int atlas_buffer_predisable(struct iio_dev *indio_dev)
return ret;
pm_runtime_mark_last_busy(&data->client->dev);
- ret = pm_runtime_put_autosuspend(&data->client->dev);
+ ret = __pm_runtime_put_autosuspend(&data->client->dev);
if (ret)
return ret;
@@ -492,7 +492,7 @@ static int atlas_read_measurement(struct atlas_data *data, int reg, __be32 *val)
ret = regmap_bulk_read(data->regmap, reg, val, sizeof(*val));
pm_runtime_mark_last_busy(dev);
- pm_runtime_put_autosuspend(dev);
+ __pm_runtime_put_autosuspend(dev);
return ret;
}
diff --git a/drivers/iio/common/hid-sensors/hid-sensor-trigger.c b/drivers/iio/common/hid-sensors/hid-sensor-trigger.c
index ad8910e6ad59..e6bf7eb4e23c 100644
--- a/drivers/iio/common/hid-sensors/hid-sensor-trigger.c
+++ b/drivers/iio/common/hid-sensors/hid-sensor-trigger.c
@@ -165,7 +165,7 @@ int hid_sensor_power_state(struct hid_sensor_common *st, bool state)
atomic_dec(&st->user_requested_state);
pm_runtime_mark_last_busy(&st->pdev->dev);
pm_runtime_use_autosuspend(&st->pdev->dev);
- ret = pm_runtime_put_autosuspend(&st->pdev->dev);
+ ret = __pm_runtime_put_autosuspend(&st->pdev->dev);
}
if (ret < 0)
return ret;
diff --git a/drivers/iio/dac/stm32-dac.c b/drivers/iio/dac/stm32-dac.c
index 5a722f307e7e..8dadf90546b4 100644
--- a/drivers/iio/dac/stm32-dac.c
+++ b/drivers/iio/dac/stm32-dac.c
@@ -97,7 +97,7 @@ static int stm32_dac_set_enable_state(struct iio_dev *indio_dev, int ch,
if (!enable) {
pm_runtime_mark_last_busy(dev);
- pm_runtime_put_autosuspend(dev);
+ __pm_runtime_put_autosuspend(dev);
}
return 0;
@@ -105,7 +105,7 @@ static int stm32_dac_set_enable_state(struct iio_dev *indio_dev, int ch,
err_put_pm:
if (enable) {
pm_runtime_mark_last_busy(dev);
- pm_runtime_put_autosuspend(dev);
+ __pm_runtime_put_autosuspend(dev);
}
return ret;
@@ -350,7 +350,7 @@ static int stm32_dac_probe(struct platform_device *pdev)
goto err_pm_put;
pm_runtime_mark_last_busy(dev);
- pm_runtime_put_autosuspend(dev);
+ __pm_runtime_put_autosuspend(dev);
return 0;
diff --git a/drivers/iio/gyro/bmg160_core.c b/drivers/iio/gyro/bmg160_core.c
index 10728d5ccae3..97f3045dc2a9 100644
--- a/drivers/iio/gyro/bmg160_core.c
+++ b/drivers/iio/gyro/bmg160_core.c
@@ -314,7 +314,7 @@ static int bmg160_set_power_state(struct bmg160_data *data, bool on)
ret = pm_runtime_get_sync(dev);
else {
pm_runtime_mark_last_busy(dev);
- ret = pm_runtime_put_autosuspend(dev);
+ ret = __pm_runtime_put_autosuspend(dev);
}
if (ret < 0) {
diff --git a/drivers/iio/gyro/fxas21002c_core.c b/drivers/iio/gyro/fxas21002c_core.c
index 688966129f70..f6263187f6c7 100644
--- a/drivers/iio/gyro/fxas21002c_core.c
+++ b/drivers/iio/gyro/fxas21002c_core.c
@@ -375,7 +375,7 @@ static int fxas21002c_pm_put(struct fxas21002c_data *data)
pm_runtime_mark_last_busy(dev);
- return pm_runtime_put_autosuspend(dev);
+ return __pm_runtime_put_autosuspend(dev);
}
static int fxas21002c_temp_get(struct fxas21002c_data *data, int *val)
diff --git a/drivers/iio/gyro/mpu3050-core.c b/drivers/iio/gyro/mpu3050-core.c
index b6883e8b2a8b..93d9d0e4626b 100644
--- a/drivers/iio/gyro/mpu3050-core.c
+++ b/drivers/iio/gyro/mpu3050-core.c
@@ -371,7 +371,7 @@ static int mpu3050_read_raw(struct iio_dev *indio_dev,
out_read_raw_unlock:
mutex_unlock(&mpu3050->lock);
pm_runtime_mark_last_busy(mpu3050->dev);
- pm_runtime_put_autosuspend(mpu3050->dev);
+ __pm_runtime_put_autosuspend(mpu3050->dev);
return ret;
}
@@ -663,7 +663,7 @@ static int mpu3050_buffer_postdisable(struct iio_dev *indio_dev)
struct mpu3050 *mpu3050 = iio_priv(indio_dev);
pm_runtime_mark_last_busy(mpu3050->dev);
- pm_runtime_put_autosuspend(mpu3050->dev);
+ __pm_runtime_put_autosuspend(mpu3050->dev);
return 0;
}
@@ -977,7 +977,7 @@ static int mpu3050_drdy_trigger_set_state(struct iio_trigger *trig,
dev_err(mpu3050->dev, "error resetting FIFO\n");
pm_runtime_mark_last_busy(mpu3050->dev);
- pm_runtime_put_autosuspend(mpu3050->dev);
+ __pm_runtime_put_autosuspend(mpu3050->dev);
mpu3050->hw_irq_trigger = false;
return 0;
diff --git a/drivers/iio/gyro/mpu3050-i2c.c b/drivers/iio/gyro/mpu3050-i2c.c
index 29ecfa6fd633..49256fc6c6ad 100644
--- a/drivers/iio/gyro/mpu3050-i2c.c
+++ b/drivers/iio/gyro/mpu3050-i2c.c
@@ -28,7 +28,7 @@ static int mpu3050_i2c_bypass_deselect(struct i2c_mux_core *mux, u32 chan_id)
struct mpu3050 *mpu3050 = i2c_mux_priv(mux);
pm_runtime_mark_last_busy(mpu3050->dev);
- pm_runtime_put_autosuspend(mpu3050->dev);
+ __pm_runtime_put_autosuspend(mpu3050->dev);
return 0;
}
diff --git a/drivers/iio/imu/inv_icm42600/inv_icm42600_accel.c b/drivers/iio/imu/inv_icm42600/inv_icm42600_accel.c
index 56ac19814250..4e43deadf02f 100644
--- a/drivers/iio/imu/inv_icm42600/inv_icm42600_accel.c
+++ b/drivers/iio/imu/inv_icm42600/inv_icm42600_accel.c
@@ -292,7 +292,7 @@ static int inv_icm42600_accel_read_sensor(struct iio_dev *indio_dev,
exit:
mutex_unlock(&st->lock);
pm_runtime_mark_last_busy(dev);
- pm_runtime_put_autosuspend(dev);
+ __pm_runtime_put_autosuspend(dev);
return ret;
}
@@ -370,7 +370,7 @@ static int inv_icm42600_accel_write_scale(struct iio_dev *indio_dev,
mutex_unlock(&st->lock);
pm_runtime_mark_last_busy(dev);
- pm_runtime_put_autosuspend(dev);
+ __pm_runtime_put_autosuspend(dev);
return ret;
}
@@ -474,7 +474,7 @@ static int inv_icm42600_accel_write_odr(struct iio_dev *indio_dev,
out_unlock:
mutex_unlock(&st->lock);
pm_runtime_mark_last_busy(dev);
- pm_runtime_put_autosuspend(dev);
+ __pm_runtime_put_autosuspend(dev);
return ret;
}
@@ -526,7 +526,7 @@ static int inv_icm42600_accel_read_offset(struct inv_icm42600_state *st,
mutex_unlock(&st->lock);
pm_runtime_mark_last_busy(dev);
- pm_runtime_put_autosuspend(dev);
+ __pm_runtime_put_autosuspend(dev);
if (ret)
return ret;
@@ -664,7 +664,7 @@ static int inv_icm42600_accel_write_offset(struct inv_icm42600_state *st,
out_unlock:
mutex_unlock(&st->lock);
pm_runtime_mark_last_busy(dev);
- pm_runtime_put_autosuspend(dev);
+ __pm_runtime_put_autosuspend(dev);
return ret;
}
diff --git a/drivers/iio/imu/inv_icm42600/inv_icm42600_buffer.c b/drivers/iio/imu/inv_icm42600/inv_icm42600_buffer.c
index aae7c56481a3..acc141657d3f 100644
--- a/drivers/iio/imu/inv_icm42600/inv_icm42600_buffer.c
+++ b/drivers/iio/imu/inv_icm42600/inv_icm42600_buffer.c
@@ -440,7 +440,7 @@ static int inv_icm42600_buffer_postdisable(struct iio_dev *indio_dev)
msleep(sleep);
pm_runtime_mark_last_busy(dev);
- pm_runtime_put_autosuspend(dev);
+ __pm_runtime_put_autosuspend(dev);
return ret;
}
diff --git a/drivers/iio/imu/inv_icm42600/inv_icm42600_gyro.c b/drivers/iio/imu/inv_icm42600/inv_icm42600_gyro.c
index 938af5b640b0..3784b1719433 100644
--- a/drivers/iio/imu/inv_icm42600/inv_icm42600_gyro.c
+++ b/drivers/iio/imu/inv_icm42600/inv_icm42600_gyro.c
@@ -188,7 +188,7 @@ static int inv_icm42600_gyro_read_sensor(struct inv_icm42600_state *st,
exit:
mutex_unlock(&st->lock);
pm_runtime_mark_last_busy(dev);
- pm_runtime_put_autosuspend(dev);
+ __pm_runtime_put_autosuspend(dev);
return ret;
}
@@ -287,7 +287,7 @@ static int inv_icm42600_gyro_write_scale(struct iio_dev *indio_dev,
mutex_unlock(&st->lock);
pm_runtime_mark_last_busy(dev);
- pm_runtime_put_autosuspend(dev);
+ __pm_runtime_put_autosuspend(dev);
return ret;
}
@@ -382,7 +382,7 @@ static int inv_icm42600_gyro_write_odr(struct iio_dev *indio_dev,
out_unlock:
mutex_unlock(&st->lock);
pm_runtime_mark_last_busy(dev);
- pm_runtime_put_autosuspend(dev);
+ __pm_runtime_put_autosuspend(dev);
return ret;
}
@@ -434,7 +434,7 @@ static int inv_icm42600_gyro_read_offset(struct inv_icm42600_state *st,
mutex_unlock(&st->lock);
pm_runtime_mark_last_busy(dev);
- pm_runtime_put_autosuspend(dev);
+ __pm_runtime_put_autosuspend(dev);
if (ret)
return ret;
@@ -571,7 +571,7 @@ static int inv_icm42600_gyro_write_offset(struct inv_icm42600_state *st,
out_unlock:
mutex_unlock(&st->lock);
pm_runtime_mark_last_busy(dev);
- pm_runtime_put_autosuspend(dev);
+ __pm_runtime_put_autosuspend(dev);
return ret;
}
diff --git a/drivers/iio/imu/inv_icm42600/inv_icm42600_temp.c b/drivers/iio/imu/inv_icm42600/inv_icm42600_temp.c
index 213cce1c3111..4c2f2d6dfff9 100644
--- a/drivers/iio/imu/inv_icm42600/inv_icm42600_temp.c
+++ b/drivers/iio/imu/inv_icm42600/inv_icm42600_temp.c
@@ -38,7 +38,7 @@ static int inv_icm42600_temp_read(struct inv_icm42600_state *st, int16_t *temp)
exit:
mutex_unlock(&st->lock);
pm_runtime_mark_last_busy(dev);
- pm_runtime_put_autosuspend(dev);
+ __pm_runtime_put_autosuspend(dev);
return ret;
}
diff --git a/drivers/iio/imu/inv_mpu6050/inv_mpu_core.c b/drivers/iio/imu/inv_mpu6050/inv_mpu_core.c
index fdb48c5e5686..8fb35f37e5d2 100644
--- a/drivers/iio/imu/inv_mpu6050/inv_mpu_core.c
+++ b/drivers/iio/imu/inv_mpu6050/inv_mpu_core.c
@@ -708,12 +708,12 @@ static int inv_mpu6050_read_channel_data(struct iio_dev *indio_dev,
}
pm_runtime_mark_last_busy(pdev);
- pm_runtime_put_autosuspend(pdev);
+ __pm_runtime_put_autosuspend(pdev);
return ret;
error_power_off:
- pm_runtime_put_autosuspend(pdev);
+ __pm_runtime_put_autosuspend(pdev);
return result;
}
@@ -913,7 +913,7 @@ static int inv_mpu6050_write_raw(struct iio_dev *indio_dev,
}
pm_runtime_mark_last_busy(pdev);
- pm_runtime_put_autosuspend(pdev);
+ __pm_runtime_put_autosuspend(pdev);
error_write_raw_unlock:
mutex_unlock(&st->lock);
iio_device_release_direct_mode(indio_dev);
@@ -1121,14 +1121,14 @@ static int inv_mpu6050_enable_wom(struct inv_mpu6050_state *st, bool en)
}
pm_runtime_mark_last_busy(pdev);
- pm_runtime_put_autosuspend(pdev);
+ __pm_runtime_put_autosuspend(pdev);
}
return result;
error_suspend:
pm_runtime_mark_last_busy(pdev);
- pm_runtime_put_autosuspend(pdev);
+ __pm_runtime_put_autosuspend(pdev);
return result;
}
@@ -1227,7 +1227,7 @@ static int inv_mpu6050_write_event_value(struct iio_dev *indio_dev,
result = inv_mpu6050_set_wom_threshold(st, value, INV_MPU6050_FREQ_DIVIDER(st));
pm_runtime_mark_last_busy(pdev);
- pm_runtime_put_autosuspend(pdev);
+ __pm_runtime_put_autosuspend(pdev);
return result;
}
@@ -1336,7 +1336,7 @@ inv_mpu6050_fifo_rate_store(struct device *dev, struct device_attribute *attr,
pm_runtime_mark_last_busy(pdev);
fifo_rate_fail_power_off:
- pm_runtime_put_autosuspend(pdev);
+ __pm_runtime_put_autosuspend(pdev);
fifo_rate_fail_unlock:
mutex_unlock(&st->lock);
if (result)
diff --git a/drivers/iio/imu/inv_mpu6050/inv_mpu_trigger.c b/drivers/iio/imu/inv_mpu6050/inv_mpu_trigger.c
index 3bfeabab0ec4..e501ac9276d4 100644
--- a/drivers/iio/imu/inv_mpu6050/inv_mpu_trigger.c
+++ b/drivers/iio/imu/inv_mpu6050/inv_mpu_trigger.c
@@ -196,13 +196,13 @@ static int inv_mpu6050_set_enable(struct iio_dev *indio_dev, bool enable)
if (result)
goto error_power_off;
pm_runtime_mark_last_busy(pdev);
- pm_runtime_put_autosuspend(pdev);
+ __pm_runtime_put_autosuspend(pdev);
}
return 0;
error_power_off:
- pm_runtime_put_autosuspend(pdev);
+ __pm_runtime_put_autosuspend(pdev);
return result;
}
diff --git a/drivers/iio/imu/kmx61.c b/drivers/iio/imu/kmx61.c
index c61c012e25bb..75942b0b95d7 100644
--- a/drivers/iio/imu/kmx61.c
+++ b/drivers/iio/imu/kmx61.c
@@ -753,7 +753,7 @@ static int kmx61_set_power_state(struct kmx61_data *data, bool on, u8 device)
ret = pm_runtime_resume_and_get(&data->client->dev);
} else {
pm_runtime_mark_last_busy(&data->client->dev);
- ret = pm_runtime_put_autosuspend(&data->client->dev);
+ ret = __pm_runtime_put_autosuspend(&data->client->dev);
}
if (ret < 0) {
dev_err(&data->client->dev,
diff --git a/drivers/iio/light/apds9306.c b/drivers/iio/light/apds9306.c
index 079e02be1005..ade25e461397 100644
--- a/drivers/iio/light/apds9306.c
+++ b/drivers/iio/light/apds9306.c
@@ -538,7 +538,7 @@ static int apds9306_read_data(struct apds9306_data *data, int *val, int reg)
*val = get_unaligned_le24(&buff);
pm_runtime_mark_last_busy(data->dev);
- pm_runtime_put_autosuspend(data->dev);
+ __pm_runtime_put_autosuspend(data->dev);
return 0;
}
@@ -1119,7 +1119,7 @@ static int apds9306_write_event_config(struct iio_dev *indio_dev,
return ret;
pm_runtime_mark_last_busy(data->dev);
- pm_runtime_put_autosuspend(data->dev);
+ __pm_runtime_put_autosuspend(data->dev);
return 0;
}
@@ -1315,7 +1315,7 @@ static int apds9306_probe(struct i2c_client *client)
if (ret)
return dev_err_probe(dev, ret, "failed iio device registration\n");
- pm_runtime_put_autosuspend(dev);
+ __pm_runtime_put_autosuspend(dev);
return 0;
}
diff --git a/drivers/iio/light/apds9960.c b/drivers/iio/light/apds9960.c
index 3c14e4c30805..13db160be094 100644
--- a/drivers/iio/light/apds9960.c
+++ b/drivers/iio/light/apds9960.c
@@ -497,7 +497,7 @@ static int apds9960_set_power_state(struct apds9960_data *data, bool on)
APDS9960_MAX_INT_TIME_IN_US);
} else {
pm_runtime_mark_last_busy(dev);
- ret = pm_runtime_put_autosuspend(dev);
+ ret = __pm_runtime_put_autosuspend(dev);
}
mutex_unlock(&data->lock);
@@ -910,7 +910,7 @@ static int apds9960_buffer_predisable(struct iio_dev *indio_dev)
if (ret)
return ret;
- pm_runtime_put_autosuspend(&data->client->dev);
+ __pm_runtime_put_autosuspend(&data->client->dev);
return 0;
}
diff --git a/drivers/iio/light/bh1780.c b/drivers/iio/light/bh1780.c
index 475f44954f61..d22bf5f684b1 100644
--- a/drivers/iio/light/bh1780.c
+++ b/drivers/iio/light/bh1780.c
@@ -112,7 +112,7 @@ static int bh1780_read_raw(struct iio_dev *indio_dev,
if (value < 0)
return value;
pm_runtime_mark_last_busy(&bh1780->client->dev);
- pm_runtime_put_autosuspend(&bh1780->client->dev);
+ __pm_runtime_put_autosuspend(&bh1780->client->dev);
*val = value;
return IIO_VAL_INT;
diff --git a/drivers/iio/light/gp2ap002.c b/drivers/iio/light/gp2ap002.c
index f8b1d7dd6f5f..aeaba841dbb4 100644
--- a/drivers/iio/light/gp2ap002.c
+++ b/drivers/iio/light/gp2ap002.c
@@ -272,7 +272,7 @@ static int gp2ap002_read_raw(struct iio_dev *indio_dev,
out:
pm_runtime_mark_last_busy(gp2ap002->dev);
- pm_runtime_put_autosuspend(gp2ap002->dev);
+ __pm_runtime_put_autosuspend(gp2ap002->dev);
return ret;
}
@@ -354,7 +354,7 @@ static int gp2ap002_write_event_config(struct iio_dev *indio_dev,
gp2ap002->enabled = true;
} else {
pm_runtime_mark_last_busy(gp2ap002->dev);
- pm_runtime_put_autosuspend(gp2ap002->dev);
+ __pm_runtime_put_autosuspend(gp2ap002->dev);
gp2ap002->enabled = false;
}
diff --git a/drivers/iio/light/isl29028.c b/drivers/iio/light/isl29028.c
index 95bfb3ffa519..63b6fdda25ed 100644
--- a/drivers/iio/light/isl29028.c
+++ b/drivers/iio/light/isl29028.c
@@ -342,7 +342,7 @@ static int isl29028_set_pm_runtime_busy(struct isl29028_chip *chip, bool on)
ret = pm_runtime_resume_and_get(dev);
} else {
pm_runtime_mark_last_busy(dev);
- ret = pm_runtime_put_autosuspend(dev);
+ ret = __pm_runtime_put_autosuspend(dev);
}
return ret;
diff --git a/drivers/iio/light/ltrf216a.c b/drivers/iio/light/ltrf216a.c
index 37eecff571b9..228f03c7f192 100644
--- a/drivers/iio/light/ltrf216a.c
+++ b/drivers/iio/light/ltrf216a.c
@@ -209,7 +209,7 @@ static int ltrf216a_set_power_state(struct ltrf216a_data *data, bool on)
}
} else {
pm_runtime_mark_last_busy(dev);
- pm_runtime_put_autosuspend(dev);
+ __pm_runtime_put_autosuspend(dev);
}
return ret;
diff --git a/drivers/iio/light/pa12203001.c b/drivers/iio/light/pa12203001.c
index b920bf82c102..38313e712e65 100644
--- a/drivers/iio/light/pa12203001.c
+++ b/drivers/iio/light/pa12203001.c
@@ -190,7 +190,7 @@ static int pa12203001_set_power_state(struct pa12203001_data *data, bool on,
} else {
pm_runtime_mark_last_busy(&data->client->dev);
- ret = pm_runtime_put_autosuspend(&data->client->dev);
+ ret = __pm_runtime_put_autosuspend(&data->client->dev);
}
return ret;
diff --git a/drivers/iio/light/rpr0521.c b/drivers/iio/light/rpr0521.c
index 78c08e0bd077..2010b6387be7 100644
--- a/drivers/iio/light/rpr0521.c
+++ b/drivers/iio/light/rpr0521.c
@@ -363,7 +363,7 @@ static int rpr0521_set_power_state(struct rpr0521_data *data, bool on,
ret = pm_runtime_resume_and_get(&data->client->dev);
} else {
pm_runtime_mark_last_busy(&data->client->dev);
- ret = pm_runtime_put_autosuspend(&data->client->dev);
+ ret = __pm_runtime_put_autosuspend(&data->client->dev);
}
if (ret < 0) {
dev_err(&data->client->dev,
diff --git a/drivers/iio/light/tsl2583.c b/drivers/iio/light/tsl2583.c
index 02ad11611b9c..d41fd79e724c 100644
--- a/drivers/iio/light/tsl2583.c
+++ b/drivers/iio/light/tsl2583.c
@@ -647,7 +647,7 @@ static int tsl2583_set_pm_runtime_busy(struct tsl2583_chip *chip, bool on)
ret = pm_runtime_resume_and_get(&chip->client->dev);
} else {
pm_runtime_mark_last_busy(&chip->client->dev);
- ret = pm_runtime_put_autosuspend(&chip->client->dev);
+ ret = __pm_runtime_put_autosuspend(&chip->client->dev);
}
return ret;
diff --git a/drivers/iio/light/tsl2591.c b/drivers/iio/light/tsl2591.c
index 850c2465992f..43adaffe1400 100644
--- a/drivers/iio/light/tsl2591.c
+++ b/drivers/iio/light/tsl2591.c
@@ -773,7 +773,7 @@ static int tsl2591_read_raw(struct iio_dev *indio_dev,
mutex_unlock(&chip->als_mutex);
pm_runtime_mark_last_busy(&client->dev);
- pm_runtime_put_autosuspend(&client->dev);
+ __pm_runtime_put_autosuspend(&client->dev);
return ret;
}
@@ -996,7 +996,7 @@ static int tsl2591_write_event_config(struct iio_dev *indio_dev,
} else if (!state && chip->events_enabled) {
chip->events_enabled = false;
pm_runtime_mark_last_busy(&client->dev);
- pm_runtime_put_autosuspend(&client->dev);
+ __pm_runtime_put_autosuspend(&client->dev);
}
return 0;
diff --git a/drivers/iio/light/us5182d.c b/drivers/iio/light/us5182d.c
index de6967ac3b0b..901288236d38 100644
--- a/drivers/iio/light/us5182d.c
+++ b/drivers/iio/light/us5182d.c
@@ -370,7 +370,7 @@ static int us5182d_set_power_state(struct us5182d_data *data, bool on)
ret = pm_runtime_resume_and_get(&data->client->dev);
} else {
pm_runtime_mark_last_busy(&data->client->dev);
- ret = pm_runtime_put_autosuspend(&data->client->dev);
+ ret = __pm_runtime_put_autosuspend(&data->client->dev);
}
return ret;
diff --git a/drivers/iio/light/vcnl4000.c b/drivers/iio/light/vcnl4000.c
index 4e3641ff2ed4..2877880897e4 100644
--- a/drivers/iio/light/vcnl4000.c
+++ b/drivers/iio/light/vcnl4000.c
@@ -582,7 +582,7 @@ static int vcnl4000_set_pm_runtime_state(struct vcnl4000_data *data, bool on)
ret = pm_runtime_resume_and_get(dev);
} else {
pm_runtime_mark_last_busy(dev);
- ret = pm_runtime_put_autosuspend(dev);
+ ret = __pm_runtime_put_autosuspend(dev);
}
return ret;
diff --git a/drivers/iio/light/vcnl4035.c b/drivers/iio/light/vcnl4035.c
index 337a1332c2c6..a7393255f6ac 100644
--- a/drivers/iio/light/vcnl4035.c
+++ b/drivers/iio/light/vcnl4035.c
@@ -150,7 +150,7 @@ static int vcnl4035_set_pm_runtime_state(struct vcnl4035_data *data, bool on)
ret = pm_runtime_resume_and_get(dev);
} else {
pm_runtime_mark_last_busy(dev);
- ret = pm_runtime_put_autosuspend(dev);
+ ret = __pm_runtime_put_autosuspend(dev);
}
return ret;
diff --git a/drivers/iio/magnetometer/af8133j.c b/drivers/iio/magnetometer/af8133j.c
index d81d89af6283..f0530854698d 100644
--- a/drivers/iio/magnetometer/af8133j.c
+++ b/drivers/iio/magnetometer/af8133j.c
@@ -235,7 +235,7 @@ static int af8133j_read_measurement(struct af8133j_data *data, __le16 buf[3])
out_rpm_put:
pm_runtime_mark_last_busy(dev);
- pm_runtime_put_autosuspend(dev);
+ __pm_runtime_put_autosuspend(dev);
return ret;
}
@@ -454,7 +454,7 @@ static int af8133j_probe(struct i2c_client *client)
if (ret)
return ret;
- pm_runtime_put_autosuspend(dev);
+ __pm_runtime_put_autosuspend(dev);
indio_dev->info = &af8133j_info;
indio_dev->name = "af8133j";
diff --git a/drivers/iio/magnetometer/ak8974.c b/drivers/iio/magnetometer/ak8974.c
index 8306a18706ac..eed25cd701f0 100644
--- a/drivers/iio/magnetometer/ak8974.c
+++ b/drivers/iio/magnetometer/ak8974.c
@@ -584,7 +584,7 @@ static int ak8974_measure_channel(struct ak8974 *ak8974, unsigned long address,
out_unlock:
mutex_unlock(&ak8974->lock);
pm_runtime_mark_last_busy(&ak8974->i2c->dev);
- pm_runtime_put_autosuspend(&ak8974->i2c->dev);
+ __pm_runtime_put_autosuspend(&ak8974->i2c->dev);
return ret;
}
@@ -679,7 +679,7 @@ static void ak8974_fill_buffer(struct iio_dev *indio_dev)
out_unlock:
mutex_unlock(&ak8974->lock);
pm_runtime_mark_last_busy(&ak8974->i2c->dev);
- pm_runtime_put_autosuspend(&ak8974->i2c->dev);
+ __pm_runtime_put_autosuspend(&ak8974->i2c->dev);
}
static irqreturn_t ak8974_handle_trigger(int irq, void *p)
diff --git a/drivers/iio/magnetometer/ak8975.c b/drivers/iio/magnetometer/ak8975.c
index 18077fb463a9..b637385f9d26 100644
--- a/drivers/iio/magnetometer/ak8975.c
+++ b/drivers/iio/magnetometer/ak8975.c
@@ -776,7 +776,7 @@ static int ak8975_read_axis(struct iio_dev *indio_dev, int index, int *val)
mutex_unlock(&data->lock);
pm_runtime_mark_last_busy(&data->client->dev);
- pm_runtime_put_autosuspend(&data->client->dev);
+ __pm_runtime_put_autosuspend(&data->client->dev);
/* Swap bytes and convert to valid range. */
buff = le16_to_cpu(rval);
diff --git a/drivers/iio/magnetometer/bmc150_magn.c b/drivers/iio/magnetometer/bmc150_magn.c
index 06d5a1ef1fbd..26dc68e4270d 100644
--- a/drivers/iio/magnetometer/bmc150_magn.c
+++ b/drivers/iio/magnetometer/bmc150_magn.c
@@ -268,7 +268,7 @@ static int bmc150_magn_set_power_state(struct bmc150_magn_data *data, bool on)
ret = pm_runtime_resume_and_get(data->dev);
} else {
pm_runtime_mark_last_busy(data->dev);
- ret = pm_runtime_put_autosuspend(data->dev);
+ ret = __pm_runtime_put_autosuspend(data->dev);
}
if (ret < 0) {
diff --git a/drivers/iio/magnetometer/tmag5273.c b/drivers/iio/magnetometer/tmag5273.c
index 4187abe12784..bec579b7c6c6 100644
--- a/drivers/iio/magnetometer/tmag5273.c
+++ b/drivers/iio/magnetometer/tmag5273.c
@@ -296,7 +296,7 @@ static int tmag5273_read_raw(struct iio_dev *indio_dev,
ret = tmag5273_get_measure(data, &t, &x, &y, &z, &angle, &magnitude);
pm_runtime_mark_last_busy(data->dev);
- pm_runtime_put_autosuspend(data->dev);
+ __pm_runtime_put_autosuspend(data->dev);
if (ret)
return ret;
@@ -669,7 +669,7 @@ static int tmag5273_probe(struct i2c_client *i2c)
indio_dev->num_channels = ARRAY_SIZE(tmag5273_channels);
pm_runtime_mark_last_busy(dev);
- pm_runtime_put_autosuspend(dev);
+ __pm_runtime_put_autosuspend(dev);
ret = devm_iio_device_register(dev, indio_dev);
if (ret)
diff --git a/drivers/iio/magnetometer/yamaha-yas530.c b/drivers/iio/magnetometer/yamaha-yas530.c
index 65011a8598d3..62df8b91df3a 100644
--- a/drivers/iio/magnetometer/yamaha-yas530.c
+++ b/drivers/iio/magnetometer/yamaha-yas530.c
@@ -623,7 +623,7 @@ static int yas5xx_read_raw(struct iio_dev *indio_dev,
pm_runtime_get_sync(yas5xx->dev);
ret = ci->get_measure(yas5xx, &t, &x, &y, &z);
pm_runtime_mark_last_busy(yas5xx->dev);
- pm_runtime_put_autosuspend(yas5xx->dev);
+ __pm_runtime_put_autosuspend(yas5xx->dev);
if (ret)
return ret;
switch (chan->address) {
@@ -664,7 +664,7 @@ static void yas5xx_fill_buffer(struct iio_dev *indio_dev)
pm_runtime_get_sync(yas5xx->dev);
ret = ci->get_measure(yas5xx, &t, &x, &y, &z);
pm_runtime_mark_last_busy(yas5xx->dev);
- pm_runtime_put_autosuspend(yas5xx->dev);
+ __pm_runtime_put_autosuspend(yas5xx->dev);
if (ret) {
dev_err(yas5xx->dev, "error refilling buffer\n");
return;
diff --git a/drivers/iio/pressure/bmp280-core.c b/drivers/iio/pressure/bmp280-core.c
index ca4915c9a394..806933baeffd 100644
--- a/drivers/iio/pressure/bmp280-core.c
+++ b/drivers/iio/pressure/bmp280-core.c
@@ -729,7 +729,7 @@ static int bmp280_read_raw(struct iio_dev *indio_dev,
pm_runtime_get_sync(data->dev);
ret = bmp280_read_raw_impl(indio_dev, chan, val, val2, mask);
pm_runtime_mark_last_busy(data->dev);
- pm_runtime_put_autosuspend(data->dev);
+ __pm_runtime_put_autosuspend(data->dev);
return ret;
}
@@ -904,7 +904,7 @@ static int bmp280_write_raw(struct iio_dev *indio_dev,
pm_runtime_get_sync(data->dev);
ret = bmp280_write_raw_impl(indio_dev, chan, val, val2, mask);
pm_runtime_mark_last_busy(data->dev);
- pm_runtime_put_autosuspend(data->dev);
+ __pm_runtime_put_autosuspend(data->dev);
return ret;
}
@@ -1960,7 +1960,7 @@ static int bmp580_nvmem_read(void *priv, unsigned int offset, void *val,
pm_runtime_get_sync(data->dev);
ret = bmp580_nvmem_read_impl(priv, offset, val, bytes);
pm_runtime_mark_last_busy(data->dev);
- pm_runtime_put_autosuspend(data->dev);
+ __pm_runtime_put_autosuspend(data->dev);
return ret;
}
@@ -2035,7 +2035,7 @@ static int bmp580_nvmem_write(void *priv, unsigned int offset, void *val,
pm_runtime_get_sync(data->dev);
ret = bmp580_nvmem_write_impl(priv, offset, val, bytes);
pm_runtime_mark_last_busy(data->dev);
- pm_runtime_put_autosuspend(data->dev);
+ __pm_runtime_put_autosuspend(data->dev);
return ret;
}
@@ -2641,7 +2641,7 @@ static int bmp280_buffer_postdisable(struct iio_dev *indio_dev)
struct bmp280_data *data = iio_priv(indio_dev);
pm_runtime_mark_last_busy(data->dev);
- pm_runtime_put_autosuspend(data->dev);
+ __pm_runtime_put_autosuspend(data->dev);
return 0;
}
diff --git a/drivers/iio/pressure/icp10100.c b/drivers/iio/pressure/icp10100.c
index 3e0bf5d31ad7..866381bb1452 100644
--- a/drivers/iio/pressure/icp10100.c
+++ b/drivers/iio/pressure/icp10100.c
@@ -267,7 +267,7 @@ static int icp10100_get_measures(struct icp10100_state *st,
pm_runtime_mark_last_busy(&st->client->dev);
error_measure:
- pm_runtime_put_autosuspend(&st->client->dev);
+ __pm_runtime_put_autosuspend(&st->client->dev);
return ret;
}
diff --git a/drivers/iio/pressure/mpl115.c b/drivers/iio/pressure/mpl115.c
index 02ea38c8a3e4..70b711b16e52 100644
--- a/drivers/iio/pressure/mpl115.c
+++ b/drivers/iio/pressure/mpl115.c
@@ -109,7 +109,7 @@ static int mpl115_read_raw(struct iio_dev *indio_dev,
if (ret < 0)
return ret;
pm_runtime_mark_last_busy(data->dev);
- pm_runtime_put_autosuspend(data->dev);
+ __pm_runtime_put_autosuspend(data->dev);
return IIO_VAL_INT_PLUS_MICRO;
case IIO_CHAN_INFO_RAW:
@@ -119,7 +119,7 @@ static int mpl115_read_raw(struct iio_dev *indio_dev,
if (ret < 0)
return ret;
pm_runtime_mark_last_busy(data->dev);
- pm_runtime_put_autosuspend(data->dev);
+ __pm_runtime_put_autosuspend(data->dev);
*val = ret >> 6;
return IIO_VAL_INT;
diff --git a/drivers/iio/pressure/zpa2326.c b/drivers/iio/pressure/zpa2326.c
index 950f8dee2b26..7274855d0297 100644
--- a/drivers/iio/pressure/zpa2326.c
+++ b/drivers/iio/pressure/zpa2326.c
@@ -698,7 +698,7 @@ static void zpa2326_suspend(struct iio_dev *indio_dev)
zpa2326_sleep(indio_dev);
pm_runtime_mark_last_busy(parent);
- pm_runtime_put_autosuspend(parent);
+ __pm_runtime_put_autosuspend(parent);
}
static void zpa2326_init_runtime(struct device *parent)
@@ -709,7 +709,7 @@ static void zpa2326_init_runtime(struct device *parent)
pm_runtime_set_autosuspend_delay(parent, 1000);
pm_runtime_use_autosuspend(parent);
pm_runtime_mark_last_busy(parent);
- pm_runtime_put_autosuspend(parent);
+ __pm_runtime_put_autosuspend(parent);
}
static void zpa2326_fini_runtime(struct device *parent)
diff --git a/drivers/iio/proximity/pulsedlight-lidar-lite-v2.c b/drivers/iio/proximity/pulsedlight-lidar-lite-v2.c
index 5c959730aecd..6be27497d6e3 100644
--- a/drivers/iio/proximity/pulsedlight-lidar-lite-v2.c
+++ b/drivers/iio/proximity/pulsedlight-lidar-lite-v2.c
@@ -192,7 +192,7 @@ static int lidar_get_measurement(struct lidar_data *data, u16 *reg)
ret = -EIO;
}
pm_runtime_mark_last_busy(&client->dev);
- pm_runtime_put_autosuspend(&client->dev);
+ __pm_runtime_put_autosuspend(&client->dev);
return ret;
}
diff --git a/drivers/iio/proximity/srf04.c b/drivers/iio/proximity/srf04.c
index 86c57672fc7e..ecea2671ce62 100644
--- a/drivers/iio/proximity/srf04.c
+++ b/drivers/iio/proximity/srf04.c
@@ -119,7 +119,7 @@ static int srf04_read(struct srf04_data *data)
if (data->gpiod_power) {
pm_runtime_mark_last_busy(data->dev);
- pm_runtime_put_autosuspend(data->dev);
+ __pm_runtime_put_autosuspend(data->dev);
}
/* it should not take more than 20 ms until echo is rising */
diff --git a/drivers/iio/temperature/mlx90614.c b/drivers/iio/temperature/mlx90614.c
index 740018d4b3df..22bed79589d1 100644
--- a/drivers/iio/temperature/mlx90614.c
+++ b/drivers/iio/temperature/mlx90614.c
@@ -212,7 +212,7 @@ static int mlx90614_power_get(struct mlx90614_data *data, bool startup)
if (time_before(now, data->ready_timestamp) &&
msleep_interruptible(jiffies_to_msecs(
data->ready_timestamp - now)) != 0) {
- pm_runtime_put_autosuspend(&data->client->dev);
+ __pm_runtime_put_autosuspend(&data->client->dev);
return -EINTR;
}
}
@@ -226,7 +226,7 @@ static void mlx90614_power_put(struct mlx90614_data *data)
return;
pm_runtime_mark_last_busy(&data->client->dev);
- pm_runtime_put_autosuspend(&data->client->dev);
+ __pm_runtime_put_autosuspend(&data->client->dev);
}
#else
static inline int mlx90614_power_get(struct mlx90614_data *data, bool startup)
diff --git a/drivers/iio/temperature/mlx90632.c b/drivers/iio/temperature/mlx90632.c
index ae4ea587e7f9..c8cea6a4f390 100644
--- a/drivers/iio/temperature/mlx90632.c
+++ b/drivers/iio/temperature/mlx90632.c
@@ -1044,7 +1044,7 @@ static int mlx90632_read_raw(struct iio_dev *indio_dev,
mlx90632_read_raw_pm:
pm_runtime_mark_last_busy(&data->client->dev);
- pm_runtime_put_autosuspend(&data->client->dev);
+ __pm_runtime_put_autosuspend(&data->client->dev);
return ret;
}
@@ -1273,7 +1273,7 @@ static int mlx90632_probe(struct i2c_client *client)
pm_runtime_set_autosuspend_delay(&client->dev, MLX90632_SLEEP_DELAY_MS);
pm_runtime_use_autosuspend(&client->dev);
- pm_runtime_put_autosuspend(&client->dev);
+ __pm_runtime_put_autosuspend(&client->dev);
return devm_iio_device_register(&client->dev, indio_dev);
}
diff --git a/drivers/iio/temperature/mlx90635.c b/drivers/iio/temperature/mlx90635.c
index f7f88498ba0e..77ea81aa5c9e 100644
--- a/drivers/iio/temperature/mlx90635.c
+++ b/drivers/iio/temperature/mlx90635.c
@@ -750,7 +750,7 @@ static int mlx90635_read_raw(struct iio_dev *indio_dev,
mlx90635_read_raw_pm:
pm_runtime_mark_last_busy(&data->client->dev);
- pm_runtime_put_autosuspend(&data->client->dev);
+ __pm_runtime_put_autosuspend(&data->client->dev);
return ret;
}
@@ -1023,7 +1023,7 @@ static int mlx90635_probe(struct i2c_client *client)
pm_runtime_set_autosuspend_delay(&client->dev, MLX90635_SLEEP_DELAY_MS);
pm_runtime_use_autosuspend(&client->dev);
- pm_runtime_put_autosuspend(&client->dev);
+ __pm_runtime_put_autosuspend(&client->dev);
return devm_iio_device_register(&client->dev, indio_dev);
}
--
2.39.5
^ permalink raw reply related [flat|nested] 14+ messages in thread
* Re: [PATCH 19/51] iio: Switch to __pm_runtime_put_autosuspend()
2024-10-04 9:41 ` [PATCH 19/51] iio: " Sakari Ailus
@ 2024-10-04 13:45 ` Jonathan Cameron
0 siblings, 0 replies; 14+ messages in thread
From: Jonathan Cameron @ 2024-10-04 13:45 UTC (permalink / raw)
To: Sakari Ailus; +Cc: Jonathan Cameron, Lars-Peter Clausen, linux-iio
On Fri, 4 Oct 2024 12:41:23 +0300
Sakari Ailus <sakari.ailus@linux.intel.com> wrote:
> pm_runtime_put_autosuspend() will soon be changed to include a call to
> pm_runtime_mark_last_busy(). This patch switches the current users to
> __pm_runtime_put_autosuspend() which will continue to have the
> functionality of old pm_runtime_put_autosuspend().
Similar to some of the other feedback you've had, there is no
obvious point in this churn. Given mark_last_busy()
should be non destructive, just call it twice, then remove
the unnecessary calls after you have added on in autosuspend.
Jonathan
>
> Signed-off-by: Sakari Ailus <sakari.ailus@linux.intel.com>
> ---
> drivers/iio/accel/bmc150-accel-core.c | 2 +-
> drivers/iio/accel/bmi088-accel-core.c | 6 +++---
> drivers/iio/accel/fxls8962af-core.c | 2 +-
> drivers/iio/accel/kxcjk-1013.c | 2 +-
> drivers/iio/accel/kxsd9.c | 6 +++---
> drivers/iio/accel/mma8452.c | 2 +-
> drivers/iio/accel/mma9551_core.c | 2 +-
> drivers/iio/accel/msa311.c | 12 +++++------
> drivers/iio/adc/ab8500-gpadc.c | 2 +-
> drivers/iio/adc/at91-sama5d2_adc.c | 20 +++++++++----------
> drivers/iio/adc/rcar-gyroadc.c | 2 +-
> drivers/iio/adc/stm32-adc-core.c | 2 +-
> drivers/iio/adc/stm32-adc.c | 12 +++++------
> drivers/iio/adc/sun4i-gpadc-iio.c | 4 ++--
> drivers/iio/adc/ti-ads1015.c | 2 +-
> drivers/iio/adc/ti-ads1100.c | 2 +-
> drivers/iio/adc/ti-ads1119.c | 4 ++--
> drivers/iio/chemical/atlas-sensor.c | 4 ++--
> .../common/hid-sensors/hid-sensor-trigger.c | 2 +-
> drivers/iio/dac/stm32-dac.c | 6 +++---
> drivers/iio/gyro/bmg160_core.c | 2 +-
> drivers/iio/gyro/fxas21002c_core.c | 2 +-
> drivers/iio/gyro/mpu3050-core.c | 6 +++---
> drivers/iio/gyro/mpu3050-i2c.c | 2 +-
> .../iio/imu/inv_icm42600/inv_icm42600_accel.c | 10 +++++-----
> .../imu/inv_icm42600/inv_icm42600_buffer.c | 2 +-
> .../iio/imu/inv_icm42600/inv_icm42600_gyro.c | 10 +++++-----
> .../iio/imu/inv_icm42600/inv_icm42600_temp.c | 2 +-
> drivers/iio/imu/inv_mpu6050/inv_mpu_core.c | 14 ++++++-------
> drivers/iio/imu/inv_mpu6050/inv_mpu_trigger.c | 4 ++--
> drivers/iio/imu/kmx61.c | 2 +-
> drivers/iio/light/apds9306.c | 6 +++---
> drivers/iio/light/apds9960.c | 4 ++--
> drivers/iio/light/bh1780.c | 2 +-
> drivers/iio/light/gp2ap002.c | 4 ++--
> drivers/iio/light/isl29028.c | 2 +-
> drivers/iio/light/ltrf216a.c | 2 +-
> drivers/iio/light/pa12203001.c | 2 +-
> drivers/iio/light/rpr0521.c | 2 +-
> drivers/iio/light/tsl2583.c | 2 +-
> drivers/iio/light/tsl2591.c | 4 ++--
> drivers/iio/light/us5182d.c | 2 +-
> drivers/iio/light/vcnl4000.c | 2 +-
> drivers/iio/light/vcnl4035.c | 2 +-
> drivers/iio/magnetometer/af8133j.c | 4 ++--
> drivers/iio/magnetometer/ak8974.c | 4 ++--
> drivers/iio/magnetometer/ak8975.c | 2 +-
> drivers/iio/magnetometer/bmc150_magn.c | 2 +-
> drivers/iio/magnetometer/tmag5273.c | 4 ++--
> drivers/iio/magnetometer/yamaha-yas530.c | 4 ++--
> drivers/iio/pressure/bmp280-core.c | 10 +++++-----
> drivers/iio/pressure/icp10100.c | 2 +-
> drivers/iio/pressure/mpl115.c | 4 ++--
> drivers/iio/pressure/zpa2326.c | 4 ++--
> .../iio/proximity/pulsedlight-lidar-lite-v2.c | 2 +-
> drivers/iio/proximity/srf04.c | 2 +-
> drivers/iio/temperature/mlx90614.c | 4 ++--
> drivers/iio/temperature/mlx90632.c | 4 ++--
> drivers/iio/temperature/mlx90635.c | 4 ++--
> 59 files changed, 122 insertions(+), 122 deletions(-)
>
> diff --git a/drivers/iio/accel/bmc150-accel-core.c b/drivers/iio/accel/bmc150-accel-core.c
> index 0f32c1e92b4d..da02727c8626 100644
> --- a/drivers/iio/accel/bmc150-accel-core.c
> +++ b/drivers/iio/accel/bmc150-accel-core.c
> @@ -339,7 +339,7 @@ static int bmc150_accel_set_power_state(struct bmc150_accel_data *data, bool on)
> ret = pm_runtime_resume_and_get(dev);
> } else {
> pm_runtime_mark_last_busy(dev);
> - ret = pm_runtime_put_autosuspend(dev);
> + ret = __pm_runtime_put_autosuspend(dev);
> }
>
> if (ret < 0) {
> diff --git a/drivers/iio/accel/bmi088-accel-core.c b/drivers/iio/accel/bmi088-accel-core.c
> index fc1c1613d673..f57960509c7f 100644
> --- a/drivers/iio/accel/bmi088-accel-core.c
> +++ b/drivers/iio/accel/bmi088-accel-core.c
> @@ -375,7 +375,7 @@ static int bmi088_accel_read_raw(struct iio_dev *indio_dev,
>
> out_read_raw_pm_put:
> pm_runtime_mark_last_busy(dev);
> - pm_runtime_put_autosuspend(dev);
> + __pm_runtime_put_autosuspend(dev);
>
> return ret;
> }
> @@ -419,7 +419,7 @@ static int bmi088_accel_write_raw(struct iio_dev *indio_dev,
>
> ret = bmi088_accel_set_scale(data, val, val2);
> pm_runtime_mark_last_busy(dev);
> - pm_runtime_put_autosuspend(dev);
> + __pm_runtime_put_autosuspend(dev);
> return ret;
> case IIO_CHAN_INFO_SAMP_FREQ:
> ret = pm_runtime_resume_and_get(dev);
> @@ -428,7 +428,7 @@ static int bmi088_accel_write_raw(struct iio_dev *indio_dev,
>
> ret = bmi088_accel_set_sample_freq(data, val);
> pm_runtime_mark_last_busy(dev);
> - pm_runtime_put_autosuspend(dev);
> + __pm_runtime_put_autosuspend(dev);
> return ret;
> default:
> return -EINVAL;
> diff --git a/drivers/iio/accel/fxls8962af-core.c b/drivers/iio/accel/fxls8962af-core.c
> index 37f33c29fb4b..50e1b2575af0 100644
> --- a/drivers/iio/accel/fxls8962af-core.c
> +++ b/drivers/iio/accel/fxls8962af-core.c
> @@ -219,7 +219,7 @@ static int fxls8962af_power_off(struct fxls8962af_data *data)
> int ret;
>
> pm_runtime_mark_last_busy(dev);
> - ret = pm_runtime_put_autosuspend(dev);
> + ret = __pm_runtime_put_autosuspend(dev);
> if (ret)
> dev_err(dev, "failed to power off\n");
>
> diff --git a/drivers/iio/accel/kxcjk-1013.c b/drivers/iio/accel/kxcjk-1013.c
> index b76df8816323..01c6bc9b0f99 100644
> --- a/drivers/iio/accel/kxcjk-1013.c
> +++ b/drivers/iio/accel/kxcjk-1013.c
> @@ -625,7 +625,7 @@ static int kxcjk1013_set_power_state(struct kxcjk1013_data *data, bool on)
> ret = pm_runtime_resume_and_get(&data->client->dev);
> else {
> pm_runtime_mark_last_busy(&data->client->dev);
> - ret = pm_runtime_put_autosuspend(&data->client->dev);
> + ret = __pm_runtime_put_autosuspend(&data->client->dev);
> }
> if (ret < 0) {
> dev_err(&data->client->dev,
> diff --git a/drivers/iio/accel/kxsd9.c b/drivers/iio/accel/kxsd9.c
> index 70dfd6e354db..41dcf80784f1 100644
> --- a/drivers/iio/accel/kxsd9.c
> +++ b/drivers/iio/accel/kxsd9.c
> @@ -151,7 +151,7 @@ static int kxsd9_write_raw(struct iio_dev *indio_dev,
> }
>
> pm_runtime_mark_last_busy(st->dev);
> - pm_runtime_put_autosuspend(st->dev);
> + __pm_runtime_put_autosuspend(st->dev);
>
> return ret;
> }
> @@ -199,7 +199,7 @@ static int kxsd9_read_raw(struct iio_dev *indio_dev,
>
> error_ret:
> pm_runtime_mark_last_busy(st->dev);
> - pm_runtime_put_autosuspend(st->dev);
> + __pm_runtime_put_autosuspend(st->dev);
>
> return ret;
> };
> @@ -251,7 +251,7 @@ static int kxsd9_buffer_postdisable(struct iio_dev *indio_dev)
> struct kxsd9_state *st = iio_priv(indio_dev);
>
> pm_runtime_mark_last_busy(st->dev);
> - pm_runtime_put_autosuspend(st->dev);
> + __pm_runtime_put_autosuspend(st->dev);
>
> return 0;
> }
> diff --git a/drivers/iio/accel/mma8452.c b/drivers/iio/accel/mma8452.c
> index 62e6369e2269..17786868855b 100644
> --- a/drivers/iio/accel/mma8452.c
> +++ b/drivers/iio/accel/mma8452.c
> @@ -227,7 +227,7 @@ static int mma8452_set_runtime_pm_state(struct i2c_client *client, bool on)
> ret = pm_runtime_resume_and_get(&client->dev);
> } else {
> pm_runtime_mark_last_busy(&client->dev);
> - ret = pm_runtime_put_autosuspend(&client->dev);
> + ret = __pm_runtime_put_autosuspend(&client->dev);
> }
>
> if (ret < 0) {
> diff --git a/drivers/iio/accel/mma9551_core.c b/drivers/iio/accel/mma9551_core.c
> index b898f865fb87..d97cac6cc4da 100644
> --- a/drivers/iio/accel/mma9551_core.c
> +++ b/drivers/iio/accel/mma9551_core.c
> @@ -673,7 +673,7 @@ int mma9551_set_power_state(struct i2c_client *client, bool on)
> ret = pm_runtime_resume_and_get(&client->dev);
> else {
> pm_runtime_mark_last_busy(&client->dev);
> - ret = pm_runtime_put_autosuspend(&client->dev);
> + ret = __pm_runtime_put_autosuspend(&client->dev);
> }
>
> if (ret < 0) {
> diff --git a/drivers/iio/accel/msa311.c b/drivers/iio/accel/msa311.c
> index 57025354c7cd..21ec55dc1c5a 100644
> --- a/drivers/iio/accel/msa311.c
> +++ b/drivers/iio/accel/msa311.c
> @@ -608,7 +608,7 @@ static int msa311_read_raw_data(struct iio_dev *indio_dev,
> iio_device_release_direct_mode(indio_dev);
>
> pm_runtime_mark_last_busy(dev);
> - pm_runtime_put_autosuspend(dev);
> + __pm_runtime_put_autosuspend(dev);
>
> if (err) {
> dev_err(dev, "can't get axis %s (%pe)\n",
> @@ -740,7 +740,7 @@ static int msa311_write_scale(struct iio_dev *indio_dev, int val, int val2)
> }
>
> pm_runtime_mark_last_busy(dev);
> - pm_runtime_put_autosuspend(dev);
> + __pm_runtime_put_autosuspend(dev);
>
> if (err)
> dev_err(dev, "can't update scale (%pe)\n", ERR_PTR(err));
> @@ -781,7 +781,7 @@ static int msa311_write_samp_freq(struct iio_dev *indio_dev, int val, int val2)
> iio_device_release_direct_mode(indio_dev);
>
> pm_runtime_mark_last_busy(dev);
> - pm_runtime_put_autosuspend(dev);
> + __pm_runtime_put_autosuspend(dev);
>
> if (err)
> dev_err(dev, "can't update frequency (%pe)\n", ERR_PTR(err));
> @@ -830,7 +830,7 @@ static int msa311_debugfs_reg_access(struct iio_dev *indio_dev,
> mutex_unlock(&msa311->lock);
>
> pm_runtime_mark_last_busy(dev);
> - pm_runtime_put_autosuspend(dev);
> + __pm_runtime_put_autosuspend(dev);
>
> if (err)
> dev_err(dev, "can't %s register %u from debugfs (%pe)\n",
> @@ -853,7 +853,7 @@ static int msa311_buffer_postdisable(struct iio_dev *indio_dev)
> struct device *dev = msa311->dev;
>
> pm_runtime_mark_last_busy(dev);
> - pm_runtime_put_autosuspend(dev);
> + __pm_runtime_put_autosuspend(dev);
>
> return 0;
> }
> @@ -1231,7 +1231,7 @@ static int msa311_probe(struct i2c_client *i2c)
> return err;
>
> pm_runtime_mark_last_busy(dev);
> - pm_runtime_put_autosuspend(dev);
> + __pm_runtime_put_autosuspend(dev);
>
> err = devm_iio_device_register(dev, indio_dev);
> if (err)
> diff --git a/drivers/iio/adc/ab8500-gpadc.c b/drivers/iio/adc/ab8500-gpadc.c
> index 59f66e9cb0e8..f2d1b06bac44 100644
> --- a/drivers/iio/adc/ab8500-gpadc.c
> +++ b/drivers/iio/adc/ab8500-gpadc.c
> @@ -608,7 +608,7 @@ static int ab8500_gpadc_read(struct ab8500_gpadc *gpadc,
>
> /* This eventually drops the regulator */
> pm_runtime_mark_last_busy(gpadc->dev);
> - pm_runtime_put_autosuspend(gpadc->dev);
> + __pm_runtime_put_autosuspend(gpadc->dev);
>
> return (high_data << 8) | low_data;
>
> diff --git a/drivers/iio/adc/at91-sama5d2_adc.c b/drivers/iio/adc/at91-sama5d2_adc.c
> index d7fd21e7c6e2..628e6e3c667c 100644
> --- a/drivers/iio/adc/at91-sama5d2_adc.c
> +++ b/drivers/iio/adc/at91-sama5d2_adc.c
> @@ -893,7 +893,7 @@ static int at91_adc_config_emr(struct at91_adc_state *st,
> at91_adc_writel(st, EMR, emr);
>
> pm_runtime_mark_last_busy(st->dev);
> - pm_runtime_put_autosuspend(st->dev);
> + __pm_runtime_put_autosuspend(st->dev);
>
> st->oversampling_ratio = oversampling_ratio;
>
> @@ -968,7 +968,7 @@ static int at91_adc_configure_touch(struct at91_adc_state *st, bool state)
> at91_adc_writel(st, TSMR, 0);
>
> pm_runtime_mark_last_busy(st->dev);
> - pm_runtime_put_autosuspend(st->dev);
> + __pm_runtime_put_autosuspend(st->dev);
> return 0;
> }
> /*
> @@ -1140,7 +1140,7 @@ static int at91_adc_configure_trigger(struct iio_trigger *trig, bool state)
>
> if (!state) {
> pm_runtime_mark_last_busy(st->dev);
> - pm_runtime_put_autosuspend(st->dev);
> + __pm_runtime_put_autosuspend(st->dev);
> }
>
> return 0;
> @@ -1333,7 +1333,7 @@ static int at91_adc_buffer_prepare(struct iio_dev *indio_dev)
>
> pm_runtime_put:
> pm_runtime_mark_last_busy(st->dev);
> - pm_runtime_put_autosuspend(st->dev);
> + __pm_runtime_put_autosuspend(st->dev);
> return ret;
> }
>
> @@ -1391,7 +1391,7 @@ static int at91_adc_buffer_postdisable(struct iio_dev *indio_dev)
> dmaengine_terminate_sync(st->dma_st.dma_chan);
>
> pm_runtime_mark_last_busy(st->dev);
> - pm_runtime_put_autosuspend(st->dev);
> + __pm_runtime_put_autosuspend(st->dev);
>
> return 0;
> }
> @@ -1600,7 +1600,7 @@ static void at91_adc_setup_samp_freq(struct iio_dev *indio_dev, unsigned freq,
> at91_adc_writel(st, MR, mr);
>
> pm_runtime_mark_last_busy(st->dev);
> - pm_runtime_put_autosuspend(st->dev);
> + __pm_runtime_put_autosuspend(st->dev);
>
> dev_dbg(&indio_dev->dev, "freq: %u, startup: %u, prescal: %u, tracktim=%u\n",
> freq, startup, prescal, tracktim);
> @@ -1806,7 +1806,7 @@ static int at91_adc_read_info_raw(struct iio_dev *indio_dev,
>
> pm_runtime_put:
> pm_runtime_mark_last_busy(st->dev);
> - pm_runtime_put_autosuspend(st->dev);
> + __pm_runtime_put_autosuspend(st->dev);
> return ret;
> }
>
> @@ -1899,7 +1899,7 @@ static int at91_adc_read_temp(struct iio_dev *indio_dev,
> /* Revert previous settings. */
> at91_adc_temp_sensor_configure(st, false);
> pm_runtime_mark_last_busy(st->dev);
> - pm_runtime_put_autosuspend(st->dev);
> + __pm_runtime_put_autosuspend(st->dev);
> unlock:
> mutex_unlock(&st->lock);
> iio_device_release_direct_mode(indio_dev);
> @@ -2467,7 +2467,7 @@ static int at91_adc_probe(struct platform_device *pdev)
> readl_relaxed(st->base + st->soc_info.platform->layout->VERSION));
>
> pm_runtime_mark_last_busy(st->dev);
> - pm_runtime_put_autosuspend(st->dev);
> + __pm_runtime_put_autosuspend(st->dev);
>
> return 0;
>
> @@ -2569,7 +2569,7 @@ static int at91_adc_resume(struct device *dev)
> }
>
> pm_runtime_mark_last_busy(st->dev);
> - pm_runtime_put_autosuspend(st->dev);
> + __pm_runtime_put_autosuspend(st->dev);
>
> return 0;
>
> diff --git a/drivers/iio/adc/rcar-gyroadc.c b/drivers/iio/adc/rcar-gyroadc.c
> index 15a21d2860e7..d2a4557a5c07 100644
> --- a/drivers/iio/adc/rcar-gyroadc.c
> +++ b/drivers/iio/adc/rcar-gyroadc.c
> @@ -167,7 +167,7 @@ static int rcar_gyroadc_set_power(struct rcar_gyroadc *priv, bool on)
> return pm_runtime_resume_and_get(dev);
> } else {
> pm_runtime_mark_last_busy(dev);
> - return pm_runtime_put_autosuspend(dev);
> + return __pm_runtime_put_autosuspend(dev);
> }
> }
>
> diff --git a/drivers/iio/adc/stm32-adc-core.c b/drivers/iio/adc/stm32-adc-core.c
> index 616dd729666a..a67e972bcc5d 100644
> --- a/drivers/iio/adc/stm32-adc-core.c
> +++ b/drivers/iio/adc/stm32-adc-core.c
> @@ -798,7 +798,7 @@ static int stm32_adc_probe(struct platform_device *pdev)
> }
>
> pm_runtime_mark_last_busy(dev);
> - pm_runtime_put_autosuspend(dev);
> + __pm_runtime_put_autosuspend(dev);
>
> return 0;
>
> diff --git a/drivers/iio/adc/stm32-adc.c b/drivers/iio/adc/stm32-adc.c
> index 32ca26ed59f7..50c3651413d2 100644
> --- a/drivers/iio/adc/stm32-adc.c
> +++ b/drivers/iio/adc/stm32-adc.c
> @@ -1456,7 +1456,7 @@ static int stm32_adc_single_conv(struct iio_dev *indio_dev,
> stm32_adc_conv_irq_disable(adc);
>
> pm_runtime_mark_last_busy(dev);
> - pm_runtime_put_autosuspend(dev);
> + __pm_runtime_put_autosuspend(dev);
>
> return ret;
> }
> @@ -1623,7 +1623,7 @@ static int stm32_adc_update_scan_mode(struct iio_dev *indio_dev,
>
> ret = stm32_adc_conf_scan_seq(indio_dev, scan_mask);
> pm_runtime_mark_last_busy(dev);
> - pm_runtime_put_autosuspend(dev);
> + __pm_runtime_put_autosuspend(dev);
>
> return ret;
> }
> @@ -1672,7 +1672,7 @@ static int stm32_adc_debugfs_reg_access(struct iio_dev *indio_dev,
> *readval = stm32_adc_readl(adc, reg);
>
> pm_runtime_mark_last_busy(dev);
> - pm_runtime_put_autosuspend(dev);
> + __pm_runtime_put_autosuspend(dev);
>
> return 0;
> }
> @@ -1816,7 +1816,7 @@ static int stm32_adc_buffer_postenable(struct iio_dev *indio_dev)
> stm32_adc_set_trig(indio_dev, NULL);
> err_pm_put:
> pm_runtime_mark_last_busy(dev);
> - pm_runtime_put_autosuspend(dev);
> + __pm_runtime_put_autosuspend(dev);
>
> return ret;
> }
> @@ -1839,7 +1839,7 @@ static int stm32_adc_buffer_predisable(struct iio_dev *indio_dev)
> dev_err(&indio_dev->dev, "Can't clear trigger\n");
>
> pm_runtime_mark_last_busy(dev);
> - pm_runtime_put_autosuspend(dev);
> + __pm_runtime_put_autosuspend(dev);
>
> return 0;
> }
> @@ -2473,7 +2473,7 @@ static int stm32_adc_probe(struct platform_device *pdev)
> }
>
> pm_runtime_mark_last_busy(dev);
> - pm_runtime_put_autosuspend(dev);
> + __pm_runtime_put_autosuspend(dev);
>
> if (IS_ENABLED(CONFIG_DEBUG_FS))
> stm32_adc_debugfs_init(indio_dev);
> diff --git a/drivers/iio/adc/sun4i-gpadc-iio.c b/drivers/iio/adc/sun4i-gpadc-iio.c
> index 00a3a4db0fe0..43746e026042 100644
> --- a/drivers/iio/adc/sun4i-gpadc-iio.c
> +++ b/drivers/iio/adc/sun4i-gpadc-iio.c
> @@ -248,7 +248,7 @@ static int sun4i_gpadc_read(struct iio_dev *indio_dev, int channel, int *val,
> pm_runtime_mark_last_busy(indio_dev->dev.parent);
>
> err:
> - pm_runtime_put_autosuspend(indio_dev->dev.parent);
> + __pm_runtime_put_autosuspend(indio_dev->dev.parent);
> disable_irq(irq);
> mutex_unlock(&info->mutex);
>
> @@ -273,7 +273,7 @@ static int sun4i_gpadc_temp_read(struct iio_dev *indio_dev, int *val)
> regmap_read(info->regmap, SUN4I_GPADC_TEMP_DATA, val);
>
> pm_runtime_mark_last_busy(indio_dev->dev.parent);
> - pm_runtime_put_autosuspend(indio_dev->dev.parent);
> + __pm_runtime_put_autosuspend(indio_dev->dev.parent);
>
> return 0;
> }
> diff --git a/drivers/iio/adc/ti-ads1015.c b/drivers/iio/adc/ti-ads1015.c
> index 052d2124b215..380aeabc8a72 100644
> --- a/drivers/iio/adc/ti-ads1015.c
> +++ b/drivers/iio/adc/ti-ads1015.c
> @@ -377,7 +377,7 @@ static int ads1015_set_power_state(struct ads1015_data *data, bool on)
> ret = pm_runtime_resume_and_get(dev);
> } else {
> pm_runtime_mark_last_busy(dev);
> - ret = pm_runtime_put_autosuspend(dev);
> + ret = __pm_runtime_put_autosuspend(dev);
> }
>
> return ret < 0 ? ret : 0;
> diff --git a/drivers/iio/adc/ti-ads1100.c b/drivers/iio/adc/ti-ads1100.c
> index 1e46f07a9ca6..038901c93b7d 100644
> --- a/drivers/iio/adc/ti-ads1100.c
> +++ b/drivers/iio/adc/ti-ads1100.c
> @@ -105,7 +105,7 @@ static int ads1100_get_adc_result(struct ads1100_data *data, int chan, int *val)
> ret = i2c_master_recv(data->client, (char *)&buffer, sizeof(buffer));
>
> pm_runtime_mark_last_busy(&data->client->dev);
> - pm_runtime_put_autosuspend(&data->client->dev);
> + __pm_runtime_put_autosuspend(&data->client->dev);
>
> if (ret < 0) {
> dev_err(&data->client->dev, "I2C read fail: %d\n", ret);
> diff --git a/drivers/iio/adc/ti-ads1119.c b/drivers/iio/adc/ti-ads1119.c
> index 1c7606375149..52e20c4ed8bb 100644
> --- a/drivers/iio/adc/ti-ads1119.c
> +++ b/drivers/iio/adc/ti-ads1119.c
> @@ -292,7 +292,7 @@ static int ads1119_single_conversion(struct ads1119_state *st,
> ret = IIO_VAL_INT;
> pdown:
> pm_runtime_mark_last_busy(dev);
> - pm_runtime_put_autosuspend(dev);
> + __pm_runtime_put_autosuspend(dev);
> return ret;
> }
>
> @@ -466,7 +466,7 @@ static int ads1119_triggered_buffer_postdisable(struct iio_dev *indio_dev)
> return ret;
>
> pm_runtime_mark_last_busy(dev);
> - pm_runtime_put_autosuspend(dev);
> + __pm_runtime_put_autosuspend(dev);
>
> return 0;
> }
> diff --git a/drivers/iio/chemical/atlas-sensor.c b/drivers/iio/chemical/atlas-sensor.c
> index baf93e5e3ca7..d0ab2656919e 100644
> --- a/drivers/iio/chemical/atlas-sensor.c
> +++ b/drivers/iio/chemical/atlas-sensor.c
> @@ -427,7 +427,7 @@ static int atlas_buffer_predisable(struct iio_dev *indio_dev)
> return ret;
>
> pm_runtime_mark_last_busy(&data->client->dev);
> - ret = pm_runtime_put_autosuspend(&data->client->dev);
> + ret = __pm_runtime_put_autosuspend(&data->client->dev);
> if (ret)
> return ret;
>
> @@ -492,7 +492,7 @@ static int atlas_read_measurement(struct atlas_data *data, int reg, __be32 *val)
> ret = regmap_bulk_read(data->regmap, reg, val, sizeof(*val));
>
> pm_runtime_mark_last_busy(dev);
> - pm_runtime_put_autosuspend(dev);
> + __pm_runtime_put_autosuspend(dev);
>
> return ret;
> }
> diff --git a/drivers/iio/common/hid-sensors/hid-sensor-trigger.c b/drivers/iio/common/hid-sensors/hid-sensor-trigger.c
> index ad8910e6ad59..e6bf7eb4e23c 100644
> --- a/drivers/iio/common/hid-sensors/hid-sensor-trigger.c
> +++ b/drivers/iio/common/hid-sensors/hid-sensor-trigger.c
> @@ -165,7 +165,7 @@ int hid_sensor_power_state(struct hid_sensor_common *st, bool state)
> atomic_dec(&st->user_requested_state);
> pm_runtime_mark_last_busy(&st->pdev->dev);
> pm_runtime_use_autosuspend(&st->pdev->dev);
> - ret = pm_runtime_put_autosuspend(&st->pdev->dev);
> + ret = __pm_runtime_put_autosuspend(&st->pdev->dev);
> }
> if (ret < 0)
> return ret;
> diff --git a/drivers/iio/dac/stm32-dac.c b/drivers/iio/dac/stm32-dac.c
> index 5a722f307e7e..8dadf90546b4 100644
> --- a/drivers/iio/dac/stm32-dac.c
> +++ b/drivers/iio/dac/stm32-dac.c
> @@ -97,7 +97,7 @@ static int stm32_dac_set_enable_state(struct iio_dev *indio_dev, int ch,
>
> if (!enable) {
> pm_runtime_mark_last_busy(dev);
> - pm_runtime_put_autosuspend(dev);
> + __pm_runtime_put_autosuspend(dev);
> }
>
> return 0;
> @@ -105,7 +105,7 @@ static int stm32_dac_set_enable_state(struct iio_dev *indio_dev, int ch,
> err_put_pm:
> if (enable) {
> pm_runtime_mark_last_busy(dev);
> - pm_runtime_put_autosuspend(dev);
> + __pm_runtime_put_autosuspend(dev);
> }
>
> return ret;
> @@ -350,7 +350,7 @@ static int stm32_dac_probe(struct platform_device *pdev)
> goto err_pm_put;
>
> pm_runtime_mark_last_busy(dev);
> - pm_runtime_put_autosuspend(dev);
> + __pm_runtime_put_autosuspend(dev);
>
> return 0;
>
> diff --git a/drivers/iio/gyro/bmg160_core.c b/drivers/iio/gyro/bmg160_core.c
> index 10728d5ccae3..97f3045dc2a9 100644
> --- a/drivers/iio/gyro/bmg160_core.c
> +++ b/drivers/iio/gyro/bmg160_core.c
> @@ -314,7 +314,7 @@ static int bmg160_set_power_state(struct bmg160_data *data, bool on)
> ret = pm_runtime_get_sync(dev);
> else {
> pm_runtime_mark_last_busy(dev);
> - ret = pm_runtime_put_autosuspend(dev);
> + ret = __pm_runtime_put_autosuspend(dev);
> }
>
> if (ret < 0) {
> diff --git a/drivers/iio/gyro/fxas21002c_core.c b/drivers/iio/gyro/fxas21002c_core.c
> index 688966129f70..f6263187f6c7 100644
> --- a/drivers/iio/gyro/fxas21002c_core.c
> +++ b/drivers/iio/gyro/fxas21002c_core.c
> @@ -375,7 +375,7 @@ static int fxas21002c_pm_put(struct fxas21002c_data *data)
>
> pm_runtime_mark_last_busy(dev);
>
> - return pm_runtime_put_autosuspend(dev);
> + return __pm_runtime_put_autosuspend(dev);
> }
>
> static int fxas21002c_temp_get(struct fxas21002c_data *data, int *val)
> diff --git a/drivers/iio/gyro/mpu3050-core.c b/drivers/iio/gyro/mpu3050-core.c
> index b6883e8b2a8b..93d9d0e4626b 100644
> --- a/drivers/iio/gyro/mpu3050-core.c
> +++ b/drivers/iio/gyro/mpu3050-core.c
> @@ -371,7 +371,7 @@ static int mpu3050_read_raw(struct iio_dev *indio_dev,
> out_read_raw_unlock:
> mutex_unlock(&mpu3050->lock);
> pm_runtime_mark_last_busy(mpu3050->dev);
> - pm_runtime_put_autosuspend(mpu3050->dev);
> + __pm_runtime_put_autosuspend(mpu3050->dev);
>
> return ret;
> }
> @@ -663,7 +663,7 @@ static int mpu3050_buffer_postdisable(struct iio_dev *indio_dev)
> struct mpu3050 *mpu3050 = iio_priv(indio_dev);
>
> pm_runtime_mark_last_busy(mpu3050->dev);
> - pm_runtime_put_autosuspend(mpu3050->dev);
> + __pm_runtime_put_autosuspend(mpu3050->dev);
>
> return 0;
> }
> @@ -977,7 +977,7 @@ static int mpu3050_drdy_trigger_set_state(struct iio_trigger *trig,
> dev_err(mpu3050->dev, "error resetting FIFO\n");
>
> pm_runtime_mark_last_busy(mpu3050->dev);
> - pm_runtime_put_autosuspend(mpu3050->dev);
> + __pm_runtime_put_autosuspend(mpu3050->dev);
> mpu3050->hw_irq_trigger = false;
>
> return 0;
> diff --git a/drivers/iio/gyro/mpu3050-i2c.c b/drivers/iio/gyro/mpu3050-i2c.c
> index 29ecfa6fd633..49256fc6c6ad 100644
> --- a/drivers/iio/gyro/mpu3050-i2c.c
> +++ b/drivers/iio/gyro/mpu3050-i2c.c
> @@ -28,7 +28,7 @@ static int mpu3050_i2c_bypass_deselect(struct i2c_mux_core *mux, u32 chan_id)
> struct mpu3050 *mpu3050 = i2c_mux_priv(mux);
>
> pm_runtime_mark_last_busy(mpu3050->dev);
> - pm_runtime_put_autosuspend(mpu3050->dev);
> + __pm_runtime_put_autosuspend(mpu3050->dev);
> return 0;
> }
>
> diff --git a/drivers/iio/imu/inv_icm42600/inv_icm42600_accel.c b/drivers/iio/imu/inv_icm42600/inv_icm42600_accel.c
> index 56ac19814250..4e43deadf02f 100644
> --- a/drivers/iio/imu/inv_icm42600/inv_icm42600_accel.c
> +++ b/drivers/iio/imu/inv_icm42600/inv_icm42600_accel.c
> @@ -292,7 +292,7 @@ static int inv_icm42600_accel_read_sensor(struct iio_dev *indio_dev,
> exit:
> mutex_unlock(&st->lock);
> pm_runtime_mark_last_busy(dev);
> - pm_runtime_put_autosuspend(dev);
> + __pm_runtime_put_autosuspend(dev);
> return ret;
> }
>
> @@ -370,7 +370,7 @@ static int inv_icm42600_accel_write_scale(struct iio_dev *indio_dev,
>
> mutex_unlock(&st->lock);
> pm_runtime_mark_last_busy(dev);
> - pm_runtime_put_autosuspend(dev);
> + __pm_runtime_put_autosuspend(dev);
>
> return ret;
> }
> @@ -474,7 +474,7 @@ static int inv_icm42600_accel_write_odr(struct iio_dev *indio_dev,
> out_unlock:
> mutex_unlock(&st->lock);
> pm_runtime_mark_last_busy(dev);
> - pm_runtime_put_autosuspend(dev);
> + __pm_runtime_put_autosuspend(dev);
>
> return ret;
> }
> @@ -526,7 +526,7 @@ static int inv_icm42600_accel_read_offset(struct inv_icm42600_state *st,
>
> mutex_unlock(&st->lock);
> pm_runtime_mark_last_busy(dev);
> - pm_runtime_put_autosuspend(dev);
> + __pm_runtime_put_autosuspend(dev);
> if (ret)
> return ret;
>
> @@ -664,7 +664,7 @@ static int inv_icm42600_accel_write_offset(struct inv_icm42600_state *st,
> out_unlock:
> mutex_unlock(&st->lock);
> pm_runtime_mark_last_busy(dev);
> - pm_runtime_put_autosuspend(dev);
> + __pm_runtime_put_autosuspend(dev);
> return ret;
> }
>
> diff --git a/drivers/iio/imu/inv_icm42600/inv_icm42600_buffer.c b/drivers/iio/imu/inv_icm42600/inv_icm42600_buffer.c
> index aae7c56481a3..acc141657d3f 100644
> --- a/drivers/iio/imu/inv_icm42600/inv_icm42600_buffer.c
> +++ b/drivers/iio/imu/inv_icm42600/inv_icm42600_buffer.c
> @@ -440,7 +440,7 @@ static int inv_icm42600_buffer_postdisable(struct iio_dev *indio_dev)
> msleep(sleep);
>
> pm_runtime_mark_last_busy(dev);
> - pm_runtime_put_autosuspend(dev);
> + __pm_runtime_put_autosuspend(dev);
>
> return ret;
> }
> diff --git a/drivers/iio/imu/inv_icm42600/inv_icm42600_gyro.c b/drivers/iio/imu/inv_icm42600/inv_icm42600_gyro.c
> index 938af5b640b0..3784b1719433 100644
> --- a/drivers/iio/imu/inv_icm42600/inv_icm42600_gyro.c
> +++ b/drivers/iio/imu/inv_icm42600/inv_icm42600_gyro.c
> @@ -188,7 +188,7 @@ static int inv_icm42600_gyro_read_sensor(struct inv_icm42600_state *st,
> exit:
> mutex_unlock(&st->lock);
> pm_runtime_mark_last_busy(dev);
> - pm_runtime_put_autosuspend(dev);
> + __pm_runtime_put_autosuspend(dev);
> return ret;
> }
>
> @@ -287,7 +287,7 @@ static int inv_icm42600_gyro_write_scale(struct iio_dev *indio_dev,
>
> mutex_unlock(&st->lock);
> pm_runtime_mark_last_busy(dev);
> - pm_runtime_put_autosuspend(dev);
> + __pm_runtime_put_autosuspend(dev);
>
> return ret;
> }
> @@ -382,7 +382,7 @@ static int inv_icm42600_gyro_write_odr(struct iio_dev *indio_dev,
> out_unlock:
> mutex_unlock(&st->lock);
> pm_runtime_mark_last_busy(dev);
> - pm_runtime_put_autosuspend(dev);
> + __pm_runtime_put_autosuspend(dev);
>
> return ret;
> }
> @@ -434,7 +434,7 @@ static int inv_icm42600_gyro_read_offset(struct inv_icm42600_state *st,
>
> mutex_unlock(&st->lock);
> pm_runtime_mark_last_busy(dev);
> - pm_runtime_put_autosuspend(dev);
> + __pm_runtime_put_autosuspend(dev);
> if (ret)
> return ret;
>
> @@ -571,7 +571,7 @@ static int inv_icm42600_gyro_write_offset(struct inv_icm42600_state *st,
> out_unlock:
> mutex_unlock(&st->lock);
> pm_runtime_mark_last_busy(dev);
> - pm_runtime_put_autosuspend(dev);
> + __pm_runtime_put_autosuspend(dev);
> return ret;
> }
>
> diff --git a/drivers/iio/imu/inv_icm42600/inv_icm42600_temp.c b/drivers/iio/imu/inv_icm42600/inv_icm42600_temp.c
> index 213cce1c3111..4c2f2d6dfff9 100644
> --- a/drivers/iio/imu/inv_icm42600/inv_icm42600_temp.c
> +++ b/drivers/iio/imu/inv_icm42600/inv_icm42600_temp.c
> @@ -38,7 +38,7 @@ static int inv_icm42600_temp_read(struct inv_icm42600_state *st, int16_t *temp)
> exit:
> mutex_unlock(&st->lock);
> pm_runtime_mark_last_busy(dev);
> - pm_runtime_put_autosuspend(dev);
> + __pm_runtime_put_autosuspend(dev);
>
> return ret;
> }
> diff --git a/drivers/iio/imu/inv_mpu6050/inv_mpu_core.c b/drivers/iio/imu/inv_mpu6050/inv_mpu_core.c
> index fdb48c5e5686..8fb35f37e5d2 100644
> --- a/drivers/iio/imu/inv_mpu6050/inv_mpu_core.c
> +++ b/drivers/iio/imu/inv_mpu6050/inv_mpu_core.c
> @@ -708,12 +708,12 @@ static int inv_mpu6050_read_channel_data(struct iio_dev *indio_dev,
> }
>
> pm_runtime_mark_last_busy(pdev);
> - pm_runtime_put_autosuspend(pdev);
> + __pm_runtime_put_autosuspend(pdev);
>
> return ret;
>
> error_power_off:
> - pm_runtime_put_autosuspend(pdev);
> + __pm_runtime_put_autosuspend(pdev);
> return result;
> }
>
> @@ -913,7 +913,7 @@ static int inv_mpu6050_write_raw(struct iio_dev *indio_dev,
> }
>
> pm_runtime_mark_last_busy(pdev);
> - pm_runtime_put_autosuspend(pdev);
> + __pm_runtime_put_autosuspend(pdev);
> error_write_raw_unlock:
> mutex_unlock(&st->lock);
> iio_device_release_direct_mode(indio_dev);
> @@ -1121,14 +1121,14 @@ static int inv_mpu6050_enable_wom(struct inv_mpu6050_state *st, bool en)
> }
>
> pm_runtime_mark_last_busy(pdev);
> - pm_runtime_put_autosuspend(pdev);
> + __pm_runtime_put_autosuspend(pdev);
> }
>
> return result;
>
> error_suspend:
> pm_runtime_mark_last_busy(pdev);
> - pm_runtime_put_autosuspend(pdev);
> + __pm_runtime_put_autosuspend(pdev);
> return result;
> }
>
> @@ -1227,7 +1227,7 @@ static int inv_mpu6050_write_event_value(struct iio_dev *indio_dev,
> result = inv_mpu6050_set_wom_threshold(st, value, INV_MPU6050_FREQ_DIVIDER(st));
>
> pm_runtime_mark_last_busy(pdev);
> - pm_runtime_put_autosuspend(pdev);
> + __pm_runtime_put_autosuspend(pdev);
>
> return result;
> }
> @@ -1336,7 +1336,7 @@ inv_mpu6050_fifo_rate_store(struct device *dev, struct device_attribute *attr,
>
> pm_runtime_mark_last_busy(pdev);
> fifo_rate_fail_power_off:
> - pm_runtime_put_autosuspend(pdev);
> + __pm_runtime_put_autosuspend(pdev);
> fifo_rate_fail_unlock:
> mutex_unlock(&st->lock);
> if (result)
> diff --git a/drivers/iio/imu/inv_mpu6050/inv_mpu_trigger.c b/drivers/iio/imu/inv_mpu6050/inv_mpu_trigger.c
> index 3bfeabab0ec4..e501ac9276d4 100644
> --- a/drivers/iio/imu/inv_mpu6050/inv_mpu_trigger.c
> +++ b/drivers/iio/imu/inv_mpu6050/inv_mpu_trigger.c
> @@ -196,13 +196,13 @@ static int inv_mpu6050_set_enable(struct iio_dev *indio_dev, bool enable)
> if (result)
> goto error_power_off;
> pm_runtime_mark_last_busy(pdev);
> - pm_runtime_put_autosuspend(pdev);
> + __pm_runtime_put_autosuspend(pdev);
> }
>
> return 0;
>
> error_power_off:
> - pm_runtime_put_autosuspend(pdev);
> + __pm_runtime_put_autosuspend(pdev);
> return result;
> }
>
> diff --git a/drivers/iio/imu/kmx61.c b/drivers/iio/imu/kmx61.c
> index c61c012e25bb..75942b0b95d7 100644
> --- a/drivers/iio/imu/kmx61.c
> +++ b/drivers/iio/imu/kmx61.c
> @@ -753,7 +753,7 @@ static int kmx61_set_power_state(struct kmx61_data *data, bool on, u8 device)
> ret = pm_runtime_resume_and_get(&data->client->dev);
> } else {
> pm_runtime_mark_last_busy(&data->client->dev);
> - ret = pm_runtime_put_autosuspend(&data->client->dev);
> + ret = __pm_runtime_put_autosuspend(&data->client->dev);
> }
> if (ret < 0) {
> dev_err(&data->client->dev,
> diff --git a/drivers/iio/light/apds9306.c b/drivers/iio/light/apds9306.c
> index 079e02be1005..ade25e461397 100644
> --- a/drivers/iio/light/apds9306.c
> +++ b/drivers/iio/light/apds9306.c
> @@ -538,7 +538,7 @@ static int apds9306_read_data(struct apds9306_data *data, int *val, int reg)
> *val = get_unaligned_le24(&buff);
>
> pm_runtime_mark_last_busy(data->dev);
> - pm_runtime_put_autosuspend(data->dev);
> + __pm_runtime_put_autosuspend(data->dev);
>
> return 0;
> }
> @@ -1119,7 +1119,7 @@ static int apds9306_write_event_config(struct iio_dev *indio_dev,
> return ret;
>
> pm_runtime_mark_last_busy(data->dev);
> - pm_runtime_put_autosuspend(data->dev);
> + __pm_runtime_put_autosuspend(data->dev);
>
> return 0;
> }
> @@ -1315,7 +1315,7 @@ static int apds9306_probe(struct i2c_client *client)
> if (ret)
> return dev_err_probe(dev, ret, "failed iio device registration\n");
>
> - pm_runtime_put_autosuspend(dev);
> + __pm_runtime_put_autosuspend(dev);
>
> return 0;
> }
> diff --git a/drivers/iio/light/apds9960.c b/drivers/iio/light/apds9960.c
> index 3c14e4c30805..13db160be094 100644
> --- a/drivers/iio/light/apds9960.c
> +++ b/drivers/iio/light/apds9960.c
> @@ -497,7 +497,7 @@ static int apds9960_set_power_state(struct apds9960_data *data, bool on)
> APDS9960_MAX_INT_TIME_IN_US);
> } else {
> pm_runtime_mark_last_busy(dev);
> - ret = pm_runtime_put_autosuspend(dev);
> + ret = __pm_runtime_put_autosuspend(dev);
> }
>
> mutex_unlock(&data->lock);
> @@ -910,7 +910,7 @@ static int apds9960_buffer_predisable(struct iio_dev *indio_dev)
> if (ret)
> return ret;
>
> - pm_runtime_put_autosuspend(&data->client->dev);
> + __pm_runtime_put_autosuspend(&data->client->dev);
>
> return 0;
> }
> diff --git a/drivers/iio/light/bh1780.c b/drivers/iio/light/bh1780.c
> index 475f44954f61..d22bf5f684b1 100644
> --- a/drivers/iio/light/bh1780.c
> +++ b/drivers/iio/light/bh1780.c
> @@ -112,7 +112,7 @@ static int bh1780_read_raw(struct iio_dev *indio_dev,
> if (value < 0)
> return value;
> pm_runtime_mark_last_busy(&bh1780->client->dev);
> - pm_runtime_put_autosuspend(&bh1780->client->dev);
> + __pm_runtime_put_autosuspend(&bh1780->client->dev);
> *val = value;
>
> return IIO_VAL_INT;
> diff --git a/drivers/iio/light/gp2ap002.c b/drivers/iio/light/gp2ap002.c
> index f8b1d7dd6f5f..aeaba841dbb4 100644
> --- a/drivers/iio/light/gp2ap002.c
> +++ b/drivers/iio/light/gp2ap002.c
> @@ -272,7 +272,7 @@ static int gp2ap002_read_raw(struct iio_dev *indio_dev,
>
> out:
> pm_runtime_mark_last_busy(gp2ap002->dev);
> - pm_runtime_put_autosuspend(gp2ap002->dev);
> + __pm_runtime_put_autosuspend(gp2ap002->dev);
>
> return ret;
> }
> @@ -354,7 +354,7 @@ static int gp2ap002_write_event_config(struct iio_dev *indio_dev,
> gp2ap002->enabled = true;
> } else {
> pm_runtime_mark_last_busy(gp2ap002->dev);
> - pm_runtime_put_autosuspend(gp2ap002->dev);
> + __pm_runtime_put_autosuspend(gp2ap002->dev);
> gp2ap002->enabled = false;
> }
>
> diff --git a/drivers/iio/light/isl29028.c b/drivers/iio/light/isl29028.c
> index 95bfb3ffa519..63b6fdda25ed 100644
> --- a/drivers/iio/light/isl29028.c
> +++ b/drivers/iio/light/isl29028.c
> @@ -342,7 +342,7 @@ static int isl29028_set_pm_runtime_busy(struct isl29028_chip *chip, bool on)
> ret = pm_runtime_resume_and_get(dev);
> } else {
> pm_runtime_mark_last_busy(dev);
> - ret = pm_runtime_put_autosuspend(dev);
> + ret = __pm_runtime_put_autosuspend(dev);
> }
>
> return ret;
> diff --git a/drivers/iio/light/ltrf216a.c b/drivers/iio/light/ltrf216a.c
> index 37eecff571b9..228f03c7f192 100644
> --- a/drivers/iio/light/ltrf216a.c
> +++ b/drivers/iio/light/ltrf216a.c
> @@ -209,7 +209,7 @@ static int ltrf216a_set_power_state(struct ltrf216a_data *data, bool on)
> }
> } else {
> pm_runtime_mark_last_busy(dev);
> - pm_runtime_put_autosuspend(dev);
> + __pm_runtime_put_autosuspend(dev);
> }
>
> return ret;
> diff --git a/drivers/iio/light/pa12203001.c b/drivers/iio/light/pa12203001.c
> index b920bf82c102..38313e712e65 100644
> --- a/drivers/iio/light/pa12203001.c
> +++ b/drivers/iio/light/pa12203001.c
> @@ -190,7 +190,7 @@ static int pa12203001_set_power_state(struct pa12203001_data *data, bool on,
>
> } else {
> pm_runtime_mark_last_busy(&data->client->dev);
> - ret = pm_runtime_put_autosuspend(&data->client->dev);
> + ret = __pm_runtime_put_autosuspend(&data->client->dev);
> }
>
> return ret;
> diff --git a/drivers/iio/light/rpr0521.c b/drivers/iio/light/rpr0521.c
> index 78c08e0bd077..2010b6387be7 100644
> --- a/drivers/iio/light/rpr0521.c
> +++ b/drivers/iio/light/rpr0521.c
> @@ -363,7 +363,7 @@ static int rpr0521_set_power_state(struct rpr0521_data *data, bool on,
> ret = pm_runtime_resume_and_get(&data->client->dev);
> } else {
> pm_runtime_mark_last_busy(&data->client->dev);
> - ret = pm_runtime_put_autosuspend(&data->client->dev);
> + ret = __pm_runtime_put_autosuspend(&data->client->dev);
> }
> if (ret < 0) {
> dev_err(&data->client->dev,
> diff --git a/drivers/iio/light/tsl2583.c b/drivers/iio/light/tsl2583.c
> index 02ad11611b9c..d41fd79e724c 100644
> --- a/drivers/iio/light/tsl2583.c
> +++ b/drivers/iio/light/tsl2583.c
> @@ -647,7 +647,7 @@ static int tsl2583_set_pm_runtime_busy(struct tsl2583_chip *chip, bool on)
> ret = pm_runtime_resume_and_get(&chip->client->dev);
> } else {
> pm_runtime_mark_last_busy(&chip->client->dev);
> - ret = pm_runtime_put_autosuspend(&chip->client->dev);
> + ret = __pm_runtime_put_autosuspend(&chip->client->dev);
> }
>
> return ret;
> diff --git a/drivers/iio/light/tsl2591.c b/drivers/iio/light/tsl2591.c
> index 850c2465992f..43adaffe1400 100644
> --- a/drivers/iio/light/tsl2591.c
> +++ b/drivers/iio/light/tsl2591.c
> @@ -773,7 +773,7 @@ static int tsl2591_read_raw(struct iio_dev *indio_dev,
> mutex_unlock(&chip->als_mutex);
>
> pm_runtime_mark_last_busy(&client->dev);
> - pm_runtime_put_autosuspend(&client->dev);
> + __pm_runtime_put_autosuspend(&client->dev);
>
> return ret;
> }
> @@ -996,7 +996,7 @@ static int tsl2591_write_event_config(struct iio_dev *indio_dev,
> } else if (!state && chip->events_enabled) {
> chip->events_enabled = false;
> pm_runtime_mark_last_busy(&client->dev);
> - pm_runtime_put_autosuspend(&client->dev);
> + __pm_runtime_put_autosuspend(&client->dev);
> }
>
> return 0;
> diff --git a/drivers/iio/light/us5182d.c b/drivers/iio/light/us5182d.c
> index de6967ac3b0b..901288236d38 100644
> --- a/drivers/iio/light/us5182d.c
> +++ b/drivers/iio/light/us5182d.c
> @@ -370,7 +370,7 @@ static int us5182d_set_power_state(struct us5182d_data *data, bool on)
> ret = pm_runtime_resume_and_get(&data->client->dev);
> } else {
> pm_runtime_mark_last_busy(&data->client->dev);
> - ret = pm_runtime_put_autosuspend(&data->client->dev);
> + ret = __pm_runtime_put_autosuspend(&data->client->dev);
> }
>
> return ret;
> diff --git a/drivers/iio/light/vcnl4000.c b/drivers/iio/light/vcnl4000.c
> index 4e3641ff2ed4..2877880897e4 100644
> --- a/drivers/iio/light/vcnl4000.c
> +++ b/drivers/iio/light/vcnl4000.c
> @@ -582,7 +582,7 @@ static int vcnl4000_set_pm_runtime_state(struct vcnl4000_data *data, bool on)
> ret = pm_runtime_resume_and_get(dev);
> } else {
> pm_runtime_mark_last_busy(dev);
> - ret = pm_runtime_put_autosuspend(dev);
> + ret = __pm_runtime_put_autosuspend(dev);
> }
>
> return ret;
> diff --git a/drivers/iio/light/vcnl4035.c b/drivers/iio/light/vcnl4035.c
> index 337a1332c2c6..a7393255f6ac 100644
> --- a/drivers/iio/light/vcnl4035.c
> +++ b/drivers/iio/light/vcnl4035.c
> @@ -150,7 +150,7 @@ static int vcnl4035_set_pm_runtime_state(struct vcnl4035_data *data, bool on)
> ret = pm_runtime_resume_and_get(dev);
> } else {
> pm_runtime_mark_last_busy(dev);
> - ret = pm_runtime_put_autosuspend(dev);
> + ret = __pm_runtime_put_autosuspend(dev);
> }
>
> return ret;
> diff --git a/drivers/iio/magnetometer/af8133j.c b/drivers/iio/magnetometer/af8133j.c
> index d81d89af6283..f0530854698d 100644
> --- a/drivers/iio/magnetometer/af8133j.c
> +++ b/drivers/iio/magnetometer/af8133j.c
> @@ -235,7 +235,7 @@ static int af8133j_read_measurement(struct af8133j_data *data, __le16 buf[3])
>
> out_rpm_put:
> pm_runtime_mark_last_busy(dev);
> - pm_runtime_put_autosuspend(dev);
> + __pm_runtime_put_autosuspend(dev);
>
> return ret;
> }
> @@ -454,7 +454,7 @@ static int af8133j_probe(struct i2c_client *client)
> if (ret)
> return ret;
>
> - pm_runtime_put_autosuspend(dev);
> + __pm_runtime_put_autosuspend(dev);
>
> indio_dev->info = &af8133j_info;
> indio_dev->name = "af8133j";
> diff --git a/drivers/iio/magnetometer/ak8974.c b/drivers/iio/magnetometer/ak8974.c
> index 8306a18706ac..eed25cd701f0 100644
> --- a/drivers/iio/magnetometer/ak8974.c
> +++ b/drivers/iio/magnetometer/ak8974.c
> @@ -584,7 +584,7 @@ static int ak8974_measure_channel(struct ak8974 *ak8974, unsigned long address,
> out_unlock:
> mutex_unlock(&ak8974->lock);
> pm_runtime_mark_last_busy(&ak8974->i2c->dev);
> - pm_runtime_put_autosuspend(&ak8974->i2c->dev);
> + __pm_runtime_put_autosuspend(&ak8974->i2c->dev);
>
> return ret;
> }
> @@ -679,7 +679,7 @@ static void ak8974_fill_buffer(struct iio_dev *indio_dev)
> out_unlock:
> mutex_unlock(&ak8974->lock);
> pm_runtime_mark_last_busy(&ak8974->i2c->dev);
> - pm_runtime_put_autosuspend(&ak8974->i2c->dev);
> + __pm_runtime_put_autosuspend(&ak8974->i2c->dev);
> }
>
> static irqreturn_t ak8974_handle_trigger(int irq, void *p)
> diff --git a/drivers/iio/magnetometer/ak8975.c b/drivers/iio/magnetometer/ak8975.c
> index 18077fb463a9..b637385f9d26 100644
> --- a/drivers/iio/magnetometer/ak8975.c
> +++ b/drivers/iio/magnetometer/ak8975.c
> @@ -776,7 +776,7 @@ static int ak8975_read_axis(struct iio_dev *indio_dev, int index, int *val)
> mutex_unlock(&data->lock);
>
> pm_runtime_mark_last_busy(&data->client->dev);
> - pm_runtime_put_autosuspend(&data->client->dev);
> + __pm_runtime_put_autosuspend(&data->client->dev);
>
> /* Swap bytes and convert to valid range. */
> buff = le16_to_cpu(rval);
> diff --git a/drivers/iio/magnetometer/bmc150_magn.c b/drivers/iio/magnetometer/bmc150_magn.c
> index 06d5a1ef1fbd..26dc68e4270d 100644
> --- a/drivers/iio/magnetometer/bmc150_magn.c
> +++ b/drivers/iio/magnetometer/bmc150_magn.c
> @@ -268,7 +268,7 @@ static int bmc150_magn_set_power_state(struct bmc150_magn_data *data, bool on)
> ret = pm_runtime_resume_and_get(data->dev);
> } else {
> pm_runtime_mark_last_busy(data->dev);
> - ret = pm_runtime_put_autosuspend(data->dev);
> + ret = __pm_runtime_put_autosuspend(data->dev);
> }
>
> if (ret < 0) {
> diff --git a/drivers/iio/magnetometer/tmag5273.c b/drivers/iio/magnetometer/tmag5273.c
> index 4187abe12784..bec579b7c6c6 100644
> --- a/drivers/iio/magnetometer/tmag5273.c
> +++ b/drivers/iio/magnetometer/tmag5273.c
> @@ -296,7 +296,7 @@ static int tmag5273_read_raw(struct iio_dev *indio_dev,
> ret = tmag5273_get_measure(data, &t, &x, &y, &z, &angle, &magnitude);
>
> pm_runtime_mark_last_busy(data->dev);
> - pm_runtime_put_autosuspend(data->dev);
> + __pm_runtime_put_autosuspend(data->dev);
>
> if (ret)
> return ret;
> @@ -669,7 +669,7 @@ static int tmag5273_probe(struct i2c_client *i2c)
> indio_dev->num_channels = ARRAY_SIZE(tmag5273_channels);
>
> pm_runtime_mark_last_busy(dev);
> - pm_runtime_put_autosuspend(dev);
> + __pm_runtime_put_autosuspend(dev);
>
> ret = devm_iio_device_register(dev, indio_dev);
> if (ret)
> diff --git a/drivers/iio/magnetometer/yamaha-yas530.c b/drivers/iio/magnetometer/yamaha-yas530.c
> index 65011a8598d3..62df8b91df3a 100644
> --- a/drivers/iio/magnetometer/yamaha-yas530.c
> +++ b/drivers/iio/magnetometer/yamaha-yas530.c
> @@ -623,7 +623,7 @@ static int yas5xx_read_raw(struct iio_dev *indio_dev,
> pm_runtime_get_sync(yas5xx->dev);
> ret = ci->get_measure(yas5xx, &t, &x, &y, &z);
> pm_runtime_mark_last_busy(yas5xx->dev);
> - pm_runtime_put_autosuspend(yas5xx->dev);
> + __pm_runtime_put_autosuspend(yas5xx->dev);
> if (ret)
> return ret;
> switch (chan->address) {
> @@ -664,7 +664,7 @@ static void yas5xx_fill_buffer(struct iio_dev *indio_dev)
> pm_runtime_get_sync(yas5xx->dev);
> ret = ci->get_measure(yas5xx, &t, &x, &y, &z);
> pm_runtime_mark_last_busy(yas5xx->dev);
> - pm_runtime_put_autosuspend(yas5xx->dev);
> + __pm_runtime_put_autosuspend(yas5xx->dev);
> if (ret) {
> dev_err(yas5xx->dev, "error refilling buffer\n");
> return;
> diff --git a/drivers/iio/pressure/bmp280-core.c b/drivers/iio/pressure/bmp280-core.c
> index ca4915c9a394..806933baeffd 100644
> --- a/drivers/iio/pressure/bmp280-core.c
> +++ b/drivers/iio/pressure/bmp280-core.c
> @@ -729,7 +729,7 @@ static int bmp280_read_raw(struct iio_dev *indio_dev,
> pm_runtime_get_sync(data->dev);
> ret = bmp280_read_raw_impl(indio_dev, chan, val, val2, mask);
> pm_runtime_mark_last_busy(data->dev);
> - pm_runtime_put_autosuspend(data->dev);
> + __pm_runtime_put_autosuspend(data->dev);
>
> return ret;
> }
> @@ -904,7 +904,7 @@ static int bmp280_write_raw(struct iio_dev *indio_dev,
> pm_runtime_get_sync(data->dev);
> ret = bmp280_write_raw_impl(indio_dev, chan, val, val2, mask);
> pm_runtime_mark_last_busy(data->dev);
> - pm_runtime_put_autosuspend(data->dev);
> + __pm_runtime_put_autosuspend(data->dev);
>
> return ret;
> }
> @@ -1960,7 +1960,7 @@ static int bmp580_nvmem_read(void *priv, unsigned int offset, void *val,
> pm_runtime_get_sync(data->dev);
> ret = bmp580_nvmem_read_impl(priv, offset, val, bytes);
> pm_runtime_mark_last_busy(data->dev);
> - pm_runtime_put_autosuspend(data->dev);
> + __pm_runtime_put_autosuspend(data->dev);
>
> return ret;
> }
> @@ -2035,7 +2035,7 @@ static int bmp580_nvmem_write(void *priv, unsigned int offset, void *val,
> pm_runtime_get_sync(data->dev);
> ret = bmp580_nvmem_write_impl(priv, offset, val, bytes);
> pm_runtime_mark_last_busy(data->dev);
> - pm_runtime_put_autosuspend(data->dev);
> + __pm_runtime_put_autosuspend(data->dev);
>
> return ret;
> }
> @@ -2641,7 +2641,7 @@ static int bmp280_buffer_postdisable(struct iio_dev *indio_dev)
> struct bmp280_data *data = iio_priv(indio_dev);
>
> pm_runtime_mark_last_busy(data->dev);
> - pm_runtime_put_autosuspend(data->dev);
> + __pm_runtime_put_autosuspend(data->dev);
>
> return 0;
> }
> diff --git a/drivers/iio/pressure/icp10100.c b/drivers/iio/pressure/icp10100.c
> index 3e0bf5d31ad7..866381bb1452 100644
> --- a/drivers/iio/pressure/icp10100.c
> +++ b/drivers/iio/pressure/icp10100.c
> @@ -267,7 +267,7 @@ static int icp10100_get_measures(struct icp10100_state *st,
>
> pm_runtime_mark_last_busy(&st->client->dev);
> error_measure:
> - pm_runtime_put_autosuspend(&st->client->dev);
> + __pm_runtime_put_autosuspend(&st->client->dev);
> return ret;
> }
>
> diff --git a/drivers/iio/pressure/mpl115.c b/drivers/iio/pressure/mpl115.c
> index 02ea38c8a3e4..70b711b16e52 100644
> --- a/drivers/iio/pressure/mpl115.c
> +++ b/drivers/iio/pressure/mpl115.c
> @@ -109,7 +109,7 @@ static int mpl115_read_raw(struct iio_dev *indio_dev,
> if (ret < 0)
> return ret;
> pm_runtime_mark_last_busy(data->dev);
> - pm_runtime_put_autosuspend(data->dev);
> + __pm_runtime_put_autosuspend(data->dev);
>
> return IIO_VAL_INT_PLUS_MICRO;
> case IIO_CHAN_INFO_RAW:
> @@ -119,7 +119,7 @@ static int mpl115_read_raw(struct iio_dev *indio_dev,
> if (ret < 0)
> return ret;
> pm_runtime_mark_last_busy(data->dev);
> - pm_runtime_put_autosuspend(data->dev);
> + __pm_runtime_put_autosuspend(data->dev);
> *val = ret >> 6;
>
> return IIO_VAL_INT;
> diff --git a/drivers/iio/pressure/zpa2326.c b/drivers/iio/pressure/zpa2326.c
> index 950f8dee2b26..7274855d0297 100644
> --- a/drivers/iio/pressure/zpa2326.c
> +++ b/drivers/iio/pressure/zpa2326.c
> @@ -698,7 +698,7 @@ static void zpa2326_suspend(struct iio_dev *indio_dev)
> zpa2326_sleep(indio_dev);
>
> pm_runtime_mark_last_busy(parent);
> - pm_runtime_put_autosuspend(parent);
> + __pm_runtime_put_autosuspend(parent);
> }
>
> static void zpa2326_init_runtime(struct device *parent)
> @@ -709,7 +709,7 @@ static void zpa2326_init_runtime(struct device *parent)
> pm_runtime_set_autosuspend_delay(parent, 1000);
> pm_runtime_use_autosuspend(parent);
> pm_runtime_mark_last_busy(parent);
> - pm_runtime_put_autosuspend(parent);
> + __pm_runtime_put_autosuspend(parent);
> }
>
> static void zpa2326_fini_runtime(struct device *parent)
> diff --git a/drivers/iio/proximity/pulsedlight-lidar-lite-v2.c b/drivers/iio/proximity/pulsedlight-lidar-lite-v2.c
> index 5c959730aecd..6be27497d6e3 100644
> --- a/drivers/iio/proximity/pulsedlight-lidar-lite-v2.c
> +++ b/drivers/iio/proximity/pulsedlight-lidar-lite-v2.c
> @@ -192,7 +192,7 @@ static int lidar_get_measurement(struct lidar_data *data, u16 *reg)
> ret = -EIO;
> }
> pm_runtime_mark_last_busy(&client->dev);
> - pm_runtime_put_autosuspend(&client->dev);
> + __pm_runtime_put_autosuspend(&client->dev);
>
> return ret;
> }
> diff --git a/drivers/iio/proximity/srf04.c b/drivers/iio/proximity/srf04.c
> index 86c57672fc7e..ecea2671ce62 100644
> --- a/drivers/iio/proximity/srf04.c
> +++ b/drivers/iio/proximity/srf04.c
> @@ -119,7 +119,7 @@ static int srf04_read(struct srf04_data *data)
>
> if (data->gpiod_power) {
> pm_runtime_mark_last_busy(data->dev);
> - pm_runtime_put_autosuspend(data->dev);
> + __pm_runtime_put_autosuspend(data->dev);
> }
>
> /* it should not take more than 20 ms until echo is rising */
> diff --git a/drivers/iio/temperature/mlx90614.c b/drivers/iio/temperature/mlx90614.c
> index 740018d4b3df..22bed79589d1 100644
> --- a/drivers/iio/temperature/mlx90614.c
> +++ b/drivers/iio/temperature/mlx90614.c
> @@ -212,7 +212,7 @@ static int mlx90614_power_get(struct mlx90614_data *data, bool startup)
> if (time_before(now, data->ready_timestamp) &&
> msleep_interruptible(jiffies_to_msecs(
> data->ready_timestamp - now)) != 0) {
> - pm_runtime_put_autosuspend(&data->client->dev);
> + __pm_runtime_put_autosuspend(&data->client->dev);
> return -EINTR;
> }
> }
> @@ -226,7 +226,7 @@ static void mlx90614_power_put(struct mlx90614_data *data)
> return;
>
> pm_runtime_mark_last_busy(&data->client->dev);
> - pm_runtime_put_autosuspend(&data->client->dev);
> + __pm_runtime_put_autosuspend(&data->client->dev);
> }
> #else
> static inline int mlx90614_power_get(struct mlx90614_data *data, bool startup)
> diff --git a/drivers/iio/temperature/mlx90632.c b/drivers/iio/temperature/mlx90632.c
> index ae4ea587e7f9..c8cea6a4f390 100644
> --- a/drivers/iio/temperature/mlx90632.c
> +++ b/drivers/iio/temperature/mlx90632.c
> @@ -1044,7 +1044,7 @@ static int mlx90632_read_raw(struct iio_dev *indio_dev,
>
> mlx90632_read_raw_pm:
> pm_runtime_mark_last_busy(&data->client->dev);
> - pm_runtime_put_autosuspend(&data->client->dev);
> + __pm_runtime_put_autosuspend(&data->client->dev);
> return ret;
> }
>
> @@ -1273,7 +1273,7 @@ static int mlx90632_probe(struct i2c_client *client)
>
> pm_runtime_set_autosuspend_delay(&client->dev, MLX90632_SLEEP_DELAY_MS);
> pm_runtime_use_autosuspend(&client->dev);
> - pm_runtime_put_autosuspend(&client->dev);
> + __pm_runtime_put_autosuspend(&client->dev);
>
> return devm_iio_device_register(&client->dev, indio_dev);
> }
> diff --git a/drivers/iio/temperature/mlx90635.c b/drivers/iio/temperature/mlx90635.c
> index f7f88498ba0e..77ea81aa5c9e 100644
> --- a/drivers/iio/temperature/mlx90635.c
> +++ b/drivers/iio/temperature/mlx90635.c
> @@ -750,7 +750,7 @@ static int mlx90635_read_raw(struct iio_dev *indio_dev,
>
> mlx90635_read_raw_pm:
> pm_runtime_mark_last_busy(&data->client->dev);
> - pm_runtime_put_autosuspend(&data->client->dev);
> + __pm_runtime_put_autosuspend(&data->client->dev);
> return ret;
> }
>
> @@ -1023,7 +1023,7 @@ static int mlx90635_probe(struct i2c_client *client)
>
> pm_runtime_set_autosuspend_delay(&client->dev, MLX90635_SLEEP_DELAY_MS);
> pm_runtime_use_autosuspend(&client->dev);
> - pm_runtime_put_autosuspend(&client->dev);
> + __pm_runtime_put_autosuspend(&client->dev);
>
> return devm_iio_device_register(&client->dev, indio_dev);
> }
^ permalink raw reply [flat|nested] 14+ messages in thread
* Re: [PATCH 00/51] treewide: Switch to __pm_runtime_put_autosuspend()
2024-10-04 9:41 [PATCH 00/51] treewide: Switch to __pm_runtime_put_autosuspend() Sakari Ailus
2024-10-04 9:41 ` [PATCH 19/51] iio: " Sakari Ailus
@ 2024-10-04 14:38 ` Ulf Hansson
2024-10-07 18:49 ` Laurent Pinchart
1 sibling, 1 reply; 14+ messages in thread
From: Ulf Hansson @ 2024-10-04 14:38 UTC (permalink / raw)
To: Sakari Ailus
Cc: dri-devel, linux-kernel, linux-bluetooth, linux-clk, linux-crypto,
dmaengine, linux-gpio, amd-gfx, nouveau, linux-stm32,
linux-arm-kernel, linux-i2c, linux-i3c, linux-iio, linux-input,
patches, iommu, imx, linux-mediatek, linux-media, linux-mmc,
linux-mtd, netdev, linux-wireless, linux-pci, linux-phy,
linux-pwm, linux-remoteproc, linux-sound, linux-spi,
linux-staging, linux-usb, linux-serial, greybus-dev, asahi,
laurent.pinchart, rafael, Andy Shevchenko
On Fri, 4 Oct 2024 at 11:41, Sakari Ailus <sakari.ailus@linux.intel.com> wrote:
>
> Hello everyone,
>
> This set will switch the users of pm_runtime_put_autosuspend() to
> __pm_runtime_put_autosuspend() while the former will soon be re-purposed
> to include a call to pm_runtime_mark_last_busy(). The two are almost
> always used together, apart from bugs which are likely common. Going
> forward, most new users should be using pm_runtime_put_autosuspend().
>
> Once this conversion is done and pm_runtime_put_autosuspend() re-purposed,
> I'll post another set to merge the calls to __pm_runtime_put_autosuspend()
> and pm_runtime_mark_last_busy().
That sounds like it could cause a lot of churns.
Why not add a new helper function that does the
pm_runtime_put_autosuspend() and the pm_runtime_mark_last_busy()
things? Then we can start moving users over to this new interface,
rather than having this intermediate step?
Kind regards
Uffe
>
> The diff in these patches have been generated using the following
> Coccinelle script (besides a manual change in
> drivers/iio/magnetometer/af8133j.c):
>
> ----------8<-------------------
> @@
> expression E1;
>
> @@
>
> - pm_runtime_put_autosuspend(E1)
> + __pm_runtime_put_autosuspend(E1)
> ----------8<-------------------
>
> These patches are on top of today's linux-next (i.e. next-20241004).
>
> Sakari Ailus (51):
> accel/ivpu: Switch to __pm_runtime_put_autosuspend()
> bluetooth: Switch to __pm_runtime_put_autosuspend()
> bus: sunxi-rsb: Switch to __pm_runtime_put_autosuspend()
> hwrng: Switch to __pm_runtime_put_autosuspend()
> clk: Switch to __pm_runtime_put_autosuspend()
> crypto: Switch to __pm_runtime_put_autosuspend()
> dmaengine: Switch to __pm_runtime_put_autosuspend()
> gpio: Switch to __pm_runtime_put_autosuspend()
> drm/amd: Switch to __pm_runtime_put_autosuspend()
> drm/nouveau: Switch to __pm_runtime_put_autosuspend()
> drm/radeon: Switch to __pm_runtime_put_autosuspend()
> drm/panfrost: Switch to __pm_runtime_put_autosuspend()
> drivers: drm: Switch to __pm_runtime_put_autosuspend()
> HSI: omap_ssi_port: Switch to __pm_runtime_put_autosuspend()
> stm class: Switch to __pm_runtime_put_autosuspend()
> i2c: Switch to __pm_runtime_put_autosuspend()
> i3c: master: svc: Switch to __pm_runtime_put_autosuspend()
> i3c: dw: Switch to __pm_runtime_put_autosuspend()
> iio: Switch to __pm_runtime_put_autosuspend()
> Input: omap4-keypad: Switch to __pm_runtime_put_autosuspend()
> Input: cs40l50: Switch to __pm_runtime_put_autosuspend()
> iommu/arm-smmu: Switch to __pm_runtime_put_autosuspend()
> irqchip/imx-irqsteer: Switch to __pm_runtime_put_autosuspend()
> mailbox: mtk-cmdq-mailbox: Switch to __pm_runtime_put_autosuspend()
> media: Switch to __pm_runtime_put_autosuspend()
> mfd: Switch to __pm_runtime_put_autosuspend()
> mei: Switch to __pm_runtime_put_autosuspend()
> mmc: Switch to __pm_runtime_put_autosuspend()
> mtd: rawnand: gpmi: Switch to __pm_runtime_put_autosuspend()
> net: Switch to __pm_runtime_put_autosuspend()
> nfc: trf7970a: Switch to __pm_runtime_put_autosuspend()
> PCI/portdrv: Switch to __pm_runtime_put_autosuspend()
> phy: motorola: phy-mapphone-mdm6600: Switch to
> __pm_runtime_put_autosuspend()
> phy: ti: phy-twl4030-usb: Switch to __pm_runtime_put_autosuspend()
> power: Switch to __pm_runtime_put_autosuspend()
> pwm: img: Switch to __pm_runtime_put_autosuspend()
> regulator: stm32-vrefbuf: Switch to __pm_runtime_put_autosuspend()
> remoteproc: omap: Switch to __pm_runtime_put_autosuspend()
> slimbus: Switch to __pm_runtime_put_autosuspend()
> soundwire: Switch to __pm_runtime_put_autosuspend()
> spi: Switch to __pm_runtime_put_autosuspend()
> staging: Switch to __pm_runtime_put_autosuspend()
> thunderbolt: Switch to __pm_runtime_put_autosuspend()
> serial: Switch to __pm_runtime_put_autosuspend()
> usb: Switch to __pm_runtime_put_autosuspend()
> w1: omap-hdq: Switch to __pm_runtime_put_autosuspend()
> staging: greybus: Switch to __pm_runtime_put_autosuspend()
> ALSA: hda: Switch to __pm_runtime_put_autosuspend()
> ASoC: Switch to __pm_runtime_put_autosuspend()
> ALSA: intel_hdmi: Switch to __pm_runtime_put_autosuspend()
> soc: apple: mailbox: Switch to __pm_runtime_put_autosuspend()
>
> drivers/accel/ivpu/ivpu_drv.c | 2 +-
> drivers/accel/ivpu/ivpu_pm.c | 8 +-
> drivers/bluetooth/btmtksdio.c | 2 +-
> drivers/bluetooth/hci_bcm.c | 6 +-
> drivers/bluetooth/hci_h5.c | 4 +-
> drivers/bluetooth/hci_intel.c | 6 +-
> drivers/bus/sunxi-rsb.c | 4 +-
> drivers/char/hw_random/cctrng.c | 2 +-
> drivers/char/hw_random/omap3-rom-rng.c | 2 +-
> drivers/clk/imx/clk-imx8qxp-lpcg.c | 2 +-
> drivers/clk/imx/clk-scu.c | 2 +-
> drivers/clk/qcom/lpassaudiocc-sc7280.c | 4 +-
> drivers/clk/qcom/lpasscorecc-sc7180.c | 4 +-
> drivers/crypto/ccree/cc_pm.c | 2 +-
> drivers/crypto/hisilicon/qm.c | 2 +-
> drivers/crypto/omap-aes-gcm.c | 2 +-
> drivers/crypto/omap-aes.c | 2 +-
> drivers/crypto/omap-des.c | 2 +-
> drivers/crypto/omap-sham.c | 2 +-
> drivers/crypto/rockchip/rk3288_crypto_ahash.c | 2 +-
> .../crypto/rockchip/rk3288_crypto_skcipher.c | 2 +-
> drivers/crypto/stm32/stm32-crc32.c | 4 +-
> drivers/crypto/stm32/stm32-cryp.c | 2 +-
> drivers/crypto/stm32/stm32-hash.c | 2 +-
> drivers/dma/at_xdmac.c | 24 +--
> drivers/dma/pl330.c | 14 +-
> drivers/dma/qcom/bam_dma.c | 10 +-
> drivers/dma/qcom/hidma.c | 18 +-
> drivers/dma/qcom/hidma_dbg.c | 2 +-
> drivers/dma/qcom/hidma_mgmt.c | 4 +-
> drivers/dma/ste_dma40.c | 16 +-
> drivers/dma/ti/cppi41.c | 10 +-
> drivers/dma/xilinx/zynqmp_dma.c | 2 +-
> drivers/gpio/gpio-arizona.c | 10 +-
> drivers/gpio/gpio-mxc.c | 2 +-
> drivers/gpu/drm/amd/amdgpu/amdgpu_acpi.c | 2 +-
> .../gpu/drm/amd/amdgpu/amdgpu_connectors.c | 16 +-
> drivers/gpu/drm/amd/amdgpu/amdgpu_debugfs.c | 120 ++++++------
> drivers/gpu/drm/amd/amdgpu/amdgpu_display.c | 2 +-
> drivers/gpu/drm/amd/amdgpu/amdgpu_drv.c | 6 +-
> drivers/gpu/drm/amd/amdgpu/amdgpu_fence.c | 6 +-
> drivers/gpu/drm/amd/amdgpu/amdgpu_gfx.c | 4 +-
> drivers/gpu/drm/amd/amdgpu/amdgpu_kms.c | 4 +-
> drivers/gpu/drm/amd/amdgpu/amdgpu_rap.c | 4 +-
> drivers/gpu/drm/amd/amdgpu/amdgpu_ras.c | 2 +-
> .../gpu/drm/amd/amdgpu/amdgpu_securedisplay.c | 4 +-
> drivers/gpu/drm/amd/amdkfd/kfd_process.c | 4 +-
> .../gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c | 2 +-
> drivers/gpu/drm/amd/pm/amdgpu_pm.c | 178 +++++++++---------
> .../drm/bridge/analogix/analogix_dp_core.c | 2 +-
> drivers/gpu/drm/bridge/analogix/anx7625.c | 4 +-
> drivers/gpu/drm/bridge/parade-ps8640.c | 4 +-
> drivers/gpu/drm/bridge/ti-sn65dsi86.c | 14 +-
> drivers/gpu/drm/etnaviv/etnaviv_gpu.c | 12 +-
> drivers/gpu/drm/exynos/exynos_drm_fimc.c | 4 +-
> drivers/gpu/drm/exynos/exynos_drm_g2d.c | 4 +-
> drivers/gpu/drm/exynos/exynos_drm_gsc.c | 6 +-
> drivers/gpu/drm/exynos/exynos_drm_rotator.c | 2 +-
> drivers/gpu/drm/exynos/exynos_drm_scaler.c | 2 +-
> drivers/gpu/drm/i915/intel_runtime_pm.c | 4 +-
> drivers/gpu/drm/imx/dcss/dcss-crtc.c | 2 +-
> drivers/gpu/drm/lima/lima_sched.c | 2 +-
> drivers/gpu/drm/msm/adreno/adreno_device.c | 2 +-
> drivers/gpu/drm/msm/adreno/adreno_gpu.c | 2 +-
> drivers/gpu/drm/msm/msm_gpu.c | 2 +-
> drivers/gpu/drm/msm/msm_iommu.c | 4 +-
> drivers/gpu/drm/msm/msm_submitqueue.c | 2 +-
> drivers/gpu/drm/nouveau/dispnv50/disp.c | 10 +-
> drivers/gpu/drm/nouveau/nouveau_connector.c | 4 +-
> drivers/gpu/drm/nouveau/nouveau_debugfs.c | 8 +-
> drivers/gpu/drm/nouveau/nouveau_display.c | 4 +-
> drivers/gpu/drm/nouveau/nouveau_drm.c | 10 +-
> drivers/gpu/drm/nouveau/nouveau_gem.c | 10 +-
> drivers/gpu/drm/panel/panel-edp.c | 8 +-
> .../gpu/drm/panel/panel-samsung-atna33xc20.c | 6 +-
> drivers/gpu/drm/panel/panel-simple.c | 6 +-
> drivers/gpu/drm/panfrost/panfrost_job.c | 4 +-
> drivers/gpu/drm/panfrost/panfrost_mmu.c | 4 +-
> drivers/gpu/drm/panfrost/panfrost_perfcnt.c | 4 +-
> drivers/gpu/drm/panthor/panthor_device.c | 2 +-
> drivers/gpu/drm/panthor/panthor_sched.c | 6 +-
> drivers/gpu/drm/radeon/radeon_acpi.c | 2 +-
> drivers/gpu/drm/radeon/radeon_connectors.c | 20 +-
> drivers/gpu/drm/radeon/radeon_display.c | 6 +-
> drivers/gpu/drm/radeon/radeon_drv.c | 4 +-
> drivers/gpu/drm/radeon/radeon_fbdev.c | 4 +-
> drivers/gpu/drm/radeon/radeon_kms.c | 10 +-
> drivers/gpu/drm/tegra/submit.c | 2 +-
> drivers/gpu/drm/tidss/tidss_drv.c | 2 +-
> drivers/gpu/drm/vc4/vc4_v3d.c | 2 +-
> drivers/hsi/controllers/omap_ssi_port.c | 42 ++---
> drivers/hwtracing/stm/core.c | 8 +-
> drivers/i2c/busses/i2c-amd-mp2-pci.c | 2 +-
> drivers/i2c/busses/i2c-amd-mp2.h | 2 +-
> drivers/i2c/busses/i2c-at91-master.c | 2 +-
> drivers/i2c/busses/i2c-cadence.c | 2 +-
> drivers/i2c/busses/i2c-davinci.c | 4 +-
> drivers/i2c/busses/i2c-designware-master.c | 2 +-
> drivers/i2c/busses/i2c-designware-pcidrv.c | 2 +-
> drivers/i2c/busses/i2c-hix5hd2.c | 2 +-
> drivers/i2c/busses/i2c-i801.c | 4 +-
> drivers/i2c/busses/i2c-img-scb.c | 6 +-
> drivers/i2c/busses/i2c-imx-lpi2c.c | 6 +-
> drivers/i2c/busses/i2c-imx.c | 4 +-
> drivers/i2c/busses/i2c-mv64xxx.c | 2 +-
> drivers/i2c/busses/i2c-nvidia-gpu.c | 4 +-
> drivers/i2c/busses/i2c-omap.c | 6 +-
> drivers/i2c/busses/i2c-qcom-cci.c | 2 +-
> drivers/i2c/busses/i2c-qcom-geni.c | 2 +-
> drivers/i2c/busses/i2c-qup.c | 4 +-
> drivers/i2c/busses/i2c-riic.c | 4 +-
> drivers/i2c/busses/i2c-rzv2m.c | 2 +-
> drivers/i2c/busses/i2c-sprd.c | 4 +-
> drivers/i2c/busses/i2c-stm32f7.c | 10 +-
> drivers/i2c/busses/i2c-xiic.c | 2 +-
> drivers/i3c/master/dw-i3c-master.c | 16 +-
> drivers/i3c/master/svc-i3c-master.c | 16 +-
> drivers/iio/accel/bmc150-accel-core.c | 2 +-
> drivers/iio/accel/bmi088-accel-core.c | 6 +-
> drivers/iio/accel/fxls8962af-core.c | 2 +-
> drivers/iio/accel/kxcjk-1013.c | 2 +-
> drivers/iio/accel/kxsd9.c | 6 +-
> drivers/iio/accel/mma8452.c | 2 +-
> drivers/iio/accel/mma9551_core.c | 2 +-
> drivers/iio/accel/msa311.c | 12 +-
> drivers/iio/adc/ab8500-gpadc.c | 2 +-
> drivers/iio/adc/at91-sama5d2_adc.c | 20 +-
> drivers/iio/adc/rcar-gyroadc.c | 2 +-
> drivers/iio/adc/stm32-adc-core.c | 2 +-
> drivers/iio/adc/stm32-adc.c | 12 +-
> drivers/iio/adc/sun4i-gpadc-iio.c | 4 +-
> drivers/iio/adc/ti-ads1015.c | 2 +-
> drivers/iio/adc/ti-ads1100.c | 2 +-
> drivers/iio/adc/ti-ads1119.c | 4 +-
> drivers/iio/chemical/atlas-sensor.c | 4 +-
> .../common/hid-sensors/hid-sensor-trigger.c | 2 +-
> drivers/iio/dac/stm32-dac.c | 6 +-
> drivers/iio/gyro/bmg160_core.c | 2 +-
> drivers/iio/gyro/fxas21002c_core.c | 2 +-
> drivers/iio/gyro/mpu3050-core.c | 6 +-
> drivers/iio/gyro/mpu3050-i2c.c | 2 +-
> .../iio/imu/inv_icm42600/inv_icm42600_accel.c | 10 +-
> .../imu/inv_icm42600/inv_icm42600_buffer.c | 2 +-
> .../iio/imu/inv_icm42600/inv_icm42600_gyro.c | 10 +-
> .../iio/imu/inv_icm42600/inv_icm42600_temp.c | 2 +-
> drivers/iio/imu/inv_mpu6050/inv_mpu_core.c | 14 +-
> drivers/iio/imu/inv_mpu6050/inv_mpu_trigger.c | 4 +-
> drivers/iio/imu/kmx61.c | 2 +-
> drivers/iio/light/apds9306.c | 6 +-
> drivers/iio/light/apds9960.c | 4 +-
> drivers/iio/light/bh1780.c | 2 +-
> drivers/iio/light/gp2ap002.c | 4 +-
> drivers/iio/light/isl29028.c | 2 +-
> drivers/iio/light/ltrf216a.c | 2 +-
> drivers/iio/light/pa12203001.c | 2 +-
> drivers/iio/light/rpr0521.c | 2 +-
> drivers/iio/light/tsl2583.c | 2 +-
> drivers/iio/light/tsl2591.c | 4 +-
> drivers/iio/light/us5182d.c | 2 +-
> drivers/iio/light/vcnl4000.c | 2 +-
> drivers/iio/light/vcnl4035.c | 2 +-
> drivers/iio/magnetometer/af8133j.c | 4 +-
> drivers/iio/magnetometer/ak8974.c | 4 +-
> drivers/iio/magnetometer/ak8975.c | 2 +-
> drivers/iio/magnetometer/bmc150_magn.c | 2 +-
> drivers/iio/magnetometer/tmag5273.c | 4 +-
> drivers/iio/magnetometer/yamaha-yas530.c | 4 +-
> drivers/iio/pressure/bmp280-core.c | 10 +-
> drivers/iio/pressure/icp10100.c | 2 +-
> drivers/iio/pressure/mpl115.c | 4 +-
> drivers/iio/pressure/zpa2326.c | 4 +-
> .../iio/proximity/pulsedlight-lidar-lite-v2.c | 2 +-
> drivers/iio/proximity/srf04.c | 2 +-
> drivers/iio/temperature/mlx90614.c | 4 +-
> drivers/iio/temperature/mlx90632.c | 4 +-
> drivers/iio/temperature/mlx90635.c | 4 +-
> drivers/input/keyboard/omap4-keypad.c | 8 +-
> drivers/input/misc/cs40l50-vibra.c | 8 +-
> drivers/iommu/arm/arm-smmu/arm-smmu.c | 2 +-
> drivers/irqchip/irq-imx-irqsteer.c | 2 +-
> drivers/mailbox/mtk-cmdq-mailbox.c | 10 +-
> drivers/media/i2c/alvium-csi2.c | 2 +-
> drivers/media/i2c/ccs/ccs-core.c | 10 +-
> drivers/media/i2c/dw9719.c | 2 +-
> drivers/media/i2c/gc0308.c | 6 +-
> drivers/media/i2c/gc2145.c | 8 +-
> drivers/media/i2c/imx283.c | 6 +-
> drivers/media/i2c/imx290.c | 6 +-
> drivers/media/i2c/imx296.c | 4 +-
> drivers/media/i2c/imx415.c | 4 +-
> drivers/media/i2c/mt9m114.c | 12 +-
> drivers/media/i2c/ov2680.c | 2 +-
> drivers/media/i2c/ov4689.c | 6 +-
> drivers/media/i2c/ov5640.c | 8 +-
> drivers/media/i2c/ov5645.c | 6 +-
> drivers/media/i2c/ov5693.c | 2 +-
> drivers/media/i2c/ov64a40.c | 8 +-
> drivers/media/i2c/ov7251.c | 2 +-
> drivers/media/i2c/ov8858.c | 4 +-
> drivers/media/i2c/thp7312.c | 8 +-
> drivers/media/i2c/video-i2c.c | 8 +-
> .../media/platform/nvidia/tegra-vde/h264.c | 4 +-
> drivers/media/platform/qcom/venus/vdec.c | 4 +-
> drivers/media/platform/qcom/venus/venc.c | 4 +-
> .../platform/raspberrypi/pisp_be/pisp_be.c | 4 +-
> .../media/platform/st/sti/delta/delta-v4l2.c | 4 +-
> drivers/media/platform/st/sti/hva/hva-hw.c | 8 +-
> .../media/platform/verisilicon/hantro_drv.c | 2 +-
> drivers/media/rc/gpio-ir-recv.c | 2 +-
> drivers/mfd/arizona-irq.c | 2 +-
> drivers/mfd/cs40l50-core.c | 2 +-
> drivers/mfd/cs42l43.c | 2 +-
> drivers/misc/mei/client.c | 14 +-
> drivers/mmc/core/core.c | 4 +-
> drivers/mmc/host/atmel-mci.c | 4 +-
> drivers/mmc/host/dw_mmc-rockchip.c | 2 +-
> drivers/mmc/host/dw_mmc.c | 2 +-
> drivers/mmc/host/mmci.c | 2 +-
> drivers/mmc/host/omap_hsmmc.c | 6 +-
> drivers/mmc/host/sdhci-msm.c | 2 +-
> drivers/mmc/host/sdhci-of-at91.c | 2 +-
> drivers/mmc/host/sdhci-omap.c | 4 +-
> drivers/mmc/host/sdhci-pci-core.c | 2 +-
> drivers/mmc/host/sdhci-pxav3.c | 6 +-
> drivers/mmc/host/sdhci-sprd.c | 2 +-
> drivers/mmc/host/sdhci-xenon.c | 2 +-
> drivers/mmc/host/sdhci_am654.c | 2 +-
> drivers/mmc/host/tmio_mmc_core.c | 2 +-
> drivers/mtd/nand/raw/gpmi-nand/gpmi-nand.c | 10 +-
> drivers/net/ethernet/cadence/macb_main.c | 10 +-
> drivers/net/ethernet/freescale/fec_main.c | 16 +-
> drivers/net/ethernet/renesas/ravb_main.c | 8 +-
> drivers/net/ethernet/ti/davinci_mdio.c | 14 +-
> drivers/net/ipa/ipa_interrupt.c | 2 +-
> drivers/net/ipa/ipa_main.c | 2 +-
> drivers/net/ipa/ipa_modem.c | 8 +-
> drivers/net/ipa/ipa_smp2p.c | 4 +-
> drivers/net/ipa/ipa_uc.c | 4 +-
> drivers/net/wireless/ath/wil6210/pm.c | 2 +-
> drivers/net/wireless/ti/wl18xx/debugfs.c | 6 +-
> drivers/net/wireless/ti/wlcore/cmd.c | 2 +-
> drivers/net/wireless/ti/wlcore/debugfs.c | 22 +--
> drivers/net/wireless/ti/wlcore/main.c | 72 +++----
> drivers/net/wireless/ti/wlcore/scan.c | 2 +-
> drivers/net/wireless/ti/wlcore/sysfs.c | 2 +-
> drivers/net/wireless/ti/wlcore/testmode.c | 4 +-
> drivers/net/wireless/ti/wlcore/tx.c | 2 +-
> drivers/net/wireless/ti/wlcore/vendor_cmd.c | 6 +-
> drivers/net/wwan/qcom_bam_dmux.c | 4 +-
> drivers/net/wwan/t7xx/t7xx_hif_cldma.c | 6 +-
> drivers/net/wwan/t7xx/t7xx_hif_dpmaif_rx.c | 6 +-
> drivers/net/wwan/t7xx/t7xx_hif_dpmaif_tx.c | 4 +-
> drivers/nfc/trf7970a.c | 2 +-
> drivers/pci/pcie/portdrv.c | 2 +-
> drivers/phy/motorola/phy-mapphone-mdm6600.c | 4 +-
> drivers/phy/ti/phy-twl4030-usb.c | 8 +-
> drivers/power/supply/bq24190_charger.c | 28 +--
> drivers/power/supply/twl4030_charger.c | 2 +-
> drivers/pwm/pwm-img.c | 4 +-
> drivers/regulator/stm32-vrefbuf.c | 12 +-
> drivers/remoteproc/omap_remoteproc.c | 6 +-
> drivers/slimbus/core.c | 2 +-
> drivers/slimbus/messaging.c | 4 +-
> drivers/soc/apple/mailbox.c | 2 +-
> drivers/soundwire/bus.c | 2 +-
> drivers/soundwire/cadence_master.c | 2 +-
> drivers/soundwire/qcom.c | 6 +-
> drivers/spi/atmel-quadspi.c | 10 +-
> drivers/spi/spi-cadence-quadspi.c | 4 +-
> drivers/spi/spi-cadence.c | 2 +-
> drivers/spi/spi-dw-pci.c | 2 +-
> drivers/spi/spi-fsl-espi.c | 4 +-
> drivers/spi/spi-fsl-lpspi.c | 4 +-
> drivers/spi/spi-imx.c | 6 +-
> drivers/spi/spi-mtk-nor.c | 2 +-
> drivers/spi/spi-omap2-mcspi.c | 6 +-
> drivers/spi/spi-pxa2xx-pci.c | 2 +-
> drivers/spi/spi-s3c64xx.c | 6 +-
> drivers/spi/spi-sprd.c | 2 +-
> drivers/spi/spi-stm32-qspi.c | 14 +-
> drivers/spi/spi-stm32.c | 4 +-
> drivers/spi/spi-ti-qspi.c | 4 +-
> drivers/spi/spi-zynqmp-gqspi.c | 2 +-
> drivers/spi/spi.c | 6 +-
> drivers/staging/greybus/gbphy.h | 2 +-
> drivers/staging/media/rkvdec/rkvdec.c | 2 +-
> drivers/thunderbolt/debugfs.c | 22 +--
> drivers/thunderbolt/domain.c | 4 +-
> drivers/thunderbolt/icm.c | 14 +-
> drivers/thunderbolt/nhi.c | 2 +-
> drivers/thunderbolt/retimer.c | 4 +-
> drivers/thunderbolt/switch.c | 6 +-
> drivers/thunderbolt/tb.c | 18 +-
> drivers/thunderbolt/usb4_port.c | 4 +-
> drivers/tty/serial/8250/8250_omap.c | 18 +-
> drivers/tty/serial/8250/8250_port.c | 4 +-
> drivers/tty/serial/fsl_lpuart.c | 2 +-
> drivers/tty/serial/serial_core.c | 2 +-
> drivers/tty/serial/uartlite.c | 4 +-
> drivers/tty/serial/xilinx_uartps.c | 2 +-
> drivers/usb/cdns3/cdns3-gadget.c | 2 +-
> drivers/usb/cdns3/cdnsp-gadget.c | 2 +-
> drivers/usb/chipidea/core.c | 2 +-
> drivers/usb/chipidea/otg_fsm.c | 2 +-
> drivers/usb/dwc3/core.c | 2 +-
> drivers/usb/dwc3/dwc3-am62.c | 2 +-
> drivers/usb/dwc3/dwc3-imx8mp.c | 2 +-
> drivers/usb/gadget/udc/cdns2/cdns2-gadget.c | 2 +-
> drivers/usb/host/xhci-mtk.c | 2 +-
> drivers/usb/misc/apple-mfi-fastcharge.c | 2 +-
> drivers/usb/mtu3/mtu3_plat.c | 2 +-
> drivers/usb/musb/musb_core.c | 10 +-
> drivers/usb/musb/musb_debugfs.c | 10 +-
> drivers/usb/musb/musb_dsps.c | 2 +-
> drivers/usb/musb/musb_gadget.c | 8 +-
> drivers/usb/musb/omap2430.c | 2 +-
> drivers/w1/masters/omap_hdq.c | 10 +-
> include/linux/greybus/bundle.h | 2 +-
> sound/hda/hdac_device.c | 2 +-
> sound/pci/hda/cs35l41_hda.c | 8 +-
> sound/pci/hda/cs35l56_hda.c | 2 +-
> sound/pci/hda/hda_intel.c | 2 +-
> sound/pci/hda/tas2781_hda_i2c.c | 6 +-
> sound/soc/atmel/mchp-spdifrx.c | 12 +-
> sound/soc/codecs/arizona-jack.c | 12 +-
> sound/soc/codecs/arizona.c | 2 +-
> sound/soc/codecs/cs35l41.c | 4 +-
> sound/soc/codecs/cs35l45.c | 2 +-
> sound/soc/codecs/cs35l56-sdw.c | 4 +-
> sound/soc/codecs/cs35l56-shared.c | 2 +-
> sound/soc/codecs/cs35l56.c | 2 +-
> sound/soc/codecs/cs42l42-sdw.c | 2 +-
> sound/soc/codecs/cs42l42.c | 4 +-
> sound/soc/codecs/cs42l43-jack.c | 10 +-
> sound/soc/codecs/cs42l43.c | 4 +-
> sound/soc/codecs/hda.c | 6 +-
> sound/soc/codecs/madera.c | 6 +-
> sound/soc/codecs/max98363.c | 2 +-
> sound/soc/codecs/max98373-sdw.c | 2 +-
> sound/soc/codecs/rt1017-sdca-sdw.c | 2 +-
> sound/soc/codecs/rt1308-sdw.c | 2 +-
> sound/soc/codecs/rt1316-sdw.c | 2 +-
> sound/soc/codecs/rt1318-sdw.c | 2 +-
> sound/soc/codecs/rt1320-sdw.c | 2 +-
> sound/soc/codecs/rt5682-sdw.c | 2 +-
> sound/soc/codecs/rt700.c | 4 +-
> sound/soc/codecs/rt711-sdca.c | 4 +-
> sound/soc/codecs/rt711.c | 4 +-
> sound/soc/codecs/rt712-sdca-dmic.c | 2 +-
> sound/soc/codecs/rt712-sdca.c | 4 +-
> sound/soc/codecs/rt715-sdca.c | 2 +-
> sound/soc/codecs/rt715.c | 2 +-
> sound/soc/codecs/rt722-sdca.c | 4 +-
> sound/soc/codecs/wcd-mbhc-v2.c | 4 +-
> sound/soc/codecs/wsa881x.c | 2 +-
> sound/soc/codecs/wsa884x.c | 2 +-
> sound/soc/intel/atom/sst/sst_pvt.c | 2 +-
> sound/soc/intel/avs/core.c | 2 +-
> sound/soc/intel/avs/debugfs.c | 4 +-
> sound/soc/intel/avs/pcm.c | 2 +-
> sound/soc/intel/catpt/pcm.c | 12 +-
> sound/soc/intel/catpt/sysfs.c | 2 +-
> sound/soc/soc-component.c | 2 +-
> sound/soc/sof/control.c | 2 +-
> sound/soc/sof/debug.c | 2 +-
> sound/soc/sof/ipc3-dtrace.c | 2 +-
> sound/soc/sof/ipc4-loader.c | 2 +-
> sound/soc/sof/pcm.c | 2 +-
> sound/soc/sof/sof-client-ipc-flood-test.c | 2 +-
> .../soc/sof/sof-client-ipc-kernel-injector.c | 2 +-
> sound/soc/sof/sof-client-ipc-msg-injector.c | 2 +-
> sound/soc/sof/sof-client-probes.c | 6 +-
> sound/x86/intel_hdmi_audio.c | 6 +-
> 373 files changed, 1076 insertions(+), 1076 deletions(-)
>
> --
> 2.39.5
>
>
^ permalink raw reply [flat|nested] 14+ messages in thread
* Re: [PATCH 00/51] treewide: Switch to __pm_runtime_put_autosuspend()
2024-10-04 14:38 ` [PATCH 00/51] treewide: " Ulf Hansson
@ 2024-10-07 18:49 ` Laurent Pinchart
2024-10-07 22:08 ` Ulf Hansson
2024-10-08 20:38 ` Uwe Kleine-König
0 siblings, 2 replies; 14+ messages in thread
From: Laurent Pinchart @ 2024-10-07 18:49 UTC (permalink / raw)
To: Ulf Hansson
Cc: Sakari Ailus, dri-devel, linux-kernel, linux-bluetooth, linux-clk,
linux-crypto, dmaengine, linux-gpio, amd-gfx, nouveau,
linux-stm32, linux-arm-kernel, linux-i2c, linux-i3c, linux-iio,
linux-input, patches, iommu, imx, linux-mediatek, linux-media,
linux-mmc, linux-mtd, netdev, linux-wireless, linux-pci,
linux-phy, linux-pwm, linux-remoteproc, linux-sound, linux-spi,
linux-staging, linux-usb, linux-serial, greybus-dev, asahi,
rafael, Andy Shevchenko
Hi Ulf,
On Fri, Oct 04, 2024 at 04:38:36PM +0200, Ulf Hansson wrote:
> On Fri, 4 Oct 2024 at 11:41, Sakari Ailus <sakari.ailus@linux.intel.com> wrote:
> >
> > Hello everyone,
> >
> > This set will switch the users of pm_runtime_put_autosuspend() to
> > __pm_runtime_put_autosuspend() while the former will soon be re-purposed
> > to include a call to pm_runtime_mark_last_busy(). The two are almost
> > always used together, apart from bugs which are likely common. Going
> > forward, most new users should be using pm_runtime_put_autosuspend().
> >
> > Once this conversion is done and pm_runtime_put_autosuspend() re-purposed,
> > I'll post another set to merge the calls to __pm_runtime_put_autosuspend()
> > and pm_runtime_mark_last_busy().
>
> That sounds like it could cause a lot of churns.
>
> Why not add a new helper function that does the
> pm_runtime_put_autosuspend() and the pm_runtime_mark_last_busy()
> things? Then we can start moving users over to this new interface,
> rather than having this intermediate step?
I think the API would be nicer if we used the shortest and simplest
function names for the most common use cases. Following
pm_runtime_put_autosuspend() with pm_runtime_mark_last_busy() is that
most common use case. That's why I like Sakari's approach of repurposing
pm_runtime_put_autosuspend(), and introducing
__pm_runtime_put_autosuspend() for the odd cases where
pm_runtime_mark_last_busy() shouldn't be called.
> > The diff in these patches have been generated using the following
> > Coccinelle script (besides a manual change in
> > drivers/iio/magnetometer/af8133j.c):
> >
> > ----------8<-------------------
> > @@
> > expression E1;
> >
> > @@
> >
> > - pm_runtime_put_autosuspend(E1)
> > + __pm_runtime_put_autosuspend(E1)
> > ----------8<-------------------
> >
> > These patches are on top of today's linux-next (i.e. next-20241004).
> >
> > Sakari Ailus (51):
> > accel/ivpu: Switch to __pm_runtime_put_autosuspend()
> > bluetooth: Switch to __pm_runtime_put_autosuspend()
> > bus: sunxi-rsb: Switch to __pm_runtime_put_autosuspend()
> > hwrng: Switch to __pm_runtime_put_autosuspend()
> > clk: Switch to __pm_runtime_put_autosuspend()
> > crypto: Switch to __pm_runtime_put_autosuspend()
> > dmaengine: Switch to __pm_runtime_put_autosuspend()
> > gpio: Switch to __pm_runtime_put_autosuspend()
> > drm/amd: Switch to __pm_runtime_put_autosuspend()
> > drm/nouveau: Switch to __pm_runtime_put_autosuspend()
> > drm/radeon: Switch to __pm_runtime_put_autosuspend()
> > drm/panfrost: Switch to __pm_runtime_put_autosuspend()
> > drivers: drm: Switch to __pm_runtime_put_autosuspend()
> > HSI: omap_ssi_port: Switch to __pm_runtime_put_autosuspend()
> > stm class: Switch to __pm_runtime_put_autosuspend()
> > i2c: Switch to __pm_runtime_put_autosuspend()
> > i3c: master: svc: Switch to __pm_runtime_put_autosuspend()
> > i3c: dw: Switch to __pm_runtime_put_autosuspend()
> > iio: Switch to __pm_runtime_put_autosuspend()
> > Input: omap4-keypad: Switch to __pm_runtime_put_autosuspend()
> > Input: cs40l50: Switch to __pm_runtime_put_autosuspend()
> > iommu/arm-smmu: Switch to __pm_runtime_put_autosuspend()
> > irqchip/imx-irqsteer: Switch to __pm_runtime_put_autosuspend()
> > mailbox: mtk-cmdq-mailbox: Switch to __pm_runtime_put_autosuspend()
> > media: Switch to __pm_runtime_put_autosuspend()
> > mfd: Switch to __pm_runtime_put_autosuspend()
> > mei: Switch to __pm_runtime_put_autosuspend()
> > mmc: Switch to __pm_runtime_put_autosuspend()
> > mtd: rawnand: gpmi: Switch to __pm_runtime_put_autosuspend()
> > net: Switch to __pm_runtime_put_autosuspend()
> > nfc: trf7970a: Switch to __pm_runtime_put_autosuspend()
> > PCI/portdrv: Switch to __pm_runtime_put_autosuspend()
> > phy: motorola: phy-mapphone-mdm6600: Switch to
> > __pm_runtime_put_autosuspend()
> > phy: ti: phy-twl4030-usb: Switch to __pm_runtime_put_autosuspend()
> > power: Switch to __pm_runtime_put_autosuspend()
> > pwm: img: Switch to __pm_runtime_put_autosuspend()
> > regulator: stm32-vrefbuf: Switch to __pm_runtime_put_autosuspend()
> > remoteproc: omap: Switch to __pm_runtime_put_autosuspend()
> > slimbus: Switch to __pm_runtime_put_autosuspend()
> > soundwire: Switch to __pm_runtime_put_autosuspend()
> > spi: Switch to __pm_runtime_put_autosuspend()
> > staging: Switch to __pm_runtime_put_autosuspend()
> > thunderbolt: Switch to __pm_runtime_put_autosuspend()
> > serial: Switch to __pm_runtime_put_autosuspend()
> > usb: Switch to __pm_runtime_put_autosuspend()
> > w1: omap-hdq: Switch to __pm_runtime_put_autosuspend()
> > staging: greybus: Switch to __pm_runtime_put_autosuspend()
> > ALSA: hda: Switch to __pm_runtime_put_autosuspend()
> > ASoC: Switch to __pm_runtime_put_autosuspend()
> > ALSA: intel_hdmi: Switch to __pm_runtime_put_autosuspend()
> > soc: apple: mailbox: Switch to __pm_runtime_put_autosuspend()
> >
> > drivers/accel/ivpu/ivpu_drv.c | 2 +-
> > drivers/accel/ivpu/ivpu_pm.c | 8 +-
> > drivers/bluetooth/btmtksdio.c | 2 +-
> > drivers/bluetooth/hci_bcm.c | 6 +-
> > drivers/bluetooth/hci_h5.c | 4 +-
> > drivers/bluetooth/hci_intel.c | 6 +-
> > drivers/bus/sunxi-rsb.c | 4 +-
> > drivers/char/hw_random/cctrng.c | 2 +-
> > drivers/char/hw_random/omap3-rom-rng.c | 2 +-
> > drivers/clk/imx/clk-imx8qxp-lpcg.c | 2 +-
> > drivers/clk/imx/clk-scu.c | 2 +-
> > drivers/clk/qcom/lpassaudiocc-sc7280.c | 4 +-
> > drivers/clk/qcom/lpasscorecc-sc7180.c | 4 +-
> > drivers/crypto/ccree/cc_pm.c | 2 +-
> > drivers/crypto/hisilicon/qm.c | 2 +-
> > drivers/crypto/omap-aes-gcm.c | 2 +-
> > drivers/crypto/omap-aes.c | 2 +-
> > drivers/crypto/omap-des.c | 2 +-
> > drivers/crypto/omap-sham.c | 2 +-
> > drivers/crypto/rockchip/rk3288_crypto_ahash.c | 2 +-
> > .../crypto/rockchip/rk3288_crypto_skcipher.c | 2 +-
> > drivers/crypto/stm32/stm32-crc32.c | 4 +-
> > drivers/crypto/stm32/stm32-cryp.c | 2 +-
> > drivers/crypto/stm32/stm32-hash.c | 2 +-
> > drivers/dma/at_xdmac.c | 24 +--
> > drivers/dma/pl330.c | 14 +-
> > drivers/dma/qcom/bam_dma.c | 10 +-
> > drivers/dma/qcom/hidma.c | 18 +-
> > drivers/dma/qcom/hidma_dbg.c | 2 +-
> > drivers/dma/qcom/hidma_mgmt.c | 4 +-
> > drivers/dma/ste_dma40.c | 16 +-
> > drivers/dma/ti/cppi41.c | 10 +-
> > drivers/dma/xilinx/zynqmp_dma.c | 2 +-
> > drivers/gpio/gpio-arizona.c | 10 +-
> > drivers/gpio/gpio-mxc.c | 2 +-
> > drivers/gpu/drm/amd/amdgpu/amdgpu_acpi.c | 2 +-
> > .../gpu/drm/amd/amdgpu/amdgpu_connectors.c | 16 +-
> > drivers/gpu/drm/amd/amdgpu/amdgpu_debugfs.c | 120 ++++++------
> > drivers/gpu/drm/amd/amdgpu/amdgpu_display.c | 2 +-
> > drivers/gpu/drm/amd/amdgpu/amdgpu_drv.c | 6 +-
> > drivers/gpu/drm/amd/amdgpu/amdgpu_fence.c | 6 +-
> > drivers/gpu/drm/amd/amdgpu/amdgpu_gfx.c | 4 +-
> > drivers/gpu/drm/amd/amdgpu/amdgpu_kms.c | 4 +-
> > drivers/gpu/drm/amd/amdgpu/amdgpu_rap.c | 4 +-
> > drivers/gpu/drm/amd/amdgpu/amdgpu_ras.c | 2 +-
> > .../gpu/drm/amd/amdgpu/amdgpu_securedisplay.c | 4 +-
> > drivers/gpu/drm/amd/amdkfd/kfd_process.c | 4 +-
> > .../gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c | 2 +-
> > drivers/gpu/drm/amd/pm/amdgpu_pm.c | 178 +++++++++---------
> > .../drm/bridge/analogix/analogix_dp_core.c | 2 +-
> > drivers/gpu/drm/bridge/analogix/anx7625.c | 4 +-
> > drivers/gpu/drm/bridge/parade-ps8640.c | 4 +-
> > drivers/gpu/drm/bridge/ti-sn65dsi86.c | 14 +-
> > drivers/gpu/drm/etnaviv/etnaviv_gpu.c | 12 +-
> > drivers/gpu/drm/exynos/exynos_drm_fimc.c | 4 +-
> > drivers/gpu/drm/exynos/exynos_drm_g2d.c | 4 +-
> > drivers/gpu/drm/exynos/exynos_drm_gsc.c | 6 +-
> > drivers/gpu/drm/exynos/exynos_drm_rotator.c | 2 +-
> > drivers/gpu/drm/exynos/exynos_drm_scaler.c | 2 +-
> > drivers/gpu/drm/i915/intel_runtime_pm.c | 4 +-
> > drivers/gpu/drm/imx/dcss/dcss-crtc.c | 2 +-
> > drivers/gpu/drm/lima/lima_sched.c | 2 +-
> > drivers/gpu/drm/msm/adreno/adreno_device.c | 2 +-
> > drivers/gpu/drm/msm/adreno/adreno_gpu.c | 2 +-
> > drivers/gpu/drm/msm/msm_gpu.c | 2 +-
> > drivers/gpu/drm/msm/msm_iommu.c | 4 +-
> > drivers/gpu/drm/msm/msm_submitqueue.c | 2 +-
> > drivers/gpu/drm/nouveau/dispnv50/disp.c | 10 +-
> > drivers/gpu/drm/nouveau/nouveau_connector.c | 4 +-
> > drivers/gpu/drm/nouveau/nouveau_debugfs.c | 8 +-
> > drivers/gpu/drm/nouveau/nouveau_display.c | 4 +-
> > drivers/gpu/drm/nouveau/nouveau_drm.c | 10 +-
> > drivers/gpu/drm/nouveau/nouveau_gem.c | 10 +-
> > drivers/gpu/drm/panel/panel-edp.c | 8 +-
> > .../gpu/drm/panel/panel-samsung-atna33xc20.c | 6 +-
> > drivers/gpu/drm/panel/panel-simple.c | 6 +-
> > drivers/gpu/drm/panfrost/panfrost_job.c | 4 +-
> > drivers/gpu/drm/panfrost/panfrost_mmu.c | 4 +-
> > drivers/gpu/drm/panfrost/panfrost_perfcnt.c | 4 +-
> > drivers/gpu/drm/panthor/panthor_device.c | 2 +-
> > drivers/gpu/drm/panthor/panthor_sched.c | 6 +-
> > drivers/gpu/drm/radeon/radeon_acpi.c | 2 +-
> > drivers/gpu/drm/radeon/radeon_connectors.c | 20 +-
> > drivers/gpu/drm/radeon/radeon_display.c | 6 +-
> > drivers/gpu/drm/radeon/radeon_drv.c | 4 +-
> > drivers/gpu/drm/radeon/radeon_fbdev.c | 4 +-
> > drivers/gpu/drm/radeon/radeon_kms.c | 10 +-
> > drivers/gpu/drm/tegra/submit.c | 2 +-
> > drivers/gpu/drm/tidss/tidss_drv.c | 2 +-
> > drivers/gpu/drm/vc4/vc4_v3d.c | 2 +-
> > drivers/hsi/controllers/omap_ssi_port.c | 42 ++---
> > drivers/hwtracing/stm/core.c | 8 +-
> > drivers/i2c/busses/i2c-amd-mp2-pci.c | 2 +-
> > drivers/i2c/busses/i2c-amd-mp2.h | 2 +-
> > drivers/i2c/busses/i2c-at91-master.c | 2 +-
> > drivers/i2c/busses/i2c-cadence.c | 2 +-
> > drivers/i2c/busses/i2c-davinci.c | 4 +-
> > drivers/i2c/busses/i2c-designware-master.c | 2 +-
> > drivers/i2c/busses/i2c-designware-pcidrv.c | 2 +-
> > drivers/i2c/busses/i2c-hix5hd2.c | 2 +-
> > drivers/i2c/busses/i2c-i801.c | 4 +-
> > drivers/i2c/busses/i2c-img-scb.c | 6 +-
> > drivers/i2c/busses/i2c-imx-lpi2c.c | 6 +-
> > drivers/i2c/busses/i2c-imx.c | 4 +-
> > drivers/i2c/busses/i2c-mv64xxx.c | 2 +-
> > drivers/i2c/busses/i2c-nvidia-gpu.c | 4 +-
> > drivers/i2c/busses/i2c-omap.c | 6 +-
> > drivers/i2c/busses/i2c-qcom-cci.c | 2 +-
> > drivers/i2c/busses/i2c-qcom-geni.c | 2 +-
> > drivers/i2c/busses/i2c-qup.c | 4 +-
> > drivers/i2c/busses/i2c-riic.c | 4 +-
> > drivers/i2c/busses/i2c-rzv2m.c | 2 +-
> > drivers/i2c/busses/i2c-sprd.c | 4 +-
> > drivers/i2c/busses/i2c-stm32f7.c | 10 +-
> > drivers/i2c/busses/i2c-xiic.c | 2 +-
> > drivers/i3c/master/dw-i3c-master.c | 16 +-
> > drivers/i3c/master/svc-i3c-master.c | 16 +-
> > drivers/iio/accel/bmc150-accel-core.c | 2 +-
> > drivers/iio/accel/bmi088-accel-core.c | 6 +-
> > drivers/iio/accel/fxls8962af-core.c | 2 +-
> > drivers/iio/accel/kxcjk-1013.c | 2 +-
> > drivers/iio/accel/kxsd9.c | 6 +-
> > drivers/iio/accel/mma8452.c | 2 +-
> > drivers/iio/accel/mma9551_core.c | 2 +-
> > drivers/iio/accel/msa311.c | 12 +-
> > drivers/iio/adc/ab8500-gpadc.c | 2 +-
> > drivers/iio/adc/at91-sama5d2_adc.c | 20 +-
> > drivers/iio/adc/rcar-gyroadc.c | 2 +-
> > drivers/iio/adc/stm32-adc-core.c | 2 +-
> > drivers/iio/adc/stm32-adc.c | 12 +-
> > drivers/iio/adc/sun4i-gpadc-iio.c | 4 +-
> > drivers/iio/adc/ti-ads1015.c | 2 +-
> > drivers/iio/adc/ti-ads1100.c | 2 +-
> > drivers/iio/adc/ti-ads1119.c | 4 +-
> > drivers/iio/chemical/atlas-sensor.c | 4 +-
> > .../common/hid-sensors/hid-sensor-trigger.c | 2 +-
> > drivers/iio/dac/stm32-dac.c | 6 +-
> > drivers/iio/gyro/bmg160_core.c | 2 +-
> > drivers/iio/gyro/fxas21002c_core.c | 2 +-
> > drivers/iio/gyro/mpu3050-core.c | 6 +-
> > drivers/iio/gyro/mpu3050-i2c.c | 2 +-
> > .../iio/imu/inv_icm42600/inv_icm42600_accel.c | 10 +-
> > .../imu/inv_icm42600/inv_icm42600_buffer.c | 2 +-
> > .../iio/imu/inv_icm42600/inv_icm42600_gyro.c | 10 +-
> > .../iio/imu/inv_icm42600/inv_icm42600_temp.c | 2 +-
> > drivers/iio/imu/inv_mpu6050/inv_mpu_core.c | 14 +-
> > drivers/iio/imu/inv_mpu6050/inv_mpu_trigger.c | 4 +-
> > drivers/iio/imu/kmx61.c | 2 +-
> > drivers/iio/light/apds9306.c | 6 +-
> > drivers/iio/light/apds9960.c | 4 +-
> > drivers/iio/light/bh1780.c | 2 +-
> > drivers/iio/light/gp2ap002.c | 4 +-
> > drivers/iio/light/isl29028.c | 2 +-
> > drivers/iio/light/ltrf216a.c | 2 +-
> > drivers/iio/light/pa12203001.c | 2 +-
> > drivers/iio/light/rpr0521.c | 2 +-
> > drivers/iio/light/tsl2583.c | 2 +-
> > drivers/iio/light/tsl2591.c | 4 +-
> > drivers/iio/light/us5182d.c | 2 +-
> > drivers/iio/light/vcnl4000.c | 2 +-
> > drivers/iio/light/vcnl4035.c | 2 +-
> > drivers/iio/magnetometer/af8133j.c | 4 +-
> > drivers/iio/magnetometer/ak8974.c | 4 +-
> > drivers/iio/magnetometer/ak8975.c | 2 +-
> > drivers/iio/magnetometer/bmc150_magn.c | 2 +-
> > drivers/iio/magnetometer/tmag5273.c | 4 +-
> > drivers/iio/magnetometer/yamaha-yas530.c | 4 +-
> > drivers/iio/pressure/bmp280-core.c | 10 +-
> > drivers/iio/pressure/icp10100.c | 2 +-
> > drivers/iio/pressure/mpl115.c | 4 +-
> > drivers/iio/pressure/zpa2326.c | 4 +-
> > .../iio/proximity/pulsedlight-lidar-lite-v2.c | 2 +-
> > drivers/iio/proximity/srf04.c | 2 +-
> > drivers/iio/temperature/mlx90614.c | 4 +-
> > drivers/iio/temperature/mlx90632.c | 4 +-
> > drivers/iio/temperature/mlx90635.c | 4 +-
> > drivers/input/keyboard/omap4-keypad.c | 8 +-
> > drivers/input/misc/cs40l50-vibra.c | 8 +-
> > drivers/iommu/arm/arm-smmu/arm-smmu.c | 2 +-
> > drivers/irqchip/irq-imx-irqsteer.c | 2 +-
> > drivers/mailbox/mtk-cmdq-mailbox.c | 10 +-
> > drivers/media/i2c/alvium-csi2.c | 2 +-
> > drivers/media/i2c/ccs/ccs-core.c | 10 +-
> > drivers/media/i2c/dw9719.c | 2 +-
> > drivers/media/i2c/gc0308.c | 6 +-
> > drivers/media/i2c/gc2145.c | 8 +-
> > drivers/media/i2c/imx283.c | 6 +-
> > drivers/media/i2c/imx290.c | 6 +-
> > drivers/media/i2c/imx296.c | 4 +-
> > drivers/media/i2c/imx415.c | 4 +-
> > drivers/media/i2c/mt9m114.c | 12 +-
> > drivers/media/i2c/ov2680.c | 2 +-
> > drivers/media/i2c/ov4689.c | 6 +-
> > drivers/media/i2c/ov5640.c | 8 +-
> > drivers/media/i2c/ov5645.c | 6 +-
> > drivers/media/i2c/ov5693.c | 2 +-
> > drivers/media/i2c/ov64a40.c | 8 +-
> > drivers/media/i2c/ov7251.c | 2 +-
> > drivers/media/i2c/ov8858.c | 4 +-
> > drivers/media/i2c/thp7312.c | 8 +-
> > drivers/media/i2c/video-i2c.c | 8 +-
> > .../media/platform/nvidia/tegra-vde/h264.c | 4 +-
> > drivers/media/platform/qcom/venus/vdec.c | 4 +-
> > drivers/media/platform/qcom/venus/venc.c | 4 +-
> > .../platform/raspberrypi/pisp_be/pisp_be.c | 4 +-
> > .../media/platform/st/sti/delta/delta-v4l2.c | 4 +-
> > drivers/media/platform/st/sti/hva/hva-hw.c | 8 +-
> > .../media/platform/verisilicon/hantro_drv.c | 2 +-
> > drivers/media/rc/gpio-ir-recv.c | 2 +-
> > drivers/mfd/arizona-irq.c | 2 +-
> > drivers/mfd/cs40l50-core.c | 2 +-
> > drivers/mfd/cs42l43.c | 2 +-
> > drivers/misc/mei/client.c | 14 +-
> > drivers/mmc/core/core.c | 4 +-
> > drivers/mmc/host/atmel-mci.c | 4 +-
> > drivers/mmc/host/dw_mmc-rockchip.c | 2 +-
> > drivers/mmc/host/dw_mmc.c | 2 +-
> > drivers/mmc/host/mmci.c | 2 +-
> > drivers/mmc/host/omap_hsmmc.c | 6 +-
> > drivers/mmc/host/sdhci-msm.c | 2 +-
> > drivers/mmc/host/sdhci-of-at91.c | 2 +-
> > drivers/mmc/host/sdhci-omap.c | 4 +-
> > drivers/mmc/host/sdhci-pci-core.c | 2 +-
> > drivers/mmc/host/sdhci-pxav3.c | 6 +-
> > drivers/mmc/host/sdhci-sprd.c | 2 +-
> > drivers/mmc/host/sdhci-xenon.c | 2 +-
> > drivers/mmc/host/sdhci_am654.c | 2 +-
> > drivers/mmc/host/tmio_mmc_core.c | 2 +-
> > drivers/mtd/nand/raw/gpmi-nand/gpmi-nand.c | 10 +-
> > drivers/net/ethernet/cadence/macb_main.c | 10 +-
> > drivers/net/ethernet/freescale/fec_main.c | 16 +-
> > drivers/net/ethernet/renesas/ravb_main.c | 8 +-
> > drivers/net/ethernet/ti/davinci_mdio.c | 14 +-
> > drivers/net/ipa/ipa_interrupt.c | 2 +-
> > drivers/net/ipa/ipa_main.c | 2 +-
> > drivers/net/ipa/ipa_modem.c | 8 +-
> > drivers/net/ipa/ipa_smp2p.c | 4 +-
> > drivers/net/ipa/ipa_uc.c | 4 +-
> > drivers/net/wireless/ath/wil6210/pm.c | 2 +-
> > drivers/net/wireless/ti/wl18xx/debugfs.c | 6 +-
> > drivers/net/wireless/ti/wlcore/cmd.c | 2 +-
> > drivers/net/wireless/ti/wlcore/debugfs.c | 22 +--
> > drivers/net/wireless/ti/wlcore/main.c | 72 +++----
> > drivers/net/wireless/ti/wlcore/scan.c | 2 +-
> > drivers/net/wireless/ti/wlcore/sysfs.c | 2 +-
> > drivers/net/wireless/ti/wlcore/testmode.c | 4 +-
> > drivers/net/wireless/ti/wlcore/tx.c | 2 +-
> > drivers/net/wireless/ti/wlcore/vendor_cmd.c | 6 +-
> > drivers/net/wwan/qcom_bam_dmux.c | 4 +-
> > drivers/net/wwan/t7xx/t7xx_hif_cldma.c | 6 +-
> > drivers/net/wwan/t7xx/t7xx_hif_dpmaif_rx.c | 6 +-
> > drivers/net/wwan/t7xx/t7xx_hif_dpmaif_tx.c | 4 +-
> > drivers/nfc/trf7970a.c | 2 +-
> > drivers/pci/pcie/portdrv.c | 2 +-
> > drivers/phy/motorola/phy-mapphone-mdm6600.c | 4 +-
> > drivers/phy/ti/phy-twl4030-usb.c | 8 +-
> > drivers/power/supply/bq24190_charger.c | 28 +--
> > drivers/power/supply/twl4030_charger.c | 2 +-
> > drivers/pwm/pwm-img.c | 4 +-
> > drivers/regulator/stm32-vrefbuf.c | 12 +-
> > drivers/remoteproc/omap_remoteproc.c | 6 +-
> > drivers/slimbus/core.c | 2 +-
> > drivers/slimbus/messaging.c | 4 +-
> > drivers/soc/apple/mailbox.c | 2 +-
> > drivers/soundwire/bus.c | 2 +-
> > drivers/soundwire/cadence_master.c | 2 +-
> > drivers/soundwire/qcom.c | 6 +-
> > drivers/spi/atmel-quadspi.c | 10 +-
> > drivers/spi/spi-cadence-quadspi.c | 4 +-
> > drivers/spi/spi-cadence.c | 2 +-
> > drivers/spi/spi-dw-pci.c | 2 +-
> > drivers/spi/spi-fsl-espi.c | 4 +-
> > drivers/spi/spi-fsl-lpspi.c | 4 +-
> > drivers/spi/spi-imx.c | 6 +-
> > drivers/spi/spi-mtk-nor.c | 2 +-
> > drivers/spi/spi-omap2-mcspi.c | 6 +-
> > drivers/spi/spi-pxa2xx-pci.c | 2 +-
> > drivers/spi/spi-s3c64xx.c | 6 +-
> > drivers/spi/spi-sprd.c | 2 +-
> > drivers/spi/spi-stm32-qspi.c | 14 +-
> > drivers/spi/spi-stm32.c | 4 +-
> > drivers/spi/spi-ti-qspi.c | 4 +-
> > drivers/spi/spi-zynqmp-gqspi.c | 2 +-
> > drivers/spi/spi.c | 6 +-
> > drivers/staging/greybus/gbphy.h | 2 +-
> > drivers/staging/media/rkvdec/rkvdec.c | 2 +-
> > drivers/thunderbolt/debugfs.c | 22 +--
> > drivers/thunderbolt/domain.c | 4 +-
> > drivers/thunderbolt/icm.c | 14 +-
> > drivers/thunderbolt/nhi.c | 2 +-
> > drivers/thunderbolt/retimer.c | 4 +-
> > drivers/thunderbolt/switch.c | 6 +-
> > drivers/thunderbolt/tb.c | 18 +-
> > drivers/thunderbolt/usb4_port.c | 4 +-
> > drivers/tty/serial/8250/8250_omap.c | 18 +-
> > drivers/tty/serial/8250/8250_port.c | 4 +-
> > drivers/tty/serial/fsl_lpuart.c | 2 +-
> > drivers/tty/serial/serial_core.c | 2 +-
> > drivers/tty/serial/uartlite.c | 4 +-
> > drivers/tty/serial/xilinx_uartps.c | 2 +-
> > drivers/usb/cdns3/cdns3-gadget.c | 2 +-
> > drivers/usb/cdns3/cdnsp-gadget.c | 2 +-
> > drivers/usb/chipidea/core.c | 2 +-
> > drivers/usb/chipidea/otg_fsm.c | 2 +-
> > drivers/usb/dwc3/core.c | 2 +-
> > drivers/usb/dwc3/dwc3-am62.c | 2 +-
> > drivers/usb/dwc3/dwc3-imx8mp.c | 2 +-
> > drivers/usb/gadget/udc/cdns2/cdns2-gadget.c | 2 +-
> > drivers/usb/host/xhci-mtk.c | 2 +-
> > drivers/usb/misc/apple-mfi-fastcharge.c | 2 +-
> > drivers/usb/mtu3/mtu3_plat.c | 2 +-
> > drivers/usb/musb/musb_core.c | 10 +-
> > drivers/usb/musb/musb_debugfs.c | 10 +-
> > drivers/usb/musb/musb_dsps.c | 2 +-
> > drivers/usb/musb/musb_gadget.c | 8 +-
> > drivers/usb/musb/omap2430.c | 2 +-
> > drivers/w1/masters/omap_hdq.c | 10 +-
> > include/linux/greybus/bundle.h | 2 +-
> > sound/hda/hdac_device.c | 2 +-
> > sound/pci/hda/cs35l41_hda.c | 8 +-
> > sound/pci/hda/cs35l56_hda.c | 2 +-
> > sound/pci/hda/hda_intel.c | 2 +-
> > sound/pci/hda/tas2781_hda_i2c.c | 6 +-
> > sound/soc/atmel/mchp-spdifrx.c | 12 +-
> > sound/soc/codecs/arizona-jack.c | 12 +-
> > sound/soc/codecs/arizona.c | 2 +-
> > sound/soc/codecs/cs35l41.c | 4 +-
> > sound/soc/codecs/cs35l45.c | 2 +-
> > sound/soc/codecs/cs35l56-sdw.c | 4 +-
> > sound/soc/codecs/cs35l56-shared.c | 2 +-
> > sound/soc/codecs/cs35l56.c | 2 +-
> > sound/soc/codecs/cs42l42-sdw.c | 2 +-
> > sound/soc/codecs/cs42l42.c | 4 +-
> > sound/soc/codecs/cs42l43-jack.c | 10 +-
> > sound/soc/codecs/cs42l43.c | 4 +-
> > sound/soc/codecs/hda.c | 6 +-
> > sound/soc/codecs/madera.c | 6 +-
> > sound/soc/codecs/max98363.c | 2 +-
> > sound/soc/codecs/max98373-sdw.c | 2 +-
> > sound/soc/codecs/rt1017-sdca-sdw.c | 2 +-
> > sound/soc/codecs/rt1308-sdw.c | 2 +-
> > sound/soc/codecs/rt1316-sdw.c | 2 +-
> > sound/soc/codecs/rt1318-sdw.c | 2 +-
> > sound/soc/codecs/rt1320-sdw.c | 2 +-
> > sound/soc/codecs/rt5682-sdw.c | 2 +-
> > sound/soc/codecs/rt700.c | 4 +-
> > sound/soc/codecs/rt711-sdca.c | 4 +-
> > sound/soc/codecs/rt711.c | 4 +-
> > sound/soc/codecs/rt712-sdca-dmic.c | 2 +-
> > sound/soc/codecs/rt712-sdca.c | 4 +-
> > sound/soc/codecs/rt715-sdca.c | 2 +-
> > sound/soc/codecs/rt715.c | 2 +-
> > sound/soc/codecs/rt722-sdca.c | 4 +-
> > sound/soc/codecs/wcd-mbhc-v2.c | 4 +-
> > sound/soc/codecs/wsa881x.c | 2 +-
> > sound/soc/codecs/wsa884x.c | 2 +-
> > sound/soc/intel/atom/sst/sst_pvt.c | 2 +-
> > sound/soc/intel/avs/core.c | 2 +-
> > sound/soc/intel/avs/debugfs.c | 4 +-
> > sound/soc/intel/avs/pcm.c | 2 +-
> > sound/soc/intel/catpt/pcm.c | 12 +-
> > sound/soc/intel/catpt/sysfs.c | 2 +-
> > sound/soc/soc-component.c | 2 +-
> > sound/soc/sof/control.c | 2 +-
> > sound/soc/sof/debug.c | 2 +-
> > sound/soc/sof/ipc3-dtrace.c | 2 +-
> > sound/soc/sof/ipc4-loader.c | 2 +-
> > sound/soc/sof/pcm.c | 2 +-
> > sound/soc/sof/sof-client-ipc-flood-test.c | 2 +-
> > .../soc/sof/sof-client-ipc-kernel-injector.c | 2 +-
> > sound/soc/sof/sof-client-ipc-msg-injector.c | 2 +-
> > sound/soc/sof/sof-client-probes.c | 6 +-
> > sound/x86/intel_hdmi_audio.c | 6 +-
> > 373 files changed, 1076 insertions(+), 1076 deletions(-)
--
Regards,
Laurent Pinchart
^ permalink raw reply [flat|nested] 14+ messages in thread
* Re: [PATCH 00/51] treewide: Switch to __pm_runtime_put_autosuspend()
2024-10-07 18:49 ` Laurent Pinchart
@ 2024-10-07 22:08 ` Ulf Hansson
2024-10-07 22:25 ` Laurent Pinchart
2024-10-08 20:38 ` Uwe Kleine-König
1 sibling, 1 reply; 14+ messages in thread
From: Ulf Hansson @ 2024-10-07 22:08 UTC (permalink / raw)
To: Laurent Pinchart
Cc: Sakari Ailus, dri-devel, linux-kernel, linux-bluetooth, linux-clk,
linux-crypto, dmaengine, linux-gpio, amd-gfx, nouveau,
linux-stm32, linux-arm-kernel, linux-i2c, linux-i3c, linux-iio,
linux-input, patches, iommu, imx, linux-mediatek, linux-media,
linux-mmc, linux-mtd, netdev, linux-wireless, linux-pci,
linux-phy, linux-pwm, linux-remoteproc, linux-sound, linux-spi,
linux-staging, linux-usb, linux-serial, greybus-dev, asahi,
rafael, Andy Shevchenko
On Mon, 7 Oct 2024 at 20:49, Laurent Pinchart
<laurent.pinchart@ideasonboard.com> wrote:
>
> Hi Ulf,
>
> On Fri, Oct 04, 2024 at 04:38:36PM +0200, Ulf Hansson wrote:
> > On Fri, 4 Oct 2024 at 11:41, Sakari Ailus <sakari.ailus@linux.intel.com> wrote:
> > >
> > > Hello everyone,
> > >
> > > This set will switch the users of pm_runtime_put_autosuspend() to
> > > __pm_runtime_put_autosuspend() while the former will soon be re-purposed
> > > to include a call to pm_runtime_mark_last_busy(). The two are almost
> > > always used together, apart from bugs which are likely common. Going
> > > forward, most new users should be using pm_runtime_put_autosuspend().
> > >
> > > Once this conversion is done and pm_runtime_put_autosuspend() re-purposed,
> > > I'll post another set to merge the calls to __pm_runtime_put_autosuspend()
> > > and pm_runtime_mark_last_busy().
> >
> > That sounds like it could cause a lot of churns.
> >
> > Why not add a new helper function that does the
> > pm_runtime_put_autosuspend() and the pm_runtime_mark_last_busy()
> > things? Then we can start moving users over to this new interface,
> > rather than having this intermediate step?
>
> I think the API would be nicer if we used the shortest and simplest
> function names for the most common use cases. Following
> pm_runtime_put_autosuspend() with pm_runtime_mark_last_busy() is that
> most common use case. That's why I like Sakari's approach of repurposing
> pm_runtime_put_autosuspend(), and introducing
> __pm_runtime_put_autosuspend() for the odd cases where
> pm_runtime_mark_last_busy() shouldn't be called.
Okay, so the reason for this approach is because we couldn't find a
short and descriptive name that could be used in favor of
pm_runtime_put_autosuspend(). Let me throw some ideas at it and maybe
you like it - or not. :-)
I don't know what options you guys discussed, but to me the entire
"autosuspend"-suffix isn't really that necessary in my opinion. There
are more ways than calling pm_runtime_put_autosuspend() that triggers
us to use the RPM_AUTO flag for rpm_suspend(). For example, just
calling pm_runtime_put() has the similar effect.
Moreover, it's similar for pm_runtime_mark_last_busy(), it's called
during rpm_resume() too, for example. So why bother about having
"mark_last_busy" in the new name too.
That said, my suggestion is simply "pm_runtime_put_suspend".
If you don't like it, I will certainly not object to your current
approach, even if I think it leads to unnecessary churns.
[...]
Kind regards
Uffe
^ permalink raw reply [flat|nested] 14+ messages in thread
* Re: [PATCH 00/51] treewide: Switch to __pm_runtime_put_autosuspend()
2024-10-07 22:08 ` Ulf Hansson
@ 2024-10-07 22:25 ` Laurent Pinchart
2024-10-07 22:34 ` Ulf Hansson
0 siblings, 1 reply; 14+ messages in thread
From: Laurent Pinchart @ 2024-10-07 22:25 UTC (permalink / raw)
To: Ulf Hansson
Cc: Sakari Ailus, dri-devel, linux-kernel, linux-bluetooth, linux-clk,
linux-crypto, dmaengine, linux-gpio, amd-gfx, nouveau,
linux-stm32, linux-arm-kernel, linux-i2c, linux-i3c, linux-iio,
linux-input, patches, iommu, imx, linux-mediatek, linux-media,
linux-mmc, linux-mtd, netdev, linux-wireless, linux-pci,
linux-phy, linux-pwm, linux-remoteproc, linux-sound, linux-spi,
linux-staging, linux-usb, linux-serial, greybus-dev, asahi,
rafael, Andy Shevchenko
Hi Ulf,
On Tue, Oct 08, 2024 at 12:08:24AM +0200, Ulf Hansson wrote:
> On Mon, 7 Oct 2024 at 20:49, Laurent Pinchart wrote:
> > On Fri, Oct 04, 2024 at 04:38:36PM +0200, Ulf Hansson wrote:
> > > On Fri, 4 Oct 2024 at 11:41, Sakari Ailus wrote:
> > > >
> > > > Hello everyone,
> > > >
> > > > This set will switch the users of pm_runtime_put_autosuspend() to
> > > > __pm_runtime_put_autosuspend() while the former will soon be re-purposed
> > > > to include a call to pm_runtime_mark_last_busy(). The two are almost
> > > > always used together, apart from bugs which are likely common. Going
> > > > forward, most new users should be using pm_runtime_put_autosuspend().
> > > >
> > > > Once this conversion is done and pm_runtime_put_autosuspend() re-purposed,
> > > > I'll post another set to merge the calls to __pm_runtime_put_autosuspend()
> > > > and pm_runtime_mark_last_busy().
> > >
> > > That sounds like it could cause a lot of churns.
> > >
> > > Why not add a new helper function that does the
> > > pm_runtime_put_autosuspend() and the pm_runtime_mark_last_busy()
> > > things? Then we can start moving users over to this new interface,
> > > rather than having this intermediate step?
> >
> > I think the API would be nicer if we used the shortest and simplest
> > function names for the most common use cases. Following
> > pm_runtime_put_autosuspend() with pm_runtime_mark_last_busy() is that
> > most common use case. That's why I like Sakari's approach of repurposing
> > pm_runtime_put_autosuspend(), and introducing
> > __pm_runtime_put_autosuspend() for the odd cases where
> > pm_runtime_mark_last_busy() shouldn't be called.
>
> Okay, so the reason for this approach is because we couldn't find a
> short and descriptive name that could be used in favor of
> pm_runtime_put_autosuspend(). Let me throw some ideas at it and maybe
> you like it - or not. :-)
I like the idea at least :-)
> I don't know what options you guys discussed, but to me the entire
> "autosuspend"-suffix isn't really that necessary in my opinion. There
> are more ways than calling pm_runtime_put_autosuspend() that triggers
> us to use the RPM_AUTO flag for rpm_suspend(). For example, just
> calling pm_runtime_put() has the similar effect.
To be honest, I'm lost there. pm_runtime_put() calls
__pm_runtime_idle(RPM_GET_PUT | RPM_ASYNC), while
pm_runtime_put_autosuspend() calls __pm_runtime_suspend(RPM_GET_PUT |
RPM_ASYNC | RPM_AUTO).
>
> Moreover, it's similar for pm_runtime_mark_last_busy(), it's called
> during rpm_resume() too, for example. So why bother about having
> "mark_last_busy" in the new name too.
>
> That said, my suggestion is simply "pm_runtime_put_suspend".
Can we do even better, and make pm_runtime_put() to handle autosuspend
automatically when autosuspend is enabled ?
> If you don't like it, I will certainly not object to your current
> approach, even if I think it leads to unnecessary churns.
>
> [...]
>
> Kind regards
> Uffe
--
Regards,
Laurent Pinchart
^ permalink raw reply [flat|nested] 14+ messages in thread
* Re: [PATCH 00/51] treewide: Switch to __pm_runtime_put_autosuspend()
2024-10-07 22:25 ` Laurent Pinchart
@ 2024-10-07 22:34 ` Ulf Hansson
2024-10-08 18:24 ` Rafael J. Wysocki
0 siblings, 1 reply; 14+ messages in thread
From: Ulf Hansson @ 2024-10-07 22:34 UTC (permalink / raw)
To: Laurent Pinchart
Cc: Sakari Ailus, dri-devel, linux-kernel, linux-bluetooth, linux-clk,
linux-crypto, dmaengine, linux-gpio, amd-gfx, nouveau,
linux-stm32, linux-arm-kernel, linux-i2c, linux-i3c, linux-iio,
linux-input, patches, iommu, imx, linux-mediatek, linux-media,
linux-mmc, linux-mtd, netdev, linux-wireless, linux-pci,
linux-phy, linux-pwm, linux-remoteproc, linux-sound, linux-spi,
linux-staging, linux-usb, linux-serial, greybus-dev, asahi,
rafael, Andy Shevchenko
On Tue, 8 Oct 2024 at 00:25, Laurent Pinchart
<laurent.pinchart@ideasonboard.com> wrote:
>
> Hi Ulf,
>
> On Tue, Oct 08, 2024 at 12:08:24AM +0200, Ulf Hansson wrote:
> > On Mon, 7 Oct 2024 at 20:49, Laurent Pinchart wrote:
> > > On Fri, Oct 04, 2024 at 04:38:36PM +0200, Ulf Hansson wrote:
> > > > On Fri, 4 Oct 2024 at 11:41, Sakari Ailus wrote:
> > > > >
> > > > > Hello everyone,
> > > > >
> > > > > This set will switch the users of pm_runtime_put_autosuspend() to
> > > > > __pm_runtime_put_autosuspend() while the former will soon be re-purposed
> > > > > to include a call to pm_runtime_mark_last_busy(). The two are almost
> > > > > always used together, apart from bugs which are likely common. Going
> > > > > forward, most new users should be using pm_runtime_put_autosuspend().
> > > > >
> > > > > Once this conversion is done and pm_runtime_put_autosuspend() re-purposed,
> > > > > I'll post another set to merge the calls to __pm_runtime_put_autosuspend()
> > > > > and pm_runtime_mark_last_busy().
> > > >
> > > > That sounds like it could cause a lot of churns.
> > > >
> > > > Why not add a new helper function that does the
> > > > pm_runtime_put_autosuspend() and the pm_runtime_mark_last_busy()
> > > > things? Then we can start moving users over to this new interface,
> > > > rather than having this intermediate step?
> > >
> > > I think the API would be nicer if we used the shortest and simplest
> > > function names for the most common use cases. Following
> > > pm_runtime_put_autosuspend() with pm_runtime_mark_last_busy() is that
> > > most common use case. That's why I like Sakari's approach of repurposing
> > > pm_runtime_put_autosuspend(), and introducing
> > > __pm_runtime_put_autosuspend() for the odd cases where
> > > pm_runtime_mark_last_busy() shouldn't be called.
> >
> > Okay, so the reason for this approach is because we couldn't find a
> > short and descriptive name that could be used in favor of
> > pm_runtime_put_autosuspend(). Let me throw some ideas at it and maybe
> > you like it - or not. :-)
>
> I like the idea at least :-)
>
> > I don't know what options you guys discussed, but to me the entire
> > "autosuspend"-suffix isn't really that necessary in my opinion. There
> > are more ways than calling pm_runtime_put_autosuspend() that triggers
> > us to use the RPM_AUTO flag for rpm_suspend(). For example, just
> > calling pm_runtime_put() has the similar effect.
>
> To be honest, I'm lost there. pm_runtime_put() calls
> __pm_runtime_idle(RPM_GET_PUT | RPM_ASYNC), while
> pm_runtime_put_autosuspend() calls __pm_runtime_suspend(RPM_GET_PUT |
> RPM_ASYNC | RPM_AUTO).
__pm_runtime_idle() ends up calling rpm_idle(), which may call
rpm_suspend() - if it succeeds to idle the device. In that case, it
tags on the RPM_AUTO flag in the call to rpm_suspend(). Quite similar
to what is happening when calling pm_runtime_put_autosuspend().
>
> >
> > Moreover, it's similar for pm_runtime_mark_last_busy(), it's called
> > during rpm_resume() too, for example. So why bother about having
> > "mark_last_busy" in the new name too.
> >
> > That said, my suggestion is simply "pm_runtime_put_suspend".
>
> Can we do even better, and make pm_runtime_put() to handle autosuspend
> automatically when autosuspend is enabled ?
As stated above, this is already the case.
>
> > If you don't like it, I will certainly not object to your current
> > approach, even if I think it leads to unnecessary churns.
> >
> > [...]
> >
> > Kind regards
> > Uffe
>
> --
> Regards,
>
> Laurent Pinchart
Kind regards
Uffe
^ permalink raw reply [flat|nested] 14+ messages in thread
* Re: [PATCH 00/51] treewide: Switch to __pm_runtime_put_autosuspend()
2024-10-07 22:34 ` Ulf Hansson
@ 2024-10-08 18:24 ` Rafael J. Wysocki
2024-10-09 10:20 ` Rafael J. Wysocki
` (2 more replies)
0 siblings, 3 replies; 14+ messages in thread
From: Rafael J. Wysocki @ 2024-10-08 18:24 UTC (permalink / raw)
To: Ulf Hansson, Laurent Pinchart, Sakari Ailus
Cc: dri-devel, linux-kernel, linux-bluetooth, linux-clk, linux-crypto,
dmaengine, linux-gpio, amd-gfx, nouveau, linux-stm32,
linux-arm-kernel, linux-i2c, linux-i3c, linux-iio, linux-input,
patches, iommu, imx, linux-mediatek, linux-media, linux-mmc,
linux-mtd, netdev, linux-wireless, linux-pci, linux-phy,
linux-pwm, linux-remoteproc, linux-sound, linux-spi,
linux-staging, linux-usb, linux-serial, greybus-dev, asahi,
Andy Shevchenko
On Tue, Oct 8, 2024 at 12:35 AM Ulf Hansson <ulf.hansson@linaro.org> wrote:
>
> On Tue, 8 Oct 2024 at 00:25, Laurent Pinchart
> <laurent.pinchart@ideasonboard.com> wrote:
> >
> > Hi Ulf,
> >
> > On Tue, Oct 08, 2024 at 12:08:24AM +0200, Ulf Hansson wrote:
> > > On Mon, 7 Oct 2024 at 20:49, Laurent Pinchart wrote:
> > > > On Fri, Oct 04, 2024 at 04:38:36PM +0200, Ulf Hansson wrote:
> > > > > On Fri, 4 Oct 2024 at 11:41, Sakari Ailus wrote:
> > > > > >
> > > > > > Hello everyone,
> > > > > >
> > > > > > This set will switch the users of pm_runtime_put_autosuspend() to
> > > > > > __pm_runtime_put_autosuspend() while the former will soon be re-purposed
> > > > > > to include a call to pm_runtime_mark_last_busy(). The two are almost
> > > > > > always used together, apart from bugs which are likely common. Going
> > > > > > forward, most new users should be using pm_runtime_put_autosuspend().
> > > > > >
> > > > > > Once this conversion is done and pm_runtime_put_autosuspend() re-purposed,
> > > > > > I'll post another set to merge the calls to __pm_runtime_put_autosuspend()
> > > > > > and pm_runtime_mark_last_busy().
> > > > >
> > > > > That sounds like it could cause a lot of churns.
> > > > >
> > > > > Why not add a new helper function that does the
> > > > > pm_runtime_put_autosuspend() and the pm_runtime_mark_last_busy()
> > > > > things? Then we can start moving users over to this new interface,
> > > > > rather than having this intermediate step?
> > > >
> > > > I think the API would be nicer if we used the shortest and simplest
> > > > function names for the most common use cases. Following
> > > > pm_runtime_put_autosuspend() with pm_runtime_mark_last_busy() is that
> > > > most common use case. That's why I like Sakari's approach of repurposing
> > > > pm_runtime_put_autosuspend(), and introducing
> > > > __pm_runtime_put_autosuspend() for the odd cases where
> > > > pm_runtime_mark_last_busy() shouldn't be called.
> > >
> > > Okay, so the reason for this approach is because we couldn't find a
> > > short and descriptive name that could be used in favor of
> > > pm_runtime_put_autosuspend(). Let me throw some ideas at it and maybe
> > > you like it - or not. :-)
> >
> > I like the idea at least :-)
> >
> > > I don't know what options you guys discussed, but to me the entire
> > > "autosuspend"-suffix isn't really that necessary in my opinion. There
> > > are more ways than calling pm_runtime_put_autosuspend() that triggers
> > > us to use the RPM_AUTO flag for rpm_suspend(). For example, just
> > > calling pm_runtime_put() has the similar effect.
> >
> > To be honest, I'm lost there. pm_runtime_put() calls
> > __pm_runtime_idle(RPM_GET_PUT | RPM_ASYNC), while
> > pm_runtime_put_autosuspend() calls __pm_runtime_suspend(RPM_GET_PUT |
> > RPM_ASYNC | RPM_AUTO).
>
> __pm_runtime_idle() ends up calling rpm_idle(), which may call
> rpm_suspend() - if it succeeds to idle the device. In that case, it
> tags on the RPM_AUTO flag in the call to rpm_suspend(). Quite similar
> to what is happening when calling pm_runtime_put_autosuspend().
Right.
For almost everybody, except for a small bunch of drivers that
actually have a .runtime_idle() callback, pm_runtime_put() is
literally equivalent to pm_runtime_put_autosuspend().
So really the question is why anyone who doesn't provide a
.runtime_idle() callback bothers with using this special
pm_runtime_put_autosuspend() thing, which really means "do a
runtime_put(), but skip my .runtime_idle() callback".
> >
> > >
> > > Moreover, it's similar for pm_runtime_mark_last_busy(), it's called
> > > during rpm_resume() too, for example. So why bother about having
> > > "mark_last_busy" in the new name too.
> > >
> > > That said, my suggestion is simply "pm_runtime_put_suspend".
> >
> > Can we do even better, and make pm_runtime_put() to handle autosuspend
> > automatically when autosuspend is enabled ?
>
> As stated above, this is already the case.
What really is needed appears to be a combination of
pm_runtime_mark_last_busy() with pm_runtime_put().
Granted, pm_runtime_put() could do the pm_runtime_mark_last_busy()
thing automatically if autosuspend is enabled and the only consequence
of it might be delaying a suspend of the device until its autosuspend
timer expires, which should not be a problem in the vast majority of
cases.
^ permalink raw reply [flat|nested] 14+ messages in thread
* Re: [PATCH 00/51] treewide: Switch to __pm_runtime_put_autosuspend()
2024-10-07 18:49 ` Laurent Pinchart
2024-10-07 22:08 ` Ulf Hansson
@ 2024-10-08 20:38 ` Uwe Kleine-König
1 sibling, 0 replies; 14+ messages in thread
From: Uwe Kleine-König @ 2024-10-08 20:38 UTC (permalink / raw)
To: Laurent Pinchart
Cc: Ulf Hansson, Sakari Ailus, dri-devel, linux-kernel,
linux-bluetooth, linux-clk, linux-crypto, dmaengine, linux-gpio,
amd-gfx, nouveau, linux-stm32, linux-arm-kernel, linux-i2c,
linux-i3c, linux-iio, linux-input, patches, iommu, imx,
linux-mediatek, linux-media, linux-mmc, linux-mtd, netdev,
linux-wireless, linux-pci, linux-phy, linux-pwm, linux-remoteproc,
linux-sound, linux-spi, linux-staging, linux-usb, linux-serial,
greybus-dev, asahi, rafael, Andy Shevchenko
[-- Attachment #1: Type: text/plain, Size: 2371 bytes --]
Hello,
On Mon, Oct 07, 2024 at 09:49:24PM +0300, Laurent Pinchart wrote:
> On Fri, Oct 04, 2024 at 04:38:36PM +0200, Ulf Hansson wrote:
> > On Fri, 4 Oct 2024 at 11:41, Sakari Ailus <sakari.ailus@linux.intel.com> wrote:
> > >
> > > Hello everyone,
> > >
> > > This set will switch the users of pm_runtime_put_autosuspend() to
> > > __pm_runtime_put_autosuspend() while the former will soon be re-purposed
> > > to include a call to pm_runtime_mark_last_busy(). The two are almost
> > > always used together, apart from bugs which are likely common. Going
> > > forward, most new users should be using pm_runtime_put_autosuspend().
> > >
> > > Once this conversion is done and pm_runtime_put_autosuspend() re-purposed,
> > > I'll post another set to merge the calls to __pm_runtime_put_autosuspend()
> > > and pm_runtime_mark_last_busy().
> >
> > That sounds like it could cause a lot of churns.
> >
> > Why not add a new helper function that does the
> > pm_runtime_put_autosuspend() and the pm_runtime_mark_last_busy()
> > things? Then we can start moving users over to this new interface,
> > rather than having this intermediate step?
>
> I think the API would be nicer if we used the shortest and simplest
> function names for the most common use cases. Following
> pm_runtime_put_autosuspend() with pm_runtime_mark_last_busy() is that
> most common use case. That's why I like Sakari's approach of repurposing
> pm_runtime_put_autosuspend(), and introducing
> __pm_runtime_put_autosuspend() for the odd cases where
> pm_runtime_mark_last_busy() shouldn't be called.
That's ok for me. However this patch series isn't the optimal path to
there because most drivers (i.e. those that already today do
pm_runtime_mark_last_busy() in combination with
pm_runtime_put_autosuspend()) have to be patched twice.
The saner route is: Only convert the drivers with a sole
pm_runtime_put_autosuspend() (i.e. without pm_runtime_mark_last_busy())
to __pm_runtime_put_autosuspend(). Then add the mark_last_busy() bits to
pm_runtime_put_autosuspend() and then drop the explicit calls to
pm_runtime_mark_last_busy() before pm_runtime_put_autosuspend().
(Note this doesn't take into account Rafael's position that
pm_runtime_put() might be the saner option. My argument applies for that
conversion analogously.)
Best regards
Uwe
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
^ permalink raw reply [flat|nested] 14+ messages in thread
* Re: [PATCH 00/51] treewide: Switch to __pm_runtime_put_autosuspend()
2024-10-08 18:24 ` Rafael J. Wysocki
@ 2024-10-09 10:20 ` Rafael J. Wysocki
2024-10-09 10:27 ` Ulf Hansson
2024-10-09 12:48 ` Richard Fitzgerald
2 siblings, 0 replies; 14+ messages in thread
From: Rafael J. Wysocki @ 2024-10-09 10:20 UTC (permalink / raw)
To: Ulf Hansson, Laurent Pinchart, Sakari Ailus
Cc: dri-devel, linux-kernel, linux-bluetooth, linux-clk, linux-crypto,
dmaengine, linux-gpio, amd-gfx, nouveau, linux-stm32,
linux-arm-kernel, linux-i2c, linux-i3c, linux-iio, linux-input,
patches, iommu, imx, linux-mediatek, linux-media, linux-mmc,
linux-mtd, netdev, linux-wireless, linux-pci, linux-phy,
linux-pwm, linux-remoteproc, linux-sound, linux-spi,
linux-staging, linux-usb, linux-serial, greybus-dev, asahi,
Andy Shevchenko
On Tue, Oct 8, 2024 at 8:24 PM Rafael J. Wysocki <rafael@kernel.org> wrote:
>
> On Tue, Oct 8, 2024 at 12:35 AM Ulf Hansson <ulf.hansson@linaro.org> wrote:
> >
> > On Tue, 8 Oct 2024 at 00:25, Laurent Pinchart
> > <laurent.pinchart@ideasonboard.com> wrote:
> > >
> > > Hi Ulf,
> > >
> > > On Tue, Oct 08, 2024 at 12:08:24AM +0200, Ulf Hansson wrote:
> > > > On Mon, 7 Oct 2024 at 20:49, Laurent Pinchart wrote:
> > > > > On Fri, Oct 04, 2024 at 04:38:36PM +0200, Ulf Hansson wrote:
> > > > > > On Fri, 4 Oct 2024 at 11:41, Sakari Ailus wrote:
> > > > > > >
> > > > > > > Hello everyone,
> > > > > > >
> > > > > > > This set will switch the users of pm_runtime_put_autosuspend() to
> > > > > > > __pm_runtime_put_autosuspend() while the former will soon be re-purposed
> > > > > > > to include a call to pm_runtime_mark_last_busy(). The two are almost
> > > > > > > always used together, apart from bugs which are likely common. Going
> > > > > > > forward, most new users should be using pm_runtime_put_autosuspend().
> > > > > > >
> > > > > > > Once this conversion is done and pm_runtime_put_autosuspend() re-purposed,
> > > > > > > I'll post another set to merge the calls to __pm_runtime_put_autosuspend()
> > > > > > > and pm_runtime_mark_last_busy().
> > > > > >
> > > > > > That sounds like it could cause a lot of churns.
> > > > > >
> > > > > > Why not add a new helper function that does the
> > > > > > pm_runtime_put_autosuspend() and the pm_runtime_mark_last_busy()
> > > > > > things? Then we can start moving users over to this new interface,
> > > > > > rather than having this intermediate step?
> > > > >
> > > > > I think the API would be nicer if we used the shortest and simplest
> > > > > function names for the most common use cases. Following
> > > > > pm_runtime_put_autosuspend() with pm_runtime_mark_last_busy() is that
> > > > > most common use case. That's why I like Sakari's approach of repurposing
> > > > > pm_runtime_put_autosuspend(), and introducing
> > > > > __pm_runtime_put_autosuspend() for the odd cases where
> > > > > pm_runtime_mark_last_busy() shouldn't be called.
> > > >
> > > > Okay, so the reason for this approach is because we couldn't find a
> > > > short and descriptive name that could be used in favor of
> > > > pm_runtime_put_autosuspend(). Let me throw some ideas at it and maybe
> > > > you like it - or not. :-)
> > >
> > > I like the idea at least :-)
> > >
> > > > I don't know what options you guys discussed, but to me the entire
> > > > "autosuspend"-suffix isn't really that necessary in my opinion. There
> > > > are more ways than calling pm_runtime_put_autosuspend() that triggers
> > > > us to use the RPM_AUTO flag for rpm_suspend(). For example, just
> > > > calling pm_runtime_put() has the similar effect.
> > >
> > > To be honest, I'm lost there. pm_runtime_put() calls
> > > __pm_runtime_idle(RPM_GET_PUT | RPM_ASYNC), while
> > > pm_runtime_put_autosuspend() calls __pm_runtime_suspend(RPM_GET_PUT |
> > > RPM_ASYNC | RPM_AUTO).
> >
> > __pm_runtime_idle() ends up calling rpm_idle(), which may call
> > rpm_suspend() - if it succeeds to idle the device. In that case, it
> > tags on the RPM_AUTO flag in the call to rpm_suspend(). Quite similar
> > to what is happening when calling pm_runtime_put_autosuspend().
>
> Right.
>
> For almost everybody, except for a small bunch of drivers that
> actually have a .runtime_idle() callback, pm_runtime_put() is
> literally equivalent to pm_runtime_put_autosuspend().
>
> So really the question is why anyone who doesn't provide a
> .runtime_idle() callback bothers with using this special
> pm_runtime_put_autosuspend() thing, which really means "do a
> runtime_put(), but skip my .runtime_idle() callback".
>
> > >
> > > >
> > > > Moreover, it's similar for pm_runtime_mark_last_busy(), it's called
> > > > during rpm_resume() too, for example. So why bother about having
> > > > "mark_last_busy" in the new name too.
> > > >
> > > > That said, my suggestion is simply "pm_runtime_put_suspend".
> > >
> > > Can we do even better, and make pm_runtime_put() to handle autosuspend
> > > automatically when autosuspend is enabled ?
> >
> > As stated above, this is already the case.
>
> What really is needed appears to be a combination of
> pm_runtime_mark_last_busy() with pm_runtime_put().
>
> Granted, pm_runtime_put() could do the pm_runtime_mark_last_busy()
> thing automatically if autosuspend is enabled and the only consequence
> of it might be delaying a suspend of the device until its autosuspend
> timer expires, which should not be a problem in the vast majority of
> cases.
That said, it is likely better to avoid surprising the current users
of pm_runtime_put() and define something like
static inline void pm_runtime_touch_and_put(struct device *dev)
{
pm_runtime_mark_last_busy(dev);
pm_runtime_put(dev);
}
^ permalink raw reply [flat|nested] 14+ messages in thread
* Re: [PATCH 00/51] treewide: Switch to __pm_runtime_put_autosuspend()
2024-10-08 18:24 ` Rafael J. Wysocki
2024-10-09 10:20 ` Rafael J. Wysocki
@ 2024-10-09 10:27 ` Ulf Hansson
2024-10-09 12:48 ` Richard Fitzgerald
2 siblings, 0 replies; 14+ messages in thread
From: Ulf Hansson @ 2024-10-09 10:27 UTC (permalink / raw)
To: Rafael J. Wysocki
Cc: Laurent Pinchart, Sakari Ailus, dri-devel, linux-kernel,
linux-bluetooth, linux-clk, linux-crypto, dmaengine, linux-gpio,
amd-gfx, nouveau, linux-stm32, linux-arm-kernel, linux-i2c,
linux-i3c, linux-iio, linux-input, patches, iommu, imx,
linux-mediatek, linux-media, linux-mmc, linux-mtd, netdev,
linux-wireless, linux-pci, linux-phy, linux-pwm, linux-remoteproc,
linux-sound, linux-spi, linux-staging, linux-usb, linux-serial,
greybus-dev, asahi, Andy Shevchenko
On Tue, 8 Oct 2024 at 20:25, Rafael J. Wysocki <rafael@kernel.org> wrote:
>
> On Tue, Oct 8, 2024 at 12:35 AM Ulf Hansson <ulf.hansson@linaro.org> wrote:
> >
> > On Tue, 8 Oct 2024 at 00:25, Laurent Pinchart
> > <laurent.pinchart@ideasonboard.com> wrote:
> > >
> > > Hi Ulf,
> > >
> > > On Tue, Oct 08, 2024 at 12:08:24AM +0200, Ulf Hansson wrote:
> > > > On Mon, 7 Oct 2024 at 20:49, Laurent Pinchart wrote:
> > > > > On Fri, Oct 04, 2024 at 04:38:36PM +0200, Ulf Hansson wrote:
> > > > > > On Fri, 4 Oct 2024 at 11:41, Sakari Ailus wrote:
> > > > > > >
> > > > > > > Hello everyone,
> > > > > > >
> > > > > > > This set will switch the users of pm_runtime_put_autosuspend() to
> > > > > > > __pm_runtime_put_autosuspend() while the former will soon be re-purposed
> > > > > > > to include a call to pm_runtime_mark_last_busy(). The two are almost
> > > > > > > always used together, apart from bugs which are likely common. Going
> > > > > > > forward, most new users should be using pm_runtime_put_autosuspend().
> > > > > > >
> > > > > > > Once this conversion is done and pm_runtime_put_autosuspend() re-purposed,
> > > > > > > I'll post another set to merge the calls to __pm_runtime_put_autosuspend()
> > > > > > > and pm_runtime_mark_last_busy().
> > > > > >
> > > > > > That sounds like it could cause a lot of churns.
> > > > > >
> > > > > > Why not add a new helper function that does the
> > > > > > pm_runtime_put_autosuspend() and the pm_runtime_mark_last_busy()
> > > > > > things? Then we can start moving users over to this new interface,
> > > > > > rather than having this intermediate step?
> > > > >
> > > > > I think the API would be nicer if we used the shortest and simplest
> > > > > function names for the most common use cases. Following
> > > > > pm_runtime_put_autosuspend() with pm_runtime_mark_last_busy() is that
> > > > > most common use case. That's why I like Sakari's approach of repurposing
> > > > > pm_runtime_put_autosuspend(), and introducing
> > > > > __pm_runtime_put_autosuspend() for the odd cases where
> > > > > pm_runtime_mark_last_busy() shouldn't be called.
> > > >
> > > > Okay, so the reason for this approach is because we couldn't find a
> > > > short and descriptive name that could be used in favor of
> > > > pm_runtime_put_autosuspend(). Let me throw some ideas at it and maybe
> > > > you like it - or not. :-)
> > >
> > > I like the idea at least :-)
> > >
> > > > I don't know what options you guys discussed, but to me the entire
> > > > "autosuspend"-suffix isn't really that necessary in my opinion. There
> > > > are more ways than calling pm_runtime_put_autosuspend() that triggers
> > > > us to use the RPM_AUTO flag for rpm_suspend(). For example, just
> > > > calling pm_runtime_put() has the similar effect.
> > >
> > > To be honest, I'm lost there. pm_runtime_put() calls
> > > __pm_runtime_idle(RPM_GET_PUT | RPM_ASYNC), while
> > > pm_runtime_put_autosuspend() calls __pm_runtime_suspend(RPM_GET_PUT |
> > > RPM_ASYNC | RPM_AUTO).
> >
> > __pm_runtime_idle() ends up calling rpm_idle(), which may call
> > rpm_suspend() - if it succeeds to idle the device. In that case, it
> > tags on the RPM_AUTO flag in the call to rpm_suspend(). Quite similar
> > to what is happening when calling pm_runtime_put_autosuspend().
>
> Right.
>
> For almost everybody, except for a small bunch of drivers that
> actually have a .runtime_idle() callback, pm_runtime_put() is
> literally equivalent to pm_runtime_put_autosuspend().
>
> So really the question is why anyone who doesn't provide a
> .runtime_idle() callback bothers with using this special
> pm_runtime_put_autosuspend() thing, which really means "do a
> runtime_put(), but skip my .runtime_idle() callback".
My guess is that it's in most cases a legacy pattern that is being
followed. Also note that rpm_idle() didn't "always" tag on the
RPM_AUTO flag, even if it's quite a while ago (2013) since we added
it.
Unless there is some actual optimization involved, as it also allows
us to skip calling rpm_idle() and go directly for rpm_suspend().
>
> > >
> > > >
> > > > Moreover, it's similar for pm_runtime_mark_last_busy(), it's called
> > > > during rpm_resume() too, for example. So why bother about having
> > > > "mark_last_busy" in the new name too.
> > > >
> > > > That said, my suggestion is simply "pm_runtime_put_suspend".
> > >
> > > Can we do even better, and make pm_runtime_put() to handle autosuspend
> > > automatically when autosuspend is enabled ?
> >
> > As stated above, this is already the case.
>
> What really is needed appears to be a combination of
> pm_runtime_mark_last_busy() with pm_runtime_put().
This makes sense to me too, but I don't think we should limit it to this.
Making pm_runtime_put_autosuspend (or if the name
"pm_runtime_put_suspend" is better?) to do the similar thing, is
probably a good idea too. At least in my opinion.
>
> Granted, pm_runtime_put() could do the pm_runtime_mark_last_busy()
> thing automatically if autosuspend is enabled and the only consequence
> of it might be delaying a suspend of the device until its autosuspend
> timer expires, which should not be a problem in the vast majority of
> cases.
Right.
I guess we should expect the *sync* variants to be used, if the timer
really needs to be overridden.
Kind regards
Uffe
^ permalink raw reply [flat|nested] 14+ messages in thread
* Re: [PATCH 00/51] treewide: Switch to __pm_runtime_put_autosuspend()
2024-10-08 18:24 ` Rafael J. Wysocki
2024-10-09 10:20 ` Rafael J. Wysocki
2024-10-09 10:27 ` Ulf Hansson
@ 2024-10-09 12:48 ` Richard Fitzgerald
2024-10-09 13:34 ` Rafael J. Wysocki
2 siblings, 1 reply; 14+ messages in thread
From: Richard Fitzgerald @ 2024-10-09 12:48 UTC (permalink / raw)
To: Rafael J. Wysocki, Ulf Hansson, Laurent Pinchart, Sakari Ailus
Cc: dri-devel, linux-kernel, linux-bluetooth, linux-clk, linux-crypto,
dmaengine, linux-gpio, amd-gfx, nouveau, linux-stm32,
linux-arm-kernel, linux-i2c, linux-i3c, linux-iio, linux-input,
patches, iommu, imx, linux-mediatek, linux-media, linux-mmc,
linux-mtd, netdev, linux-wireless, linux-pci, linux-phy,
linux-pwm, linux-remoteproc, linux-sound, linux-spi,
linux-staging, linux-usb, linux-serial, greybus-dev, asahi,
Andy Shevchenko
On 08/10/2024 7:24 pm, Rafael J. Wysocki wrote:
> On Tue, Oct 8, 2024 at 12:35 AM Ulf Hansson <ulf.hansson@linaro.org> wrote:
>>
>> On Tue, 8 Oct 2024 at 00:25, Laurent Pinchart
>> <laurent.pinchart@ideasonboard.com> wrote:
>>>
>>> Hi Ulf,
>>>
>>> On Tue, Oct 08, 2024 at 12:08:24AM +0200, Ulf Hansson wrote:
>>>> On Mon, 7 Oct 2024 at 20:49, Laurent Pinchart wrote:
>>>>> On Fri, Oct 04, 2024 at 04:38:36PM +0200, Ulf Hansson wrote:
>>>>>> On Fri, 4 Oct 2024 at 11:41, Sakari Ailus wrote:
>>>>>>>
>>>>>>> Hello everyone,
>>>>>>>
>>>>>>> This set will switch the users of pm_runtime_put_autosuspend() to
>>>>>>> __pm_runtime_put_autosuspend() while the former will soon be re-purposed
>>>>>>> to include a call to pm_runtime_mark_last_busy(). The two are almost
>>>>>>> always used together, apart from bugs which are likely common. Going
>>>>>>> forward, most new users should be using pm_runtime_put_autosuspend().
>>>>>>>
>>>>>>> Once this conversion is done and pm_runtime_put_autosuspend() re-purposed,
>>>>>>> I'll post another set to merge the calls to __pm_runtime_put_autosuspend()
>>>>>>> and pm_runtime_mark_last_busy().
>>>>>>
>>>>>> That sounds like it could cause a lot of churns.
>>>>>>
>>>>>> Why not add a new helper function that does the
>>>>>> pm_runtime_put_autosuspend() and the pm_runtime_mark_last_busy()
>>>>>> things? Then we can start moving users over to this new interface,
>>>>>> rather than having this intermediate step?
>>>>>
>>>>> I think the API would be nicer if we used the shortest and simplest
>>>>> function names for the most common use cases. Following
>>>>> pm_runtime_put_autosuspend() with pm_runtime_mark_last_busy() is that
>>>>> most common use case. That's why I like Sakari's approach of repurposing
>>>>> pm_runtime_put_autosuspend(), and introducing
>>>>> __pm_runtime_put_autosuspend() for the odd cases where
>>>>> pm_runtime_mark_last_busy() shouldn't be called.
>>>>
>>>> Okay, so the reason for this approach is because we couldn't find a
>>>> short and descriptive name that could be used in favor of
>>>> pm_runtime_put_autosuspend(). Let me throw some ideas at it and maybe
>>>> you like it - or not. :-)
>>>
>>> I like the idea at least :-)
>>>
>>>> I don't know what options you guys discussed, but to me the entire
>>>> "autosuspend"-suffix isn't really that necessary in my opinion. There
>>>> are more ways than calling pm_runtime_put_autosuspend() that triggers
>>>> us to use the RPM_AUTO flag for rpm_suspend(). For example, just
>>>> calling pm_runtime_put() has the similar effect.
>>>
>>> To be honest, I'm lost there. pm_runtime_put() calls
>>> __pm_runtime_idle(RPM_GET_PUT | RPM_ASYNC), while
>>> pm_runtime_put_autosuspend() calls __pm_runtime_suspend(RPM_GET_PUT |
>>> RPM_ASYNC | RPM_AUTO).
>>
>> __pm_runtime_idle() ends up calling rpm_idle(), which may call
>> rpm_suspend() - if it succeeds to idle the device. In that case, it
>> tags on the RPM_AUTO flag in the call to rpm_suspend(). Quite similar
>> to what is happening when calling pm_runtime_put_autosuspend().
>
> Right.
>
> For almost everybody, except for a small bunch of drivers that
> actually have a .runtime_idle() callback, pm_runtime_put() is
> literally equivalent to pm_runtime_put_autosuspend().
>
> So really the question is why anyone who doesn't provide a
> .runtime_idle() callback bothers with using this special
> pm_runtime_put_autosuspend() thing,
Because they are following the documentation? It says:
"Drivers should call pm_runtime_mark_last_busy() to update this field
after carrying out I/O, typically just before calling
pm_runtime_put_autosuspend()."
and
"In order to use autosuspend, subsystems or drivers must call
pm_runtime_use_autosuspend() (...), and thereafter they should use the
various `*_autosuspend()` helper functions instead of the non#
autosuspend counterparts"
So the documentation says I should be using pm_runtime_put_autosuspend()
instead of pm_runtime_put().
Seems unfair to criticise people for following the documentation.
^ permalink raw reply [flat|nested] 14+ messages in thread
* Re: [PATCH 00/51] treewide: Switch to __pm_runtime_put_autosuspend()
2024-10-09 12:48 ` Richard Fitzgerald
@ 2024-10-09 13:34 ` Rafael J. Wysocki
0 siblings, 0 replies; 14+ messages in thread
From: Rafael J. Wysocki @ 2024-10-09 13:34 UTC (permalink / raw)
To: Richard Fitzgerald, Sakari Ailus
Cc: Ulf Hansson, Laurent Pinchart, dri-devel, linux-kernel,
linux-bluetooth, linux-clk, linux-crypto, dmaengine, linux-gpio,
amd-gfx, nouveau, linux-stm32, linux-arm-kernel, linux-i2c,
linux-i3c, linux-iio, linux-input, patches, iommu, imx,
linux-mediatek, linux-media, linux-mmc, linux-mtd, netdev,
linux-wireless, linux-pci, linux-phy, linux-pwm, linux-remoteproc,
linux-sound, linux-spi, linux-staging, linux-usb, linux-serial,
greybus-dev, asahi, Andy Shevchenko, Uwe Kleine-König
On Wed, Oct 9, 2024 at 2:48 PM Richard Fitzgerald
<rf@opensource.cirrus.com> wrote:
>
> On 08/10/2024 7:24 pm, Rafael J. Wysocki wrote:
> > On Tue, Oct 8, 2024 at 12:35 AM Ulf Hansson <ulf.hansson@linaro.org> wrote:
> >>
> >> On Tue, 8 Oct 2024 at 00:25, Laurent Pinchart
> >> <laurent.pinchart@ideasonboard.com> wrote:
> >>>
> >>> Hi Ulf,
> >>>
> >>> On Tue, Oct 08, 2024 at 12:08:24AM +0200, Ulf Hansson wrote:
> >>>> On Mon, 7 Oct 2024 at 20:49, Laurent Pinchart wrote:
> >>>>> On Fri, Oct 04, 2024 at 04:38:36PM +0200, Ulf Hansson wrote:
> >>>>>> On Fri, 4 Oct 2024 at 11:41, Sakari Ailus wrote:
> >>>>>>>
> >>>>>>> Hello everyone,
> >>>>>>>
> >>>>>>> This set will switch the users of pm_runtime_put_autosuspend() to
> >>>>>>> __pm_runtime_put_autosuspend() while the former will soon be re-purposed
> >>>>>>> to include a call to pm_runtime_mark_last_busy(). The two are almost
> >>>>>>> always used together, apart from bugs which are likely common. Going
> >>>>>>> forward, most new users should be using pm_runtime_put_autosuspend().
> >>>>>>>
> >>>>>>> Once this conversion is done and pm_runtime_put_autosuspend() re-purposed,
> >>>>>>> I'll post another set to merge the calls to __pm_runtime_put_autosuspend()
> >>>>>>> and pm_runtime_mark_last_busy().
> >>>>>>
> >>>>>> That sounds like it could cause a lot of churns.
> >>>>>>
> >>>>>> Why not add a new helper function that does the
> >>>>>> pm_runtime_put_autosuspend() and the pm_runtime_mark_last_busy()
> >>>>>> things? Then we can start moving users over to this new interface,
> >>>>>> rather than having this intermediate step?
> >>>>>
> >>>>> I think the API would be nicer if we used the shortest and simplest
> >>>>> function names for the most common use cases. Following
> >>>>> pm_runtime_put_autosuspend() with pm_runtime_mark_last_busy() is that
> >>>>> most common use case. That's why I like Sakari's approach of repurposing
> >>>>> pm_runtime_put_autosuspend(), and introducing
> >>>>> __pm_runtime_put_autosuspend() for the odd cases where
> >>>>> pm_runtime_mark_last_busy() shouldn't be called.
> >>>>
> >>>> Okay, so the reason for this approach is because we couldn't find a
> >>>> short and descriptive name that could be used in favor of
> >>>> pm_runtime_put_autosuspend(). Let me throw some ideas at it and maybe
> >>>> you like it - or not. :-)
> >>>
> >>> I like the idea at least :-)
> >>>
> >>>> I don't know what options you guys discussed, but to me the entire
> >>>> "autosuspend"-suffix isn't really that necessary in my opinion. There
> >>>> are more ways than calling pm_runtime_put_autosuspend() that triggers
> >>>> us to use the RPM_AUTO flag for rpm_suspend(). For example, just
> >>>> calling pm_runtime_put() has the similar effect.
> >>>
> >>> To be honest, I'm lost there. pm_runtime_put() calls
> >>> __pm_runtime_idle(RPM_GET_PUT | RPM_ASYNC), while
> >>> pm_runtime_put_autosuspend() calls __pm_runtime_suspend(RPM_GET_PUT |
> >>> RPM_ASYNC | RPM_AUTO).
> >>
> >> __pm_runtime_idle() ends up calling rpm_idle(), which may call
> >> rpm_suspend() - if it succeeds to idle the device. In that case, it
> >> tags on the RPM_AUTO flag in the call to rpm_suspend(). Quite similar
> >> to what is happening when calling pm_runtime_put_autosuspend().
> >
> > Right.
> >
> > For almost everybody, except for a small bunch of drivers that
> > actually have a .runtime_idle() callback, pm_runtime_put() is
> > literally equivalent to pm_runtime_put_autosuspend().
> >
> > So really the question is why anyone who doesn't provide a
> > .runtime_idle() callback bothers with using this special
> > pm_runtime_put_autosuspend() thing,
>
> Because they are following the documentation? It says:
>
> "Drivers should call pm_runtime_mark_last_busy() to update this field
> after carrying out I/O, typically just before calling
> pm_runtime_put_autosuspend()."
>
> and
>
> "In order to use autosuspend, subsystems or drivers must call
> pm_runtime_use_autosuspend() (...), and thereafter they should use the
> various `*_autosuspend()` helper functions instead of the non#
> autosuspend counterparts"
>
> So the documentation says I should be using pm_runtime_put_autosuspend()
> instead of pm_runtime_put().
>
> Seems unfair to criticise people for following the documentation.
I'm not criticising anyone, just wondering why they do what they do.
"Because it is documented this way" is a fair answer, but it doesn't
invalidate the observation that the difference between
pm_runtime_put_autosuspend() and pm_runtime_put() boils down to the
cases when the .runtime_idle() callback is present (which are few and
far between so to speak). Moreover, there are call sites using
pm_runtime_*() functions even though they may not know whether or not
autosuspend is enabled for the target devices, so the advice given in
the documentation cannot be universally followed regardless.
This thread is about the way to go, generally speaking, and what I'm
saying is effectively that replacing pm_runtime_put_autosuspend() with
pm_runtime_put() almost everywhere (if not just everywhere) would be
fine with me.
I also think that the current users of pm_runtime_put_autosuspend()
that is not immediately preceded by pm_runtime_mark_last_busy() can be
readily switched over to using pm_runtime_put() instead of it and then
pm_runtime_put_autosuspend() can be made call
pm_runtime_mark_last_busy(), so the latter can be removed from the
code using the former. Note that this last step does not require
tree-wide changes, because calling pm_runtime_mark_last_busy() twice
in a row for the same device is not a problem.
Of course, the documentation needs to be updated in accordance with
the code changes, which didn't happen when previous changes were made
to pm_runtime_put() and that likely is why it does not reflect the
current code.
^ permalink raw reply [flat|nested] 14+ messages in thread
end of thread, other threads:[~2024-10-09 13:34 UTC | newest]
Thread overview: 14+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2024-10-04 9:41 [PATCH 00/51] treewide: Switch to __pm_runtime_put_autosuspend() Sakari Ailus
2024-10-04 9:41 ` [PATCH 19/51] iio: " Sakari Ailus
2024-10-04 13:45 ` Jonathan Cameron
2024-10-04 14:38 ` [PATCH 00/51] treewide: " Ulf Hansson
2024-10-07 18:49 ` Laurent Pinchart
2024-10-07 22:08 ` Ulf Hansson
2024-10-07 22:25 ` Laurent Pinchart
2024-10-07 22:34 ` Ulf Hansson
2024-10-08 18:24 ` Rafael J. Wysocki
2024-10-09 10:20 ` Rafael J. Wysocki
2024-10-09 10:27 ` Ulf Hansson
2024-10-09 12:48 ` Richard Fitzgerald
2024-10-09 13:34 ` Rafael J. Wysocki
2024-10-08 20:38 ` Uwe Kleine-König
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox