From: Jonathan Cameron <jic23@kernel.org>
To: Jinjie Ruan <ruanjinjie@huawei.com>
Cc: <lars@metafoo.de>, <paul.walmsley@sifive.com>,
<palmer@dabbelt.com>, <aou@eecs.berkeley.edu>,
<nuno.sa@analog.com>, <javier.carrasco.cruz@gmail.com>,
<sunke@kylinos.cn>, <conor.dooley@microchip.com>,
<anshulusr@gmail.com>, <kimseer.paller@analog.com>,
<michael.hennerich@analog.com>, <linux-iio@vger.kernel.org>,
<linux-kernel@vger.kernel.org>, <linux-riscv@lists.infradead.org>,
<noname.nuno@gmail.com>
Subject: Re: [PATCH v2] iio: dac: Kconfig: Fix build error for ltc2664
Date: Thu, 24 Oct 2024 18:46:34 +0100 [thread overview]
Message-ID: <20241024184634.3bfcde82@jic23-huawei> (raw)
In-Reply-To: <20241024015553.1111253-1-ruanjinjie@huawei.com>
On Thu, 24 Oct 2024 09:55:53 +0800
Jinjie Ruan <ruanjinjie@huawei.com> wrote:
> If REGMAP_SPI is n and LTC2664 is y, the following build error occurs:
>
> riscv64-unknown-linux-gnu-ld: drivers/iio/dac/ltc2664.o: in function `ltc2664_probe':
> ltc2664.c:(.text+0x714): undefined reference to `__devm_regmap_init_spi'
>
> Select REGMAP_SPI instead of REGMAP for LTC2664 to fix it.
>
> Fixes: 4cc2fc445d2e ("iio: dac: ltc2664: Add driver for LTC2664 and LTC2672")
> Reviewed-by: Nuno Sa <nuno.sa@analog.com>
> Signed-off-by: Jinjie Ruan <ruanjinjie@huawei.com>
Applied to the fixes-togreg branch of iio.git
Thanks,
Jonathan
> ---
> v2:
> - Select REGMAP_SPI instead of REGMAP.
> - Update the commit subject.
> - Add Reviewed-by.
> ---
> drivers/iio/dac/Kconfig | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/iio/dac/Kconfig b/drivers/iio/dac/Kconfig
> index 45e337c6d256..9f5d5ebb8653 100644
> --- a/drivers/iio/dac/Kconfig
> +++ b/drivers/iio/dac/Kconfig
> @@ -380,7 +380,7 @@ config LTC2632
> config LTC2664
> tristate "Analog Devices LTC2664 and LTC2672 DAC SPI driver"
> depends on SPI
> - select REGMAP
> + select REGMAP_SPI
> help
> Say yes here to build support for Analog Devices
> LTC2664 and LTC2672 converters (DAC).
prev parent reply other threads:[~2024-10-24 17:46 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-10-24 1:55 [PATCH v2] iio: dac: Kconfig: Fix build error for ltc2664 Jinjie Ruan
2024-10-24 17:46 ` Jonathan Cameron [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20241024184634.3bfcde82@jic23-huawei \
--to=jic23@kernel.org \
--cc=anshulusr@gmail.com \
--cc=aou@eecs.berkeley.edu \
--cc=conor.dooley@microchip.com \
--cc=javier.carrasco.cruz@gmail.com \
--cc=kimseer.paller@analog.com \
--cc=lars@metafoo.de \
--cc=linux-iio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-riscv@lists.infradead.org \
--cc=michael.hennerich@analog.com \
--cc=noname.nuno@gmail.com \
--cc=nuno.sa@analog.com \
--cc=palmer@dabbelt.com \
--cc=paul.walmsley@sifive.com \
--cc=ruanjinjie@huawei.com \
--cc=sunke@kylinos.cn \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox