* [PATCH v2] iio: dac: Kconfig: Fix build error for ltc2664
@ 2024-10-24 1:55 Jinjie Ruan
2024-10-24 17:46 ` Jonathan Cameron
0 siblings, 1 reply; 2+ messages in thread
From: Jinjie Ruan @ 2024-10-24 1:55 UTC (permalink / raw)
To: jic23, lars, paul.walmsley, palmer, aou, nuno.sa,
javier.carrasco.cruz, sunke, conor.dooley, anshulusr, ruanjinjie,
kimseer.paller, michael.hennerich, linux-iio, linux-kernel,
linux-riscv, noname.nuno
If REGMAP_SPI is n and LTC2664 is y, the following build error occurs:
riscv64-unknown-linux-gnu-ld: drivers/iio/dac/ltc2664.o: in function `ltc2664_probe':
ltc2664.c:(.text+0x714): undefined reference to `__devm_regmap_init_spi'
Select REGMAP_SPI instead of REGMAP for LTC2664 to fix it.
Fixes: 4cc2fc445d2e ("iio: dac: ltc2664: Add driver for LTC2664 and LTC2672")
Reviewed-by: Nuno Sa <nuno.sa@analog.com>
Signed-off-by: Jinjie Ruan <ruanjinjie@huawei.com>
---
v2:
- Select REGMAP_SPI instead of REGMAP.
- Update the commit subject.
- Add Reviewed-by.
---
drivers/iio/dac/Kconfig | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/iio/dac/Kconfig b/drivers/iio/dac/Kconfig
index 45e337c6d256..9f5d5ebb8653 100644
--- a/drivers/iio/dac/Kconfig
+++ b/drivers/iio/dac/Kconfig
@@ -380,7 +380,7 @@ config LTC2632
config LTC2664
tristate "Analog Devices LTC2664 and LTC2672 DAC SPI driver"
depends on SPI
- select REGMAP
+ select REGMAP_SPI
help
Say yes here to build support for Analog Devices
LTC2664 and LTC2672 converters (DAC).
--
2.34.1
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH v2] iio: dac: Kconfig: Fix build error for ltc2664
2024-10-24 1:55 [PATCH v2] iio: dac: Kconfig: Fix build error for ltc2664 Jinjie Ruan
@ 2024-10-24 17:46 ` Jonathan Cameron
0 siblings, 0 replies; 2+ messages in thread
From: Jonathan Cameron @ 2024-10-24 17:46 UTC (permalink / raw)
To: Jinjie Ruan
Cc: lars, paul.walmsley, palmer, aou, nuno.sa, javier.carrasco.cruz,
sunke, conor.dooley, anshulusr, kimseer.paller, michael.hennerich,
linux-iio, linux-kernel, linux-riscv, noname.nuno
On Thu, 24 Oct 2024 09:55:53 +0800
Jinjie Ruan <ruanjinjie@huawei.com> wrote:
> If REGMAP_SPI is n and LTC2664 is y, the following build error occurs:
>
> riscv64-unknown-linux-gnu-ld: drivers/iio/dac/ltc2664.o: in function `ltc2664_probe':
> ltc2664.c:(.text+0x714): undefined reference to `__devm_regmap_init_spi'
>
> Select REGMAP_SPI instead of REGMAP for LTC2664 to fix it.
>
> Fixes: 4cc2fc445d2e ("iio: dac: ltc2664: Add driver for LTC2664 and LTC2672")
> Reviewed-by: Nuno Sa <nuno.sa@analog.com>
> Signed-off-by: Jinjie Ruan <ruanjinjie@huawei.com>
Applied to the fixes-togreg branch of iio.git
Thanks,
Jonathan
> ---
> v2:
> - Select REGMAP_SPI instead of REGMAP.
> - Update the commit subject.
> - Add Reviewed-by.
> ---
> drivers/iio/dac/Kconfig | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/iio/dac/Kconfig b/drivers/iio/dac/Kconfig
> index 45e337c6d256..9f5d5ebb8653 100644
> --- a/drivers/iio/dac/Kconfig
> +++ b/drivers/iio/dac/Kconfig
> @@ -380,7 +380,7 @@ config LTC2632
> config LTC2664
> tristate "Analog Devices LTC2664 and LTC2672 DAC SPI driver"
> depends on SPI
> - select REGMAP
> + select REGMAP_SPI
> help
> Say yes here to build support for Analog Devices
> LTC2664 and LTC2672 converters (DAC).
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2024-10-24 17:46 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2024-10-24 1:55 [PATCH v2] iio: dac: Kconfig: Fix build error for ltc2664 Jinjie Ruan
2024-10-24 17:46 ` Jonathan Cameron
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox