Linux IIO development
 help / color / mirror / Atom feed
From: Jonathan Cameron <jic23@kernel.org>
To: linux-iio@vger.kernel.org
Cc: Andy Shevchenko <andriy.shevchenko@linux.intel.com>,
	Jonathan Corbet <corbet@lwn.net>,
	linux-doc@vger.kernel.org,
	Jonathan Cameron <Jonathan.Cameron@huawei.com>
Subject: [PATCH] iio: Move __private marking before struct element priv in struct iio_dev
Date: Thu,  7 Nov 2024 18:57:46 +0000	[thread overview]
Message-ID: <20241107185746.138146-1-jic23@kernel.org> (raw)

From: Jonathan Cameron <Jonathan.Cameron@huawei.com>

This is to avoid tripping up kernel-doc which filters it out before
but not after the name.

Fixes:
./include/linux/iio/iio.h:628: warning: Function parameter or struct member '__private' not described in 'iio_dev'
./include/linux/iio/iio.h:628: warning: Excess struct member 'priv' description in 'iio_dev'

Signed-off-by: Jonathan Cameron <Jonathan.Cameron@huawei.com>
---
 The alternative is tweak kernel-doc. Given it was inconsistent with the
 other __private entry anyway I decided to do it like this.

 Not already applied and pushed out to squash the issue in linux-next.

 include/linux/iio/iio.h | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/include/linux/iio/iio.h b/include/linux/iio/iio.h
index 59c58f455311..3350162f190f 100644
--- a/include/linux/iio/iio.h
+++ b/include/linux/iio/iio.h
@@ -624,7 +624,7 @@ struct iio_dev {
 	const struct iio_info		*info;
 	const struct iio_buffer_setup_ops	*setup_ops;
 
-	void				*priv __private;
+	void				__private *priv;
 };
 
 int iio_device_id(struct iio_dev *indio_dev);
-- 
2.46.2


             reply	other threads:[~2024-11-07 18:57 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-11-07 18:57 Jonathan Cameron [this message]
2024-11-08  8:41 ` [PATCH] iio: Move __private marking before struct element priv in struct iio_dev Andy Shevchenko
2024-11-08 11:14   ` Jonathan Cameron
2024-11-08 11:18     ` Jonathan Cameron

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20241107185746.138146-1-jic23@kernel.org \
    --to=jic23@kernel.org \
    --cc=Jonathan.Cameron@huawei.com \
    --cc=andriy.shevchenko@linux.intel.com \
    --cc=corbet@lwn.net \
    --cc=linux-doc@vger.kernel.org \
    --cc=linux-iio@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox