From: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
To: Jonathan Cameron <jic23@kernel.org>
Cc: linux-iio@vger.kernel.org, Jonathan Corbet <corbet@lwn.net>,
linux-doc@vger.kernel.org,
Jonathan Cameron <Jonathan.Cameron@huawei.com>
Subject: Re: [PATCH] iio: Move __private marking before struct element priv in struct iio_dev
Date: Fri, 8 Nov 2024 10:41:02 +0200 [thread overview]
Message-ID: <Zy3Ongpc0vdGxKsX@smile.fi.intel.com> (raw)
In-Reply-To: <20241107185746.138146-1-jic23@kernel.org>
On Thu, Nov 07, 2024 at 06:57:46PM +0000, Jonathan Cameron wrote:
> From: Jonathan Cameron <Jonathan.Cameron@huawei.com>
>
> This is to avoid tripping up kernel-doc which filters it out before
> but not after the name.
>
> Fixes:
> ./include/linux/iio/iio.h:628: warning: Function parameter or struct member '__private' not described in 'iio_dev'
> ./include/linux/iio/iio.h:628: warning: Excess struct member 'priv' description in 'iio_dev'
...
> - void *priv __private;
> + void __private *priv;
> };
This is still inconsistent from the position perspective (while may still
work). I specifically placed it there, otherwise what you need is to have
void * __private priv;
to be fully consistent.
That said, either you need to carefully reindent all the affected members,
or fix the kernel-doc, or both.
--
With Best Regards,
Andy Shevchenko
next prev parent reply other threads:[~2024-11-08 8:41 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-11-07 18:57 [PATCH] iio: Move __private marking before struct element priv in struct iio_dev Jonathan Cameron
2024-11-08 8:41 ` Andy Shevchenko [this message]
2024-11-08 11:14 ` Jonathan Cameron
2024-11-08 11:18 ` Jonathan Cameron
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Zy3Ongpc0vdGxKsX@smile.fi.intel.com \
--to=andriy.shevchenko@linux.intel.com \
--cc=Jonathan.Cameron@huawei.com \
--cc=corbet@lwn.net \
--cc=jic23@kernel.org \
--cc=linux-doc@vger.kernel.org \
--cc=linux-iio@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox