From: Jonathan Cameron <jic23@kernel.org>
To: "Uwe Kleine-König" <u.kleine-koenig@baylibre.com>
Cc: Lars-Peter Clausen <lars@metafoo.de>,
Michael Hennerich <Michael.Hennerich@analog.com>,
linux-iio@vger.kernel.org
Subject: Re: [PATCH] iio: adc: ad_sigma_delta: Use `unsigned int` instead of plain `unsigned`
Date: Thu, 19 Dec 2024 15:06:26 +0000 [thread overview]
Message-ID: <20241219150626.6f6092ed@jic23-huawei> (raw)
In-Reply-To: <20241218114809.1378063-2-u.kleine-koenig@baylibre.com>
On Wed, 18 Dec 2024 12:48:09 +0100
Uwe Kleine-König <u.kleine-koenig@baylibre.com> wrote:
> This fixes a checkpatch warning:
>
> WARNING: Prefer 'unsigned int' to bare use of 'unsigned'
> #70: FILE: drivers/iio/adc/ad_sigma_delta.c:253:
> + unsigned status_reg;
>
> Fixes: 132d44dc6966 ("iio: adc: ad_sigma_delta: Check for previous ready signals")
> Signed-off-by: Uwe Kleine-König <u.kleine-koenig@baylibre.com>
Applied. I dropped the fixes tag (which was useful to me to find the patch)
because it's just a warning + I don't want to mess up if I do have to rebase
for some reasons (and all the tags change!)
Thanks,
Jonathan
> ---
> Hello,
>
> if it's not already to late for that, feel free to squash this into the
> original commit.
>
> Best regards
> Uwe
>
> drivers/iio/adc/ad_sigma_delta.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/iio/adc/ad_sigma_delta.c b/drivers/iio/adc/ad_sigma_delta.c
> index c3c81aef34d8..7164ae255ed7 100644
> --- a/drivers/iio/adc/ad_sigma_delta.c
> +++ b/drivers/iio/adc/ad_sigma_delta.c
> @@ -251,7 +251,7 @@ static int ad_sigma_delta_clear_pending_event(struct ad_sigma_delta *sigma_delta
> if (sigma_delta->rdy_gpiod) {
> pending_event = gpiod_get_value(sigma_delta->rdy_gpiod);
> } else {
> - unsigned status_reg;
> + unsigned int status_reg;
>
> ret = ad_sd_read_reg(sigma_delta, AD_SD_REG_STATUS, 1, &status_reg);
> if (ret)
>
> base-commit: 132d44dc6966c1cf841ffe0f6f048165687e870b
prev parent reply other threads:[~2024-12-19 15:06 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-12-18 11:48 [PATCH] iio: adc: ad_sigma_delta: Use `unsigned int` instead of plain `unsigned` Uwe Kleine-König
2024-12-19 15:06 ` Jonathan Cameron [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20241219150626.6f6092ed@jic23-huawei \
--to=jic23@kernel.org \
--cc=Michael.Hennerich@analog.com \
--cc=lars@metafoo.de \
--cc=linux-iio@vger.kernel.org \
--cc=u.kleine-koenig@baylibre.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox