* [PATCH] iio: adc: ad_sigma_delta: Use `unsigned int` instead of plain `unsigned`
@ 2024-12-18 11:48 Uwe Kleine-König
2024-12-19 15:06 ` Jonathan Cameron
0 siblings, 1 reply; 2+ messages in thread
From: Uwe Kleine-König @ 2024-12-18 11:48 UTC (permalink / raw)
To: Jonathan Cameron; +Cc: Lars-Peter Clausen, Michael Hennerich, linux-iio
This fixes a checkpatch warning:
WARNING: Prefer 'unsigned int' to bare use of 'unsigned'
#70: FILE: drivers/iio/adc/ad_sigma_delta.c:253:
+ unsigned status_reg;
Fixes: 132d44dc6966 ("iio: adc: ad_sigma_delta: Check for previous ready signals")
Signed-off-by: Uwe Kleine-König <u.kleine-koenig@baylibre.com>
---
Hello,
if it's not already to late for that, feel free to squash this into the
original commit.
Best regards
Uwe
drivers/iio/adc/ad_sigma_delta.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/iio/adc/ad_sigma_delta.c b/drivers/iio/adc/ad_sigma_delta.c
index c3c81aef34d8..7164ae255ed7 100644
--- a/drivers/iio/adc/ad_sigma_delta.c
+++ b/drivers/iio/adc/ad_sigma_delta.c
@@ -251,7 +251,7 @@ static int ad_sigma_delta_clear_pending_event(struct ad_sigma_delta *sigma_delta
if (sigma_delta->rdy_gpiod) {
pending_event = gpiod_get_value(sigma_delta->rdy_gpiod);
} else {
- unsigned status_reg;
+ unsigned int status_reg;
ret = ad_sd_read_reg(sigma_delta, AD_SD_REG_STATUS, 1, &status_reg);
if (ret)
base-commit: 132d44dc6966c1cf841ffe0f6f048165687e870b
--
2.45.2
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] iio: adc: ad_sigma_delta: Use `unsigned int` instead of plain `unsigned`
2024-12-18 11:48 [PATCH] iio: adc: ad_sigma_delta: Use `unsigned int` instead of plain `unsigned` Uwe Kleine-König
@ 2024-12-19 15:06 ` Jonathan Cameron
0 siblings, 0 replies; 2+ messages in thread
From: Jonathan Cameron @ 2024-12-19 15:06 UTC (permalink / raw)
To: Uwe Kleine-König; +Cc: Lars-Peter Clausen, Michael Hennerich, linux-iio
On Wed, 18 Dec 2024 12:48:09 +0100
Uwe Kleine-König <u.kleine-koenig@baylibre.com> wrote:
> This fixes a checkpatch warning:
>
> WARNING: Prefer 'unsigned int' to bare use of 'unsigned'
> #70: FILE: drivers/iio/adc/ad_sigma_delta.c:253:
> + unsigned status_reg;
>
> Fixes: 132d44dc6966 ("iio: adc: ad_sigma_delta: Check for previous ready signals")
> Signed-off-by: Uwe Kleine-König <u.kleine-koenig@baylibre.com>
Applied. I dropped the fixes tag (which was useful to me to find the patch)
because it's just a warning + I don't want to mess up if I do have to rebase
for some reasons (and all the tags change!)
Thanks,
Jonathan
> ---
> Hello,
>
> if it's not already to late for that, feel free to squash this into the
> original commit.
>
> Best regards
> Uwe
>
> drivers/iio/adc/ad_sigma_delta.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/iio/adc/ad_sigma_delta.c b/drivers/iio/adc/ad_sigma_delta.c
> index c3c81aef34d8..7164ae255ed7 100644
> --- a/drivers/iio/adc/ad_sigma_delta.c
> +++ b/drivers/iio/adc/ad_sigma_delta.c
> @@ -251,7 +251,7 @@ static int ad_sigma_delta_clear_pending_event(struct ad_sigma_delta *sigma_delta
> if (sigma_delta->rdy_gpiod) {
> pending_event = gpiod_get_value(sigma_delta->rdy_gpiod);
> } else {
> - unsigned status_reg;
> + unsigned int status_reg;
>
> ret = ad_sd_read_reg(sigma_delta, AD_SD_REG_STATUS, 1, &status_reg);
> if (ret)
>
> base-commit: 132d44dc6966c1cf841ffe0f6f048165687e870b
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2024-12-19 15:06 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2024-12-18 11:48 [PATCH] iio: adc: ad_sigma_delta: Use `unsigned int` instead of plain `unsigned` Uwe Kleine-König
2024-12-19 15:06 ` Jonathan Cameron
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox