From: Jonathan Cameron <jic23@kernel.org>
To: linux-iio@vger.kernel.org
Cc: "David Lechner" <dlechner@baylibre.com>,
"Nuno Sá" <noname.nuno@gmail.com>,
"Olivier Moysan" <olivier.moysan@foss.st.com>,
"Mike Looijmans" <mike.looijmans@topic.nl>,
"Phil Reid" <preid@electromag.com.au>,
"Marek Vasut" <marek.vasut+renesas@gmail.com>,
"Miquel Raynal" <miquel.raynal@bootlin.com>,
"Claudiu Beznea" <claudiu.beznea@tuxon.dev>,
"Uwe Kleine-König" <u.kleine-koenig@baylibre.com>,
"Alisa-Dariana Roman" <alisa.roman@analog.com>,
"Marek Vasut" <marex@denx.de>, "Frank Li" <Frank.Li@nxp.com>,
"Jonathan Cameron" <Jonathan.Cameron@huawei.com>
Subject: [PATCH 14/29] iio: adc: ad7606: Switch to sparse friendly iio_device_claim/release_direct()
Date: Mon, 17 Feb 2025 14:16:14 +0000 [thread overview]
Message-ID: <20250217141630.897334-15-jic23@kernel.org> (raw)
In-Reply-To: <20250217141630.897334-1-jic23@kernel.org>
From: Jonathan Cameron <Jonathan.Cameron@huawei.com>
These new functions allow sparse to find failures to release
direct mode reducing chances of bugs over the claim_direct_mode()
functions that are deprecated.
This driver got partly converted during removal of the _scoped form.
However some more cases got added in parallel.
Signed-off-by: Jonathan Cameron <Jonathan.Cameron@huawei.com>
---
drivers/iio/adc/ad7606.c | 14 ++++++--------
1 file changed, 6 insertions(+), 8 deletions(-)
diff --git a/drivers/iio/adc/ad7606.c b/drivers/iio/adc/ad7606.c
index 87908cc51e48..f566248db70a 100644
--- a/drivers/iio/adc/ad7606.c
+++ b/drivers/iio/adc/ad7606.c
@@ -862,11 +862,10 @@ static int ad7606_write_raw(struct iio_dev *indio_dev,
val = (val * MICRO) + val2;
i = find_closest(val, scale_avail_uv, cs->num_scales);
- ret = iio_device_claim_direct_mode(indio_dev);
- if (ret < 0)
- return ret;
+ if (!iio_device_claim_direct(indio_dev))
+ return -EBUSY;
ret = st->write_scale(indio_dev, ch, i + cs->reg_offset);
- iio_device_release_direct_mode(indio_dev);
+ iio_device_release_direct(indio_dev);
if (ret < 0)
return ret;
cs->range = i;
@@ -878,11 +877,10 @@ static int ad7606_write_raw(struct iio_dev *indio_dev,
i = find_closest(val, st->oversampling_avail,
st->num_os_ratios);
- ret = iio_device_claim_direct_mode(indio_dev);
- if (ret < 0)
- return ret;
+ if (!iio_device_claim_direct(indio_dev))
+ return -EBUSY;
ret = st->write_os(indio_dev, i);
- iio_device_release_direct_mode(indio_dev);
+ iio_device_release_direct(indio_dev);
if (ret < 0)
return ret;
st->oversampling = st->oversampling_avail[i];
--
2.48.1
next prev parent reply other threads:[~2025-02-17 14:18 UTC|newest]
Thread overview: 55+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-02-17 14:16 [PATCH 00/29] IIO: ADCs: Sparse friendly claim of direct mode Jonathan Cameron
2025-02-17 14:16 ` [PATCH 01/29] iio: adc: vf610: Move claim of direct mode to caller of vf610_read_sample and use guard(mutex) Jonathan Cameron
2025-02-17 14:16 ` [PATCH 02/29] iio: adc: vf610: Switch to sparse friendly iio_device_claim/release_direct() Jonathan Cameron
2025-02-17 14:16 ` [PATCH 03/29] iio: adc: ti-ads1100: Use guard(mutex) to allow direct returns Jonathan Cameron
2025-02-17 14:16 ` [PATCH 04/29] iio: adc: ti-ads1100: Switch to sparse friendly iio_device_claim/release_direct() Jonathan Cameron
2025-02-17 14:16 ` [PATCH 05/29] iio: adc: ti-ads1015: Use guard(mutex) and factor out code for INFO_RAW Jonathan Cameron
2025-02-17 14:16 ` [PATCH 06/29] iio: adc: ti-ads1015: Switch to sparse friendly iio_device_claim/release_direct() Jonathan Cameron
2025-02-17 14:16 ` [PATCH 07/29] iio: adc: stm32-dfsdm: Factor out core of reading INFO_RAW Jonathan Cameron
2025-02-18 15:32 ` Olivier MOYSAN
2025-02-17 14:16 ` [PATCH 08/29] iio: adc: stm32-dfsdm: Switch to sparse friendly iio_device_claim/release_direct() Jonathan Cameron
2025-02-18 15:34 ` Olivier MOYSAN
2025-02-17 14:16 ` [PATCH 09/29] iio: adc: ad4030: " Jonathan Cameron
2025-02-19 10:54 ` Nuno Sá
2025-02-17 14:16 ` [PATCH 10/29] iio: adc: ad7192: Factor out core of ad7192_write_raw() to simplify error handling Jonathan Cameron
2025-02-19 10:54 ` Nuno Sá
2025-02-17 14:16 ` [PATCH 11/29] iio: adc: ad7192: Switch to sparse friendly iio_device_claim/release_direct() Jonathan Cameron
2025-02-19 10:55 ` Nuno Sá
2025-02-17 14:16 ` [PATCH 12/29] iio: adc: ad7768-1: Move setting of val a bit later to avoid unnecessary return value check Jonathan Cameron
2025-02-19 10:56 ` Nuno Sá
2025-02-17 14:16 ` [PATCH 13/29] iio: adc: ad7768-1: Switch to sparse friendly iio_device_claim/release_direct() Jonathan Cameron
2025-02-19 10:56 ` Nuno Sá
2025-02-17 14:16 ` Jonathan Cameron [this message]
2025-02-19 10:57 ` [PATCH 14/29] iio: adc: ad7606: " Nuno Sá
2025-02-17 14:16 ` [PATCH 15/29] iio: adc: ad7791: Factor out core of ad7791_write_raw() to simplify error handling Jonathan Cameron
2025-02-19 10:59 ` Nuno Sá
2025-02-17 14:16 ` [PATCH 16/29] iio: adc: ad7791: Switch to sparse friendly iio_device_claim/release_direct() Jonathan Cameron
2025-02-19 11:00 ` Nuno Sá
2025-02-17 14:16 ` [PATCH 17/29] iio: adc: ad7793: Factor out core of ad7793_write_raw() to simplify error handling Jonathan Cameron
2025-02-19 11:00 ` Nuno Sá
2025-02-17 14:16 ` [PATCH 18/29] iio: adc: ad7793: Switch to sparse friendly iio_device_claim/release_direct() Jonathan Cameron
2025-02-19 11:01 ` Nuno Sá
2025-02-17 14:16 ` [PATCH 19/29] iio: adc: ad799x: " Jonathan Cameron
2025-02-19 11:02 ` Nuno Sá
2025-02-17 14:16 ` [PATCH 20/29] iio: adc: ad_sigma_delta: " Jonathan Cameron
2025-02-19 11:03 ` Nuno Sá
2025-02-17 14:16 ` [PATCH 21/29] iio: adc: at91-sama5d2: Move claim of direct mode up a level and use guard() Jonathan Cameron
2025-02-19 12:45 ` Claudiu Beznea
2025-02-17 14:16 ` [PATCH 22/29] iio: adc: at91-sama5d2: Switch to sparse friendly iio_device_claim/release_direct() Jonathan Cameron
2025-02-19 12:46 ` Claudiu Beznea
2025-02-17 14:16 ` [PATCH 23/29] iio: adc: max1027: Move claim of direct mode up one level and use guard() Jonathan Cameron
2025-02-17 15:38 ` Miquel Raynal
2025-02-22 13:04 ` Jonathan Cameron
2025-02-17 14:16 ` [PATCH 24/29] iio: adc: max1027: Switch to sparse friendly iio_device_claim/release_direct() Jonathan Cameron
2025-02-17 15:40 ` Miquel Raynal
2025-02-22 13:06 ` Jonathan Cameron
2025-02-17 14:16 ` [PATCH 25/29] iio: adc: max11410: Factor out writing of sampling frequency to simplify errro paths Jonathan Cameron
2025-02-19 11:03 ` Nuno Sá
2025-02-17 14:16 ` [PATCH 26/29] iio: adc: max11410: Switch to sparse friendly iio_device_claim/release_direct() Jonathan Cameron
2025-02-19 11:04 ` Nuno Sá
2025-02-17 14:16 ` [PATCH 27/29] iio: adc: mxs-lradc: " Jonathan Cameron
2025-02-17 14:16 ` [PATCH 28/29] iio: adc: rcar: " Jonathan Cameron
2025-02-17 14:16 ` [PATCH 29/29] iio: adc: " Jonathan Cameron
2025-02-19 11:07 ` Nuno Sá
2025-02-20 12:47 ` Mike Looijmans
2025-02-22 13:09 ` [PATCH 00/29] IIO: ADCs: Sparse friendly claim of direct mode Jonathan Cameron
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250217141630.897334-15-jic23@kernel.org \
--to=jic23@kernel.org \
--cc=Frank.Li@nxp.com \
--cc=Jonathan.Cameron@huawei.com \
--cc=alisa.roman@analog.com \
--cc=claudiu.beznea@tuxon.dev \
--cc=dlechner@baylibre.com \
--cc=linux-iio@vger.kernel.org \
--cc=marek.vasut+renesas@gmail.com \
--cc=marex@denx.de \
--cc=mike.looijmans@topic.nl \
--cc=miquel.raynal@bootlin.com \
--cc=noname.nuno@gmail.com \
--cc=olivier.moysan@foss.st.com \
--cc=preid@electromag.com.au \
--cc=u.kleine-koenig@baylibre.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox