Linux IIO development
 help / color / mirror / Atom feed
From: Jonathan Cameron <jic23@kernel.org>
To: Gustavo Silva <gustavograzs@gmail.com>
Cc: Alex Lanzano <lanzano.alex@gmail.com>,
	Lars-Peter Clausen <lars@metafoo.de>,
	linux-iio@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] iio: imu: bmi270: fix initial sampling frequency configuration
Date: Sat, 8 Mar 2025 14:55:51 +0000	[thread overview]
Message-ID: <20250308145551.06d9ca14@jic23-huawei> (raw)
In-Reply-To: <5se4isw4f6xpbub62tna53ah2qjcf3mwks23ifc2yn4u462lpn@u53frmcgjth2>

On Wed, 5 Mar 2025 21:11:54 -0300
Gustavo Silva <gustavograzs@gmail.com> wrote:

> On Wed, Mar 05, 2025 at 02:49:28PM +0000, Jonathan Cameron wrote:
> > On Tue, 04 Mar 2025 15:01:02 -0300
> > Gustavo Silva <gustavograzs@gmail.com> wrote:
> >   
> > > In the bmi270_configure_imu() function, the accelerometer and gyroscope
> > > configuration registers are incorrectly written with the mask
> > > BMI270_PWR_CONF_ADV_PWR_SAVE_MSK, which is unrelated to these registers.
> > > 
> > > As a result, the accelerometer's sampling frequency is set to 200 Hz
> > > instead of the intended 100 Hz.
> > > 
> > > Remove the mask to ensure the correct bits are set in the configuration
> > > registers.
> > > 
> > > Signed-off-by: Gustavo Silva <gustavograzs@gmail.com>  
> > 
> > Hi Gustavo,
> > 
> > Please reply to this thread with a suitable fixes tag.
> > 
> > Thanks,
> > 
> > Jonathan
> >   
> 
> Fixes: 3ea51548d6b2 ("iio: imu: Add i2c driver for bmi270 imu")

Thanks. Applied to the fixes-togreg branch of iio.git.
Given where we are in the cycle I might just drag this into the pull
request for the next merge window.

Jonathan


      reply	other threads:[~2025-03-08 14:56 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-03-04 18:01 [PATCH] iio: imu: bmi270: fix initial sampling frequency configuration Gustavo Silva
2025-03-05  4:25 ` Alex Lanzano
2025-03-05 14:49 ` Jonathan Cameron
2025-03-06  0:11   ` Gustavo Silva
2025-03-08 14:55     ` Jonathan Cameron [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20250308145551.06d9ca14@jic23-huawei \
    --to=jic23@kernel.org \
    --cc=gustavograzs@gmail.com \
    --cc=lanzano.alex@gmail.com \
    --cc=lars@metafoo.de \
    --cc=linux-iio@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox