* [PATCH] iio: imu: bmi270: fix initial sampling frequency configuration
@ 2025-03-04 18:01 Gustavo Silva
2025-03-05 4:25 ` Alex Lanzano
2025-03-05 14:49 ` Jonathan Cameron
0 siblings, 2 replies; 5+ messages in thread
From: Gustavo Silva @ 2025-03-04 18:01 UTC (permalink / raw)
To: Alex Lanzano, Jonathan Cameron, Lars-Peter Clausen
Cc: linux-iio, linux-kernel, Gustavo Silva
In the bmi270_configure_imu() function, the accelerometer and gyroscope
configuration registers are incorrectly written with the mask
BMI270_PWR_CONF_ADV_PWR_SAVE_MSK, which is unrelated to these registers.
As a result, the accelerometer's sampling frequency is set to 200 Hz
instead of the intended 100 Hz.
Remove the mask to ensure the correct bits are set in the configuration
registers.
Signed-off-by: Gustavo Silva <gustavograzs@gmail.com>
---
drivers/iio/imu/bmi270/bmi270_core.c | 6 ++----
1 file changed, 2 insertions(+), 4 deletions(-)
diff --git a/drivers/iio/imu/bmi270/bmi270_core.c b/drivers/iio/imu/bmi270/bmi270_core.c
index a86be5af5ccb1f010f2282ee31c47f284c1bcc86..2e4469f30d538ca3e9eb9ef8bbc6eaa8b6a144b8 100644
--- a/drivers/iio/imu/bmi270/bmi270_core.c
+++ b/drivers/iio/imu/bmi270/bmi270_core.c
@@ -918,8 +918,7 @@ static int bmi270_configure_imu(struct bmi270_data *data)
FIELD_PREP(BMI270_ACC_CONF_ODR_MSK,
BMI270_ACC_CONF_ODR_100HZ) |
FIELD_PREP(BMI270_ACC_CONF_BWP_MSK,
- BMI270_ACC_CONF_BWP_NORMAL_MODE) |
- BMI270_PWR_CONF_ADV_PWR_SAVE_MSK);
+ BMI270_ACC_CONF_BWP_NORMAL_MODE));
if (ret)
return dev_err_probe(dev, ret, "Failed to configure accelerometer");
@@ -927,8 +926,7 @@ static int bmi270_configure_imu(struct bmi270_data *data)
FIELD_PREP(BMI270_GYR_CONF_ODR_MSK,
BMI270_GYR_CONF_ODR_200HZ) |
FIELD_PREP(BMI270_GYR_CONF_BWP_MSK,
- BMI270_GYR_CONF_BWP_NORMAL_MODE) |
- BMI270_PWR_CONF_ADV_PWR_SAVE_MSK);
+ BMI270_GYR_CONF_BWP_NORMAL_MODE));
if (ret)
return dev_err_probe(dev, ret, "Failed to configure gyroscope");
---
base-commit: 8cca9edca867350e5f8dc65b71e7a6ef4157981e
change-id: 20250304-bmi270-odr-fix-620e7f8daa7a
Best regards,
--
Gustavo Silva <gustavograzs@gmail.com>
^ permalink raw reply related [flat|nested] 5+ messages in thread
* Re: [PATCH] iio: imu: bmi270: fix initial sampling frequency configuration
2025-03-04 18:01 [PATCH] iio: imu: bmi270: fix initial sampling frequency configuration Gustavo Silva
@ 2025-03-05 4:25 ` Alex Lanzano
2025-03-05 14:49 ` Jonathan Cameron
1 sibling, 0 replies; 5+ messages in thread
From: Alex Lanzano @ 2025-03-05 4:25 UTC (permalink / raw)
To: Gustavo Silva
Cc: Jonathan Cameron, Lars-Peter Clausen, linux-iio, linux-kernel
On Tue, Mar 04, 2025 at 03:01:02PM -0300, Gustavo Silva wrote:
> In the bmi270_configure_imu() function, the accelerometer and gyroscope
> configuration registers are incorrectly written with the mask
> BMI270_PWR_CONF_ADV_PWR_SAVE_MSK, which is unrelated to these registers.
>
> As a result, the accelerometer's sampling frequency is set to 200 Hz
> instead of the intended 100 Hz.
>
> Remove the mask to ensure the correct bits are set in the configuration
> registers.
>
> Signed-off-by: Gustavo Silva <gustavograzs@gmail.com>
> ---
> drivers/iio/imu/bmi270/bmi270_core.c | 6 ++----
> 1 file changed, 2 insertions(+), 4 deletions(-)
>
> diff --git a/drivers/iio/imu/bmi270/bmi270_core.c b/drivers/iio/imu/bmi270/bmi270_core.c
> index a86be5af5ccb1f010f2282ee31c47f284c1bcc86..2e4469f30d538ca3e9eb9ef8bbc6eaa8b6a144b8 100644
> --- a/drivers/iio/imu/bmi270/bmi270_core.c
> +++ b/drivers/iio/imu/bmi270/bmi270_core.c
> @@ -918,8 +918,7 @@ static int bmi270_configure_imu(struct bmi270_data *data)
> FIELD_PREP(BMI270_ACC_CONF_ODR_MSK,
> BMI270_ACC_CONF_ODR_100HZ) |
> FIELD_PREP(BMI270_ACC_CONF_BWP_MSK,
> - BMI270_ACC_CONF_BWP_NORMAL_MODE) |
> - BMI270_PWR_CONF_ADV_PWR_SAVE_MSK);
> + BMI270_ACC_CONF_BWP_NORMAL_MODE));
> if (ret)
> return dev_err_probe(dev, ret, "Failed to configure accelerometer");
>
> @@ -927,8 +926,7 @@ static int bmi270_configure_imu(struct bmi270_data *data)
> FIELD_PREP(BMI270_GYR_CONF_ODR_MSK,
> BMI270_GYR_CONF_ODR_200HZ) |
> FIELD_PREP(BMI270_GYR_CONF_BWP_MSK,
> - BMI270_GYR_CONF_BWP_NORMAL_MODE) |
> - BMI270_PWR_CONF_ADV_PWR_SAVE_MSK);
> + BMI270_GYR_CONF_BWP_NORMAL_MODE));
> if (ret)
> return dev_err_probe(dev, ret, "Failed to configure gyroscope");
>
>
> ---
> base-commit: 8cca9edca867350e5f8dc65b71e7a6ef4157981e
> change-id: 20250304-bmi270-odr-fix-620e7f8daa7a
>
Good catch!
Reviewed-by: Alex Lanzano <lanzano.alex@gmail.com>
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] iio: imu: bmi270: fix initial sampling frequency configuration
2025-03-04 18:01 [PATCH] iio: imu: bmi270: fix initial sampling frequency configuration Gustavo Silva
2025-03-05 4:25 ` Alex Lanzano
@ 2025-03-05 14:49 ` Jonathan Cameron
2025-03-06 0:11 ` Gustavo Silva
1 sibling, 1 reply; 5+ messages in thread
From: Jonathan Cameron @ 2025-03-05 14:49 UTC (permalink / raw)
To: Gustavo Silva; +Cc: Alex Lanzano, Lars-Peter Clausen, linux-iio, linux-kernel
On Tue, 04 Mar 2025 15:01:02 -0300
Gustavo Silva <gustavograzs@gmail.com> wrote:
> In the bmi270_configure_imu() function, the accelerometer and gyroscope
> configuration registers are incorrectly written with the mask
> BMI270_PWR_CONF_ADV_PWR_SAVE_MSK, which is unrelated to these registers.
>
> As a result, the accelerometer's sampling frequency is set to 200 Hz
> instead of the intended 100 Hz.
>
> Remove the mask to ensure the correct bits are set in the configuration
> registers.
>
> Signed-off-by: Gustavo Silva <gustavograzs@gmail.com>
Hi Gustavo,
Please reply to this thread with a suitable fixes tag.
Thanks,
Jonathan
> ---
> drivers/iio/imu/bmi270/bmi270_core.c | 6 ++----
> 1 file changed, 2 insertions(+), 4 deletions(-)
>
> diff --git a/drivers/iio/imu/bmi270/bmi270_core.c b/drivers/iio/imu/bmi270/bmi270_core.c
> index a86be5af5ccb1f010f2282ee31c47f284c1bcc86..2e4469f30d538ca3e9eb9ef8bbc6eaa8b6a144b8 100644
> --- a/drivers/iio/imu/bmi270/bmi270_core.c
> +++ b/drivers/iio/imu/bmi270/bmi270_core.c
> @@ -918,8 +918,7 @@ static int bmi270_configure_imu(struct bmi270_data *data)
> FIELD_PREP(BMI270_ACC_CONF_ODR_MSK,
> BMI270_ACC_CONF_ODR_100HZ) |
> FIELD_PREP(BMI270_ACC_CONF_BWP_MSK,
> - BMI270_ACC_CONF_BWP_NORMAL_MODE) |
> - BMI270_PWR_CONF_ADV_PWR_SAVE_MSK);
> + BMI270_ACC_CONF_BWP_NORMAL_MODE));
> if (ret)
> return dev_err_probe(dev, ret, "Failed to configure accelerometer");
>
> @@ -927,8 +926,7 @@ static int bmi270_configure_imu(struct bmi270_data *data)
> FIELD_PREP(BMI270_GYR_CONF_ODR_MSK,
> BMI270_GYR_CONF_ODR_200HZ) |
> FIELD_PREP(BMI270_GYR_CONF_BWP_MSK,
> - BMI270_GYR_CONF_BWP_NORMAL_MODE) |
> - BMI270_PWR_CONF_ADV_PWR_SAVE_MSK);
> + BMI270_GYR_CONF_BWP_NORMAL_MODE));
> if (ret)
> return dev_err_probe(dev, ret, "Failed to configure gyroscope");
>
>
> ---
> base-commit: 8cca9edca867350e5f8dc65b71e7a6ef4157981e
> change-id: 20250304-bmi270-odr-fix-620e7f8daa7a
>
> Best regards,
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] iio: imu: bmi270: fix initial sampling frequency configuration
2025-03-05 14:49 ` Jonathan Cameron
@ 2025-03-06 0:11 ` Gustavo Silva
2025-03-08 14:55 ` Jonathan Cameron
0 siblings, 1 reply; 5+ messages in thread
From: Gustavo Silva @ 2025-03-06 0:11 UTC (permalink / raw)
To: Jonathan Cameron
Cc: Alex Lanzano, Lars-Peter Clausen, linux-iio, linux-kernel
On Wed, Mar 05, 2025 at 02:49:28PM +0000, Jonathan Cameron wrote:
> On Tue, 04 Mar 2025 15:01:02 -0300
> Gustavo Silva <gustavograzs@gmail.com> wrote:
>
> > In the bmi270_configure_imu() function, the accelerometer and gyroscope
> > configuration registers are incorrectly written with the mask
> > BMI270_PWR_CONF_ADV_PWR_SAVE_MSK, which is unrelated to these registers.
> >
> > As a result, the accelerometer's sampling frequency is set to 200 Hz
> > instead of the intended 100 Hz.
> >
> > Remove the mask to ensure the correct bits are set in the configuration
> > registers.
> >
> > Signed-off-by: Gustavo Silva <gustavograzs@gmail.com>
>
> Hi Gustavo,
>
> Please reply to this thread with a suitable fixes tag.
>
> Thanks,
>
> Jonathan
>
Fixes: 3ea51548d6b2 ("iio: imu: Add i2c driver for bmi270 imu")
^ permalink raw reply [flat|nested] 5+ messages in thread* Re: [PATCH] iio: imu: bmi270: fix initial sampling frequency configuration
2025-03-06 0:11 ` Gustavo Silva
@ 2025-03-08 14:55 ` Jonathan Cameron
0 siblings, 0 replies; 5+ messages in thread
From: Jonathan Cameron @ 2025-03-08 14:55 UTC (permalink / raw)
To: Gustavo Silva; +Cc: Alex Lanzano, Lars-Peter Clausen, linux-iio, linux-kernel
On Wed, 5 Mar 2025 21:11:54 -0300
Gustavo Silva <gustavograzs@gmail.com> wrote:
> On Wed, Mar 05, 2025 at 02:49:28PM +0000, Jonathan Cameron wrote:
> > On Tue, 04 Mar 2025 15:01:02 -0300
> > Gustavo Silva <gustavograzs@gmail.com> wrote:
> >
> > > In the bmi270_configure_imu() function, the accelerometer and gyroscope
> > > configuration registers are incorrectly written with the mask
> > > BMI270_PWR_CONF_ADV_PWR_SAVE_MSK, which is unrelated to these registers.
> > >
> > > As a result, the accelerometer's sampling frequency is set to 200 Hz
> > > instead of the intended 100 Hz.
> > >
> > > Remove the mask to ensure the correct bits are set in the configuration
> > > registers.
> > >
> > > Signed-off-by: Gustavo Silva <gustavograzs@gmail.com>
> >
> > Hi Gustavo,
> >
> > Please reply to this thread with a suitable fixes tag.
> >
> > Thanks,
> >
> > Jonathan
> >
>
> Fixes: 3ea51548d6b2 ("iio: imu: Add i2c driver for bmi270 imu")
Thanks. Applied to the fixes-togreg branch of iio.git.
Given where we are in the cycle I might just drag this into the pull
request for the next merge window.
Jonathan
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2025-03-08 14:56 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2025-03-04 18:01 [PATCH] iio: imu: bmi270: fix initial sampling frequency configuration Gustavo Silva
2025-03-05 4:25 ` Alex Lanzano
2025-03-05 14:49 ` Jonathan Cameron
2025-03-06 0:11 ` Gustavo Silva
2025-03-08 14:55 ` Jonathan Cameron
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox