From: Jonathan Cameron <jic23@kernel.org>
To: Andy Shevchenko <andy.shevchenko@gmail.com>
Cc: Gyeyoung Baek <gye976@gmail.com>,
linux-iio@vger.kernel.org, devicetree@vger.kernel.org,
dlechner@baylibre.com, nuno.sa@analog.com, andy@kernel.org,
robh@kernel.org, krzk+dt@kernel.org, conor+dt@kernel.org
Subject: Re: [PATCH v4 3/4] iio: chemical: add support for winsen MHZ19B CO2 sensor
Date: Mon, 21 Apr 2025 14:25:31 +0100 [thread overview]
Message-ID: <20250421142531.2084092e@jic23-huawei> (raw)
In-Reply-To: <CAHp75VcaGqR-c23GCOKo3RLO-omtt9YgPuHmCUteAqYt6yon7Q@mail.gmail.com>
On Sun, 20 Apr 2025 22:23:57 +0300
Andy Shevchenko <andy.shevchenko@gmail.com> wrote:
> On Sun, Apr 20, 2025 at 10:21 PM Andy Shevchenko
> <andy.shevchenko@gmail.com> wrote:
> > On Sun, Apr 20, 2025 at 9:10 PM Gyeyoung Baek <gye976@gmail.com> wrote:
>
> ...
>
> > > --- a/drivers/iio/chemical/Makefile
> > > +++ b/drivers/iio/chemical/Makefile
>
> > > obj-$(CONFIG_SPS30_I2C) += sps30_i2c.o
> > > obj-$(CONFIG_SPS30_SERIAL) += sps30_serial.o
> > > obj-$(CONFIG_VZ89X) += vz89x.o
> > > +obj-$(CONFIG_WINSEN_MHZ19B) += mhz19b.o
> >
> > Preserve order.
>
> Ah, I see it's ordered but by Kconfig, Why do you have WINSEN in the
> option and no such thing in the filename? I would drop that from the
> config option.
>
> Jonathan, what do you think about this? Which order (in case of
> misalignment between module name and configuration option) should be
> taken?
>
Hmm.. No idea. It think just dropping it from the CONFIG name
is the right way to avoid the question ;)
Jonathan
next prev parent reply other threads:[~2025-04-21 13:25 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-04-20 18:10 [PATCH v4 0/4] add support for winsen MHZ19B CO2 sensor Gyeyoung Baek
2025-04-20 18:10 ` [PATCH v4 1/4] dt-bindings: add winsen to the vendor prefixes Gyeyoung Baek
2025-04-20 18:10 ` [PATCH v4 2/4] dt-bindings: add device tree support for winsen MHZ19B CO2 sensor Gyeyoung Baek
2025-04-20 18:10 ` [PATCH v4 3/4] iio: chemical: add " Gyeyoung Baek
2025-04-20 19:21 ` Andy Shevchenko
2025-04-20 19:23 ` Andy Shevchenko
2025-04-21 13:25 ` Jonathan Cameron [this message]
2025-04-22 8:42 ` Gyeyoung Baek
2025-04-22 8:38 ` Gyeyoung Baek
2025-04-22 17:30 ` Andy Shevchenko
2025-04-25 8:22 ` Jonathan Cameron
2025-04-21 6:41 ` Gyeyoung Baek
2025-04-22 7:50 ` Andy Shevchenko
2025-04-20 18:10 ` [PATCH v4 4/4] MAINTAINERS: Add WINSEN MHZ19B Gyeyoung Baek
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250421142531.2084092e@jic23-huawei \
--to=jic23@kernel.org \
--cc=andy.shevchenko@gmail.com \
--cc=andy@kernel.org \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=dlechner@baylibre.com \
--cc=gye976@gmail.com \
--cc=krzk+dt@kernel.org \
--cc=linux-iio@vger.kernel.org \
--cc=nuno.sa@analog.com \
--cc=robh@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox