Re: [PATCH v4 3/4] iio: chemical: add support for winsen MHZ19B CO2 sensor

[Jonathan Cameron <jic23@kernel.org>]

On Tue, 22 Apr 2025 20:30:58 +0300
Andy Shevchenko <andy.shevchenko@gmail.com> wrote:

> On Tue, Apr 22, 2025 at 05:38:56PM +0900, Gyeyoung Baek wrote:
> > On Mon, Apr 21, 2025 at 4:24 AM Andy Shevchenko
> > <andy.shevchenko@gmail.com> wrote:  
> > > On Sun, Apr 20, 2025 at 10:21 PM Andy Shevchenko
> > > <andy.shevchenko@gmail.com> wrote:  
> > > > On Sun, Apr 20, 2025 at 9:10 PM Gyeyoung Baek <gye976@gmail.com> wrote:  
> 
> ...
> 
> > > > > --- a/drivers/iio/chemical/Makefile
> > > > > +++ b/drivers/iio/chemical/Makefile  
> > >  
> > > > >  obj-$(CONFIG_SPS30_I2C) += sps30_i2c.o
> > > > >  obj-$(CONFIG_SPS30_SERIAL) += sps30_serial.o
> > > > >  obj-$(CONFIG_VZ89X)            += vz89x.o
> > > > > +obj-$(CONFIG_WINSEN_MHZ19B) += mhz19b.o  
> > > >
> > > > Preserve order.  
> > >
> > > Ah, I see it's ordered but by Kconfig, Why do you have WINSEN in the
> > > option and no such thing in the filename? I would drop that from the
> > > config option.  
> > 
> > I followed the 'vendor_device' naming pattern seen in examples like
> > 'CONFIG_SENSEAIR_SUNRISE_CO2'  
> 
> Interesting... Now I understand why the above was pulled without any comment,
> because the vendor and device names start with the same letter 'S'!

These vendor + driver things originally (IIRC) snuck in with driver
moves from misc etc a long time ago and I've never really enforced having
them or not properly since then :(

I prefer not having the company in these but it is a fairly random
choice with little real justification either way.

Jonathan

> 
> > But I'll drop the vendor prefix in the next patch, thanks.  
>