From: Arthur-Prince <r2.arthur.prince@gmail.com>
To: linux-iio@vger.kernel.org, arthur.prince@ime.usp.br
Cc: "Mariana Valério" <mariana.valerio2@hotmail.com>
Subject: [PATCH 1/2] iio: adc: ti-ads1298: Add safe usage guarantee for device communication
Date: Wed, 23 Apr 2025 15:46:25 -0300 [thread overview]
Message-ID: <20250423185208.752080-2-r2.arthur.prince@gmail.com> (raw)
In-Reply-To: <20250423185208.752080-1-r2.arthur.prince@gmail.com>
Add safe usage guarantee for device communication in
ads1298_reg_access/ ads1298_write_raw (ti-ads1298) that
prevent simultaneous read/write operations.
Signed-off-by: Arthur-Prince <r2.arthur.prince@gmail.com>
Co-developed-by: Mariana Valério <mariana.valerio2@hotmail.com>
Signed-off-by: Mariana Valério <mariana.valerio2@hotmail.com>
---
drivers/iio/adc/ti-ads1298.c | 25 +++++++++++++++++++++----
1 file changed, 21 insertions(+), 4 deletions(-)
diff --git a/drivers/iio/adc/ti-ads1298.c b/drivers/iio/adc/ti-ads1298.c
index 03f762415fa5..438bcc3c74da 100644
--- a/drivers/iio/adc/ti-ads1298.c
+++ b/drivers/iio/adc/ti-ads1298.c
@@ -355,9 +355,19 @@ static int ads1298_write_raw(struct iio_dev *indio_dev,
{
struct ads1298_private *priv = iio_priv(indio_dev);
+ int ret;
+
switch (mask) {
case IIO_CHAN_INFO_SAMP_FREQ:
- return ads1298_set_samp_freq(priv, val);
+ ret = iio_device_claim_direct_mode(indio_dev);
+ if (ret)
+ return ret;
+
+ ret = ads1298_set_samp_freq(priv, val);
+
+ iio_device_release_direct_mode(indio_dev);
+
+ return ret;
default:
return -EINVAL;
}
@@ -417,10 +427,17 @@ static int ads1298_reg_access(struct iio_dev *indio_dev, unsigned int reg,
{
struct ads1298_private *priv = iio_priv(indio_dev);
+ int ret;
+ ret = iio_device_claim_direct_mode(indio_dev);
+ if (ret)
+ return ret;
if (readval)
- return regmap_read(priv->regmap, reg, readval);
-
- return regmap_write(priv->regmap, reg, writeval);
+ ret = regmap_read(priv->regmap, reg, readval);
+ else
+ ret = regmap_write(priv->regmap, reg, writeval);
+
+ iio_device_release_direct_mode(indio_dev);
+ return ret;
}
static void ads1298_rdata_unmark_busy(struct ads1298_private *priv)
--
2.45.2
next prev parent reply other threads:[~2025-04-23 18:52 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-04-23 18:46 [PATCH 0/2] iio: adc: ti-ads1298 & Kconfig Arthur-Prince
2025-04-23 18:46 ` Arthur-Prince [this message]
2025-04-26 15:30 ` [PATCH 1/2] iio: adc: ti-ads1298: Add safe usage guarantee for device communication Jonathan Cameron
2025-04-23 18:46 ` [PATCH 2/2] iio: adc: Kconfig: add kfifo dependency to fix module build Arthur-Prince
2025-04-26 15:32 ` Jonathan Cameron
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250423185208.752080-2-r2.arthur.prince@gmail.com \
--to=r2.arthur.prince@gmail.com \
--cc=arthur.prince@ime.usp.br \
--cc=linux-iio@vger.kernel.org \
--cc=mariana.valerio2@hotmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox